)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b0640a8e5c47b77fa977b87e3af600a2c6a10799","unresolved":false,"context_lines":[{"line_number":13,"context_line":"There is still use of the VFSLocalFS in xen vmutils for injecting"},{"line_number":14,"context_line":"network information if a CONF value is set, so we can\u0027t fully remove"},{"line_number":15,"context_line":"that until we address the xen case."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Iac8496065c8b6212d7edac320659444ab341b513"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7f515b1d_640c9493","line":16,"updated":"2017-10-02 22:07:13.000000000","message":"Closes-Bug: #1552042 ?","commit_id":"2edffcc753df0da2c4f9ba973a3d4f6a41aac0e3"}],"nova/virt/disk/vfs/api.py":[{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"b74349830fc881e62d586e534e78353b3b485e11","unresolved":false,"context_lines":[{"line_number":71,"context_line":"                LOG.info(\"Unable to import guestfs, \""},{"line_number":72,"context_line":"                         \"falling back to VFSLocalFS\")"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        return importutils.import_object("},{"line_number":75,"context_line":"            \"nova.virt.disk.vfs.localfs.VFSLocalFS\","},{"line_number":76,"context_line":"            image, partition)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def __init__(self, image, partition):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f515b1d_bbf3aa73","side":"PARENT","line":75,"range":{"start_line":74,"start_character":0,"end_line":75,"end_character":52},"updated":"2017-10-04 09:05:01.000000000","message":"FWIW, I think this also removes the ability to do a resize with block devices, as this code is also used here: \nhttps://github.com/openstack/nova/blob/c1eb6f0e5078051ff03e4592e5aaff7cf04aa449/nova/virt/disk/api.py#L228\n\nI\u0027m not 100% sure though.\n\nIf I\u0027m right, and this is intended, you might also want to remove/deprecate the config options for that: https://github.com/openstack/nova/blob/64cb56c81a7309a667eea2ce85147e62d02cac91/nova/conf/compute.py#L273-L286","commit_id":"8ca24bf1ff80f39b14726aca22b5cf52603ea5a0"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5660a4d0228c774c6866135a38888bf6910503c4","unresolved":true,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        LOG.debug(\"Using primary VFSGuestFS\")"},{"line_number":51,"context_line":"        vfs \u003d importutils.import_object("},{"line_number":52,"context_line":"            \"nova.virt.disk.vfs.guestfs.VFSGuestFS\","},{"line_number":53,"context_line":"            image, partition)"},{"line_number":54,"context_line":"        if not VFS.guestfs_ready:"},{"line_number":55,"context_line":"            # Inspect for capabilities and keep"}],"source_content_type":"text/x-python","patch_set":6,"id":"de9430ad_7f7a6455","line":52,"updated":"2021-03-04 16:19:07.000000000","message":"can we remove this indirect import now that we only use libguestfs ?","commit_id":"d06a10f09699ef260002cc3474b33f08aca06583"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"e33b5f399e2b30cc3c09a1d814aff0ad51d2c5a6","unresolved":true,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        LOG.debug(\"Using primary VFSGuestFS\")"},{"line_number":51,"context_line":"        vfs \u003d importutils.import_object("},{"line_number":52,"context_line":"            \"nova.virt.disk.vfs.guestfs.VFSGuestFS\","},{"line_number":53,"context_line":"            image, partition)"},{"line_number":54,"context_line":"        if not VFS.guestfs_ready:"},{"line_number":55,"context_line":"            # Inspect for capabilities and keep"}],"source_content_type":"text/x-python","patch_set":6,"id":"7744905e_ff651b9b","line":52,"in_reply_to":"2890e266_de7bd4f1","updated":"2021-03-05 16:26:38.000000000","message":"I think we need to keep this logic to avoid changing bindep of nova on a stable branch when we are backporting this fix.","commit_id":"d06a10f09699ef260002cc3474b33f08aca06583"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4c7629a478461002b35d92fc8389a135ab308886","unresolved":true,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        LOG.debug(\"Using primary VFSGuestFS\")"},{"line_number":51,"context_line":"        vfs \u003d importutils.import_object("},{"line_number":52,"context_line":"            \"nova.virt.disk.vfs.guestfs.VFSGuestFS\","},{"line_number":53,"context_line":"            image, partition)"},{"line_number":54,"context_line":"        if not VFS.guestfs_ready:"},{"line_number":55,"context_line":"            # Inspect for capabilities and keep"}],"source_content_type":"text/x-python","patch_set":6,"id":"2890e266_de7bd4f1","line":52,"in_reply_to":"857e9f6b_0912c07a","updated":"2021-03-04 20:33:52.000000000","message":"im not sure but importutils is generaly a warning flag for me that we are doing something speical so i generally like to see it paired with a comment as to why its used.\n\nthis is in theory generic code  since in this module and not under the libvirt dirver for example but i don\u0027t know if this is actually used on systems without libgustfs.","commit_id":"d06a10f09699ef260002cc3474b33f08aca06583"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"980fe69faea2e9d8476edb5d80633d3beb985fb3","unresolved":true,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        LOG.debug(\"Using primary VFSGuestFS\")"},{"line_number":51,"context_line":"        vfs \u003d importutils.import_object("},{"line_number":52,"context_line":"            \"nova.virt.disk.vfs.guestfs.VFSGuestFS\","},{"line_number":53,"context_line":"            image, partition)"},{"line_number":54,"context_line":"        if not VFS.guestfs_ready:"},{"line_number":55,"context_line":"            # Inspect for capabilities and keep"}],"source_content_type":"text/x-python","patch_set":6,"id":"857e9f6b_0912c07a","line":52,"in_reply_to":"de9430ad_7f7a6455","updated":"2021-03-04 16:31:53.000000000","message":"I thought the same but assumed we were using this to allow nova with the libvirt driver to support hosts without a suitable version of libguestfs to start. Maybe that\u0027s a bad assumption?","commit_id":"d06a10f09699ef260002cc3474b33f08aca06583"}]}