)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e8875fb0b5cbd953f52a83b440d7f091440c5b43","unresolved":false,"context_lines":[{"line_number":9,"context_line":"migrateToURI3 does not take \u0027bandwidth\u0027 argument so we shouldn\u0027t try"},{"line_number":10,"context_line":"to pass it. Actually it results with exception when libvirt\u003e\u003d1.2.17"},{"line_number":11,"context_line":"is used."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ieea2d955c763655e2b2abfb99fccb1a4c7169794"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7aa08908_c00cd596","line":12,"updated":"2016-06-06 15:22:42.000000000","message":"Track this against bug 1589548.","commit_id":"6ef26c7cf8cd5938802d5b6ae9a98466089d9a50"}],"nova/virt/libvirt/guest.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e8875fb0b5cbd953f52a83b440d7f091440c5b43","unresolved":false,"context_lines":[{"line_number":520,"context_line":"            self._domain.migrateToURI("},{"line_number":521,"context_line":"                destination, flags\u003dflags, bandwidth\u003dbandwidth)"},{"line_number":522,"context_line":"        else:"},{"line_number":523,"context_line":"            if params:"},{"line_number":524,"context_line":"                self._domain.migrateToURI3("},{"line_number":525,"context_line":"                    destination, params\u003dparams, flags\u003dflags)"},{"line_number":526,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_00dc1de3","line":523,"range":{"start_line":523,"start_character":15,"end_line":523,"end_character":21},"updated":"2016-06-06 15:22:42.000000000","message":"nit: would be cool if we actually documented what this was for in the docstring.","commit_id":"6ef26c7cf8cd5938802d5b6ae9a98466089d9a50"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"853e0495220cbee1545c9c2d611f0e1079a433f8","unresolved":false,"context_lines":[{"line_number":522,"context_line":"        else:"},{"line_number":523,"context_line":"            if params:"},{"line_number":524,"context_line":"                self._domain.migrateToURI3("},{"line_number":525,"context_line":"                    destination, params\u003dparams, flags\u003dflags)"},{"line_number":526,"context_line":"            else:"},{"line_number":527,"context_line":"                self._domain.migrateToURI2("},{"line_number":528,"context_line":"                    destination, dxml\u003ddomain_xml,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9abb7d3a_e284660c","line":525,"updated":"2016-06-03 11:53:41.000000000","message":"Ok, so you should to enhance \u0027params\u0027 with bandwich if it is not already specified in the dict.","commit_id":"6ef26c7cf8cd5938802d5b6ae9a98466089d9a50"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b477d7468d5348f732c29afe01a7c3a8f77811aa","unresolved":false,"context_lines":[{"line_number":522,"context_line":"        else:"},{"line_number":523,"context_line":"            if params:"},{"line_number":524,"context_line":"                self._domain.migrateToURI3("},{"line_number":525,"context_line":"                    destination, params\u003dparams, flags\u003dflags)"},{"line_number":526,"context_line":"            else:"},{"line_number":527,"context_line":"                self._domain.migrateToURI2("},{"line_number":528,"context_line":"                    destination, dxml\u003ddomain_xml,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_fb02663d","line":525,"in_reply_to":"7aa08908_7b2cb64a","updated":"2016-06-06 15:29:17.000000000","message":"Ah looks like Pawel pointed out it\u0027s already in the dict:\n\nhttps://github.com/openstack/nova/blob/bfc5285b4684f6e459e6232ede58365fd9d50e34/nova/virt/libvirt/driver.py#L5733\n\nI\u0027m going to do a refactor on top of this change that makes the caller pass in explicit parameters, then this guest object can sort out how to pass them to libvirt, so we don\u0027t have the caller figuring as it leaks libvirt API info.","commit_id":"6ef26c7cf8cd5938802d5b6ae9a98466089d9a50"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e8875fb0b5cbd953f52a83b440d7f091440c5b43","unresolved":false,"context_lines":[{"line_number":522,"context_line":"        else:"},{"line_number":523,"context_line":"            if params:"},{"line_number":524,"context_line":"                self._domain.migrateToURI3("},{"line_number":525,"context_line":"                    destination, params\u003dparams, flags\u003dflags)"},{"line_number":526,"context_line":"            else:"},{"line_number":527,"context_line":"                self._domain.migrateToURI2("},{"line_number":528,"context_line":"                    destination, dxml\u003ddomain_xml,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_7b2cb64a","line":525,"in_reply_to":"9abb7d3a_e284660c","updated":"2016-06-06 15:22:42.000000000","message":"Yeah, looks like you have to stuff bandwidth into the params dict:\n\nhttps://github.com/libvirt/libvirt/blob/v1.3.1/src/libvirt-domain.c#L3952\n\nI\u0027m not sure where that\u0027s used though.","commit_id":"6ef26c7cf8cd5938802d5b6ae9a98466089d9a50"}]}