)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"2708a218adec34a81cff46abacc3d9be90349106","unresolved":false,"context_lines":[{"line_number":13,"context_line":"available and you are using already compressed image formats such as"},{"line_number":14,"context_line":"qcow2 ."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Addresses bug 1189887. DocImpact."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Iacc42d8e0cab218258c3029d5395e02fddb75197"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAP3%2F%2FfCc%3D","line":16,"updated":"2013-07-17 15:28:25.000000000","message":"DocImpact typically gets its own line.","commit_id":"ea9bb364eec05be55b72c06ea6477511ad7c3df7"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"02a3ef0e29aa0a5a5246b1edfb9180361dc4ae58","unresolved":false,"context_lines":[{"line_number":10,"context_line":"available and you are using already compressed image formats such as"},{"line_number":11,"context_line":"qcow2 ."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Addresses bug 1189887."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"DocImpact."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAAP3%2F%2Fe4c%3D","line":13,"updated":"2013-07-17 16:01:14.000000000","message":"I don\u0027t really feel like this is a bug, personally ...","commit_id":"394c3740e199161bced9f166c8bf2a7eb0aab935"},{"author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"change_message_id":"adb8002402eddeab32cffd66a176538d3586d17e","unresolved":false,"context_lines":[{"line_number":10,"context_line":"available and you are using already compressed image formats such as"},{"line_number":11,"context_line":"qcow2 ."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Addresses bug 1189887."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"DocImpact."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAAP3%2F%2Fe2U%3D","line":13,"in_reply_to":"AAAAP3%2F%2Fe4c%3D","updated":"2013-07-17 16:06:24.000000000","message":"Happy to remove this line if that\u0027s preferred?","commit_id":"394c3740e199161bced9f166c8bf2a7eb0aab935"}],"nova/image/glance.py":[{"author":{"_account_id":6896,"name":"Loganathan Parthipan","email":"parthi@hpe.com","username":"parthipan"},"change_message_id":"6b11ecc0ca61de98ad4e5159fb01d2d3db659e5f","unresolved":false,"context_lines":[{"line_number":114,"context_line":"    if use_ssl:"},{"line_number":115,"context_line":"        scheme \u003d \u0027https\u0027"},{"line_number":116,"context_line":"        # https specific params"},{"line_number":117,"context_line":"        params[\u0027insecure\u0027] \u003d CONF.glance_api_insecure"},{"line_number":118,"context_line":"        params[\u0027ssl_compression\u0027] \u003d CONF.glance_api_ssl_compression"},{"line_number":119,"context_line":"    else:"},{"line_number":120,"context_line":"        scheme \u003d \u0027http\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPX%2F%2Fv%2B0%3D","line":117,"updated":"2013-06-11 13:04:04.000000000","message":"so by moving this in here if use_ssl is false then params won\u0027t have a key called \u0027insecure\u0027. I think we need to test that \u0027insecure\u0027 is not accessed elsewhere while use_ssl is false.","commit_id":"b63258e6fa6db89cf3555bfc570e99d00b20b074"},{"author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"change_message_id":"87498a58255ca015933f9d456a046c2ac4bc9e2e","unresolved":false,"context_lines":[{"line_number":114,"context_line":"    if use_ssl:"},{"line_number":115,"context_line":"        scheme \u003d \u0027https\u0027"},{"line_number":116,"context_line":"        # https specific params"},{"line_number":117,"context_line":"        params[\u0027insecure\u0027] \u003d CONF.glance_api_insecure"},{"line_number":118,"context_line":"        params[\u0027ssl_compression\u0027] \u003d CONF.glance_api_ssl_compression"},{"line_number":119,"context_line":"    else:"},{"line_number":120,"context_line":"        scheme \u003d \u0027http\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPX%2F%2Fv9c%3D","line":117,"in_reply_to":"AAAAPX%2F%2Fv%2B0%3D","updated":"2013-06-11 13:12:19.000000000","message":"Wouldn\u0027t an access of \u0027insecure\u0027 when not using https be a bug in the glance client code? By default the gating tests run using http, so they would highlight this I think.","commit_id":"b63258e6fa6db89cf3555bfc570e99d00b20b074"},{"author":{"_account_id":6896,"name":"Loganathan Parthipan","email":"parthi@hpe.com","username":"parthipan"},"change_message_id":"39727637f7e4563a7c30d0e59c5366175558efc6","unresolved":false,"context_lines":[{"line_number":114,"context_line":"    if use_ssl:"},{"line_number":115,"context_line":"        scheme \u003d \u0027https\u0027"},{"line_number":116,"context_line":"        # https specific params"},{"line_number":117,"context_line":"        params[\u0027insecure\u0027] \u003d CONF.glance_api_insecure"},{"line_number":118,"context_line":"        params[\u0027ssl_compression\u0027] \u003d CONF.glance_api_ssl_compression"},{"line_number":119,"context_line":"    else:"},{"line_number":120,"context_line":"        scheme \u003d \u0027http\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPX%2F%2Fv8I%3D","line":117,"in_reply_to":"AAAAPX%2F%2Fv9c%3D","updated":"2013-06-11 13:22:05.000000000","message":"true","commit_id":"b63258e6fa6db89cf3555bfc570e99d00b20b074"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"c53a949a34e3938fd4272818d3353eb0ade395b3","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                     \u0027disable SSL layer compression. In some cases disabling \u0027"},{"line_number":64,"context_line":"                     \u0027this may improve data throughput, eg when high network \u0027"},{"line_number":65,"context_line":"                     \u0027bandwidth is available and you are using already \u0027"},{"line_number":66,"context_line":"                     \u0027compressed image formats such as qcow2 .\u0027),"},{"line_number":67,"context_line":"    cfg.IntOpt(\u0027glance_num_retries\u0027,"},{"line_number":68,"context_line":"               default\u003d0,"},{"line_number":69,"context_line":"               help\u003d\u0027Number retries when downloading an image from glance\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2F9F8%3D","line":66,"updated":"2013-06-17 14:20:22.000000000","message":"How about the following for help:\n\nWhether we should enable SSL compression in glance during image downloads. This is disabled by default because if you are already using a compressed image format like qcow2 on a reasonable network turning on SSL compression does nothing for your bandwidth usage, and dramatically slows down the transfer by adding another layer of compression. This option may entirely be removed in the future.","commit_id":"ea9bb364eec05be55b72c06ea6477511ad7c3df7"},{"author":{"_account_id":6896,"name":"Loganathan Parthipan","email":"parthi@hpe.com","username":"parthipan"},"change_message_id":"0efdfd9673b67aedefe9de9bf609c7d4333fc0bd","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                     \u0027disable SSL layer compression. In some cases disabling \u0027"},{"line_number":64,"context_line":"                     \u0027this may improve data throughput, eg when high network \u0027"},{"line_number":65,"context_line":"                     \u0027bandwidth is available and you are using already \u0027"},{"line_number":66,"context_line":"                     \u0027compressed image formats such as qcow2 .\u0027),"},{"line_number":67,"context_line":"    cfg.IntOpt(\u0027glance_num_retries\u0027,"},{"line_number":68,"context_line":"               default\u003d0,"},{"line_number":69,"context_line":"               help\u003d\u0027Number retries when downloading an image from glance\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAP3%2F%2F6QA%3D","line":66,"in_reply_to":"AAAAPn%2F%2F8%2F8%3D","updated":"2013-07-09 11:35:33.000000000","message":"@sean, it may be better to have this option. It\u0027s true we don\u0027t want to try compressing in certain scenarios, as specified in the help message, and it\u0027s a better default. But I can see other cases where users may upload compressible images, not to mention high bandwidth but saturated networks.","commit_id":"ea9bb364eec05be55b72c06ea6477511ad7c3df7"},{"author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"change_message_id":"f235614f77ba59b806a85b5cc5632fbe435e23c9","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                     \u0027disable SSL layer compression. In some cases disabling \u0027"},{"line_number":64,"context_line":"                     \u0027this may improve data throughput, eg when high network \u0027"},{"line_number":65,"context_line":"                     \u0027bandwidth is available and you are using already \u0027"},{"line_number":66,"context_line":"                     \u0027compressed image formats such as qcow2 .\u0027),"},{"line_number":67,"context_line":"    cfg.IntOpt(\u0027glance_num_retries\u0027,"},{"line_number":68,"context_line":"               default\u003d0,"},{"line_number":69,"context_line":"               help\u003d\u0027Number retries when downloading an image from glance\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2F8%2F8%3D","line":66,"in_reply_to":"AAAAPn%2F%2F9F8%3D","updated":"2013-06-17 14:56:14.000000000","message":"Hi Sean,\n\nThe equivalent change has already merged into cinder:\n\nhttps://review.openstack.org/#/c/32572/\n\nI\u0027d like to keep the wording consistent if possible.","commit_id":"ea9bb364eec05be55b72c06ea6477511ad7c3df7"}]}