)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"8d30ec4b24734a91ece39ce693967d3531bd0d0c","unresolved":false,"context_lines":[{"line_number":6629,"context_line":"                                         in migrations])"},{"line_number":6630,"context_line":""},{"line_number":6631,"context_line":"        inst_filters \u003d {\u0027deleted\u0027: True, \u0027soft_deleted\u0027: False,"},{"line_number":6632,"context_line":"                        \u0027uuid\u0027: inst_uuid_from_migrations}"},{"line_number":6633,"context_line":"        attrs \u003d [\u0027info_cache\u0027, \u0027security_groups\u0027, \u0027system_metadata\u0027]"},{"line_number":6634,"context_line":"        with utils.temporary_mutation(context, read_deleted\u003d\u0027yes\u0027):"},{"line_number":6635,"context_line":"            instances \u003d objects.InstanceList.get_by_filters("}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_0a137a67","line":6632,"updated":"2016-06-07 06:20:45.000000000","message":"IMO the job of this periodic task is to delete instance files from host (which is not instance.host) only. \n\nSince you have called a delete request on instance, it is job of delete api to delete instance from instance.host.\n\nEg. If you are resizing the instance and after copying instance files from source to dest host, it has failed and instance.host was set to dest host. \n\nNow if you request delete instance, then it is job of delete api to delete instance files from dest node and this periodic task will remove instance files from source node and set migration status to \u0027failed\u0027 so that the same migration record doesn\u0027t come in filter in subsequent periodic task run.","commit_id":"2abadd49762a98e6d9dac8d9eb3d195435a03d18"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"db564217fe477cd3ce6682bf31ee372b91b37d0b","unresolved":false,"context_lines":[{"line_number":6630,"context_line":""},{"line_number":6631,"context_line":"        inst_filters \u003d {\u0027deleted\u0027: True, \u0027soft_deleted\u0027: False,"},{"line_number":6632,"context_line":"                        \u0027uuid\u0027: inst_uuid_from_migrations}"},{"line_number":6633,"context_line":"        attrs \u003d [\u0027info_cache\u0027, \u0027security_groups\u0027, \u0027system_metadata\u0027]"},{"line_number":6634,"context_line":"        with utils.temporary_mutation(context, read_deleted\u003d\u0027yes\u0027):"},{"line_number":6635,"context_line":"            instances \u003d objects.InstanceList.get_by_filters("},{"line_number":6636,"context_line":"                context, inst_filters, expected_attrs\u003dattrs, use_slave\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_65e18f9a","line":6633,"range":{"start_line":6633,"start_character":15,"end_line":6633,"end_character":16},"updated":"2016-06-07 07:17:16.000000000","message":"You can have a look at bug [1] and proposed patch [2].\nThe instance filtering condition was changed in patch [3].\n\n[1] https://bugs.launchpad.net/nova/+bug/1392527\n[2] https://review.openstack.org/#/c/219299/\n[3] https://review.openstack.org/#/c/256102\n\nI have submitted a patch to revert patch [3] changes.\nhttps://review.openstack.org/#/c/326262/","commit_id":"2abadd49762a98e6d9dac8d9eb3d195435a03d18"},{"author":{"_account_id":12813,"name":"Rong Han","email":"han.rong3@zte.com.cn","username":"hanrong-zte"},"change_message_id":"c041595340a821ba95a434df0f013edf6298a2bc","unresolved":false,"context_lines":[{"line_number":6630,"context_line":""},{"line_number":6631,"context_line":"        inst_filters \u003d {\u0027deleted\u0027: True, \u0027soft_deleted\u0027: False,"},{"line_number":6632,"context_line":"                        \u0027uuid\u0027: inst_uuid_from_migrations}"},{"line_number":6633,"context_line":"        attrs \u003d [\u0027info_cache\u0027, \u0027security_groups\u0027, \u0027system_metadata\u0027]"},{"line_number":6634,"context_line":"        with utils.temporary_mutation(context, read_deleted\u003d\u0027yes\u0027):"},{"line_number":6635,"context_line":"            instances \u003d objects.InstanceList.get_by_filters("},{"line_number":6636,"context_line":"                context, inst_filters, expected_attrs\u003dattrs, use_slave\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_df491ab9","line":6633,"range":{"start_line":6633,"start_character":15,"end_line":6633,"end_character":16},"in_reply_to":"7aa08908_65e18f9a","updated":"2016-06-12 00:53:17.000000000","message":"I see, I don\u0027t know what to say, but think it\u0027s not polite.I found a bug, the modification plan, but you see there are different opinions, but new raised a bug and patch set.","commit_id":"2abadd49762a98e6d9dac8d9eb3d195435a03d18"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"22b8d90fd419cc2c7a1b1504a8130a2b07b661e3","unresolved":false,"context_lines":[{"line_number":6630,"context_line":""},{"line_number":6631,"context_line":"        inst_filters \u003d {\u0027deleted\u0027: True, \u0027soft_deleted\u0027: False,"},{"line_number":6632,"context_line":"                        \u0027uuid\u0027: inst_uuid_from_migrations}"},{"line_number":6633,"context_line":"        attrs \u003d [\u0027info_cache\u0027, \u0027security_groups\u0027, \u0027system_metadata\u0027]"},{"line_number":6634,"context_line":"        with utils.temporary_mutation(context, read_deleted\u003d\u0027yes\u0027):"},{"line_number":6635,"context_line":"            instances \u003d objects.InstanceList.get_by_filters("},{"line_number":6636,"context_line":"                context, inst_filters, expected_attrs\u003dattrs, use_slave\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_bb7a5022","line":6633,"range":{"start_line":6633,"start_character":15,"end_line":6633,"end_character":16},"in_reply_to":"7aa08908_df491ab9","updated":"2016-06-13 05:41:04.000000000","message":"Hi Rong,\n\nThat should be done in different bug, because it was regression. \n\nThe original bug was security issue, for which I had provided patch. Then after some time matt has modified the condition (by mistake he assumed something else) and because of that modified condition, you got the issue. \n\nIn original patch where the periodic task was introduced the condition was correct. Since that periodic task solved security patch, and there was regression on that, so it should have done in different bug.","commit_id":"2abadd49762a98e6d9dac8d9eb3d195435a03d18"}]}