)]}'
{"nova/test.py":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"6e092209420bad0554a48945b09562d174c1268d","unresolved":false,"context_lines":[{"line_number":281,"context_line":"    def flags(self, **kw):"},{"line_number":282,"context_line":"        \"\"\"Override flag variables for a test.\"\"\""},{"line_number":283,"context_line":"        group \u003d kw.pop(\u0027group\u0027, None)"},{"line_number":284,"context_line":"        enforce_type \u003d kw.pop(\u0027enforce_type\u0027, False)"},{"line_number":285,"context_line":"        for k, v in six.iteritems(kw):"},{"line_number":286,"context_line":"            CONF.set_override(k, v, group, enforce_type\u003denforce_type)"},{"line_number":287,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_261043a8","line":284,"updated":"2016-06-06 20:00:43.000000000","message":"I can understand popping enforce_type, and deciding we always want to enforce type. I don\u0027t understand defaulting it to False.","commit_id":"725b110808d30a9036bccdbda997434b0e745388"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"d962b1b4c01e744f3052011880c67f2fb13b2368","unresolved":false,"context_lines":[{"line_number":281,"context_line":"    def flags(self, **kw):"},{"line_number":282,"context_line":"        \"\"\"Override flag variables for a test.\"\"\""},{"line_number":283,"context_line":"        group \u003d kw.pop(\u0027group\u0027, None)"},{"line_number":284,"context_line":"        enforce_type \u003d kw.pop(\u0027enforce_type\u0027, False)"},{"line_number":285,"context_line":"        for k, v in six.iteritems(kw):"},{"line_number":286,"context_line":"            CONF.set_override(k, v, group, enforce_type\u003denforce_type)"},{"line_number":287,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_d4e91b1c","line":284,"in_reply_to":"7aa08908_261043a8","updated":"2016-06-07 04:23:12.000000000","message":"method flags is used in many places, I try to pass enforce_type\u003dTrue in one commit and fixes all violations in [1], but that\u0027s not easy to review. I decide just fix violation and pass enforce_type\u003dTrue in some commits, which are easy to review. I would like to default it to True when we fix all violations in another commit.\n\n[1]https://review.openstack.org/#/c/242416/.","commit_id":"725b110808d30a9036bccdbda997434b0e745388"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"dbd6a4386bbeb60396613497b00b8fb678ba01f0","unresolved":false,"context_lines":[{"line_number":281,"context_line":"    def flags(self, **kw):"},{"line_number":282,"context_line":"        \"\"\"Override flag variables for a test.\"\"\""},{"line_number":283,"context_line":"        group \u003d kw.pop(\u0027group\u0027, None)"},{"line_number":284,"context_line":"        enforce_type \u003d kw.pop(\u0027enforce_type\u0027, True)"},{"line_number":285,"context_line":"        for k, v in six.iteritems(kw):"},{"line_number":286,"context_line":"            CONF.set_override(k, v, group, enforce_type\u003denforce_type)"},{"line_number":287,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_f8dbbd4d","line":284,"range":{"start_line":284,"start_character":50,"end_line":284,"end_character":51},"updated":"2016-07-22 08:35:31.000000000","message":"This commit depends on other commits to pass unit tests.\n\nThey are:\n\nhttps://review.openstack.org/325749\nhttps://review.openstack.org/325761\nhttps://review.openstack.org/#/c/328698/","commit_id":"49e64f5f58041a3732e2b6523765f55ddcd5d7bb"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c1c7177f016b8aa31381f0564392703d89ba9024","unresolved":false,"context_lines":[{"line_number":281,"context_line":"    def flags(self, **kw):"},{"line_number":282,"context_line":"        \"\"\"Override flag variables for a test.\"\"\""},{"line_number":283,"context_line":"        group \u003d kw.pop(\u0027group\u0027, None)"},{"line_number":284,"context_line":"        enforce_type \u003d kw.pop(\u0027enforce_type\u0027, True)"},{"line_number":285,"context_line":"        for k, v in six.iteritems(kw):"},{"line_number":286,"context_line":"            CONF.set_override(k, v, group, enforce_type\u003denforce_type)"},{"line_number":287,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_0b3c2fe1","line":284,"range":{"start_line":284,"start_character":50,"end_line":284,"end_character":51},"in_reply_to":"bacf61ea_016399b2","updated":"2016-07-28 20:13:28.000000000","message":"Can you just stack these up so they pass in order and we see this working at the end of the series?","commit_id":"49e64f5f58041a3732e2b6523765f55ddcd5d7bb"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"78cdb269222062d510a3ff0b52bd1c973cd2b3bd","unresolved":false,"context_lines":[{"line_number":281,"context_line":"    def flags(self, **kw):"},{"line_number":282,"context_line":"        \"\"\"Override flag variables for a test.\"\"\""},{"line_number":283,"context_line":"        group \u003d kw.pop(\u0027group\u0027, None)"},{"line_number":284,"context_line":"        enforce_type \u003d kw.pop(\u0027enforce_type\u0027, True)"},{"line_number":285,"context_line":"        for k, v in six.iteritems(kw):"},{"line_number":286,"context_line":"            CONF.set_override(k, v, group, enforce_type\u003denforce_type)"},{"line_number":287,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_2f73f14e","line":284,"range":{"start_line":284,"start_character":50,"end_line":284,"end_character":51},"in_reply_to":"bacf61ea_0b3c2fe1","updated":"2016-07-29 02:48:26.000000000","message":"sure, will do that ASAP","commit_id":"49e64f5f58041a3732e2b6523765f55ddcd5d7bb"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"ee503f6a68be27fd9d1f1ceee44d680653d3dff9","unresolved":false,"context_lines":[{"line_number":281,"context_line":"    def flags(self, **kw):"},{"line_number":282,"context_line":"        \"\"\"Override flag variables for a test.\"\"\""},{"line_number":283,"context_line":"        group \u003d kw.pop(\u0027group\u0027, None)"},{"line_number":284,"context_line":"        enforce_type \u003d kw.pop(\u0027enforce_type\u0027, True)"},{"line_number":285,"context_line":"        for k, v in six.iteritems(kw):"},{"line_number":286,"context_line":"            CONF.set_override(k, v, group, enforce_type\u003denforce_type)"},{"line_number":287,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_016399b2","line":284,"range":{"start_line":284,"start_character":50,"end_line":284,"end_character":51},"in_reply_to":"dada55a8_f8dbbd4d","updated":"2016-07-28 14:46:03.000000000","message":"and depends on \n\nhttps://review.openstack.org/#/c/238347/","commit_id":"49e64f5f58041a3732e2b6523765f55ddcd5d7bb"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"75a5e5e248df764a8ae51035179eb717740a3889","unresolved":false,"context_lines":[{"line_number":281,"context_line":"    def flags(self, **kw):"},{"line_number":282,"context_line":"        \"\"\"Override flag variables for a test.\"\"\""},{"line_number":283,"context_line":"        group \u003d kw.pop(\u0027group\u0027, None)"},{"line_number":284,"context_line":"        enforce_type \u003d kw.pop(\u0027enforce_type\u0027, True)"},{"line_number":285,"context_line":"        for k, v in six.iteritems(kw):"},{"line_number":286,"context_line":"            CONF.set_override(k, v, group, enforce_type\u003denforce_type)"},{"line_number":287,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_b182c9c6","line":284,"updated":"2016-08-03 11:10:54.000000000","message":"Its tempting to not give people the option to turn this off. I would just pass True into set_override.","commit_id":"a0cc1e2cbf01bfb738d0890c4a75405492d78ffa"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"951d7d3d9d945f50ba2f2c579b78bf15f5f81cf6","unresolved":false,"context_lines":[{"line_number":281,"context_line":"    def flags(self, **kw):"},{"line_number":282,"context_line":"        \"\"\"Override flag variables for a test.\"\"\""},{"line_number":283,"context_line":"        group \u003d kw.pop(\u0027group\u0027, None)"},{"line_number":284,"context_line":"        enforce_type \u003d kw.pop(\u0027enforce_type\u0027, True)"},{"line_number":285,"context_line":"        for k, v in six.iteritems(kw):"},{"line_number":286,"context_line":"            CONF.set_override(k, v, group, enforce_type\u003denforce_type)"},{"line_number":287,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_4cd77623","line":284,"in_reply_to":"bacf61ea_b182c9c6","updated":"2016-08-03 11:26:06.000000000","message":"I\u0027m fine just set enforce_type\u003dtrue in line 286\n\nNot sure somebody would set enforce_type\u003dFalse in tests.","commit_id":"a0cc1e2cbf01bfb738d0890c4a75405492d78ffa"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"75a5e5e248df764a8ae51035179eb717740a3889","unresolved":false,"context_lines":[{"line_number":283,"context_line":"        group \u003d kw.pop(\u0027group\u0027, None)"},{"line_number":284,"context_line":"        enforce_type \u003d kw.pop(\u0027enforce_type\u0027, True)"},{"line_number":285,"context_line":"        for k, v in six.iteritems(kw):"},{"line_number":286,"context_line":"            CONF.set_override(k, v, group, enforce_type\u003denforce_type)"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"    def start_service(self, name, host\u003dNone, **kwargs):"},{"line_number":289,"context_line":"        svc \u003d self.useFixture("}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_715fb175","line":286,"updated":"2016-08-03 11:10:54.000000000","message":"Maybe we should have a pep8 check to ensure enforce_type\u003dTrue is always sent to set_override? or that we don\u0027t call it directly?","commit_id":"a0cc1e2cbf01bfb738d0890c4a75405492d78ffa"}]}