)]}'
{"nova/debugger.py":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"399766a9c510c2095a916e25901e1a4e4550b3eb","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        return"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    from nova.i18n import _LW"},{"line_number":41,"context_line":"    from oslo_log import log as logging"},{"line_number":42,"context_line":"    LOG \u003d logging.getLogger(__name__)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    LOG.debug(\u0027Listening on %(host)s:%(port)s for debug connection\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_d8fbe5bf","line":41,"updated":"2016-06-07 16:14:57.000000000","message":"it looks pretty intentional that this is not using oslo.log, which is going to redirect the logging to files by default.","commit_id":"a21f7972d438898cacb294dcfb52822c71261ee1"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"a6a188f34e567deb693897a6b1312ce2a865291b","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        return"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    from nova.i18n import _LW"},{"line_number":41,"context_line":"    from oslo_log import log as logging"},{"line_number":42,"context_line":"    LOG \u003d logging.getLogger(__name__)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    LOG.debug(\u0027Listening on %(host)s:%(port)s for debug connection\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_3305ea10","line":41,"in_reply_to":"7aa08908_d8fbe5bf","updated":"2016-06-13 02:07:39.000000000","message":"Hi Sean,\n\nThank you for the comment. But sorry that I don\u0027t quite understand this. What do you mean by \"redirect the logging to files by default\" ? I can only see that it logged two messages. And cannot oslo do the same ?","commit_id":"a21f7972d438898cacb294dcfb52822c71261ee1"}],"nova/policy.py":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"399766a9c510c2095a916e25901e1a4e4550b3eb","unresolved":false,"context_lines":[{"line_number":16,"context_line":"\"\"\"Policy Engine For Nova.\"\"\""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from oslo_config import cfg"},{"line_number":19,"context_line":"from oslo_log import log as logging"},{"line_number":20,"context_line":"from oslo_policy import policy"},{"line_number":21,"context_line":"from oslo_utils import excutils"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_f8ece1f4","line":19,"updated":"2016-06-07 16:14:57.000000000","message":"this seems fine","commit_id":"a21f7972d438898cacb294dcfb52822c71261ee1"}],"nova/version.py":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"399766a9c510c2095a916e25901e1a4e4550b3eb","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    from oslo_config import cfg"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    from oslo_log import log as logging"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    global loaded, NOVA_VENDOR, NOVA_PRODUCT, NOVA_PACKAGE"},{"line_number":39,"context_line":"    if loaded:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_b8941943","line":36,"updated":"2016-06-07 16:14:57.000000000","message":"this is pretty subtle, and I think assuming oslo.log is available here is not something you should assume. The LOG.error is here only to dump out something in the basic version checking.","commit_id":"a21f7972d438898cacb294dcfb52822c71261ee1"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"a6a188f34e567deb693897a6b1312ce2a865291b","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    from oslo_config import cfg"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    from oslo_log import log as logging"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    global loaded, NOVA_VENDOR, NOVA_PRODUCT, NOVA_PACKAGE"},{"line_number":39,"context_line":"    if loaded:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_b349da33","line":36,"in_reply_to":"7aa08908_b8941943","updated":"2016-06-13 02:07:39.000000000","message":"Well, I assumed oslo.log is available because I saw that oslo.config is available here. Maybe I thought it too simply. Would you please tell me that when we can assume what is available, or is there any doc showing this ?\n\nThank you very much.","commit_id":"a21f7972d438898cacb294dcfb52822c71261ee1"}]}