)]}'
{"nova/virt/libvirt/driver.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2aaffc019c769f0b4ed8a110693a10dd189f5bf8","unresolved":false,"context_lines":[{"line_number":5732,"context_line":"                    MIN_LIBVIRT_BLOCK_LM_WITH_VOLUMES_VERSION):"},{"line_number":5733,"context_line":"                # NOTE(mriedem): This is hacky and tightly-couples the guest"},{"line_number":5734,"context_line":"                # migrate method to the driver, but it\u0027s used to tell the"},{"line_number":5735,"context_line":"                # guest when it can use migrateToURI3. We could pass a flag"},{"line_number":5736,"context_line":"                # or check the version of libvirt from the guest but those"},{"line_number":5737,"context_line":"                # are also ugly alternatives."},{"line_number":5738,"context_line":"                migrate_disks \u003d device_names"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_bbabb31c","line":5735,"range":{"start_line":5735,"start_character":55,"end_line":5735,"end_character":75},"updated":"2016-06-06 18:40:46.000000000","message":"I\u0027m open to other opinions on doing this, basically something like passing a \u0027supports_block_migrate_with_devices\u0027 flag, which we\u0027d pass as True in this case that libvirt\u003e\u003d1.2.17. We\u0027d have to also pass device_names regardless, but the guest.migrate method could ignore that parameter if supports_block_migrate_with_devices was False.","commit_id":"fbdbe881954d41b8f02aae63992b7680bdd28fea"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f7b08b49ebd58fc981944097430722934b30ebd9","unresolved":false,"context_lines":[{"line_number":5732,"context_line":"                    MIN_LIBVIRT_BLOCK_LM_WITH_VOLUMES_VERSION):"},{"line_number":5733,"context_line":"                # NOTE(mriedem): This is hacky and tightly-couples the guest"},{"line_number":5734,"context_line":"                # migrate method to the driver, but it\u0027s used to tell the"},{"line_number":5735,"context_line":"                # guest when it can use migrateToURI3. We could pass a flag"},{"line_number":5736,"context_line":"                # or check the version of libvirt from the guest but those"},{"line_number":5737,"context_line":"                # are also ugly alternatives."},{"line_number":5738,"context_line":"                migrate_disks \u003d device_names"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_ad19b67b","line":5735,"range":{"start_line":5735,"start_character":55,"end_line":5735,"end_character":75},"updated":"2016-06-06 18:43:21.000000000","message":"Let me know if people think this would be better.","commit_id":"c5bdd39ef3fe74c7299661e507a473f16884517c"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"7226af2cba926aa5cb80a83baea87792b4e1b51a","unresolved":false,"context_lines":[{"line_number":5730,"context_line":"                    guest, migrate_data, self._get_volume_config)"},{"line_number":5731,"context_line":"            if self._host.has_min_version("},{"line_number":5732,"context_line":"                    MIN_LIBVIRT_BLOCK_LM_WITH_VOLUMES_VERSION):"},{"line_number":5733,"context_line":"                # NOTE(mriedem): This is hacky and tightly-couples the guest"},{"line_number":5734,"context_line":"                # migrate method to the driver, but it\u0027s used to tell the"},{"line_number":5735,"context_line":"                # guest when it can use migrateToURI3. We could pass a flag"},{"line_number":5736,"context_line":"                # or check the version of libvirt from the guest but those"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_337f9916","line":5733,"updated":"2016-06-07 21:56:17.000000000","message":"I\u0027d remove this comment. This method handle the different ways to live migrate internally according the parameters. No need of this message.","commit_id":"6c682ac700159fa9c0f0e06acb730ef310dfc0b6"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"b78c357239c5d6b45faca76a67eb5743f75b904f","unresolved":false,"context_lines":[{"line_number":5735,"context_line":"                # guest when it can use migrateToURI3. We could pass a flag"},{"line_number":5736,"context_line":"                # or check the version of libvirt from the guest but those"},{"line_number":5737,"context_line":"                # are also ugly alternatives."},{"line_number":5738,"context_line":"                migrate_disks \u003d device_names"},{"line_number":5739,"context_line":"            guest.migrate(self._live_migration_uri(dest),"},{"line_number":5740,"context_line":"                          flags\u003dmigration_flags,"},{"line_number":5741,"context_line":"                          domain_xml\u003dnew_xml_str,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_931322b8","line":5738,"updated":"2016-06-07 08:37:06.000000000","message":"Personally I\u0027d just pass device_names into the guest.migrate() method unconditionally, and then do this version check inside guest.migrate(). Same end result, but keeps the libvirt bits isolated in migrate()","commit_id":"6c682ac700159fa9c0f0e06acb730ef310dfc0b6"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1d0276288ceeeaa66d81ad386a7cad375b921e29","unresolved":false,"context_lines":[{"line_number":5735,"context_line":"                # guest when it can use migrateToURI3. We could pass a flag"},{"line_number":5736,"context_line":"                # or check the version of libvirt from the guest but those"},{"line_number":5737,"context_line":"                # are also ugly alternatives."},{"line_number":5738,"context_line":"                migrate_disks \u003d device_names"},{"line_number":5739,"context_line":"            guest.migrate(self._live_migration_uri(dest),"},{"line_number":5740,"context_line":"                          flags\u003dmigration_flags,"},{"line_number":5741,"context_line":"                          domain_xml\u003dnew_xml_str,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_caf78089","line":5738,"in_reply_to":"7aa08908_931322b8","updated":"2016-06-07 18:39:29.000000000","message":"The guest object doesn\u0027t have a handle to the host, I don\u0027t think anyway, otherwise I would have looked at doing that. Is there something I\u0027m missing?","commit_id":"6c682ac700159fa9c0f0e06acb730ef310dfc0b6"}],"nova/virt/libvirt/guest.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2aaffc019c769f0b4ed8a110693a10dd189f5bf8","unresolved":false,"context_lines":[{"line_number":515,"context_line":"           VIR_MIGRATE_OFFLINE Migrate offline"},{"line_number":516,"context_line":"        :param domain_xml: Changing guest configuration during migration"},{"line_number":517,"context_line":"        :param bandwidth: The maximun bandwidth in MiB/s"},{"line_number":518,"context_line":"        :param supports_migrate_with_attached_block_devices:"},{"line_number":519,"context_line":"        :param device_names: list of device names that are being migrated with"},{"line_number":520,"context_line":"            instance; this is only supported with libvirt\u003e\u003d1.2.17."},{"line_number":521,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_1b7127e1","line":518,"updated":"2016-06-06 18:40:46.000000000","message":"oops","commit_id":"fbdbe881954d41b8f02aae63992b7680bdd28fea"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"b78c357239c5d6b45faca76a67eb5743f75b904f","unresolved":false,"context_lines":[{"line_number":522,"context_line":"            self._domain.migrateToURI("},{"line_number":523,"context_line":"                destination, flags\u003dflags, bandwidth\u003dbandwidth)"},{"line_number":524,"context_line":"        else:"},{"line_number":525,"context_line":"            if device_names:"},{"line_number":526,"context_line":"                params \u003d {"},{"line_number":527,"context_line":"                    \u0027bandwidth\u0027: bandwidth,"},{"line_number":528,"context_line":"                    \u0027destination_xml\u0027: domain_xml,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_f369c626","line":525,"updated":"2016-06-07 08:37:06.000000000","message":"We should just check the version here instead imho.","commit_id":"6c682ac700159fa9c0f0e06acb730ef310dfc0b6"}]}