)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"11b2e005d9e93d9258a5af0f3056e41f86d9f5d0","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Revert \"Optimize _cleanup_incomplete_migrations periodic task\""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The change modified instance filtering condition, which filters all deleted instances on current host, which is not as expected by periodic task."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"The periodic task expects instances, whose instance uuid are associated with migration record. And after filtering we only need to apply the instance deletion logic on instance files where instance.host is not set as current host (CONF.host)."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7aa08908_3708d327","line":9,"updated":"2016-06-08 22:09:58.000000000","message":"Need to wrap these lines.","commit_id":"c5e8a808c40a099358f318885ff7eba8e3b91ed5"}],"nova/compute/manager.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"cca52b068fe741bea2efa88f87b69ba73663f107","unresolved":false,"context_lines":[{"line_number":6563,"context_line":"                context, inst_filters, expected_attrs\u003dattrs, use_slave\u003dTrue)"},{"line_number":6564,"context_line":""},{"line_number":6565,"context_line":"        for instance in instances:"},{"line_number":6566,"context_line":"            if instance.host !\u003d CONF.host:"},{"line_number":6567,"context_line":"                for migration in migrations:"},{"line_number":6568,"context_line":"                    if instance.uuid \u003d\u003d migration.instance_uuid:"},{"line_number":6569,"context_line":"                        # Delete instance files if not cleanup properly either"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_c419db23","line":6566,"range":{"start_line":6566,"start_character":12,"end_line":6566,"end_character":41},"updated":"2016-06-08 21:56:46.000000000","message":"I don\u0027t understand how this is any different from filtering the instance list up front by including the host, that we\u0027re filtering here. If we filter by CONF.host in the DB query, how is that any different from filtering out the instance here?","commit_id":"c5e8a808c40a099358f318885ff7eba8e3b91ed5"}]}