)]}'
{"nova/objects/resource_provider.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"1ece2bee0669f4ca8131a718aafdd6c8ad24b4e7","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    return db_rp"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"@db_api.api_context_manager.writer"},{"line_number":32,"context_line":"def _update_rp_in_db(context, id, updates):"},{"line_number":33,"context_line":"    db_rp \u003d context.session.query(models.ResourceProvider).filter_by("},{"line_number":34,"context_line":"        id\u003did).first()"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_2fa61353","line":31,"updated":"2016-06-07 19:31:01.000000000","message":"FWIW, https://bugs.launchpad.net/oslo.db/+bug/1520195 is now fixed/released so we should no longer need to have this module method (but I need to doublecheck if Nova now uses an oslo.db updated version)","commit_id":"0dbeae009b159a32f697da3ac3e186e3db377bdc"}],"nova/tests/functional/db/test_resource_provider.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"a8a2a983ff2ccfa16b55de32d006e12233e2fd3d","unresolved":false,"context_lines":[{"line_number":80,"context_line":"            self.context,"},{"line_number":81,"context_line":"            uuidsentinel.fake_resource_provider"},{"line_number":82,"context_line":"        )"},{"line_number":83,"context_line":"        self.assertEqual(\u0027new-name\u0027, retrieved_resource_provider.name)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def test_create_inventory_with_uncreated_provider(self):"},{"line_number":86,"context_line":"        resource_provider \u003d objects.ResourceProvider("}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_4fc39f38","line":83,"updated":"2016-06-07 19:17:52.000000000","message":"Can you add a quick unit test that validates the exception raised for a immutable field?","commit_id":"e2bcf317893cf70b432a076335df687c3eecd0e1"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"8d998097046614cefd769ab7e9e8005a2c2443ba","unresolved":false,"context_lines":[{"line_number":80,"context_line":"            self.context,"},{"line_number":81,"context_line":"            uuidsentinel.fake_resource_provider"},{"line_number":82,"context_line":"        )"},{"line_number":83,"context_line":"        self.assertEqual(\u0027new-name\u0027, retrieved_resource_provider.name)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def test_create_inventory_with_uncreated_provider(self):"},{"line_number":86,"context_line":"        resource_provider \u003d objects.ResourceProvider("}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_2fee13b4","line":83,"in_reply_to":"7aa08908_4fc39f38","updated":"2016-06-07 19:20:18.000000000","message":"It\u0027s done by https://review.openstack.org/#/c/326706/1/nova/tests/unit/objects/test_resource_provider.py","commit_id":"e2bcf317893cf70b432a076335df687c3eecd0e1"}],"nova/tests/unit/objects/test_objects.py":[{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"f885c58672791229caae3fa01b851e6ee2181a3d","unresolved":false,"context_lines":[{"line_number":1180,"context_line":"    \u0027Quotas\u0027: \u00271.2-1fe4cd50593aaf5d36a6dc5ab3f98fb3\u0027,"},{"line_number":1181,"context_line":"    \u0027QuotasNoOp\u0027: \u00271.2-e041ddeb7dc8188ca71706f78aad41c1\u0027,"},{"line_number":1182,"context_line":"    \u0027RequestSpec\u0027: \u00271.6-c1cb516acdf120d367a42d343ed695b5\u0027,"},{"line_number":1183,"context_line":"    \u0027ResourceProvider\u0027: \u00271.0-57f2a7e6fa50c6573af211521e83f8c7\u0027,"},{"line_number":1184,"context_line":"    \u0027S3ImageMapping\u0027: \u00271.0-7dd7366a890d82660ed121de9092276e\u0027,"},{"line_number":1185,"context_line":"    \u0027SchedulerLimits\u0027: \u00271.0-249c4bd8e62a9b327b7026b7f19cc641\u0027,"},{"line_number":1186,"context_line":"    \u0027SchedulerRetries\u0027: \u00271.1-3c9c8b16143ebbb6ad7030e999d14cc0\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_5f7ca6eb","line":1183,"updated":"2016-06-08 17:44:52.000000000","message":"Do we only need to bump the version when the fields change? I thought a method change also required a bump.","commit_id":"fbf87c4b4d89dcf67fb08ad618b93d8c02240fba"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"ce3d2481d6da9f19fb786eea59fbdedd1d77b16b","unresolved":false,"context_lines":[{"line_number":1180,"context_line":"    \u0027Quotas\u0027: \u00271.2-1fe4cd50593aaf5d36a6dc5ab3f98fb3\u0027,"},{"line_number":1181,"context_line":"    \u0027QuotasNoOp\u0027: \u00271.2-e041ddeb7dc8188ca71706f78aad41c1\u0027,"},{"line_number":1182,"context_line":"    \u0027RequestSpec\u0027: \u00271.6-c1cb516acdf120d367a42d343ed695b5\u0027,"},{"line_number":1183,"context_line":"    \u0027ResourceProvider\u0027: \u00271.0-57f2a7e6fa50c6573af211521e83f8c7\u0027,"},{"line_number":1184,"context_line":"    \u0027S3ImageMapping\u0027: \u00271.0-7dd7366a890d82660ed121de9092276e\u0027,"},{"line_number":1185,"context_line":"    \u0027SchedulerLimits\u0027: \u00271.0-249c4bd8e62a9b327b7026b7f19cc641\u0027,"},{"line_number":1186,"context_line":"    \u0027SchedulerRetries\u0027: \u00271.1-3c9c8b16143ebbb6ad7030e999d14cc0\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_4e016839","line":1183,"in_reply_to":"7aa08908_1adb4c1c","updated":"2016-06-09 13:11:19.000000000","message":"Ah, ok, thanks for the explanation.","commit_id":"fbf87c4b4d89dcf67fb08ad618b93d8c02240fba"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"ef476ddf3a9a19f4278266c1a7bb26fb5022fb9c","unresolved":false,"context_lines":[{"line_number":1180,"context_line":"    \u0027Quotas\u0027: \u00271.2-1fe4cd50593aaf5d36a6dc5ab3f98fb3\u0027,"},{"line_number":1181,"context_line":"    \u0027QuotasNoOp\u0027: \u00271.2-e041ddeb7dc8188ca71706f78aad41c1\u0027,"},{"line_number":1182,"context_line":"    \u0027RequestSpec\u0027: \u00271.6-c1cb516acdf120d367a42d343ed695b5\u0027,"},{"line_number":1183,"context_line":"    \u0027ResourceProvider\u0027: \u00271.0-57f2a7e6fa50c6573af211521e83f8c7\u0027,"},{"line_number":1184,"context_line":"    \u0027S3ImageMapping\u0027: \u00271.0-7dd7366a890d82660ed121de9092276e\u0027,"},{"line_number":1185,"context_line":"    \u0027SchedulerLimits\u0027: \u00271.0-249c4bd8e62a9b327b7026b7f19cc641\u0027,"},{"line_number":1186,"context_line":"    \u0027SchedulerRetries\u0027: \u00271.1-3c9c8b16143ebbb6ad7030e999d14cc0\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_1adb4c1c","line":1183,"in_reply_to":"7aa08908_5f7ca6eb","updated":"2016-06-08 18:04:18.000000000","message":"We should have put a note in here about this, but we\u0027re cheating here since we\u0027ve not sent this over RPC yet. Normally, definitely.","commit_id":"fbf87c4b4d89dcf67fb08ad618b93d8c02240fba"}]}