)]}'
{"nova/objects/compute_node.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"774d422b2fcc76d7c1a540fa4556dc42d45ca498","unresolved":false,"context_lines":[{"line_number":337,"context_line":"            rp \u003d objects.ResourceProvider.get_by_uuid(self._context, self.uuid)"},{"line_number":338,"context_line":"            if rp.name !\u003d rp_name:"},{"line_number":339,"context_line":"                rp.name \u003d rp_name"},{"line_number":340,"context_line":"                rp.save()"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"        return rp"},{"line_number":343,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_d2a3b6fe","line":340,"updated":"2016-06-07 19:35:12.000000000","message":"\\o/","commit_id":"20004abb514f44279d1b6d0c7d551456b0691443"}],"nova/tests/functional/db/test_compute_node.py":[{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"3288d64eb04235e5d1fffb613c7b3f52274ffe69","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                         rp.name)"},{"line_number":68,"context_line":"        self.cn.host \u003d \u0027bar\u0027"},{"line_number":69,"context_line":"        rp \u003d self.cn._ensure_resource_provider()"},{"line_number":70,"context_line":"        self.assertEqual(\u0027compute-%s-%s\u0027 % (\u0027bar\u0027, self.cn.uuid),"},{"line_number":71,"context_line":"                         rp.name)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_69aedee8","line":70,"range":{"start_line":70,"start_character":25,"end_line":70,"end_character":64},"updated":"2016-06-09 13:15:43.000000000","message":"Not that this is in scope for this patch, but I see this pattern repeated in the code and the tests so often that it should probably be refactored into a \u0027generate_rp_name()\u0027 method on the ResourceProvider object. Or even make \u0027name\u0027 a property that is based on the class and uuid. Or something other than repeating this pattern all over the code base.\n\nJus\u0027 sayin.","commit_id":"8da53e9bab40a256c709b2d9cc180bfd2671176c"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"ddb6ae398fc12cef037014a2bd59e27557b79140","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                         rp.name)"},{"line_number":68,"context_line":"        self.cn.host \u003d \u0027bar\u0027"},{"line_number":69,"context_line":"        rp \u003d self.cn._ensure_resource_provider()"},{"line_number":70,"context_line":"        self.assertEqual(\u0027compute-%s-%s\u0027 % (\u0027bar\u0027, self.cn.uuid),"},{"line_number":71,"context_line":"                         rp.name)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_267875f8","line":70,"range":{"start_line":70,"start_character":25,"end_line":70,"end_character":64},"in_reply_to":"7aa08908_69aedee8","updated":"2016-06-09 16:28:52.000000000","message":"You mean .. once in the code and once in the test? :)","commit_id":"8da53e9bab40a256c709b2d9cc180bfd2671176c"}]}