)]}'
{"nova/api/openstack/compute/floating_ips.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"5304559be8a626c3665ff5218c0b87ef19a69ca8","unresolved":false,"context_lines":[{"line_number":241,"context_line":"        if not fixed_address:"},{"line_number":242,"context_line":"            try:"},{"line_number":243,"context_line":"                fixed_address \u003d next(ip[\u0027address\u0027] for ip in fixed_ips"},{"line_number":244,"context_line":"                                     if netaddr.valid_ipv4(ip[\u0027address\u0027]))"},{"line_number":245,"context_line":"            except StopIteration:"},{"line_number":246,"context_line":"                msg \u003d _(\u0027Unable to associate floating IP %(address)s \u0027"},{"line_number":247,"context_line":"                        \u0027to any fixed IPs for instance %(id)s. \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_b4af5693","side":"PARENT","line":244,"range":{"start_line":244,"start_character":37,"end_line":244,"end_character":73},"updated":"2016-06-10 02:59:32.000000000","message":"As the commit message said, here didn\u0027t work at all because of raising AddrFormatError instead of True/False.\n\nSo can we add the corresponding unit test which calls _add_floating_ip() to reproduce this problem?","commit_id":"b4b13b04574672e634a3f0f2066f22bfb8bfef1e"}],"nova/tests/unit/api/openstack/compute/test_floating_ips.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"f530c8ef79c596e3facbc7b41b28b60a868c6f23","unresolved":false,"context_lines":[{"line_number":585,"context_line":"    def test_associate_floating_ip_v4v6_fixed_ip(self, fixed_ips_mock):"},{"line_number":586,"context_line":"        fixed_address \u003d \u0027192.168.1.100\u0027"},{"line_number":587,"context_line":"        fixed_ips_mock.return_value \u003d [{\u0027address\u0027: \u0027fc00:2001:db8::100\u0027},"},{"line_number":588,"context_line":"                                       {\u0027address\u0027: fixed_address},"},{"line_number":589,"context_line":"                                       {\u0027address\u0027: \u0027\u0027}]"},{"line_number":590,"context_line":"        self._test_floating_ip_associate(fixed_address\u003dfixed_address)"},{"line_number":591,"context_line":""},{"line_number":592,"context_line":"    @mock.patch.object(network.model.NetworkInfo, \u0027fixed_ips\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_25328e10","line":589,"range":{"start_line":588,"start_character":0,"end_line":589,"end_character":55},"updated":"2016-06-14 01:32:57.000000000","message":"Even if reverting the code part of this patch, this new test cannot detect the bug like the following:\n\n $ tox -e py27 nova.tests.unit.api.openstack.compute.test_floating_ips.FloatingIpTestV21.test_associate_floating_ip_v4v6_fixed_ip\n [..]\n \u003d\u003d\u003d\u003d\u003d\u003d\n Totals\n \u003d\u003d\u003d\u003d\u003d\u003d\n Ran: 1 tests in 24.0000 sec.\n - Passed: 1\n - Skipped: 0\n - Expected Fail: 0\n - Unexpected Success: 0\n - Failed: 0\n Sum of execute time for each test: 3.8841 sec.","commit_id":"1b5e295fecbc5ea21dbcc8f50e2e3d2d2f826da8"}]}