)]}'
{"nova/network/neutronv2/api.py":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"bf1f6fbc42976d816ce6ad314ca5aeaa206770a5","unresolved":false,"context_lines":[{"line_number":171,"context_line":"            network_model.VIF_TYPE_BINDING_FAILED):"},{"line_number":172,"context_line":"            port_id \u003d port_response[\u0027port\u0027][\u0027id\u0027]"},{"line_number":173,"context_line":"            if delete_on_error:"},{"line_number":174,"context_line":"                port_client.delete_port(port_id)"},{"line_number":175,"context_line":"            raise exception.PortBindingFailed(port_id\u003dport_id)"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"    def _create_port(self, port_client, instance, network_id, port_req_body,"}],"source_content_type":"text/x-python","patch_set":11,"id":"3aaa91ec_321cbd69","side":"PARENT","line":174,"updated":"2016-06-23 17:36:12.000000000","message":"wait... we just added this in the last patch?","commit_id":"015d1a52fbbb855255546ecc0c68008a02a3bc6c"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"951bb1c482b75ba96326d8b9b031345cb548bc51","unresolved":false,"context_lines":[{"line_number":171,"context_line":"            network_model.VIF_TYPE_BINDING_FAILED):"},{"line_number":172,"context_line":"            port_id \u003d port_response[\u0027port\u0027][\u0027id\u0027]"},{"line_number":173,"context_line":"            if delete_on_error:"},{"line_number":174,"context_line":"                port_client.delete_port(port_id)"},{"line_number":175,"context_line":"            raise exception.PortBindingFailed(port_id\u003dport_id)"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"    def _create_port(self, port_client, instance, network_id, port_req_body,"}],"source_content_type":"text/x-python","patch_set":11,"id":"3aaa91ec_35af122d","side":"PARENT","line":174,"in_reply_to":"3aaa91ec_321cbd69","updated":"2016-06-27 12:57:18.000000000","message":"so we added the if in the last patch, and now this is only used in the case where we pass false. its a bit crazy.","commit_id":"015d1a52fbbb855255546ecc0c68008a02a3bc6c"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"152087dd2e015f491be6b27cfdddbce49d82ea87","unresolved":false,"context_lines":[{"line_number":217,"context_line":"                with excutils.save_and_reraise_exception():"},{"line_number":218,"context_line":"                    port_client.delete_port(port_id)"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"            port_id \u003d port_response[\u0027port\u0027][\u0027id\u0027]"},{"line_number":221,"context_line":"            LOG.debug(\u0027Successfully created port: %s\u0027, port_id,"},{"line_number":222,"context_line":"                      instance\u003dinstance)"},{"line_number":223,"context_line":"            return port_id"}],"source_content_type":"text/x-python","patch_set":12,"id":"3aaa91ec_d76ba4b7","line":220,"updated":"2016-06-29 16:55:42.000000000","message":"port_id is already defined on line 213.","commit_id":"43f141ebb7d84ec5bf4196b3ef2ff15a4b770c44"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"e944b9da6c8772b0ebed38175752b1dc96b6851e","unresolved":false,"context_lines":[{"line_number":217,"context_line":"                with excutils.save_and_reraise_exception():"},{"line_number":218,"context_line":"                    port_client.delete_port(port_id)"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"            port_id \u003d port_response[\u0027port\u0027][\u0027id\u0027]"},{"line_number":221,"context_line":"            LOG.debug(\u0027Successfully created port: %s\u0027, port_id,"},{"line_number":222,"context_line":"                      instance\u003dinstance)"},{"line_number":223,"context_line":"            return port_id"}],"source_content_type":"text/x-python","patch_set":12,"id":"3aaa91ec_5584b009","line":220,"in_reply_to":"3aaa91ec_d76ba4b7","updated":"2016-06-30 08:37:45.000000000","message":"dam, stupid merge conflict.","commit_id":"43f141ebb7d84ec5bf4196b3ef2ff15a4b770c44"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"152087dd2e015f491be6b27cfdddbce49d82ea87","unresolved":false,"context_lines":[{"line_number":680,"context_line":"                self._update_port("},{"line_number":681,"context_line":"                    port_client, instance, port_id, port_req_body)"},{"line_number":682,"context_line":""},{"line_number":683,"context_line":"                if request.port_id:"},{"line_number":684,"context_line":"                    # only add if update worked and port create not called"},{"line_number":685,"context_line":"                    preexisting_port_ids.append(port_id)"},{"line_number":686,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"3aaa91ec_74374eff","line":683,"updated":"2016-06-29 16:55:42.000000000","message":"Small nit but this could just be port_id.","commit_id":"43f141ebb7d84ec5bf4196b3ef2ff15a4b770c44"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"e944b9da6c8772b0ebed38175752b1dc96b6851e","unresolved":false,"context_lines":[{"line_number":680,"context_line":"                self._update_port("},{"line_number":681,"context_line":"                    port_client, instance, port_id, port_req_body)"},{"line_number":682,"context_line":""},{"line_number":683,"context_line":"                if request.port_id:"},{"line_number":684,"context_line":"                    # only add if update worked and port create not called"},{"line_number":685,"context_line":"                    preexisting_port_ids.append(port_id)"},{"line_number":686,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"3aaa91ec_75960c3f","line":683,"in_reply_to":"3aaa91ec_74374eff","updated":"2016-06-30 08:37:45.000000000","message":"It can\u0027t, because port_id now might be for the created port. This is making sure the user requested a specific port.","commit_id":"43f141ebb7d84ec5bf4196b3ef2ff15a4b770c44"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"1698addd0ee87d81454a48754ec6af99d0b747d2","unresolved":false,"context_lines":[{"line_number":680,"context_line":"                self._update_port("},{"line_number":681,"context_line":"                    port_client, instance, port_id, port_req_body)"},{"line_number":682,"context_line":""},{"line_number":683,"context_line":"                if request.port_id:"},{"line_number":684,"context_line":"                    # only add if update worked and port create not called"},{"line_number":685,"context_line":"                    preexisting_port_ids.append(port_id)"},{"line_number":686,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"3aaa91ec_b7106a5a","line":683,"in_reply_to":"3aaa91ec_75960c3f","updated":"2016-06-30 13:26:03.000000000","message":"Where is \u0027request\u0027 being modified between 666 and here? I must be missing something.\n\nIf this is, or can be, different from the port_id above can we rename the two variable to indicate that?","commit_id":"43f141ebb7d84ec5bf4196b3ef2ff15a4b770c44"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"c023c479b9ecf2400d07807041530febbb394372","unresolved":false,"context_lines":[{"line_number":680,"context_line":"                self._update_port("},{"line_number":681,"context_line":"                    port_client, instance, port_id, port_req_body)"},{"line_number":682,"context_line":""},{"line_number":683,"context_line":"                if request.port_id:"},{"line_number":684,"context_line":"                    # only add if update worked and port create not called"},{"line_number":685,"context_line":"                    preexisting_port_ids.append(port_id)"},{"line_number":686,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"3aaa91ec_e33eb4b6","line":683,"in_reply_to":"3aaa91ec_b7106a5a","updated":"2016-06-30 14:13:54.000000000","message":"It\u0027s not, but port_id is, on L671. He needs to know if a port was originally requested, which is in request and unchanged. To distinguish between the case where we now have a port_id because we created it.","commit_id":"43f141ebb7d84ec5bf4196b3ef2ff15a4b770c44"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"3e936435c4ade470f812978200e4b806ff4b1959","unresolved":false,"context_lines":[{"line_number":680,"context_line":"                self._update_port("},{"line_number":681,"context_line":"                    port_client, instance, port_id, port_req_body)"},{"line_number":682,"context_line":""},{"line_number":683,"context_line":"                if request.port_id:"},{"line_number":684,"context_line":"                    # only add if update worked and port create not called"},{"line_number":685,"context_line":"                    preexisting_port_ids.append(port_id)"},{"line_number":686,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"3aaa91ec_6ea62bc2","line":683,"in_reply_to":"3aaa91ec_e33eb4b6","updated":"2016-06-30 14:34:33.000000000","message":"Ahh, okay. That\u0027s where I was being stupid.","commit_id":"43f141ebb7d84ec5bf4196b3ef2ff15a4b770c44"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"43af7063436aa91b1d4a8bf810080f34f5aff840","unresolved":false,"context_lines":[{"line_number":256,"context_line":"            _ensure_no_port_binding_failure(port)"},{"line_number":257,"context_line":"            LOG.debug(\u0027Successfully updated port: %s\u0027, port_id,"},{"line_number":258,"context_line":"                      instance\u003dinstance)"},{"line_number":259,"context_line":"            return port"},{"line_number":260,"context_line":"        except neutron_client_exc.MacAddressInUseClient:"},{"line_number":261,"context_line":"            mac_address \u003d port_req_body[\u0027port\u0027][\u0027mac_address\u0027]"},{"line_number":262,"context_line":"            network_id \u003d port_req_body[\u0027port\u0027][\u0027network_id\u0027]"}],"source_content_type":"text/x-python","patch_set":16,"id":"3aaa91ec_fd6f7328","line":259,"updated":"2016-06-30 14:14:28.000000000","message":"I almost made this change yesterday, but didn\u0027t really need it. +1 for consistency and making the port available always to the caller.","commit_id":"15c583cb7c2d8fbad7c2334971a49ab520d22fa3"}]}