)]}'
{"api-ref/source/os-assisted-volume-snapshots.inc":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"9467e2d96df5e4a127ff9a73b81547e1917c1514","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"  - id: snapshot_id"},{"line_number":48,"context_line":"  - volume_id: volume_id"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"**Example Create Assisted Volume Snapshots: JSON response**"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"7aa08908_f158028d","line":47,"updated":"2016-06-09 10:22:07.000000000","message":"you are missing the snapshot: snapshot bit here on the line above.","commit_id":"dc7630a7546ee83d7cdef7da8e11152b363dfa16"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e4ddc6776ae810b3b60ed6c3d9a40ff975b4d607","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"  - id: snapshot_id"},{"line_number":48,"context_line":"  - volume_id: volume_id"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"**Example Create Assisted Volume Snapshots: JSON response**"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"7aa08908_114bd1b1","line":47,"in_reply_to":"7aa08908_f158028d","updated":"2016-06-10 08:27:11.000000000","message":"ops, Thanks. Done","commit_id":"dc7630a7546ee83d7cdef7da8e11152b363dfa16"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"9467e2d96df5e4a127ff9a73b81547e1917c1514","unresolved":false,"context_lines":[{"line_number":74,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"  - snapshot_id: snapshot_id"},{"line_number":77,"context_line":"  - delete_info: delete_info"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Response"},{"line_number":80,"context_line":"--------"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"7aa08908_51a63654","line":77,"updated":"2016-06-09 10:22:07.000000000","message":"I think we don\u0027t need the full delete request sample twice, as seen here:\nhttps://git.openstack.org/cgit/openstack/nova/tree/api-ref/source/parameters.yaml#n342","commit_id":"dc7630a7546ee83d7cdef7da8e11152b363dfa16"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e4ddc6776ae810b3b60ed6c3d9a40ff975b4d607","unresolved":false,"context_lines":[{"line_number":74,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"  - snapshot_id: snapshot_id"},{"line_number":77,"context_line":"  - delete_info: delete_info"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Response"},{"line_number":80,"context_line":"--------"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"7aa08908_7194d5e7","line":77,"in_reply_to":"7aa08908_51a63654","updated":"2016-06-10 08:27:11.000000000","message":"Yea nice catch. I removed that info from its definition as L64 states the same","commit_id":"dc7630a7546ee83d7cdef7da8e11152b363dfa16"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"9369c9480fc07b8e886c098206c155a7b03acc5e","unresolved":false,"context_lines":[{"line_number":4,"context_line":" Assisted volume snapshots (os-assisted-volume-snapshots)"},{"line_number":5,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Creates and deletes snapshots through an emulator/hypervisor. The qcow2"},{"line_number":8,"context_line":"file format is supported."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"An internal snapshot that lacks storage such as NFS or GlusterFS can use"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"7aa08908_b01bcdc9","line":7,"range":{"start_line":7,"start_character":66,"end_line":7,"end_character":71},"updated":"2016-06-10 12:20:14.000000000","message":"seems only libvirt use this , shall we mention it?\n\nother virt will call the function but they actually only raise 501 in compute layer (not api layer)?","commit_id":"e38bf94e315a7c6c03cf275ae30b1239bf175a41"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"9369c9480fc07b8e886c098206c155a7b03acc5e","unresolved":false,"context_lines":[{"line_number":45,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"  - snapshot: snapshot"},{"line_number":48,"context_line":"  - id: snapshot_id"},{"line_number":49,"context_line":"  - volume_id: volume_id"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"**Example Create Assisted Volume Snapshots: JSON response**"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"7aa08908_833f6924","line":48,"range":{"start_line":48,"start_character":8,"end_line":48,"end_character":19},"updated":"2016-06-10 12:20:14.000000000","message":"https://github.com/openstack/nova/blob/master/nova/compute/api.py#L3461\nseems this \u0027id\u0027 is different to \u0027snapshot_id\u0027? \ncurious where we get this value from?\n\nseems \u0027id\u0027 is not in create_info?","commit_id":"e38bf94e315a7c6c03cf275ae30b1239bf175a41"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"13dd51965d858d93163b53965f23c2efa5fde85c","unresolved":false,"context_lines":[{"line_number":45,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"  - snapshot: snapshot"},{"line_number":48,"context_line":"  - id: snapshot_id"},{"line_number":49,"context_line":"  - volume_id: volume_id"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"**Example Create Assisted Volume Snapshots: JSON response**"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"7aa08908_7c270c12","line":48,"range":{"start_line":48,"start_character":8,"end_line":48,"end_character":19},"in_reply_to":"7aa08908_833f6924","updated":"2016-06-14 08:29:36.000000000","message":"I think it is snapshot id only passed in create_info.\nand this looks like duplicate id in request which should be used while deleting the snapshot but that may be wrong if different one is passed in create_info then, cinder would not be able to find the snapshot for status update.","commit_id":"e38bf94e315a7c6c03cf275ae30b1239bf175a41"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"7d052e7307b302c1f02e39da6a3718726155e06d","unresolved":false,"context_lines":[{"line_number":4,"context_line":" Assisted volume snapshots (os-assisted-volume-snapshots)"},{"line_number":5,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Creates and deletes snapshots through an emulator/hypervisor. The qcow2"},{"line_number":8,"context_line":"file format is supported."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"This API is only implemented by the libvirt compute driver. For other"},{"line_number":11,"context_line":"compute drivers, 501 will be returned."}],"source_content_type":"text/x-c++src","patch_set":4,"id":"3aaa91ec_72e622b1","line":8,"range":{"start_line":7,"start_character":62,"end_line":8,"end_character":25},"updated":"2016-06-24 10:08:30.000000000","message":"actually only qcow2 is supported:\nMaybe note it also only works for qcow2 disk types:\nhttps://git.openstack.org/cgit/openstack/nova/tree/nova/virt/libvirt/driver.py#n1878","commit_id":"3e0aba2dd1c7b661caaa024728ccc8266f6090e0"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"7d052e7307b302c1f02e39da6a3718726155e06d","unresolved":false,"context_lines":[{"line_number":11,"context_line":"compute drivers, 501 will be returned."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"An internal snapshot that lacks storage such as NFS or GlusterFS can use"},{"line_number":14,"context_line":"an emulator/hypervisor to add the snapshot feature."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Create Assisted Volume Snapshots"},{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"3aaa91ec_f2e332a2","line":14,"updated":"2016-06-24 10:08:30.000000000","message":"So this isn\u0027t clear, but what I think it is trying to say, is this API is only ever called by Cinder, where it is used to create a snapshot for drivers that extend the remotefs cinder driver:\nhttps://github.com/openstack/cinder/blob/5792f2f9215fb2af09cc5aad04c47c2270b98b35/cinder/volume/drivers/remotefs.py#L1296\n\nWe should probably say this API is only really here for cinder to call it.\n\nInterestingly, it never passes in or reads that \"id\" in the create_info.","commit_id":"3e0aba2dd1c7b661caaa024728ccc8266f6090e0"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"3467f71633a355185089b26b7f7f29f4bf8b4acd","unresolved":false,"context_lines":[{"line_number":11,"context_line":"compute drivers, 501 will be returned."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"An internal snapshot that lacks storage such as NFS or GlusterFS can use"},{"line_number":14,"context_line":"an emulator/hypervisor to add the snapshot feature."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Create Assisted Volume Snapshots"},{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"3aaa91ec_79d00c54","line":14,"in_reply_to":"3aaa91ec_f2e332a2","updated":"2016-06-29 06:36:40.000000000","message":"Done.\nYea \"id\" in the create_info seems very odd to me too. If that is passed other than snapshot_id then same is returned in response. Which cannot be used from response as cinder store snapshot in DB only with snapshot_id. So \"id\" seems un-useful for me.\nI will put a patch to return the snapshot_id in response and see if that looks fine.","commit_id":"3e0aba2dd1c7b661caaa024728ccc8266f6090e0"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"483639b0f992b0038f11779ece8814e22b7c2a53","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"  - snapshot: snapshot"},{"line_number":34,"context_line":"  - volume_id: volume_id"},{"line_number":35,"context_line":"  - create_info: create_info"},{"line_number":36,"context_line":"  - snapshot_id: snapshot_id"},{"line_number":37,"context_line":"  - type: type-os-assisted-volume-snapshot"},{"line_number":38,"context_line":"  - new_file: new_file"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"3aaa91ec_120cfeeb","line":35,"updated":"2016-06-24 09:53:29.000000000","message":"So actually you can optionally pass in an \"id\" also:\nhttps://git.openstack.org/cgit/openstack/nova/tree/nova/api/openstack/compute/schemas/assisted_volume_snapshots.py#n36\n\nIt turns out its a string that gets passed back in the response.","commit_id":"3e0aba2dd1c7b661caaa024728ccc8266f6090e0"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"3467f71633a355185089b26b7f7f29f4bf8b4acd","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"  - snapshot: snapshot"},{"line_number":34,"context_line":"  - volume_id: volume_id"},{"line_number":35,"context_line":"  - create_info: create_info"},{"line_number":36,"context_line":"  - snapshot_id: snapshot_id"},{"line_number":37,"context_line":"  - type: type-os-assisted-volume-snapshot"},{"line_number":38,"context_line":"  - new_file: new_file"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"3aaa91ec_1eba8e0a","line":35,"in_reply_to":"3aaa91ec_120cfeeb","updated":"2016-06-29 06:36:40.000000000","message":"Yea, nice catch. Done","commit_id":"3e0aba2dd1c7b661caaa024728ccc8266f6090e0"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"483639b0f992b0038f11779ece8814e22b7c2a53","unresolved":false,"context_lines":[{"line_number":35,"context_line":"  - create_info: create_info"},{"line_number":36,"context_line":"  - snapshot_id: snapshot_id"},{"line_number":37,"context_line":"  - type: type-os-assisted-volume-snapshot"},{"line_number":38,"context_line":"  - new_file: new_file"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"**Example Create Assisted Volume Snapshots: JSON request**"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":4,"id":"3aaa91ec_92946e43","line":38,"updated":"2016-06-24 09:53:29.000000000","message":"Nit: I wonder if create_info.snapshot_id would be a good idea here, to make it clear?","commit_id":"3e0aba2dd1c7b661caaa024728ccc8266f6090e0"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"3467f71633a355185089b26b7f7f29f4bf8b4acd","unresolved":false,"context_lines":[{"line_number":35,"context_line":"  - create_info: create_info"},{"line_number":36,"context_line":"  - snapshot_id: snapshot_id"},{"line_number":37,"context_line":"  - type: type-os-assisted-volume-snapshot"},{"line_number":38,"context_line":"  - new_file: new_file"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"**Example Create Assisted Volume Snapshots: JSON request**"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":4,"id":"3aaa91ec_7e3752b0","line":38,"in_reply_to":"3aaa91ec_92946e43","updated":"2016-06-29 06:36:40.000000000","message":"Yea that\u0027s much more clear","commit_id":"3e0aba2dd1c7b661caaa024728ccc8266f6090e0"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"483639b0f992b0038f11779ece8814e22b7c2a53","unresolved":false,"context_lines":[{"line_number":48,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"  - snapshot: snapshot"},{"line_number":51,"context_line":"  - id: snapshot_id"},{"line_number":52,"context_line":"  - volume_id: volume_id"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"**Example Create Assisted Volume Snapshots: JSON response**"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"3aaa91ec_d2ec36f5","line":51,"updated":"2016-06-24 09:53:29.000000000","message":"so this is odd, its really just the idea passed in during create_info... which in the sample is an int, but the json validation says must be a string:\nhttps://git.openstack.org/cgit/openstack/nova/tree/nova/api/openstack/compute/schemas/assisted_volume_snapshots.py#n36\n\nhttps://git.openstack.org/cgit/openstack/nova/tree/nova/compute/api.py#n3453","commit_id":"3e0aba2dd1c7b661caaa024728ccc8266f6090e0"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"3467f71633a355185089b26b7f7f29f4bf8b4acd","unresolved":false,"context_lines":[{"line_number":48,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"  - snapshot: snapshot"},{"line_number":51,"context_line":"  - id: snapshot_id"},{"line_number":52,"context_line":"  - volume_id: volume_id"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"**Example Create Assisted Volume Snapshots: JSON response**"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"3aaa91ec_fe4b4229","line":51,"in_reply_to":"3aaa91ec_d2ec36f5","updated":"2016-06-29 06:36:40.000000000","message":"Ahh, ll fix the sample.","commit_id":"3e0aba2dd1c7b661caaa024728ccc8266f6090e0"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"bb39c395b682d439450ca354f90cfa91f78c2e47","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"  - snapshot: snapshot"},{"line_number":51,"context_line":"  - id: snapshot_id"},{"line_number":52,"context_line":"  - volume_id: volume_id"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"**Example Create Assisted Volume Snapshots: JSON response**"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":4,"id":"3aaa91ec_2fcf212a","line":52,"range":{"start_line":52,"start_character":4,"end_line":52,"end_character":13},"updated":"2016-06-24 05:25:35.000000000","message":"It should be \u0027volumeId\u0027.","commit_id":"3e0aba2dd1c7b661caaa024728ccc8266f6090e0"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"3467f71633a355185089b26b7f7f29f4bf8b4acd","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"  - snapshot: snapshot"},{"line_number":51,"context_line":"  - id: snapshot_id"},{"line_number":52,"context_line":"  - volume_id: volume_id"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"**Example Create Assisted Volume Snapshots: JSON response**"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":4,"id":"3aaa91ec_de464620","line":52,"range":{"start_line":52,"start_character":4,"end_line":52,"end_character":13},"in_reply_to":"3aaa91ec_2fcf212a","updated":"2016-06-29 06:36:40.000000000","message":"ops, Thanks, very nice catch.","commit_id":"3e0aba2dd1c7b661caaa024728ccc8266f6090e0"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"317ab02d96acbc13401a79f286ea968211d62e1d","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"To make this request, add the ``delete_info`` query parameter to the URI, as follows:"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"DELETE /os-assisted-volume-snapshots?delete_info\u003d\u0027{\"volume_id\": \"521752a6-acf6-4b2d-bc7a-119f9148cd8c\"}\u0027"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"Normal response codes: 204"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":4,"id":"3aaa91ec_d2ae192d","line":68,"range":{"start_line":68,"start_character":0,"end_line":68,"end_character":104},"updated":"2016-06-29 15:29:02.000000000","message":"here","commit_id":"3e0aba2dd1c7b661caaa024728ccc8266f6090e0"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"bb39c395b682d439450ca354f90cfa91f78c2e47","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"  - snapshot_id: snapshot_id"},{"line_number":81,"context_line":"  - delete_info: delete_info"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"Response"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"3aaa91ec_0feb4579","line":80,"range":{"start_line":80,"start_character":17,"end_line":80,"end_character":28},"updated":"2016-06-24 05:25:35.000000000","message":"It is not a body parameter but a path parameter.","commit_id":"3e0aba2dd1c7b661caaa024728ccc8266f6090e0"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"3467f71633a355185089b26b7f7f29f4bf8b4acd","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"  - snapshot_id: snapshot_id"},{"line_number":81,"context_line":"  - delete_info: delete_info"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"Response"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"3aaa91ec_d40e2531","line":80,"range":{"start_line":80,"start_character":17,"end_line":80,"end_character":28},"in_reply_to":"3aaa91ec_0feb4579","updated":"2016-06-29 06:36:40.000000000","message":"Done","commit_id":"3e0aba2dd1c7b661caaa024728ccc8266f6090e0"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"bb39c395b682d439450ca354f90cfa91f78c2e47","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"  - snapshot_id: snapshot_id"},{"line_number":81,"context_line":"  - delete_info: delete_info"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"Response"},{"line_number":84,"context_line":"--------"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"3aaa91ec_8f8e15ce","line":81,"range":{"start_line":80,"start_character":4,"end_line":81,"end_character":28},"updated":"2016-06-24 05:25:35.000000000","message":"They are optional parameters.","commit_id":"3e0aba2dd1c7b661caaa024728ccc8266f6090e0"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"317ab02d96acbc13401a79f286ea968211d62e1d","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"  - snapshot_id: snapshot_id"},{"line_number":81,"context_line":"  - delete_info: delete_info"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"Response"},{"line_number":84,"context_line":"--------"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"3aaa91ec_729645f1","line":81,"range":{"start_line":80,"start_character":4,"end_line":81,"end_character":28},"in_reply_to":"3aaa91ec_8044581b","updated":"2016-06-29 15:29:02.000000000","message":"If so, should Line 68 be the following?\n\nDELETE /os-assisted-volume-snapshots/{snapshot_id}?delete_info\u003d\u0027{\"volume_id\": \"521752a6-acf6-4b2d-bc7a-119f9148cd8c\"}\u0027","commit_id":"3e0aba2dd1c7b661caaa024728ccc8266f6090e0"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"7d052e7307b302c1f02e39da6a3718726155e06d","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"  - snapshot_id: snapshot_id"},{"line_number":81,"context_line":"  - delete_info: delete_info"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"Response"},{"line_number":84,"context_line":"--------"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"3aaa91ec_f5bcbc07","line":81,"range":{"start_line":80,"start_character":4,"end_line":81,"end_character":28},"in_reply_to":"3aaa91ec_8f8e15ce","updated":"2016-06-24 10:08:30.000000000","message":"No, they seem to be required:\nhttps://git.openstack.org/cgit/openstack/nova/tree/nova/api/openstack/compute/assisted_volume_snapshots.py#n71","commit_id":"3e0aba2dd1c7b661caaa024728ccc8266f6090e0"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"95559646fb56ca9189651c3910b28410997c610d","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"  - snapshot_id: snapshot_id"},{"line_number":81,"context_line":"  - delete_info: delete_info"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"Response"},{"line_number":84,"context_line":"--------"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"3aaa91ec_8044581b","line":81,"range":{"start_line":80,"start_character":4,"end_line":81,"end_character":28},"in_reply_to":"3aaa91ec_9d996171","updated":"2016-06-29 08:04:14.000000000","message":"Both are required here, it will through error if delete_info is not being passed[1]. and  {snapshot_id} is the always required as it is part of url otherwise 404. \n\n1.. https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/assisted_volume_snapshots.py#L71","commit_id":"3e0aba2dd1c7b661caaa024728ccc8266f6090e0"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"3467f71633a355185089b26b7f7f29f4bf8b4acd","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"  - snapshot_id: snapshot_id"},{"line_number":81,"context_line":"  - delete_info: delete_info"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"Response"},{"line_number":84,"context_line":"--------"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"3aaa91ec_fe7ce221","line":81,"range":{"start_line":80,"start_character":4,"end_line":81,"end_character":28},"in_reply_to":"3aaa91ec_f5bcbc07","updated":"2016-06-29 06:36:40.000000000","message":"yea its required with volume_id at least","commit_id":"3e0aba2dd1c7b661caaa024728ccc8266f6090e0"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"49efe2f3bc19c93b37d9873a2bb7d7944eb85133","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"  - snapshot_id: snapshot_id"},{"line_number":81,"context_line":"  - delete_info: delete_info"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"Response"},{"line_number":84,"context_line":"--------"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"3aaa91ec_9d996171","line":81,"range":{"start_line":80,"start_character":4,"end_line":81,"end_character":28},"in_reply_to":"3aaa91ec_fe7ce221","updated":"2016-06-29 07:43:23.000000000","message":"What I wanted to say was that its is enough to specify either one of 2 parameters.","commit_id":"3e0aba2dd1c7b661caaa024728ccc8266f6090e0"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"7d052e7307b302c1f02e39da6a3718726155e06d","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"  - snapshot_id: snapshot_id"},{"line_number":81,"context_line":"  - delete_info: delete_info"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"Response"},{"line_number":84,"context_line":"--------"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":4,"id":"3aaa91ec_757a8c78","line":82,"updated":"2016-06-24 10:08:30.000000000","message":"Hang on, delete should have a sample file, but we just don\u0027t have one in tree.","commit_id":"3e0aba2dd1c7b661caaa024728ccc8266f6090e0"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"3467f71633a355185089b26b7f7f29f4bf8b4acd","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"  - snapshot_id: snapshot_id"},{"line_number":81,"context_line":"  - delete_info: delete_info"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"Response"},{"line_number":84,"context_line":"--------"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":4,"id":"3aaa91ec_be441a74","line":82,"in_reply_to":"3aaa91ec_757a8c78","updated":"2016-06-29 06:36:40.000000000","message":"This does not have request or response body, so sample file not needed.  delete_info are passed in path only.","commit_id":"3e0aba2dd1c7b661caaa024728ccc8266f6090e0"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"c8bbd68497ab0efa8c20bbe13a4e0a603c94b962","unresolved":false,"context_lines":[{"line_number":41,"context_line":"  - create_info.snapshot_id: snapshot_id"},{"line_number":42,"context_line":"  - create_info.type: type-os-assisted-volume-snapshot"},{"line_number":43,"context_line":"  - create_info.new_file: new_file"},{"line_number":44,"context_line":"  - create_info.id: create_info_snapshot_id"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"**Example Create Assisted Volume Snapshots: JSON request**"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":7,"id":"3aaa91ec_e0255cc2","line":44,"range":{"start_line":44,"start_character":20,"end_line":44,"end_character":43},"updated":"2016-06-29 08:23:20.000000000","message":"This is not the snapshot_id, this is a random string that is returned in the response","commit_id":"b39431c1a3109ccb5c0ecfa533fd8a0dce7727fe"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"c8bbd68497ab0efa8c20bbe13a4e0a603c94b962","unresolved":false,"context_lines":[{"line_number":54,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"  - snapshot: snapshot"},{"line_number":57,"context_line":"  - id: snapshot_id"},{"line_number":58,"context_line":"  - volumeId: volume_id"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"**Example Create Assisted Volume Snapshots: JSON response**"}],"source_content_type":"text/x-c++src","patch_set":7,"id":"3aaa91ec_2007641d","line":57,"range":{"start_line":57,"start_character":8,"end_line":57,"end_character":19},"updated":"2016-06-29 08:23:20.000000000","message":"This is the same as the create_info_snapshot_id, well in reverse, this value is what ever was sent in the request.","commit_id":"b39431c1a3109ccb5c0ecfa533fd8a0dce7727fe"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"5aa6046a18f84f90b26e3d2059e67fda50d91f52","unresolved":false,"context_lines":[{"line_number":65,"context_line":"Delete Assisted Volume Snapshot"},{"line_number":66,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":".. rest_method:: DELETE /os-assisted-volume-snapshots/{snapshot_id}"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"Deletes an assisted volume snapshot."},{"line_number":71,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":7,"id":"3aaa91ec_1d78d1f1","line":68,"range":{"start_line":68,"start_character":17,"end_line":68,"end_character":67},"updated":"2016-06-29 07:50:42.000000000","message":"Currently \u0027snapshot_id\u0027 is unused (in nova/virt/libvirt/driver.py).\nIMO, \u0027DELETE /os-assisted-volume-snapshots/{snapshot_id}\u0027 can be removed.","commit_id":"b39431c1a3109ccb5c0ecfa533fd8a0dce7727fe"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"4c686611207488e1864f61cb56a0dc05a10a048a","unresolved":false,"context_lines":[{"line_number":65,"context_line":"Delete Assisted Volume Snapshot"},{"line_number":66,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":".. rest_method:: DELETE /os-assisted-volume-snapshots/{snapshot_id}"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"Deletes an assisted volume snapshot."},{"line_number":71,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":7,"id":"3aaa91ec_e020bc4b","line":68,"range":{"start_line":68,"start_character":17,"end_line":68,"end_character":67},"in_reply_to":"3aaa91ec_1d78d1f1","updated":"2016-06-29 08:07:11.000000000","message":"This is url of this API and cannot be removed.\n\nAlso snapshot_id is being used for cinder snapshot status update - https://github.com/openstack/nova/blob/19037640ea35e98cf073c21263f82d10b52e790b/nova/virt/libvirt/driver.py#L1944","commit_id":"b39431c1a3109ccb5c0ecfa533fd8a0dce7727fe"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"84b0152b384a18b08a5c21a3756f5de02e6df9ad","unresolved":false,"context_lines":[{"line_number":65,"context_line":"Delete Assisted Volume Snapshot"},{"line_number":66,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":".. rest_method:: DELETE /os-assisted-volume-snapshots/{snapshot_id}"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"Deletes an assisted volume snapshot."},{"line_number":71,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":7,"id":"3aaa91ec_cd94be8c","line":68,"range":{"start_line":68,"start_character":17,"end_line":68,"end_character":67},"in_reply_to":"3aaa91ec_60796cfc","updated":"2016-06-29 15:32:57.000000000","message":"\u003e Also snapshot_id is being used for cinder snapshot status update - \n\nWhat I said was for the delete case.","commit_id":"b39431c1a3109ccb5c0ecfa533fd8a0dce7727fe"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"c8bbd68497ab0efa8c20bbe13a4e0a603c94b962","unresolved":false,"context_lines":[{"line_number":65,"context_line":"Delete Assisted Volume Snapshot"},{"line_number":66,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":".. rest_method:: DELETE /os-assisted-volume-snapshots/{snapshot_id}"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"Deletes an assisted volume snapshot."},{"line_number":71,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":7,"id":"3aaa91ec_60796cfc","line":68,"range":{"start_line":68,"start_character":17,"end_line":68,"end_character":67},"in_reply_to":"3aaa91ec_e020bc4b","updated":"2016-06-29 08:23:20.000000000","message":"Right, this is about documenting the current API, and its routing.\n\nThis looks to be correct, odd though that may be:\nhttps://git.openstack.org/cgit/openstack/nova/tree/nova/api/openstack/compute/assisted_volume_snapshots.py#n62","commit_id":"b39431c1a3109ccb5c0ecfa533fd8a0dce7727fe"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"194da5ca2ffb303ab164d0368d5e1fc60997499c","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Normal response codes: 200"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Error response codes: badRequest(400),unauthorized(401), forbidden(403)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Request"},{"line_number":33,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"3aaa91ec_38059b79","line":30,"updated":"2016-06-30 09:03:52.000000000","message":"As you said at line 11, we should list 501 at here.","commit_id":"8ba2ea334f2d488fe78b4136a222f4cc116259ba"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2d3303d5415b2bcd14e260a26a92eb5aeea4aa9f","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Normal response codes: 200"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Error response codes: badRequest(400),unauthorized(401), forbidden(403)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Request"},{"line_number":33,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"3aaa91ec_3839e2f2","line":30,"in_reply_to":"3aaa91ec_38059b79","updated":"2016-07-01 07:21:40.000000000","message":"nice catch. and it end up that this API actually does not return 501 as it doe not handle NonImplement error from driver.\nhttps://github.com/openstack/nova/blob/master/nova/api/openstack/compute/assisted_volume_snapshots.py#L53-L58\n\nSO handling 501 will be new error code from this and thus need version bump:(.\n\nAs discussed on IRC, let\u0027s remove the doc of 501 and fix this API later.","commit_id":"8ba2ea334f2d488fe78b4136a222f4cc116259ba"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"799a12c46b579514ee298c788c12949e8812048b","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"To make this request, add the ``delete_info`` query parameter to the URI, as follows:"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"DELETE /os-assisted-volume-snapshots?delete_info\u003d\u0027{\"volume_id\": \"521752a6-acf6-4b2d-bc7a-119f9148cd8c\"}\u0027"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"Normal response codes: 204"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":8,"id":"3aaa91ec_cde5de09","line":74,"range":{"start_line":74,"start_character":0,"end_line":74,"end_character":104},"updated":"2016-06-29 15:37:06.000000000","message":"If both \u0027snapshot_id\u0027 and \u0027delete_info\u0027 is required, it is not good example.\nIn that case, it should be the following?\n\nDELETE /os-assisted-volume-snapshots/421752a6-acf6-4b2d-bc7a-119f9148cd8c?delete_info\u003d\u0027{\"volume_id\": \"521752a6-acf6-4b2d-bc7a-119f9148cd8c\"}\u0027","commit_id":"8ba2ea334f2d488fe78b4136a222f4cc116259ba"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2d3303d5415b2bcd14e260a26a92eb5aeea4aa9f","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"To make this request, add the ``delete_info`` query parameter to the URI, as follows:"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"DELETE /os-assisted-volume-snapshots?delete_info\u003d\u0027{\"volume_id\": \"521752a6-acf6-4b2d-bc7a-119f9148cd8c\"}\u0027"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"Normal response codes: 204"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":8,"id":"3aaa91ec_d564e749","line":74,"range":{"start_line":74,"start_character":0,"end_line":74,"end_character":104},"in_reply_to":"3aaa91ec_cde5de09","updated":"2016-07-01 07:21:40.000000000","message":"nice catch. Done","commit_id":"8ba2ea334f2d488fe78b4136a222f4cc116259ba"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"194da5ca2ffb303ab164d0368d5e1fc60997499c","unresolved":false,"context_lines":[{"line_number":76,"context_line":"Normal response codes: 204"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"Error response codes: badRequest(400), unauthorized(401), forbidden(403),"},{"line_number":79,"context_line":"itemNotFound(404)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"Request"},{"line_number":82,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"3aaa91ec_58006766","line":79,"updated":"2016-06-30 09:03:52.000000000","message":"ditto for 501","commit_id":"8ba2ea334f2d488fe78b4136a222f4cc116259ba"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"98cafb3d0bf7eed9eb8414f4e7a3b89c54c449d0","unresolved":false,"context_lines":[{"line_number":45,"context_line":"**Example Create Assisted Volume Snapshots: JSON request**"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":".. literalinclude:: ../../doc/api_samples/os-assisted-volume-snapshots/snapshot-create-assisted-req.json"},{"line_number":48,"context_line":"   :language: javascript"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"Response"},{"line_number":51,"context_line":"--------"}],"source_content_type":"text/x-c++src","patch_set":9,"id":"1aa78d24_d082ecff","line":48,"updated":"2016-07-04 13:52:18.000000000","message":"You could argue this sample is bad, really it should include the id that is in the response, as this currently are not a shared pair of request and response.\n\nLets make that a follow up patch?","commit_id":"26d4c055cc2b3850083bfd27aaf90a5636a185e8"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"d203785c1661069df7d8398a4c6fadc3838d55df","unresolved":false,"context_lines":[{"line_number":45,"context_line":"**Example Create Assisted Volume Snapshots: JSON request**"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":".. literalinclude:: ../../doc/api_samples/os-assisted-volume-snapshots/snapshot-create-assisted-req.json"},{"line_number":48,"context_line":"   :language: javascript"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"Response"},{"line_number":51,"context_line":"--------"}],"source_content_type":"text/x-c++src","patch_set":9,"id":"1aa78d24_13e0a228","line":48,"in_reply_to":"1aa78d24_0715323f","updated":"2016-07-06 08:40:49.000000000","message":"I just think we should have the response match the request in the samples.\n\ni.e. if we pass the id in the request, we get that same id in the response.\n\nHaving said that, they are both valid requests/responses, hence the +2, but they are just not a matching pair.","commit_id":"26d4c055cc2b3850083bfd27aaf90a5636a185e8"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"5bd735cd1e33f37cb72480a3f0d7d778fa3cca69","unresolved":false,"context_lines":[{"line_number":45,"context_line":"**Example Create Assisted Volume Snapshots: JSON request**"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":".. literalinclude:: ../../doc/api_samples/os-assisted-volume-snapshots/snapshot-create-assisted-req.json"},{"line_number":48,"context_line":"   :language: javascript"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"Response"},{"line_number":51,"context_line":"--------"}],"source_content_type":"text/x-c++src","patch_set":9,"id":"1aa78d24_0715323f","line":48,"in_reply_to":"1aa78d24_d082ecff","updated":"2016-07-05 12:21:11.000000000","message":"Sorry but I did not get this. req and resp sample both having the same id value.","commit_id":"26d4c055cc2b3850083bfd27aaf90a5636a185e8"}],"api-ref/source/parameters.yaml":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"7d052e7307b302c1f02e39da6a3718726155e06d","unresolved":false,"context_lines":[{"line_number":344,"context_line":""},{"line_number":345,"context_line":"    .. code-block:: json"},{"line_number":346,"context_line":""},{"line_number":347,"context_line":"       DELETE /os-assisted-volume-snapshots?delete_info\u003d\u0027{\"volume_id\": \"521752a6-acf6-4b2d-bc7a-119f9148cd8c\"}\u0027"},{"line_number":348,"context_line":"  in: query"},{"line_number":349,"context_line":"  required: true"},{"line_number":350,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3aaa91ec_156508b4","side":"PARENT","line":347,"range":{"start_line":347,"start_character":7,"end_line":347,"end_character":111},"updated":"2016-06-24 10:08:30.000000000","message":"I honestly think its important to keep this example, or at least some info on how to use this parameter.\n\nThis appears to be what is usually sent:\nhttps://github.com/openstack/cinder/blob/5792f2f9215fb2af09cc5aad04c47c2270b98b35/cinder/volume/drivers/remotefs.py#L1382","commit_id":"4fee0f0dc6cf0e27daf75386487fe4b1bc589ffd"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"3467f71633a355185089b26b7f7f29f4bf8b4acd","unresolved":false,"context_lines":[{"line_number":344,"context_line":""},{"line_number":345,"context_line":"    .. code-block:: json"},{"line_number":346,"context_line":""},{"line_number":347,"context_line":"       DELETE /os-assisted-volume-snapshots?delete_info\u003d\u0027{\"volume_id\": \"521752a6-acf6-4b2d-bc7a-119f9148cd8c\"}\u0027"},{"line_number":348,"context_line":"  in: query"},{"line_number":349,"context_line":"  required: true"},{"line_number":350,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3aaa91ec_543a3599","side":"PARENT","line":347,"range":{"start_line":347,"start_character":7,"end_line":347,"end_character":111},"in_reply_to":"3aaa91ec_156508b4","updated":"2016-06-29 06:36:40.000000000","message":"Done.","commit_id":"4fee0f0dc6cf0e27daf75386487fe4b1bc589ffd"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"bb39c395b682d439450ca354f90cfa91f78c2e47","unresolved":false,"context_lines":[{"line_number":3333,"context_line":"    The snapshot ID."},{"line_number":3334,"context_line":"  in: body"},{"line_number":3335,"context_line":"  required: true"},{"line_number":3336,"context_line":"  type: string"},{"line_number":3337,"context_line":"snapshot_id_1:"},{"line_number":3338,"context_line":"  description: |"},{"line_number":3339,"context_line":"    The unique identifier for a snapshot."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3aaa91ec_0f5d0579","line":3336,"range":{"start_line":3336,"start_character":8,"end_line":3336,"end_character":14},"updated":"2016-06-24 05:25:35.000000000","message":"In sample file (snapshot-create-assisted-resp.json), it is \u0027integer\u0027 value.","commit_id":"3e0aba2dd1c7b661caaa024728ccc8266f6090e0"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"483639b0f992b0038f11779ece8814e22b7c2a53","unresolved":false,"context_lines":[{"line_number":3333,"context_line":"    The snapshot ID."},{"line_number":3334,"context_line":"  in: body"},{"line_number":3335,"context_line":"  required: true"},{"line_number":3336,"context_line":"  type: string"},{"line_number":3337,"context_line":"snapshot_id_1:"},{"line_number":3338,"context_line":"  description: |"},{"line_number":3339,"context_line":"    The unique identifier for a snapshot."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3aaa91ec_529cc65c","line":3336,"range":{"start_line":3336,"start_character":8,"end_line":3336,"end_character":14},"in_reply_to":"3aaa91ec_0f5d0579","updated":"2016-06-24 09:53:29.000000000","message":"So the sample file is wrong here. But we should fix that before we can mark the samples as complete in this patch.\nhttps://git.openstack.org/cgit/openstack/nova/tree/nova/api/openstack/compute/schemas/assisted_volume_snapshots.py#n36\n\nThis can actually be string or null, not sure how we represent that.","commit_id":"3e0aba2dd1c7b661caaa024728ccc8266f6090e0"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"3467f71633a355185089b26b7f7f29f4bf8b4acd","unresolved":false,"context_lines":[{"line_number":3333,"context_line":"    The snapshot ID."},{"line_number":3334,"context_line":"  in: body"},{"line_number":3335,"context_line":"  required: true"},{"line_number":3336,"context_line":"  type: string"},{"line_number":3337,"context_line":"snapshot_id_1:"},{"line_number":3338,"context_line":"  description: |"},{"line_number":3339,"context_line":"    The unique identifier for a snapshot."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3aaa91ec_34bfa9fc","line":3336,"range":{"start_line":3336,"start_character":8,"end_line":3336,"end_character":14},"in_reply_to":"3aaa91ec_529cc65c","updated":"2016-06-29 06:36:40.000000000","message":"Done","commit_id":"3e0aba2dd1c7b661caaa024728ccc8266f6090e0"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"c8bbd68497ab0efa8c20bbe13a4e0a603c94b962","unresolved":false,"context_lines":[{"line_number":1165,"context_line":"  type: object"},{"line_number":1166,"context_line":"create_info_snapshot_id:"},{"line_number":1167,"context_line":"  description: |"},{"line_number":1168,"context_line":"    The ID send via information of snapshot creation."},{"line_number":1169,"context_line":"  in: body"},{"line_number":1170,"context_line":"  required: false"},{"line_number":1171,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3aaa91ec_a044f473","line":1168,"updated":"2016-06-29 08:23:20.000000000","message":"we can be more specific, this its the cinder uuid for the snapshot that is being created in this API call.","commit_id":"b39431c1a3109ccb5c0ecfa533fd8a0dce7727fe"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"7cea2ebaad0553b728d2de7c4d04eebb65fe3056","unresolved":false,"context_lines":[{"line_number":1165,"context_line":"  type: object"},{"line_number":1166,"context_line":"create_info_snapshot_id:"},{"line_number":1167,"context_line":"  description: |"},{"line_number":1168,"context_line":"    The ID send via information of snapshot creation."},{"line_number":1169,"context_line":"  in: body"},{"line_number":1170,"context_line":"  required: false"},{"line_number":1171,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3aaa91ec_c3fdca3c","line":1168,"in_reply_to":"3aaa91ec_a044f473","updated":"2016-06-29 08:34:41.000000000","message":"ignore this, see other comments, sorry.","commit_id":"b39431c1a3109ccb5c0ecfa533fd8a0dce7727fe"}]}