)]}'
{"nova/api/openstack/compute/disk_config.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a46bcdaf8cb3208e2935b1b78f4237e92dfd1ea5","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"class ServerDiskConfigController(wsgi.Controller):"},{"line_number":70,"context_line":"    def _add_disk_config(self, req, servers):"},{"line_number":71,"context_line":"        for server in servers:"},{"line_number":72,"context_line":"            db_server \u003d req.get_db_instance(server[\u0027id\u0027])"},{"line_number":73,"context_line":"            # server[\u0027id\u0027] is guaranteed to be in the cache due to"},{"line_number":74,"context_line":"            # the core API adding it in its \u0027show\u0027/\u0027detail\u0027 methods."},{"line_number":75,"context_line":"            value \u003d db_server.get(INTERNAL_DISK_CONFIG)"},{"line_number":76,"context_line":"            server[API_DISK_CONFIG] \u003d disk_config_to_api(value)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def _show(self, req, resp_obj):"},{"line_number":79,"context_line":"        if \u0027server\u0027 in resp_obj.obj:"},{"line_number":80,"context_line":"            server \u003d resp_obj.obj[\u0027server\u0027]"},{"line_number":81,"context_line":"            self._add_disk_config(req, [server])"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"class DiskConfig(extensions.V21APIExtensionBase):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_e09e8a61","line":81,"range":{"start_line":70,"start_character":4,"end_line":81,"end_character":48},"updated":"2016-06-08 19:39:36.000000000","message":"Nothing else is using these now.","commit_id":"0d808721d7a10c0b3dc0ce589d0d3679bc7fe963"}],"nova/api/openstack/compute/views/servers.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a46bcdaf8cb3208e2935b1b78f4237e92dfd1ea5","unresolved":false,"context_lines":[{"line_number":288,"context_line":"                # V2.1."},{"line_number":289,"context_line":"                \"image\": self._get_image(request, instance),"},{"line_number":290,"context_line":"                \"flavor\": self._get_flavor(request, instance),"},{"line_number":291,"context_line":"                # NOTE(sdague): historically this was the"},{"line_number":292,"context_line":"                # os-disk-config extension, but now that extensions"},{"line_number":293,"context_line":"                # are gone, we merge these attributes here."},{"line_number":294,"context_line":"                \"OS-DCF:diskConfig\": ("},{"line_number":295,"context_line":"                    \u0027AUTO\u0027 if instance.get(\u0027auto_disk_config\u0027) else \u0027MANUAL\u0027),"},{"line_number":296,"context_line":"                \"created\": utils.isotime(instance[\"created_at\"]),"},{"line_number":297,"context_line":"                \"updated\": utils.isotime(instance[\"updated_at\"]),"},{"line_number":298,"context_line":"                \"addresses\": self._get_addresses(request, instance,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_80a18696","line":295,"range":{"start_line":291,"start_character":16,"end_line":295,"end_character":78},"updated":"2016-06-08 19:39:36.000000000","message":"What about the policy check?","commit_id":"0d808721d7a10c0b3dc0ce589d0d3679bc7fe963"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4e87eb1a7ec4e9c883fd97af6f39cb732f83e197","unresolved":false,"context_lines":[{"line_number":69,"context_line":"                \"links\": self._get_links(request,"},{"line_number":70,"context_line":"                                         instance[\"uuid\"],"},{"line_number":71,"context_line":"                                         self._collection_name),"},{"line_number":72,"context_line":"                # NOTE(sdague): historically this was the"},{"line_number":73,"context_line":"                # os-disk-config extension, but now that extensions"},{"line_number":74,"context_line":"                # are gone, we merge these attributes here."},{"line_number":75,"context_line":"                \"OS-DCF:diskConfig\": ("}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_219214f7","line":72,"updated":"2016-06-15 18:39:31.000000000","message":"nit: I\u0027m not sure we need these notes everywhere.","commit_id":"2c437c08891acb649793db6e2add9c9169913817"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4e87eb1a7ec4e9c883fd97af6f39cb732f83e197","unresolved":false,"context_lines":[{"line_number":73,"context_line":"                # os-disk-config extension, but now that extensions"},{"line_number":74,"context_line":"                # are gone, we merge these attributes here."},{"line_number":75,"context_line":"                \"OS-DCF:diskConfig\": ("},{"line_number":76,"context_line":"                    \u0027AUTO\u0027 if instance.get(\u0027auto_disk_config\u0027) else \u0027MANUAL\u0027),"},{"line_number":77,"context_line":"            },"},{"line_number":78,"context_line":"        }"},{"line_number":79,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_a16ba4f0","line":76,"range":{"start_line":76,"start_character":21,"end_line":76,"end_character":25},"updated":"2016-06-15 18:39:31.000000000","message":"None of the unit tests hit this case...","commit_id":"2c437c08891acb649793db6e2add9c9169913817"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d84b186551990fc9476f678b137370892c3c38b3","unresolved":false,"context_lines":[{"line_number":73,"context_line":"                # os-disk-config extension, but now that extensions"},{"line_number":74,"context_line":"                # are gone, we merge these attributes here."},{"line_number":75,"context_line":"                \"OS-DCF:diskConfig\": ("},{"line_number":76,"context_line":"                    \u0027AUTO\u0027 if instance.get(\u0027auto_disk_config\u0027) else \u0027MANUAL\u0027),"},{"line_number":77,"context_line":"            },"},{"line_number":78,"context_line":"        }"},{"line_number":79,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_ac243b60","line":76,"range":{"start_line":76,"start_character":21,"end_line":76,"end_character":25},"in_reply_to":"7aa08908_a16ba4f0","updated":"2016-06-15 18:47:49.000000000","message":"Oh I guess these do:\n\nhttps://review.openstack.org/#/c/327188/3/nova/tests/unit/api/openstack/compute/test_disk_config.py@171\n\nJust that the server API tests are in a different test module, which is confusing...but could be updated later I guess?","commit_id":"2c437c08891acb649793db6e2add9c9169913817"}]}