)]}'
{"nova/tests/api/openstack/compute/contrib/test_keypairs.py":[{"author":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"change_message_id":"20224e7c1607aa1e2bb7f34a54ce00db84dec132","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        req.body \u003d jsonutils.dumps(body)"},{"line_number":134,"context_line":"        req.headers[\u0027Content-Type\u0027] \u003d \u0027application/json\u0027"},{"line_number":135,"context_line":"        res \u003d req.get_response(self.app)"},{"line_number":136,"context_line":"        jsonutils.loads(res.body)"},{"line_number":137,"context_line":"        self.assertEqual(res.status_int, 400)"},{"line_number":138,"context_line":"        res_dict \u003d jsonutils.loads(res.body)"},{"line_number":139,"context_line":"        self.assertEqual("}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPX%2F%2Fp%2Bw%3D","line":136,"updated":"2013-06-13 11:11:17.000000000","message":"This whole line is redundant","commit_id":"f73c9cb91eb8f4e5044544d51fd97c57408dfab6"},{"author":{"_account_id":1528,"name":"Stanislaw Pitucha","email":"viraptor@gmail.com","username":"stanislaw-pitucha"},"change_message_id":"ebc2bb6ca4266f4ab8c8cfb21e26431d74dd3cd0","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        req.body \u003d jsonutils.dumps(body)"},{"line_number":134,"context_line":"        req.headers[\u0027Content-Type\u0027] \u003d \u0027application/json\u0027"},{"line_number":135,"context_line":"        res \u003d req.get_response(self.app)"},{"line_number":136,"context_line":"        jsonutils.loads(res.body)"},{"line_number":137,"context_line":"        self.assertEqual(res.status_int, 400)"},{"line_number":138,"context_line":"        res_dict \u003d jsonutils.loads(res.body)"},{"line_number":139,"context_line":"        self.assertEqual("}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPX%2F%2Fp28%3D","line":136,"in_reply_to":"AAAAPX%2F%2Fp%2Bw%3D","updated":"2013-06-13 12:27:02.000000000","message":"Good catch, will remove in next patchset.","commit_id":"f73c9cb91eb8f4e5044544d51fd97c57408dfab6"}],"nova/tests/api/openstack/compute/test_extensions.py":[{"author":{"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},"change_message_id":"4b7dfa4c454b49c363a240aea0a2509dae5d170f","unresolved":false,"context_lines":[{"line_number":422,"context_line":"    def test_invalid_extensions(self):"},{"line_number":423,"context_line":"        # Don\u0027t need the serialization middleware here because we\u0027re"},{"line_number":424,"context_line":"        # not testing any serialization"},{"line_number":425,"context_line":"        compute.APIRouter()"},{"line_number":426,"context_line":"        ext_mgr \u003d compute_extensions.ExtensionManager()"},{"line_number":427,"context_line":"        ext_mgr.register(InvalidExtension())"},{"line_number":428,"context_line":"        self.assertTrue(ext_mgr.is_loaded(\u0027FOXNSOX\u0027))"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPX%2F%2FstE%3D","line":425,"updated":"2013-06-12 15:31:03.000000000","message":"I wonder if this is useless now.","commit_id":"f73c9cb91eb8f4e5044544d51fd97c57408dfab6"},{"author":{"_account_id":1528,"name":"Stanislaw Pitucha","email":"viraptor@gmail.com","username":"stanislaw-pitucha"},"change_message_id":"efec1a2998b12385ee3186260f9b2a1033e23113","unresolved":false,"context_lines":[{"line_number":422,"context_line":"    def test_invalid_extensions(self):"},{"line_number":423,"context_line":"        # Don\u0027t need the serialization middleware here because we\u0027re"},{"line_number":424,"context_line":"        # not testing any serialization"},{"line_number":425,"context_line":"        compute.APIRouter()"},{"line_number":426,"context_line":"        ext_mgr \u003d compute_extensions.ExtensionManager()"},{"line_number":427,"context_line":"        ext_mgr.register(InvalidExtension())"},{"line_number":428,"context_line":"        self.assertTrue(ext_mgr.is_loaded(\u0027FOXNSOX\u0027))"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPX%2F%2FskY%3D","line":425,"in_reply_to":"AAAAPX%2F%2FstE%3D","updated":"2013-06-12 17:05:09.000000000","message":"This one I looked at in details an I\u0027m pretty sure it\u0027s useless. I\u0027ll remove the change from this patch and kill it completely in following ones.","commit_id":"f73c9cb91eb8f4e5044544d51fd97c57408dfab6"}],"nova/tests/db/test_migrations.py":[{"author":{"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},"change_message_id":"4b7dfa4c454b49c363a240aea0a2509dae5d170f","unresolved":false,"context_lines":[{"line_number":807,"context_line":"        fake_types, fake_instances \u003d data"},{"line_number":808,"context_line":"        # NOTE(danms): Fetch all the tables and data from scratch after change"},{"line_number":809,"context_line":"        db_utils.get_table(engine, \u0027instances\u0027)"},{"line_number":810,"context_line":"        db_utils.get_table(engine, \u0027instance_types\u0027)"},{"line_number":811,"context_line":"        sys_meta \u003d db_utils.get_table(engine, \u0027instance_system_metadata\u0027)"},{"line_number":812,"context_line":""},{"line_number":813,"context_line":"        # Collect all system metadata, indexed by instance_uuid"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPX%2F%2FstU%3D","line":810,"updated":"2013-06-12 15:31:03.000000000","message":"Maybe these two lines are useless now?","commit_id":"f73c9cb91eb8f4e5044544d51fd97c57408dfab6"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"94cb4cd4f2f6ee1197829087ee49dd0a3e0f5cf4","unresolved":false,"context_lines":[{"line_number":807,"context_line":"        fake_types, fake_instances \u003d data"},{"line_number":808,"context_line":"        # NOTE(danms): Fetch all the tables and data from scratch after change"},{"line_number":809,"context_line":"        db_utils.get_table(engine, \u0027instances\u0027)"},{"line_number":810,"context_line":"        db_utils.get_table(engine, \u0027instance_types\u0027)"},{"line_number":811,"context_line":"        sys_meta \u003d db_utils.get_table(engine, \u0027instance_system_metadata\u0027)"},{"line_number":812,"context_line":""},{"line_number":813,"context_line":"        # Collect all system metadata, indexed by instance_uuid"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPX%2F%2Fpzs%3D","line":810,"in_reply_to":"AAAAPX%2F%2Fsk0%3D","updated":"2013-06-13 12:40:02.000000000","message":"They\u0027re not needed.","commit_id":"f73c9cb91eb8f4e5044544d51fd97c57408dfab6"},{"author":{"_account_id":1528,"name":"Stanislaw Pitucha","email":"viraptor@gmail.com","username":"stanislaw-pitucha"},"change_message_id":"efec1a2998b12385ee3186260f9b2a1033e23113","unresolved":false,"context_lines":[{"line_number":807,"context_line":"        fake_types, fake_instances \u003d data"},{"line_number":808,"context_line":"        # NOTE(danms): Fetch all the tables and data from scratch after change"},{"line_number":809,"context_line":"        db_utils.get_table(engine, \u0027instances\u0027)"},{"line_number":810,"context_line":"        db_utils.get_table(engine, \u0027instance_types\u0027)"},{"line_number":811,"context_line":"        sys_meta \u003d db_utils.get_table(engine, \u0027instance_system_metadata\u0027)"},{"line_number":812,"context_line":""},{"line_number":813,"context_line":"        # Collect all system metadata, indexed by instance_uuid"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPX%2F%2Fsk0%3D","line":810,"in_reply_to":"AAAAPX%2F%2FstU%3D","updated":"2013-06-12 17:05:09.000000000","message":"They were never used in the original patch. I can check with Dan Smith, but I\u0027d rather leave it in unless someone can confirm 100% that they\u0027re not needed. Always can be taken out in one of the patches to follow.","commit_id":"f73c9cb91eb8f4e5044544d51fd97c57408dfab6"}],"nova/tests/test_availability_zones.py":[{"author":{"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},"change_message_id":"4b7dfa4c454b49c363a240aea0a2509dae5d170f","unresolved":false,"context_lines":[{"line_number":145,"context_line":"        service4 \u003d self._create_service_with_topic(\u0027compute\u0027, \u0027host4\u0027,"},{"line_number":146,"context_line":"                                                   disabled\u003dTrue)"},{"line_number":147,"context_line":"        self._create_service_with_topic(\u0027compute\u0027, \u0027host5\u0027,"},{"line_number":148,"context_line":"                                        disabled\u003dTrue)"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        self._add_to_aggregate(service1, self.agg)"},{"line_number":151,"context_line":"        self._add_to_aggregate(service2, self.agg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPX%2F%2Fstg%3D","line":148,"updated":"2013-06-12 15:31:03.000000000","message":"I wonder if this one reveals a bug in the test -- maybe service5 was supposed to be added to the aggregate like the others?","commit_id":"f73c9cb91eb8f4e5044544d51fd97c57408dfab6"},{"author":{"_account_id":1528,"name":"Stanislaw Pitucha","email":"viraptor@gmail.com","username":"stanislaw-pitucha"},"change_message_id":"ebc2bb6ca4266f4ab8c8cfb21e26431d74dd3cd0","unresolved":false,"context_lines":[{"line_number":145,"context_line":"        service4 \u003d self._create_service_with_topic(\u0027compute\u0027, \u0027host4\u0027,"},{"line_number":146,"context_line":"                                                   disabled\u003dTrue)"},{"line_number":147,"context_line":"        self._create_service_with_topic(\u0027compute\u0027, \u0027host5\u0027,"},{"line_number":148,"context_line":"                                        disabled\u003dTrue)"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        self._add_to_aggregate(service1, self.agg)"},{"line_number":151,"context_line":"        self._add_to_aggregate(service2, self.agg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPX%2F%2Fp2E%3D","line":148,"in_reply_to":"AAAAPX%2F%2FsnQ%3D","updated":"2013-06-13 12:27:02.000000000","message":"Phil confirmed that\u0027s what was supposed to happen. This service should be created.","commit_id":"f73c9cb91eb8f4e5044544d51fd97c57408dfab6"},{"author":{"_account_id":1528,"name":"Stanislaw Pitucha","email":"viraptor@gmail.com","username":"stanislaw-pitucha"},"change_message_id":"efec1a2998b12385ee3186260f9b2a1033e23113","unresolved":false,"context_lines":[{"line_number":145,"context_line":"        service4 \u003d self._create_service_with_topic(\u0027compute\u0027, \u0027host4\u0027,"},{"line_number":146,"context_line":"                                                   disabled\u003dTrue)"},{"line_number":147,"context_line":"        self._create_service_with_topic(\u0027compute\u0027, \u0027host5\u0027,"},{"line_number":148,"context_line":"                                        disabled\u003dTrue)"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        self._add_to_aggregate(service1, self.agg)"},{"line_number":151,"context_line":"        self._add_to_aggregate(service2, self.agg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPX%2F%2FsnQ%3D","line":148,"in_reply_to":"AAAAPX%2F%2Fstg%3D","updated":"2013-06-12 17:05:09.000000000","message":"I think this line indicates otherwise:\n\n    134\t        # \u003cdefault\u003e    host5       No\n\nhost5 was supposed to be in the default zone (\"nova\") and since it\u0027s disabled, it shouldn\u0027t cause \"nova\" zone to be listed in \"zones\" below. (at least that\u0027s how I understand it)\n\nI can poke Phil in the morning and ask what he meant.","commit_id":"f73c9cb91eb8f4e5044544d51fd97c57408dfab6"}]}