)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"9fbf861d2da2711302dd7a652d1e6c2d152eafd7","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Force update available resources even before next"},{"line_number":10,"context_line":"periodic task to update all the resources usage"},{"line_number":11,"context_line":"before confirm stage. This will allow to ensure"},{"line_number":12,"context_line":"that we are remove old resource usage"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-Bug: #1590556"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7aa08908_7c221003","line":12,"updated":"2016-06-09 16:57:55.000000000","message":"s/we are removed/old resource from current usage./","commit_id":"5e848ae2ddd91064431494f81cbdc46a003e2925"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"ef28bbd755cec6991f48ff1dd9ebd89389aa9dbf","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Force update available resources even before next"},{"line_number":10,"context_line":"periodic task to update all the resources usage"},{"line_number":11,"context_line":"before confirm stage. This will allow to ensure"},{"line_number":12,"context_line":"that we are remove old resource usage"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-Bug: #1590556"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7aa08908_e829168b","line":12,"in_reply_to":"7aa08908_7c221003","updated":"2016-06-09 17:47:48.000000000","message":"Done","commit_id":"5e848ae2ddd91064431494f81cbdc46a003e2925"}],"nova/compute/manager.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"faeef46e5272295e940a30f49455a7928906823f","unresolved":false,"context_lines":[{"line_number":3822,"context_line":"            # NOTE(moshele): force update available resources"},{"line_number":3823,"context_line":"            # even before next periodic task to udpate all the"},{"line_number":3824,"context_line":"            # resources usage before confirm stage"},{"line_number":3825,"context_line":"            self.update_available_resource(context)"},{"line_number":3826,"context_line":"            self.driver.finish_migration(context, migration, instance,"},{"line_number":3827,"context_line":"                                         disk_info,"},{"line_number":3828,"context_line":"                                         network_info,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_14e5bf07","line":3825,"updated":"2016-06-09 09:38:15.000000000","message":"Don\u0027t we want to do that after self.driver.finish_migration has completed? As thats the point we have started using all the new resources?","commit_id":"35382e505895dfb5b98cfd09bdb20e713d13ee46"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"732e1edafdb480a6aadb97aa6be3396192eb0f90","unresolved":false,"context_lines":[{"line_number":3822,"context_line":"            # NOTE(moshele): force update available resources"},{"line_number":3823,"context_line":"            # even before next periodic task to udpate all the"},{"line_number":3824,"context_line":"            # resources usage before confirm stage"},{"line_number":3825,"context_line":"            self.update_available_resource(context)"},{"line_number":3826,"context_line":"            self.driver.finish_migration(context, migration, instance,"},{"line_number":3827,"context_line":"                                         disk_info,"},{"line_number":3828,"context_line":"                                         network_info,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_dff1816c","line":3825,"in_reply_to":"7aa08908_14e5bf07","updated":"2016-06-09 14:32:54.000000000","message":"Ok I tested also after self.driver.finish_migration and it also working.","commit_id":"35382e505895dfb5b98cfd09bdb20e713d13ee46"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"26eaa4cce5d1e724417419b98a7ddc0591d49cf4","unresolved":false,"context_lines":[{"line_number":3393,"context_line":""},{"line_number":3394,"context_line":"            # NOTE(moshele): Don\u0027t wait for next audit before updating or"},{"line_number":3395,"context_line":"            # freeing the resources."},{"line_number":3396,"context_line":"            self.update_available_resource(context)"},{"line_number":3397,"context_line":""},{"line_number":3398,"context_line":"            self._notify_about_instance_usage("},{"line_number":3399,"context_line":"                context, instance, \"resize.confirm.end\","}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_fe05b079","line":3396,"updated":"2016-06-24 15:13:42.000000000","message":"Can you move this before the instance.save() ?\n\nIt\u0027s possible that the instance be modified when calling update_available_resource().","commit_id":"b70ab81f2af2b69d9fe779f598ae948413674ac0"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"fdc198361680be012e631f6831ee1be5d35a72d8","unresolved":false,"context_lines":[{"line_number":3393,"context_line":""},{"line_number":3394,"context_line":"            # NOTE(moshele): Don\u0027t wait for next audit before updating or"},{"line_number":3395,"context_line":"            # freeing the resources."},{"line_number":3396,"context_line":"            self.update_available_resource(context)"},{"line_number":3397,"context_line":""},{"line_number":3398,"context_line":"            self._notify_about_instance_usage("},{"line_number":3399,"context_line":"                context, instance, \"resize.confirm.end\","}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_ae284934","line":3396,"in_reply_to":"3aaa91ec_fe05b079","updated":"2016-06-29 16:14:07.000000000","message":"Actually, this is should be here, after the save.","commit_id":"b70ab81f2af2b69d9fe779f598ae948413674ac0"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"26eaa4cce5d1e724417419b98a7ddc0591d49cf4","unresolved":false,"context_lines":[{"line_number":3464,"context_line":""},{"line_number":3465,"context_line":"            # NOTE(moshele): Don\u0027t wait for next audit before updating or"},{"line_number":3466,"context_line":"            # freeing the resources."},{"line_number":3467,"context_line":"            self.update_available_resource(context)"},{"line_number":3468,"context_line":""},{"line_number":3469,"context_line":"            rt \u003d self._get_resource_tracker(instance.node)"},{"line_number":3470,"context_line":"            rt.drop_move_claim(context, instance)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_b4598890","line":3467,"updated":"2016-06-24 15:13:42.000000000","message":"Please remove this one.","commit_id":"b70ab81f2af2b69d9fe779f598ae948413674ac0"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"fdc198361680be012e631f6831ee1be5d35a72d8","unresolved":false,"context_lines":[{"line_number":3464,"context_line":""},{"line_number":3465,"context_line":"            # NOTE(moshele): Don\u0027t wait for next audit before updating or"},{"line_number":3466,"context_line":"            # freeing the resources."},{"line_number":3467,"context_line":"            self.update_available_resource(context)"},{"line_number":3468,"context_line":""},{"line_number":3469,"context_line":"            rt \u003d self._get_resource_tracker(instance.node)"},{"line_number":3470,"context_line":"            rt.drop_move_claim(context, instance)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_8ede2d0f","line":3467,"in_reply_to":"3aaa91ec_b4598890","updated":"2016-06-29 16:14:07.000000000","message":"ditto, it should be after save.","commit_id":"b70ab81f2af2b69d9fe779f598ae948413674ac0"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"fdc198361680be012e631f6831ee1be5d35a72d8","unresolved":false,"context_lines":[{"line_number":3837,"context_line":"            # NOTE(moshele): force update available resources"},{"line_number":3838,"context_line":"            # even before next periodic task to update all the"},{"line_number":3839,"context_line":"            # resources usage before confirm stage"},{"line_number":3840,"context_line":"            self.update_available_resource(context)"},{"line_number":3841,"context_line":"        except Exception:"},{"line_number":3842,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":3843,"context_line":"                if old_instance_type_id !\u003d new_instance_type_id:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_cee5d5a4","line":3840,"updated":"2016-06-29 16:14:07.000000000","message":"I think it makes more sense to move this below L3854, after the save.","commit_id":"b70ab81f2af2b69d9fe779f598ae948413674ac0"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"c3aa0898d34fadf9b3ef0d7723a9202f5061e813","unresolved":false,"context_lines":[{"line_number":3837,"context_line":"            # NOTE(moshele): force update available resources"},{"line_number":3838,"context_line":"            # even before next periodic task to update all the"},{"line_number":3839,"context_line":"            # resources usage before confirm stage"},{"line_number":3840,"context_line":"            self.update_available_resource(context)"},{"line_number":3841,"context_line":"        except Exception:"},{"line_number":3842,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":3843,"context_line":"                if old_instance_type_id !\u003d new_instance_type_id:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_a9c76343","line":3840,"in_reply_to":"3aaa91ec_cee5d5a4","updated":"2016-06-30 17:34:29.000000000","message":"Done","commit_id":"b70ab81f2af2b69d9fe779f598ae948413674ac0"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"6e1c735564bf855cdda612991c05974283af8d56","unresolved":false,"context_lines":[{"line_number":3883,"context_line":"        instance.task_state \u003d None"},{"line_number":3884,"context_line":"        instance.launched_at \u003d timeutils.utcnow()"},{"line_number":3885,"context_line":"        instance.save(expected_task_state\u003dtask_states.RESIZE_FINISH)"},{"line_number":3886,"context_line":"        # NOTE(moshele): force update available resources"},{"line_number":3887,"context_line":"        # even before next periodic task to update all the"},{"line_number":3888,"context_line":"        # resources usage before confirm stage"},{"line_number":3889,"context_line":"        self.update_available_resource(context)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1aa78d24_55c9ce77","line":3886,"updated":"2016-07-04 13:31:35.000000000","message":"I would put a new line after instance.save() in order to be consistent with the other places where you add a call to update_available_resource().  I also think that this is easier to read.","commit_id":"7190a4d6cdd982641e9fecda0518af4d8e6eecc3"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"84d093e64001eb51010129f24842935561d378da","unresolved":false,"context_lines":[{"line_number":3883,"context_line":"        instance.task_state \u003d None"},{"line_number":3884,"context_line":"        instance.launched_at \u003d timeutils.utcnow()"},{"line_number":3885,"context_line":"        instance.save(expected_task_state\u003dtask_states.RESIZE_FINISH)"},{"line_number":3886,"context_line":"        # NOTE(moshele): force update available resources"},{"line_number":3887,"context_line":"        # even before next periodic task to update all the"},{"line_number":3888,"context_line":"        # resources usage before confirm stage"},{"line_number":3889,"context_line":"        self.update_available_resource(context)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1aa78d24_63140a44","line":3886,"in_reply_to":"1aa78d24_55c9ce77","updated":"2016-07-04 17:45:57.000000000","message":"Done","commit_id":"7190a4d6cdd982641e9fecda0518af4d8e6eecc3"}],"nova/tests/unit/compute/test_compute.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6389a05b4b3e62410354fe541c01cb7f8354dc12","unresolved":false,"context_lines":[{"line_number":5275,"context_line":"            mock.patch.object(self.compute.network_api,"},{"line_number":5276,"context_line":"                              \u0027setup_networks_on_host\u0027),"},{"line_number":5277,"context_line":"            mock.patch.object(self.compute, \u0027update_available_resource\u0027)"},{"line_number":5278,"context_line":"        ) as ("},{"line_number":5279,"context_line":"            setup_networks_on_host,"},{"line_number":5280,"context_line":"            update_available_resource"},{"line_number":5281,"context_line":"        ):"},{"line_number":5282,"context_line":"            self.compute.confirm_resize(self.context, instance\u003dinstance,"},{"line_number":5283,"context_line":"                                        migration\u003dmigration, reservations\u003d[])"},{"line_number":5284,"context_line":"        instance.refresh()"}],"source_content_type":"text/x-python","patch_set":10,"id":"1ac06dbe_52462ac0","line":5281,"range":{"start_line":5278,"start_character":13,"end_line":5281,"end_character":10},"updated":"2016-08-19 11:35:42.000000000","message":"nit: could you put these on the same line like elsewhere in this file?","commit_id":"5561762299cc3c32a8ff924ed8c7c4b2ec648c22"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"78496bf491de5ec53e128777d6f2cdfe5bad42e3","unresolved":false,"context_lines":[{"line_number":5275,"context_line":"            mock.patch.object(self.compute.network_api,"},{"line_number":5276,"context_line":"                              \u0027setup_networks_on_host\u0027),"},{"line_number":5277,"context_line":"            mock.patch.object(self.compute, \u0027update_available_resource\u0027)"},{"line_number":5278,"context_line":"        ) as ("},{"line_number":5279,"context_line":"            setup_networks_on_host,"},{"line_number":5280,"context_line":"            update_available_resource"},{"line_number":5281,"context_line":"        ):"},{"line_number":5282,"context_line":"            self.compute.confirm_resize(self.context, instance\u003dinstance,"},{"line_number":5283,"context_line":"                                        migration\u003dmigration, reservations\u003d[])"},{"line_number":5284,"context_line":"        instance.refresh()"}],"source_content_type":"text/x-python","patch_set":10,"id":"1ac06dbe_f53616b3","line":5281,"range":{"start_line":5278,"start_character":13,"end_line":5281,"end_character":10},"in_reply_to":"1ac06dbe_52462ac0","updated":"2016-08-19 13:54:19.000000000","message":"Done","commit_id":"5561762299cc3c32a8ff924ed8c7c4b2ec648c22"},{"author":{"_account_id":9569,"name":"Sergey Nikitin","email":"nikitinserv@gmail.com","username":"snikitin"},"change_message_id":"34fbb939905ebe2391920a0016e0dd5f6d9dbf6c","unresolved":false,"context_lines":[{"line_number":5282,"context_line":"            mock.patch.object(self.compute.network_api,"},{"line_number":5283,"context_line":"                              \u0027setup_networks_on_host\u0027),"},{"line_number":5284,"context_line":"            mock.patch.object(self.compute, \u0027update_available_resource\u0027)"},{"line_number":5285,"context_line":"        ) as (setup_networks_on_host, update_available_resource):"},{"line_number":5286,"context_line":"            self.compute.confirm_resize(self.context, instance\u003dinstance,"},{"line_number":5287,"context_line":"                                        migration\u003dmigration, reservations\u003d[])"},{"line_number":5288,"context_line":"        instance.refresh()"}],"source_content_type":"text/x-python","patch_set":11,"id":"1ac06dbe_1b032175","line":5285,"updated":"2016-08-19 14:23:28.000000000","message":"Do we need to check that update_available_resource() was called?","commit_id":"a49b80f07a9b954aa45d8bc61e13f686d1ae8e00"}]}