)]}'
{"nova/network/neutronv2/api.py":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"7de4d479256690a166e20cc81a041f1e004d08f4","unresolved":false,"context_lines":[{"line_number":629,"context_line":"                    created_port_ids.append(created_port_id)"},{"line_number":630,"context_line":"                    ports_in_requested_order.append(created_port_id)"},{"line_number":631,"context_line":"                else:"},{"line_number":632,"context_line":"                    port \u003d ports[request.port_id]"},{"line_number":633,"context_line":"                    port_client.update_port(port[\u0027id\u0027], port_req_body)"},{"line_number":634,"context_line":"                    preexisting_port_ids.append(port[\u0027id\u0027])"},{"line_number":635,"context_line":"                    ports_in_requested_order.append(port[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_78b7b5f5","side":"PARENT","line":632,"range":{"start_line":632,"start_character":20,"end_line":632,"end_character":49},"updated":"2016-06-15 17:27:08.000000000","message":"This makes me wonder why this code ever bothered to get \"port\" from ports when all it needed from it was the id (the thing it needed to get the port in the first place).\n\nThe only thing that I can think of is maybe it was counting on the KeyError from this access for some kind of error condition if the port did not exist in ports.  If that were the case, I\u0027d expect a unit test that exercised that error condition.  But, there doesn\u0027t seem to be one since nothing failed.","commit_id":"d4e2752a67edabbefde45e1c82cb6a4fa2d2d012"}]}