)]}'
{"nova/compute/rpcapi.py":[{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"7f515fc95601be79a582d1ade5918f80ee85df73","unresolved":false,"context_lines":[{"line_number":789,"context_line":"        cctxt.cast(ctxt, \u0027remove_fixed_ip_from_instance\u0027,"},{"line_number":790,"context_line":"                   instance\u003dinstance, address\u003daddress)"},{"line_number":791,"context_line":""},{"line_number":792,"context_line":"    def remove_volume_connection(self, ctxt, instance, volume_id, host):"},{"line_number":793,"context_line":"        version \u003d \u00274.0\u0027"},{"line_number":794,"context_line":"        cctxt \u003d self.get_cell_client(ctxt).prepare("},{"line_number":795,"context_line":"                server\u003dhost, version\u003dversion)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_d8558cc2","line":792,"updated":"2016-06-13 14:25:03.000000000","message":"compute/manager.py calls this method and needs to be updated. Not the remove_volume_connection method in compute manager, but just where it calls this method.","commit_id":"63383f4da2666808f6a0068cf3e8d293ad0960e7"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"17fa8c5e9f8330e37611ed7886f8f0dd1013d7b2","unresolved":false,"context_lines":[{"line_number":789,"context_line":"        cctxt.cast(ctxt, \u0027remove_fixed_ip_from_instance\u0027,"},{"line_number":790,"context_line":"                   instance\u003dinstance, address\u003daddress)"},{"line_number":791,"context_line":""},{"line_number":792,"context_line":"    def remove_volume_connection(self, ctxt, instance, volume_id, host):"},{"line_number":793,"context_line":"        version \u003d \u00274.0\u0027"},{"line_number":794,"context_line":"        cctxt \u003d self.get_cell_client(ctxt).prepare("},{"line_number":795,"context_line":"                server\u003dhost, version\u003dversion)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_57dabf78","line":792,"in_reply_to":"7aa08908_9dcc536b","updated":"2016-06-14 18:46:40.000000000","message":"I just grepped the code. I didn\u0027t see any caller of this method in the patch but knew that it must be used somewhere.","commit_id":"63383f4da2666808f6a0068cf3e8d293ad0960e7"},{"author":{"_account_id":21813,"name":"Andrey Volkov","email":"m@amadev.ru","username":"avolkov"},"change_message_id":"20f1d5aa6546751c79237ce83554225852cd4e5e","unresolved":false,"context_lines":[{"line_number":789,"context_line":"        cctxt.cast(ctxt, \u0027remove_fixed_ip_from_instance\u0027,"},{"line_number":790,"context_line":"                   instance\u003dinstance, address\u003daddress)"},{"line_number":791,"context_line":""},{"line_number":792,"context_line":"    def remove_volume_connection(self, ctxt, instance, volume_id, host):"},{"line_number":793,"context_line":"        version \u003d \u00274.0\u0027"},{"line_number":794,"context_line":"        cctxt \u003d self.get_cell_client(ctxt).prepare("},{"line_number":795,"context_line":"                server\u003dhost, version\u003dversion)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_9dcc536b","line":792,"in_reply_to":"7aa08908_d8558cc2","updated":"2016-06-14 16:05:39.000000000","message":"Thanks. I\u0027ve reverted to much from previous PS. I wonder how you found this error?","commit_id":"63383f4da2666808f6a0068cf3e8d293ad0960e7"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"0e4f71b9c5f7049f809b312277111c7707b9196e","unresolved":false,"context_lines":[{"line_number":705,"context_line":"        else:"},{"line_number":706,"context_line":"            return result"},{"line_number":707,"context_line":""},{"line_number":708,"context_line":"    def prep_resize(self, ctxt, instance, image, instance_type, host,"},{"line_number":709,"context_line":"                    reservations\u003dNone, request_spec\u003dNone,"},{"line_number":710,"context_line":"                    filter_properties\u003dNone, node\u003dNone,"},{"line_number":711,"context_line":"                    clean_shutdown\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7aa08908_2022eea3","line":708,"updated":"2016-06-16 10:34:17.000000000","message":"Isn\u0027t the ordering of arguments to our RPC methods part of the ABI. Although you\u0027ve changed the callers in this patch, that is ignoring the possibility of mixed version deployments. eg a mitaka version of conductor talking to a newton version of the rpc API, or vica-verca.\n\nIt seems to me that despite the inconsistency, this is something we must just leave alone and not try to fix.","commit_id":"9b9e3bc3981b823ce012edc3470d8da7a020e648"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"edef3db36cc1201b544f00ed1692fa12b1c61a26","unresolved":false,"context_lines":[{"line_number":705,"context_line":"        else:"},{"line_number":706,"context_line":"            return result"},{"line_number":707,"context_line":""},{"line_number":708,"context_line":"    def prep_resize(self, ctxt, instance, image, instance_type, host,"},{"line_number":709,"context_line":"                    reservations\u003dNone, request_spec\u003dNone,"},{"line_number":710,"context_line":"                    filter_properties\u003dNone, node\u003dNone,"},{"line_number":711,"context_line":"                    clean_shutdown\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7aa08908_818f612d","line":708,"in_reply_to":"7aa08908_2022eea3","updated":"2016-06-16 12:39:29.000000000","message":"This change shouldn\u0027t affect upgrades story, as both api and rpcapi will belong to the same version, at the same time real rpc-api request will be the same","commit_id":"9b9e3bc3981b823ce012edc3470d8da7a020e648"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"a8183d75d2bbef8909c8209540cd9b4931cb6db3","unresolved":false,"context_lines":[{"line_number":705,"context_line":"        else:"},{"line_number":706,"context_line":"            return result"},{"line_number":707,"context_line":""},{"line_number":708,"context_line":"    def prep_resize(self, ctxt, instance, image, instance_type, host,"},{"line_number":709,"context_line":"                    reservations\u003dNone, request_spec\u003dNone,"},{"line_number":710,"context_line":"                    filter_properties\u003dNone, node\u003dNone,"},{"line_number":711,"context_line":"                    clean_shutdown\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_91754533","line":708,"in_reply_to":"7aa08908_4137394d","updated":"2016-06-27 09:41:31.000000000","message":"Only new code calls this rpcapi, so this seems fine to me.","commit_id":"9b9e3bc3981b823ce012edc3470d8da7a020e648"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"8c7a27e699ecd2c46d73bb0b23e644c04ad8d3a3","unresolved":false,"context_lines":[{"line_number":705,"context_line":"        else:"},{"line_number":706,"context_line":"            return result"},{"line_number":707,"context_line":""},{"line_number":708,"context_line":"    def prep_resize(self, ctxt, instance, image, instance_type, host,"},{"line_number":709,"context_line":"                    reservations\u003dNone, request_spec\u003dNone,"},{"line_number":710,"context_line":"                    filter_properties\u003dNone, node\u003dNone,"},{"line_number":711,"context_line":"                    clean_shutdown\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7aa08908_4137394d","line":708,"in_reply_to":"7aa08908_818f612d","updated":"2016-06-16 12:42:27.000000000","message":"Ah ok, i\u0027ll remove my -1, but will let DanS verify and add the +W if ok","commit_id":"9b9e3bc3981b823ce012edc3470d8da7a020e648"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"edef3db36cc1201b544f00ed1692fa12b1c61a26","unresolved":false,"context_lines":[{"line_number":710,"context_line":"                    filter_properties\u003dNone, node\u003dNone,"},{"line_number":711,"context_line":"                    clean_shutdown\u003dTrue):"},{"line_number":712,"context_line":"        image_p \u003d jsonutils.to_primitive(image)"},{"line_number":713,"context_line":"        msg_args \u003d {\u0027instance\u0027: instance,"},{"line_number":714,"context_line":"                    \u0027instance_type\u0027: instance_type,"},{"line_number":715,"context_line":"                    \u0027image\u0027: image_p,"},{"line_number":716,"context_line":"                    \u0027reservations\u0027: reservations,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7aa08908_4184590a","line":713,"updated":"2016-06-16 12:39:29.000000000","message":"actual rpc request args are untouched, so everything should works fine","commit_id":"9b9e3bc3981b823ce012edc3470d8da7a020e648"}]}