)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"f7de90847c515e8d23b15db638d30f0bff5a5ecc","unresolved":false,"context_lines":[{"line_number":9,"context_line":"There are two timeouts that can cause migration to be aborted,"},{"line_number":10,"context_line":"one looks to see if forward progress is being made, while the"},{"line_number":11,"context_line":"other checks an overall time limit. Split out the code for"},{"line_number":12,"context_line":"checking these limits into a separate method and adding some"},{"line_number":13,"context_line":"explicit unit testing for the scenarios they encounter."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Implements: blueprint libvirt-clean-driver"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7aa08908_7322d2a4","line":12,"updated":"2016-06-13 01:56:34.000000000","message":"s/adding/add/","commit_id":"3244832f3f0460c16cc96a978f064fbd5fe02dad"}],"nova/tests/unit/virt/libvirt/test_migration.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"270bac16c823168432cbdcb5b118c6750735e173","unresolved":false,"context_lines":[{"line_number":274,"context_line":"    def test_live_migration_abort_stuck(self):"},{"line_number":275,"context_line":"        # Progress time exceeds progress timeout"},{"line_number":276,"context_line":"        self.assertTrue(migration.should_abort(self.instance,"},{"line_number":277,"context_line":"                                               5000,"},{"line_number":278,"context_line":"                                               1000, 2000,"},{"line_number":279,"context_line":"                                               4500, 9000))"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"    def test_live_migration_abort_no_prog_timeout(self):"},{"line_number":282,"context_line":"        # Progress timeout is disabled"}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_37c0dd4f","line":279,"range":{"start_line":277,"start_character":47,"end_line":279,"end_character":57},"updated":"2016-06-25 13:43:03.000000000","message":"nit: using kwargs would definitely make this more readable so I don\u0027t have to keep two tabs open to see what the parameters are.","commit_id":"ab907510a3da31e8ccfe811a24ebe7b85eb41e49"}],"nova/virt/libvirt/migration.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"f7de90847c515e8d23b15db638d30f0bff5a5ecc","unresolved":false,"context_lines":[{"line_number":187,"context_line":"        return True"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    if (completion_timeout !\u003d 0 and"},{"line_number":190,"context_line":"        elapsed \u003e completion_timeout):"},{"line_number":191,"context_line":"        LOG.warning("},{"line_number":192,"context_line":"            _LW(\"Live migration not completed after %d sec\"),"},{"line_number":193,"context_line":"            completion_timeout, instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_d33bc6cf","line":190,"updated":"2016-06-13 01:56:34.000000000","message":"femto-nit: here and above, this continuation of the if statement should be indented one more level to distinguish it from the code running within the conditional... but code was originally like that so, meh :)","commit_id":"3244832f3f0460c16cc96a978f064fbd5fe02dad"}]}
