)]}'
{"nova/virt/libvirt/migration.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"27278d020354bd0345898b528e0abe8cc5c7ec8b","unresolved":false,"context_lines":[{"line_number":201,"context_line":"                    downtime_steps, elapsed):"},{"line_number":202,"context_line":"    \"\"\"Update max downtime if needed"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"    :param guest: a nova.virt.libvirt.guest.Guest"},{"line_number":205,"context_line":"    :param instance: a nova.objects.Instance"},{"line_number":206,"context_line":"    :param olddowntime: current set downtime, or None"},{"line_number":207,"context_line":"    :param downtime_steps: list of downtime steps"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_53751696","line":204,"updated":"2016-06-13 01:59:53.000000000","message":"You may want to make a note here the Guest object is modified? Alternately, you could consider changing the Guest.migrate_configure_max_downtime() method to accept these parameters and move this new code there? That way, you keep code that modifies an object within the object itself...","commit_id":"a7dc767fea471b67aeffe66122348a1e563a29dd"},{"author":{"_account_id":12299,"name":"Paweł Koniszewski","email":"pawel.koniszewski@gmail.com","username":"pawel.koniszewski"},"change_message_id":"5bc69ed755f4a69d2d606fc5713a6fbc4d754c83","unresolved":false,"context_lines":[{"line_number":220,"context_line":""},{"line_number":221,"context_line":"    :returns: the new downtime value"},{"line_number":222,"context_line":"    \"\"\""},{"line_number":223,"context_line":"    LOG.info(_LI(\"Current %(dt)s elapsed %(elapsed)d steps %(steps)s\"),"},{"line_number":224,"context_line":"             {\"dt\": olddowntime, \"elapsed\": elapsed,"},{"line_number":225,"context_line":"              \"steps\": downtime_steps}, instance\u003dinstance)"},{"line_number":226,"context_line":"    thisstep \u003d None"},{"line_number":227,"context_line":"    for step in downtime_steps:"},{"line_number":228,"context_line":"        if elapsed \u003e step[0]:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_e5b00ee0","line":225,"range":{"start_line":223,"start_character":4,"end_line":225,"end_character":58},"updated":"2016-06-23 06:58:53.000000000","message":"So this runs every 0.5 second (twice for each step) and generates tons of log.info. Should be changed to LOG.debug and every N iterations log.info (like every 10 seconds?)","commit_id":"0e9da297845bd1faa1131cf51d136073760f97f3"},{"author":{"_account_id":7461,"name":"Paul Murray","email":"pmurray@hpe.com","username":"ptm"},"change_message_id":"261c855c272ed7b898acdf8bfecdf04f52c61294","unresolved":false,"context_lines":[{"line_number":220,"context_line":""},{"line_number":221,"context_line":"    :returns: the new downtime value"},{"line_number":222,"context_line":"    \"\"\""},{"line_number":223,"context_line":"    LOG.info(_LI(\"Current %(dt)s elapsed %(elapsed)d steps %(steps)s\"),"},{"line_number":224,"context_line":"             {\"dt\": olddowntime, \"elapsed\": elapsed,"},{"line_number":225,"context_line":"              \"steps\": downtime_steps}, instance\u003dinstance)"},{"line_number":226,"context_line":"    thisstep \u003d None"},{"line_number":227,"context_line":"    for step in downtime_steps:"},{"line_number":228,"context_line":"        if elapsed \u003e step[0]:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_12f07366","line":225,"range":{"start_line":223,"start_character":4,"end_line":225,"end_character":58},"in_reply_to":"3aaa91ec_e5b00ee0","updated":"2016-06-24 13:54:01.000000000","message":"I think Pawel has a point here. These logs were not in the original code right?","commit_id":"0e9da297845bd1faa1131cf51d136073760f97f3"},{"author":{"_account_id":12299,"name":"Paweł Koniszewski","email":"pawel.koniszewski@gmail.com","username":"pawel.koniszewski"},"change_message_id":"5bc69ed755f4a69d2d606fc5713a6fbc4d754c83","unresolved":false,"context_lines":[{"line_number":229,"context_line":"            thisstep \u003d step"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"    if thisstep is None:"},{"line_number":232,"context_line":"        LOG.info(_LI(\"No currentstep\"))"},{"line_number":233,"context_line":"        return olddowntime"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"    if thisstep[1] \u003d\u003d olddowntime:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_65f37e9f","line":232,"range":{"start_line":232,"start_character":25,"end_line":232,"end_character":36},"updated":"2016-06-23 06:58:53.000000000","message":"s/currentstep/current step/","commit_id":"0e9da297845bd1faa1131cf51d136073760f97f3"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"0c8b5e113c3404943a1a6e2bf64b30db42f4454c","unresolved":false,"context_lines":[{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    :returns: the new downtime value"},{"line_number":225,"context_line":"    \"\"\""},{"line_number":226,"context_line":"    LOG.debug(_LI(\"Current %(dt)s elapsed %(elapsed)d steps %(steps)s\"),"},{"line_number":227,"context_line":"              {\"dt\": olddowntime, \"elapsed\": elapsed,"},{"line_number":228,"context_line":"               \"steps\": downtime_steps}, instance\u003dinstance)"},{"line_number":229,"context_line":"    thisstep \u003d None"}],"source_content_type":"text/x-python","patch_set":7,"id":"3aaa91ec_fe2770b3","line":226,"updated":"2016-06-24 14:45:27.000000000","message":"No need of _LI for a debug level. Can you add the instance_uuid to have context","commit_id":"93e5d9e5ee6057b4f265d82325aff8a2da020477"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"0c8b5e113c3404943a1a6e2bf64b30db42f4454c","unresolved":false,"context_lines":[{"line_number":232,"context_line":"            thisstep \u003d step"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"    if thisstep is None:"},{"line_number":235,"context_line":"        LOG.info(_LI(\"No current step\"))"},{"line_number":236,"context_line":"        return olddowntime"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"    if thisstep[1] \u003d\u003d olddowntime:"}],"source_content_type":"text/x-python","patch_set":7,"id":"3aaa91ec_fe4e506d","line":235,"updated":"2016-06-24 14:45:27.000000000","message":"We should probably have it as debug at out the instance_uuid to have context","commit_id":"93e5d9e5ee6057b4f265d82325aff8a2da020477"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"0c8b5e113c3404943a1a6e2bf64b30db42f4454c","unresolved":false,"context_lines":[{"line_number":236,"context_line":"        return olddowntime"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"    if thisstep[1] \u003d\u003d olddowntime:"},{"line_number":239,"context_line":"        LOG.info(_LI(\"Downtime does not need to change\"))"},{"line_number":240,"context_line":"        return olddowntime"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"    LOG.info(_LI(\"Increasing downtime to %(downtime)d ms \""}],"source_content_type":"text/x-python","patch_set":7,"id":"3aaa91ec_5e404434","line":239,"updated":"2016-06-24 14:45:27.000000000","message":"ditto","commit_id":"93e5d9e5ee6057b4f265d82325aff8a2da020477"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"b57c3eea84bf250d62de5de1fa0811576af655cf","unresolved":false,"context_lines":[{"line_number":199,"context_line":"    return False"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"def update_downtime(guest, instance,"},{"line_number":203,"context_line":"                    olddowntime,"},{"line_number":204,"context_line":"                    downtime_steps, elapsed):"},{"line_number":205,"context_line":"    \"\"\"Update max downtime if needed"}],"source_content_type":"text/x-python","patch_set":8,"id":"3aaa91ec_ca339612","line":202,"range":{"start_line":202,"start_character":4,"end_line":202,"end_character":19},"updated":"2016-06-27 10:47:50.000000000","message":"Nit: I might have gone for update_max_downtime, but its clear enough.","commit_id":"471736c1f09899d9471acc9b22fd259d6d0cc8ab"}]}