)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"b9b32af24f85045ce02a304898eb0ac16f83d337","unresolved":false,"context_lines":[{"line_number":11,"context_line":"migration fails or is cancelled we need to do some recovery"},{"line_number":12,"context_line":"actions for any tasks that were run. This task recovery"},{"line_number":13,"context_line":"processing is handled by a separate inline method."},{"line_number":14,"context_line":"Move this inline method out to be a static method at"},{"line_number":15,"context_line":"in the class, and add explicitly testing of it. This"},{"line_number":16,"context_line":"also adds an explicit warning if it finds an unknown"},{"line_number":17,"context_line":"task"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7aa08908_33a7aabe","line":14,"updated":"2016-06-13 02:19:54.000000000","message":"s/at in the/in the/","commit_id":"80122be9825e84aba4481357fe52693381bc75b7"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"b9b32af24f85045ce02a304898eb0ac16f83d337","unresolved":false,"context_lines":[{"line_number":12,"context_line":"actions for any tasks that were run. This task recovery"},{"line_number":13,"context_line":"processing is handled by a separate inline method."},{"line_number":14,"context_line":"Move this inline method out to be a static method at"},{"line_number":15,"context_line":"in the class, and add explicitly testing of it. This"},{"line_number":16,"context_line":"also adds an explicit warning if it finds an unknown"},{"line_number":17,"context_line":"task"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7aa08908_93a81e8e","line":15,"updated":"2016-06-13 02:19:54.000000000","message":"s/add explicitly testing of/explicitly test/","commit_id":"80122be9825e84aba4481357fe52693381bc75b7"}],"nova/virt/libvirt/migration.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"b9b32af24f85045ce02a304898eb0ac16f83d337","unresolved":false,"context_lines":[{"line_number":309,"context_line":"                        {\"task\": task}, instance\u003dinstance)"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"def recover_tasks(host, guest, instance, on_migration_failure):"},{"line_number":313,"context_line":"    \"\"\"Run any pending migration recovery tasks"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"    :param host: a nova.virt.libvirt.host.Host"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_73adb29a","line":312,"updated":"2016-06-13 02:19:54.000000000","message":"How about run_recovery_tasks() instead of recover_tasks()? That way you match the run_tasks() function added in the previous patch and the name of the function matches what the function is doing.","commit_id":"80122be9825e84aba4481357fe52693381bc75b7"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"a95794f054b060fc3995a6604c060e46b9e5ef1f","unresolved":false,"context_lines":[{"line_number":316,"context_line":"                        {\"task\": task}, instance\u003dinstance)"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"def run_recover_tasks(host, guest, instance, on_migration_failure):"},{"line_number":320,"context_line":"    \"\"\"Run any pending migration recovery tasks"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"    :param host: a nova.virt.libvirt.host.Host"}],"source_content_type":"text/x-python","patch_set":8,"id":"3aaa91ec_e81e930a","line":319,"updated":"2016-06-24 16:20:45.000000000","message":"As my previous comment we can avoid to pass instance for log by using guest instead","commit_id":"e1e68eb557d2fd83d7213934450a10ebb9d354b3"}]}
