)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"06db4f1e3aa89afafde089e24d8f775ef7914a55","unresolved":false,"context_lines":[{"line_number":12,"context_line":"the usage of mox with mock for patching this method."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I3f36b72ab435dea224eb61d449e13ae80d9b61a8"},{"line_number":15,"context_line":"Closes-Bug: 1590896"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7aa08908_907958ff","line":15,"updated":"2016-06-10 19:36:40.000000000","message":"Also part of blueprint remove-mox-newton if you respin.","commit_id":"4e5015f228b789fadf8c1c551302158debe8f0a5"}],"nova/tests/unit/virt/xenapi/test_vm_utils.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"06db4f1e3aa89afafde089e24d8f775ef7914a55","unresolved":false,"context_lines":[{"line_number":703,"context_line":""},{"line_number":704,"context_line":"    @mock.patch.object(vm_utils, \u0027lookup\u0027, return_value\u003dNone)"},{"line_number":705,"context_line":"    def test_exception_msg_contains_vm_name(self, mock_lookup):"},{"line_number":706,"context_line":"        try:"},{"line_number":707,"context_line":"            vm_utils.vm_ref_or_raise(\u0027session\u0027, \u0027somename\u0027)"},{"line_number":708,"context_line":"        except exception.InstanceNotFound as e:"},{"line_number":709,"context_line":"            self.assertIn(\u0027somename\u0027, six.text_type(e))"},{"line_number":710,"context_line":"        mock_lookup.assert_called_once_with(\u0027session\u0027, \u0027somename\u0027)"},{"line_number":711,"context_line":""},{"line_number":712,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_f0d6dcc1","line":709,"range":{"start_line":706,"start_character":8,"end_line":709,"end_character":55},"updated":"2016-06-10 19:36:40.000000000","message":"It would actually be cleaner to just fold this into the test above and then get the exception as the return value from assertRaises:\n\n ex \u003d self.assertRaises(InstanceNotFound, ...)\n\nAnd then do the check on the name being in the exception returned.\n\nBut I realize this is just a mox-\u003emock conversion patch so won\u0027t force this.","commit_id":"4e5015f228b789fadf8c1c551302158debe8f0a5"}],"nova/tests/unit/virt/xenapi/test_vmops.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"3899542046759f06fa9eefafe4bd7d1f60fc4594","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        context \u003d \u0027fake_context\u0027"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        lookup_returns \u003d [backup_made and \u0027foo\u0027 or None,"},{"line_number":98,"context_line":"                          (not backup_made or new_made) and \u0027foo\u0027 or None]"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        @mock.patch.object(vm_utils, \u0027lookup\u0027,"},{"line_number":101,"context_line":"                           side_effect\u003dlookup_returns)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_b83899d4","line":98,"updated":"2016-06-13 00:31:45.000000000","message":"ewww. but it\u0027s no worse than the original :)","commit_id":"4e5015f228b789fadf8c1c551302158debe8f0a5"}],"nova/tests/unit/virt/xenapi/test_xenapi.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"06db4f1e3aa89afafde089e24d8f775ef7914a55","unresolved":false,"context_lines":[{"line_number":349,"context_line":""},{"line_number":350,"context_line":"    @mock.patch.object(vm_utils, \u0027lookup\u0027, return_value\u003dTrue)"},{"line_number":351,"context_line":"    def test_instance_exists(self, mock_lookup):"},{"line_number":352,"context_line":"        self.stubs.Set(objects.Instance, \u0027name\u0027, \u0027foo\u0027)"},{"line_number":353,"context_line":"        instance \u003d objects.Instance(uuid\u003d\u0027fake-uuid\u0027)"},{"line_number":354,"context_line":"        self.assertTrue(self.conn.instance_exists(instance))"},{"line_number":355,"context_line":"        mock_lookup.assert_called_once_with(mock.ANY, \u0027foo\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_b30c5e3c","line":352,"range":{"start_line":352,"start_character":8,"end_line":352,"end_character":22},"updated":"2016-06-10 19:36:40.000000000","message":"At some point we want to change these to using mock or self.stub_out.","commit_id":"4e5015f228b789fadf8c1c551302158debe8f0a5"}]}
