)]}'
{"nova/compute/rpcapi.py":[{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"1fcd2891b6b8b4217e451898eb7c0d26c6131a4f","unresolved":false,"context_lines":[{"line_number":377,"context_line":"    def get_cell_client(self, context):"},{"line_number":378,"context_line":"        return rpc.get_cell_client(context, self.client)"},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"    def add_aggregate_host(self, ctxt, host, aggregate, host_param,"},{"line_number":381,"context_line":"                           slave_info\u003dNone):"},{"line_number":382,"context_line":"        \u0027\u0027\u0027Add aggregate host."},{"line_number":383,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_c083a701","line":380,"range":{"start_line":380,"start_character":56,"end_line":380,"end_character":66},"updated":"2016-06-14 10:11:30.000000000","message":"it looks like we could remove host_param from this method signature at all, but it could be done in the following patch","commit_id":"19b3ef2e338ccc94ebd43ea52a6d3ae37eb1e6cc"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"93ae3f794e156c63dfb0e699e59edfe7fc23473d","unresolved":false,"context_lines":[{"line_number":377,"context_line":"    def get_cell_client(self, context):"},{"line_number":378,"context_line":"        return rpc.get_cell_client(context, self.client)"},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"    def add_aggregate_host(self, ctxt, host, aggregate, host_param,"},{"line_number":381,"context_line":"                           slave_info\u003dNone):"},{"line_number":382,"context_line":"        \u0027\u0027\u0027Add aggregate host."},{"line_number":383,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a9d85d2_4b301d57","line":380,"range":{"start_line":380,"start_character":56,"end_line":380,"end_character":66},"in_reply_to":"7aa08908_c083a701","updated":"2016-06-20 15:12:18.000000000","message":"host and host_param are actually two different things. I\u0027m not sure why exactly it is done but host is where the message is sent to and host_param is the host to add, and I think host_param is typically a different host being added to the aggregate.","commit_id":"19b3ef2e338ccc94ebd43ea52a6d3ae37eb1e6cc"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"1fcd2891b6b8b4217e451898eb7c0d26c6131a4f","unresolved":false,"context_lines":[{"line_number":391,"context_line":"        cctxt \u003d self.get_cell_client(ctxt).prepare("},{"line_number":392,"context_line":"                server\u003dhost, version\u003dversion)"},{"line_number":393,"context_line":"        cctxt.cast(ctxt, \u0027add_aggregate_host\u0027,"},{"line_number":394,"context_line":"                   aggregate\u003daggregate, host\u003dhost_param,"},{"line_number":395,"context_line":"                   slave_info\u003dslave_info)"},{"line_number":396,"context_line":""},{"line_number":397,"context_line":"    def add_fixed_ip_to_instance(self, ctxt, instance, network_id):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_e097c337","line":394,"range":{"start_line":394,"start_character":45,"end_line":394,"end_character":55},"updated":"2016-06-14 10:11:30.000000000","message":"so we\u0027ll start use host here instead","commit_id":"19b3ef2e338ccc94ebd43ea52a6d3ae37eb1e6cc"}]}
