)]}'
{"nova/api/openstack/wsgi.py":[{"author":{"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},"change_message_id":"07a442625f8461ee05317c1f3bdac51bec4ffb7a","unresolved":false,"context_lines":[{"line_number":818,"context_line":"            raise exception.InvalidContentType(content_type\u003dcontent_type)"},{"line_number":819,"context_line":""},{"line_number":820,"context_line":"        if (hasattr(deserializer, \u0027want_controller\u0027)"},{"line_number":821,"context_line":"            and deserializer.want_controller):"},{"line_number":822,"context_line":"            return deserializer(self.controller).deserialize(body)"},{"line_number":823,"context_line":"        else:"},{"line_number":824,"context_line":"            return deserializer().deserialize(body)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPX%2F%2Fmzk%3D","line":821,"updated":"2013-06-14 14:37:41.000000000","message":"please indent this line more so it stands out from the next line","commit_id":"611b0ff8a78e51c11b27450cb3db639c7ee39e46"},{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"59cc72171c60c73f8bedc23298906e87adae1d4e","unresolved":false,"context_lines":[{"line_number":818,"context_line":"            raise exception.InvalidContentType(content_type\u003dcontent_type)"},{"line_number":819,"context_line":""},{"line_number":820,"context_line":"        if (hasattr(deserializer, \u0027want_controller\u0027)"},{"line_number":821,"context_line":"            and deserializer.want_controller):"},{"line_number":822,"context_line":"            return deserializer(self.controller).deserialize(body)"},{"line_number":823,"context_line":"        else:"},{"line_number":824,"context_line":"            return deserializer().deserialize(body)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2F%2FNQ%3D","line":821,"in_reply_to":"AAAAPX%2F%2Fmzk%3D","updated":"2013-06-15 08:20:19.000000000","message":"Done","commit_id":"611b0ff8a78e51c11b27450cb3db639c7ee39e46"}],"nova/tests/api/openstack/compute/plugins/v3/test_config_drive.py":[{"author":{"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},"change_message_id":"07a442625f8461ee05317c1f3bdac51bec4ffb7a","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import datetime"},{"line_number":17,"context_line":"from oslo.config import cfg"},{"line_number":18,"context_line":"import uuid"},{"line_number":19,"context_line":"import webob"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPX%2F%2Fmzw%3D","line":17,"updated":"2013-06-14 14:37:41.000000000","message":"oslo and webob go down a section into third-party","commit_id":"611b0ff8a78e51c11b27450cb3db639c7ee39e46"},{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"59cc72171c60c73f8bedc23298906e87adae1d4e","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import datetime"},{"line_number":17,"context_line":"from oslo.config import cfg"},{"line_number":18,"context_line":"import uuid"},{"line_number":19,"context_line":"import webob"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2F%2FNU%3D","line":17,"in_reply_to":"AAAAPX%2F%2Fmzw%3D","updated":"2013-06-15 08:20:19.000000000","message":"Done","commit_id":"611b0ff8a78e51c11b27450cb3db639c7ee39e46"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"fc77f0d2ac5fd43f59e40a68f124399f637d2d58","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from oslo.config import cfg"},{"line_number":20,"context_line":"import webob"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from nova.api.openstack.compute.contrib import config_drive"},{"line_number":23,"context_line":"from nova.api.openstack.compute import plugins"},{"line_number":24,"context_line":"from nova.api.openstack.compute.plugins.v3 import servers"},{"line_number":25,"context_line":"from nova.compute import api as compute_api"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPn%2F%2FvFA%3D","line":22,"updated":"2013-06-24 03:39:07.000000000","message":"Should this not be:\n\n from nova.api.openstack.compute.plugins.v3 import config_drive","commit_id":"a4a390cac8767c3bb1c4e2cb25f6c7a504246090"},{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"389353d8074630752cb9722915e647ffc847cc88","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from oslo.config import cfg"},{"line_number":20,"context_line":"import webob"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from nova.api.openstack.compute.contrib import config_drive"},{"line_number":23,"context_line":"from nova.api.openstack.compute import plugins"},{"line_number":24,"context_line":"from nova.api.openstack.compute.plugins.v3 import servers"},{"line_number":25,"context_line":"from nova.compute import api as compute_api"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPn%2F%2Fu9Y%3D","line":22,"in_reply_to":"AAAAPn%2F%2FvFA%3D","updated":"2013-06-24 06:47:12.000000000","message":"Thanks for catching this! Have fixed this and a few other problems that were hidden because of the wrong import.","commit_id":"a4a390cac8767c3bb1c4e2cb25f6c7a504246090"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"fc77f0d2ac5fd43f59e40a68f124399f637d2d58","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        fakes.stub_out_networking(self.stubs)"},{"line_number":54,"context_line":"        fakes.stub_out_rate_limiting(self.stubs)"},{"line_number":55,"context_line":"        fake.stub_out_image_service(self.stubs)"},{"line_number":56,"context_line":"        self.flags("},{"line_number":57,"context_line":"            osapi_compute_extension\u003d["},{"line_number":58,"context_line":"                \u0027nova.api.openstack.compute.contrib.select_extensions\u0027],"},{"line_number":59,"context_line":"            osapi_compute_ext_list\u003d[\u0027Config_drive\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPn%2F%2FvEo%3D","line":56,"updated":"2013-06-24 03:39:07.000000000","message":"This should be:\n\n self.app \u003d fakes.wsgi_app_v3(init_only\u003d(\u0027servers\u0027, \u0027os-config-drive\u0027))\n\n(or something). Getting hidden by import above.","commit_id":"a4a390cac8767c3bb1c4e2cb25f6c7a504246090"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"fc77f0d2ac5fd43f59e40a68f124399f637d2d58","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    def test_show(self):"},{"line_number":62,"context_line":"        self.stubs.Set(db, \u0027instance_get\u0027,"},{"line_number":63,"context_line":"                        fakes.fake_instance_get())"},{"line_number":64,"context_line":"        req \u003d webob.Request.blank(\u0027/v2/fake/servers/1\u0027)"},{"line_number":65,"context_line":"        req.headers[\u0027Content-Type\u0027] \u003d \u0027application/json\u0027"},{"line_number":66,"context_line":"        response \u003d req.get_response(fakes.wsgi_app(init_only\u003d(\u0027servers\u0027,)))"},{"line_number":67,"context_line":"        self.assertEquals(response.status_int, 200)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPn%2F%2FvE4%3D","line":64,"updated":"2013-06-24 03:39:07.000000000","message":"Should be:\n\n req \u003d webob.Request.blank(\u0027/v3/servers/1\u0027)\n\netc for other occurrences.","commit_id":"a4a390cac8767c3bb1c4e2cb25f6c7a504246090"},{"author":{"_account_id":5586,"name":"Ivan-Zhu","email":"zhubo198511@gmail.com","username":"ivan-zhu"},"change_message_id":"c502cee185b302ace06cedc6dc4f49942dc751aa","unresolved":false,"context_lines":[{"line_number":240,"context_line":"        res \u003d self.controller.create(req, body).obj"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"        server \u003d res[\u0027server\u0027]"},{"line_number":243,"context_line":"        self.assertEqual(FAKE_UUID, server[\u0027id\u0027])"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"    def test_create_instance_with_config_drive_as_id(self):"},{"line_number":246,"context_line":"        image_href \u003d \u002776fa36fc-c930-4bf3-8c8a-ea2a2420deb6\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPn%2F%2FuL0%3D","line":243,"updated":"2013-06-24 14:06:01.000000000","message":"I think this test doesn\u0027t make sense. How can you make sure the \u0027config_drive\u0027 have been passed to compute_api.API.create? We can know the create can work regardless of \u0027config_drive\u0027 in body from test_create_instance_without_config_drive.  \nSo I suggest that add a assert in this test or add a test  test_create_instance_with_config_drive_enabled as opposed to the test above.","commit_id":"99a65f50632ed06fdc90a2d49c068d7c33b7dfa7"},{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"f51ff1c8fe16991beec753c6edf1fae7de01c88c","unresolved":false,"context_lines":[{"line_number":240,"context_line":"        res \u003d self.controller.create(req, body).obj"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"        server \u003d res[\u0027server\u0027]"},{"line_number":243,"context_line":"        self.assertEqual(FAKE_UUID, server[\u0027id\u0027])"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"    def test_create_instance_with_config_drive_as_id(self):"},{"line_number":246,"context_line":"        image_href \u003d \u002776fa36fc-c930-4bf3-8c8a-ea2a2420deb6\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPn%2F%2FpAQ%3D","line":243,"in_reply_to":"AAAAPn%2F%2FuL0%3D","updated":"2013-06-26 06:03:02.000000000","message":"I\u0027m adding an extra assert and using a create stub to check that the config_drive parameter is passed though.","commit_id":"99a65f50632ed06fdc90a2d49c068d7c33b7dfa7"}]}