)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4912,"name":"Michael H Wilson","email":"geekinutah@gmail.com","username":"geekinutah"},"change_message_id":"77b53cedc4d81b5a0754617ec3018052cfabc649","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Added a new test, based almost entirely off the existing test case"},{"line_number":19,"context_line":"for this function, which represents an XML file with two fake"},{"line_number":20,"context_line":"file-based (NFS-like) volules and associated block_device_info to"},{"line_number":21,"context_line":"claim those volumes."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Change-Id: I4809a8fd68eb0f709347aa7cad0fa85389ade41c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"AAAAPn%2F%2F27s%3D","line":20,"updated":"2013-06-19 17:03:48.000000000","message":"Slight typo here, \"volules\"","commit_id":"e9f44db577f710f5b6b482e4301df681e16a2c62"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"3d09bfb38f8c0dee7d719b7f8bab23b9280afdb9","unresolved":false,"context_lines":[{"line_number":3475,"context_line":"        for vol in block_device_mapping:"},{"line_number":3476,"context_line":"            volume_files.append(vol[\u0027connection_info\u0027][\u0027data\u0027][\u0027name\u0027])"},{"line_number":3477,"context_line":""},{"line_number":3478,"context_line":"        def contained_in_list(search_list, search_string):"},{"line_number":3479,"context_line":"            for index, contents in enumerate(search_list):"},{"line_number":3480,"context_line":"                if contents \u003d\u003d search_string:"},{"line_number":3481,"context_line":"                    return True"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPX%2F%2Fn0w%3D","line":3478,"updated":"2013-06-14 05:45:03.000000000","message":"This function is superfluous and makes the code flow harder to read.  I\u0027d remove this function and use a \"if search_string in search_list\" where this function gets called (see below)","commit_id":"78f8a1048124e9f2adfe796163cd6d50430811d7"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"3d09bfb38f8c0dee7d719b7f8bab23b9280afdb9","unresolved":false,"context_lines":[{"line_number":3503,"context_line":"                continue"},{"line_number":3504,"context_line":""},{"line_number":3505,"context_line":"            if disk_type \u003d\u003d \u0027file\u0027:"},{"line_number":3506,"context_line":"                disk_name \u003d os.path.basename(path)"},{"line_number":3507,"context_line":"                if contained_in_list(volume_files, disk_name):"},{"line_number":3508,"context_line":"                    continue"},{"line_number":3509,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPX%2F%2Fn0s%3D","line":3506,"updated":"2013-06-14 05:45:03.000000000","message":"recommend: \"if disk_name in volume_files\" here instead of using the extra function.  Will make this easier to read.","commit_id":"78f8a1048124e9f2adfe796163cd6d50430811d7"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"3d09bfb38f8c0dee7d719b7f8bab23b9280afdb9","unresolved":false,"context_lines":[{"line_number":3504,"context_line":""},{"line_number":3505,"context_line":"            if disk_type \u003d\u003d \u0027file\u0027:"},{"line_number":3506,"context_line":"                disk_name \u003d os.path.basename(path)"},{"line_number":3507,"context_line":"                if contained_in_list(volume_files, disk_name):"},{"line_number":3508,"context_line":"                    continue"},{"line_number":3509,"context_line":""},{"line_number":3510,"context_line":"            # get the real disk size or"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPX%2F%2Fn0o%3D","line":3507,"updated":"2013-06-14 05:45:03.000000000","message":"Perhaps a debug log here indicating we found a volume and are skipping.","commit_id":"78f8a1048124e9f2adfe796163cd6d50430811d7"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"a0b7168d3fdb0a37d90f8715bca2b0254cddc532","unresolved":false,"context_lines":[{"line_number":3533,"context_line":"        volume_devices \u003d set()"},{"line_number":3534,"context_line":"        for vol in block_device_mapping:"},{"line_number":3535,"context_line":"                disk_dev \u003d vol[\u0027mount_device\u0027].rpartition(\"/\")[2]"},{"line_number":3536,"context_line":"                volume_devices.add(disk_dev)"},{"line_number":3537,"context_line":""},{"line_number":3538,"context_line":"        disk_info \u003d []"},{"line_number":3539,"context_line":"        doc \u003d etree.fromstring(xml)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAPn%2F%2F1ug%3D","line":3536,"updated":"2013-06-20 01:46:57.000000000","message":"You have some weird formatting here.  It looks like these last two lines were indented with 8 spaces instead of 4?","commit_id":"3e1a1ab7932c71cc65dc49fd62ace50ef32e1207"}]}
