)]}'
{"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"cf7e1e7b665fd65db5890a67021f5d7874987883","unresolved":false,"context_lines":[{"line_number":15156,"context_line":"        inst[\u0027host\u0027] \u003d \u0027host1\u0027"},{"line_number":15157,"context_line":"        inst[\u0027root_gb\u0027] \u003d flavor.root_gb"},{"line_number":15158,"context_line":"        inst[\u0027ephemeral_gb\u0027] \u003d flavor.ephemeral_gb"},{"line_number":15159,"context_line":"        inst[\u0027config_drive\u0027] \u003d None"},{"line_number":15160,"context_line":"        inst[\u0027kernel_id\u0027] \u003d 2"},{"line_number":15161,"context_line":"        inst[\u0027ramdisk_id\u0027] \u003d 3"},{"line_number":15162,"context_line":"        inst[\u0027key_data\u0027] \u003d \u0027ABCDEFG\u0027"}],"source_content_type":"text/x-python","patch_set":13,"id":"dada55a8_ef3aba97","line":15159,"updated":"2016-07-22 15:49:28.000000000","message":"You said in the commit message that this should be a string, but you set it to not a string here. This might still be right, but it seems strange to me. Can we omit this or can you just elaborate about where/why this needs changing?","commit_id":"519830d8602c090fb9b6fe90c15c5f55d67e89ec"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"69f50a45dd01b9e122c5d1760eff636a4a5b3d6e","unresolved":false,"context_lines":[{"line_number":15156,"context_line":"        inst[\u0027host\u0027] \u003d \u0027host1\u0027"},{"line_number":15157,"context_line":"        inst[\u0027root_gb\u0027] \u003d flavor.root_gb"},{"line_number":15158,"context_line":"        inst[\u0027ephemeral_gb\u0027] \u003d flavor.ephemeral_gb"},{"line_number":15159,"context_line":"        inst[\u0027config_drive\u0027] \u003d None"},{"line_number":15160,"context_line":"        inst[\u0027kernel_id\u0027] \u003d 2"},{"line_number":15161,"context_line":"        inst[\u0027ramdisk_id\u0027] \u003d 3"},{"line_number":15162,"context_line":"        inst[\u0027key_data\u0027] \u003d \u0027ABCDEFG\u0027"}],"source_content_type":"text/x-python","patch_set":13,"id":"dada55a8_6da764a7","line":15159,"in_reply_to":"dada55a8_326b0d20","updated":"2016-07-26 17:36:21.000000000","message":"Okay, my suspicion was that it was actually not needed, but it was called out in the commit message.\n\nMy preference would be to just convert it back to no change, and if when he gets back he has a problem with that we can do another patch to change it (and make him show us why with a test :)","commit_id":"519830d8602c090fb9b6fe90c15c5f55d67e89ec"},{"author":{"_account_id":7461,"name":"Paul Murray","email":"pmurray@hpe.com","username":"ptm"},"change_message_id":"3884a359ec79cee51dd627cebf18307ce8baa2ad","unresolved":false,"context_lines":[{"line_number":15156,"context_line":"        inst[\u0027host\u0027] \u003d \u0027host1\u0027"},{"line_number":15157,"context_line":"        inst[\u0027root_gb\u0027] \u003d flavor.root_gb"},{"line_number":15158,"context_line":"        inst[\u0027ephemeral_gb\u0027] \u003d flavor.ephemeral_gb"},{"line_number":15159,"context_line":"        inst[\u0027config_drive\u0027] \u003d None"},{"line_number":15160,"context_line":"        inst[\u0027kernel_id\u0027] \u003d 2"},{"line_number":15161,"context_line":"        inst[\u0027ramdisk_id\u0027] \u003d 3"},{"line_number":15162,"context_line":"        inst[\u0027key_data\u0027] \u003d \u0027ABCDEFG\u0027"}],"source_content_type":"text/x-python","patch_set":13,"id":"bacf61ea_a45e2d43","line":15159,"in_reply_to":"dada55a8_37281633","updated":"2016-07-27 22:54:46.000000000","message":"This gets set to True by the compute manager after virt drivers spawn method has completed (for build_run, rebuild and unshelve). So I think it is either irrelevant in this test or too early to set to True.","commit_id":"519830d8602c090fb9b6fe90c15c5f55d67e89ec"},{"author":{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},"change_message_id":"e4cf7c5962b1e4681be1dddb435c4a7d88bd2db0","unresolved":false,"context_lines":[{"line_number":15156,"context_line":"        inst[\u0027host\u0027] \u003d \u0027host1\u0027"},{"line_number":15157,"context_line":"        inst[\u0027root_gb\u0027] \u003d flavor.root_gb"},{"line_number":15158,"context_line":"        inst[\u0027ephemeral_gb\u0027] \u003d flavor.ephemeral_gb"},{"line_number":15159,"context_line":"        inst[\u0027config_drive\u0027] \u003d None"},{"line_number":15160,"context_line":"        inst[\u0027kernel_id\u0027] \u003d 2"},{"line_number":15161,"context_line":"        inst[\u0027ramdisk_id\u0027] \u003d 3"},{"line_number":15162,"context_line":"        inst[\u0027key_data\u0027] \u003d \u0027ABCDEFG\u0027"}],"source_content_type":"text/x-python","patch_set":13,"id":"dada55a8_37281633","line":15159,"in_reply_to":"dada55a8_6da764a7","updated":"2016-07-26 20:25:54.000000000","message":"Done","commit_id":"519830d8602c090fb9b6fe90c15c5f55d67e89ec"},{"author":{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},"change_message_id":"8d1f6f187f1d81b00e2efb933afd382b9462adf6","unresolved":false,"context_lines":[{"line_number":15156,"context_line":"        inst[\u0027host\u0027] \u003d \u0027host1\u0027"},{"line_number":15157,"context_line":"        inst[\u0027root_gb\u0027] \u003d flavor.root_gb"},{"line_number":15158,"context_line":"        inst[\u0027ephemeral_gb\u0027] \u003d flavor.ephemeral_gb"},{"line_number":15159,"context_line":"        inst[\u0027config_drive\u0027] \u003d None"},{"line_number":15160,"context_line":"        inst[\u0027kernel_id\u0027] \u003d 2"},{"line_number":15161,"context_line":"        inst[\u0027ramdisk_id\u0027] \u003d 3"},{"line_number":15162,"context_line":"        inst[\u0027key_data\u0027] \u003d \u0027ABCDEFG\u0027"}],"source_content_type":"text/x-python","patch_set":13,"id":"dada55a8_326b0d20","line":15159,"in_reply_to":"dada55a8_ef3aba97","updated":"2016-07-26 17:33:35.000000000","message":"I\u0027m not sure why Matt changed this line, but these tests will continue to pass if you change this value to: None, \"\", \"True\", True, \"False\", False, \"no\", \"yes\", \"foo\", or even just remove the setting of this field entirely.\n\nDo you have a preference? I would probably go with not setting it at all, or setting it to None. Please let me know if you think I should change this for Matt since he\u0027s on vacation.\n\nI\u0027m also down a rabbit hole, looking into what config_drive actually is in non-test code, as well as the history behind it. In the mean time, I think None is a valid value though.\n\n    class Instance\n        ...\n            \u0027config_drive\u0027: fields.StringField(nullable\u003dTrue),\n\nTesting with devstack, it appears to start as an empty string when you first launch an instance, and then it quickly transitions to the string: \"True\", but that\u0027s all I know at this point.","commit_id":"519830d8602c090fb9b6fe90c15c5f55d67e89ec"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"6f9e7aca3952e103df5b3f7cd65ea8cae4a06c7d","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from collections import deque"},{"line_number":17,"context_line":"from collections import OrderedDict"},{"line_number":18,"context_line":"import contextlib"},{"line_number":19,"context_line":"import copy"},{"line_number":20,"context_line":"import datetime"}],"source_content_type":"text/x-python","patch_set":16,"id":"bacf61ea_8fabe0d5","line":17,"updated":"2016-07-29 14:43:27.000000000","message":"femto-nit: try to only import modules not symbols/objects","commit_id":"0b4b2cf31f57a64664e1cf33776acd1c6e46977f"}]}