)]}'
{"id":"openstack%2Fnova~32841","triplet_id":"openstack%2Fnova~master~I04dfd21bb1b7168abc71f39e836126a11dad6d8d","project":"openstack/nova","branch":"master","topic":"bug/1169057","hashtags":[],"change_id":"I04dfd21bb1b7168abc71f39e836126a11dad6d8d","subject":"Don\u0027t deallocate network if destroy time out","status":"MERGED","created":"2013-06-13 07:29:43.000000000","updated":"2013-07-08 20:07:41.000000000","submitted":"2013-07-08 20:07:38.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"65ab237b596278e73d1e3964500f0cbda9d5f62b","_number":32841,"virtual_id_number":32841,"owner":{"_account_id":4468,"name":"Wangpan","email":"hzwangpan@corp.netease.com","username":"hzwangpan"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"recommended":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},{"value":0,"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"value":0,"_account_id":4468,"name":"Wangpan","email":"hzwangpan@corp.netease.com","username":"hzwangpan"},{"value":0,"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},{"value":1,"date":"2013-06-17 14:03:16.000000000","_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},{"value":2,"date":"2013-07-08 20:07:38.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"all":[{"value":0,"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},{"value":2,"date":"2013-07-02 19:13:19.000000000","_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"value":0,"_account_id":4468,"name":"Wangpan","email":"hzwangpan@corp.netease.com","username":"hzwangpan"},{"value":1,"date":"2013-06-20 13:45:48.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":2,"date":"2013-07-08 17:22:11.000000000","_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"all":[{"value":0,"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},{"value":0,"date":"2013-07-02 19:13:19.000000000","_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"value":0,"_account_id":4468,"name":"Wangpan","email":"hzwangpan@corp.netease.com","username":"hzwangpan"},{"value":0,"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":1,"date":"2013-07-08 17:22:11.000000000","_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},{"value":0,"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"value":0,"_account_id":4468,"name":"Wangpan","email":"hzwangpan@corp.netease.com","username":"hzwangpan"},{"value":0,"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"_account_id":4468,"name":"Wangpan","email":"hzwangpan@corp.netease.com","username":"hzwangpan"},{"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-06-14 01:15:55.000000000","updated_by":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"reviewer":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"state":"REVIEWER"},{"updated":"2013-06-17 14:03:16.000000000","updated_by":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"reviewer":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2013-06-20 13:45:48.000000000","updated_by":{"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},"reviewer":{"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},"state":"REVIEWER"},{"updated":"2013-07-02 19:13:19.000000000","updated_by":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"reviewer":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"state":"REVIEWER"},{"updated":"2013-07-08 17:22:11.000000000","updated_by":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"reviewer":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"state":"REVIEWER"},{"updated":"2013-07-08 20:07:38.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"bb1b80888727e049b5dc94ac7c1000c86301810e","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2013-06-13 07:54:11.000000000","message":"Patch Set 1: Works for me\n\nSmokeStack Results (patch set 1):\n\tLibvirt (Fedora 18) Success: http://smokestack.openstack.org/?go\u003d/jobs/90926\n\tXenServer (Fedora 18) Success: http://smokestack.openstack.org/?go\u003d/jobs/90927\n","accounts_in_message":[],"_revision_number":1},{"id":"01c9d9b6feb930ce09f55514a3c152be1807f974","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-06-13 08:15:21.000000000","message":"Patch Set 1: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGithub#Test_Failures\n\n- http://logs.openstack.org/32841/1/check/gate-nova-pep8/28715 : SUCCESS in 4m 00s\n- http://docs-draft.openstack.org/32841/1/check/gate-nova-docs/22934/doc/build/html/ : SUCCESS in 3m 19s\n- http://logs.openstack.org/32841/1/check/gate-nova-python26/24322 : SUCCESS in 19m 32s\n- http://logs.openstack.org/32841/1/check/gate-nova-python27/24423 : SUCCESS in 10m 24s\n- http://logs.openstack.org/32841/1/check/gate-tempest-devstack-vm-full/22910 : SUCCESS in 39m 10s\n- http://logs.openstack.org/32841/1/check/gate-tempest-devstack-vm-postgres-full/22617 : SUCCESS in 39m 12s\n- http://logs.openstack.org/32841/1/check/gate-tempest-devstack-vm-quantum/30214 : FAILURE in 44m 50s\n- http://logs.openstack.org/32841/1/check/gate-grenade-devstack-vm/10003 : SUCCESS in 14m 43s (non-voting)\n- http://logs.openstack.org/32841/1/check/gate-nova-pylint/13631 : SUCCESS in 10m 38s (non-voting)\n","accounts_in_message":[],"_revision_number":1},{"id":"b9de89803a9dabd0e09c51e972abb72a1554f038","author":{"_account_id":4468,"name":"Wangpan","email":"hzwangpan@corp.netease.com","username":"hzwangpan"},"date":"2013-06-13 08:21:09.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"6935d1bc2faec18201d044f7a42e7e3f4388cfa4","author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"date":"2013-06-13 08:27:55.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\ncould you add some tests that shows that this code fixes bug?","accounts_in_message":[],"_revision_number":1},{"id":"8f03d284136c923bb215f2003c8fa45121671de0","author":{"_account_id":4468,"name":"Wangpan","email":"hzwangpan@corp.netease.com","username":"hzwangpan"},"date":"2013-06-13 08:58:02.000000000","message":"Patch Set 1:\n\nHi Boris, I think the unit tests have already been added here: https://review.openstack.org/#/c/30201/3/nova/tests/compute/test_compute.py, if you didn\u0027t mean that, let me know.","accounts_in_message":[],"_revision_number":1},{"id":"43b6403022eb0d23d83c4c33b5b0f8bd47e21fcb","author":{"_account_id":4468,"name":"Wangpan","email":"hzwangpan@corp.netease.com","username":"hzwangpan"},"date":"2013-06-13 09:19:52.000000000","message":"Patch Set 1:\n\nrecheck nobug","accounts_in_message":[],"_revision_number":1},{"id":"a8fb2f8846116b36e3f08a9f2dc6f10ab6894832","author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"date":"2013-06-13 10:51:15.000000000","message":"Patch Set 1:\n\nHm.. you are changing behavior of method so this behavior is not covered by tests 100%. \nSo you should add or change existing tests to cover this case.","accounts_in_message":[],"_revision_number":1},{"id":"8947ccda0f880cf28d1568e811beb4277e59788e","author":{"_account_id":4468,"name":"Wangpan","email":"hzwangpan@corp.netease.com","username":"hzwangpan"},"date":"2013-06-14 01:15:14.000000000","message":"Patch Set 1:\n\nThanks for your advice, but what I changed here is similar as this one: https://review.openstack.org/#/c/30201 and I believe the change is covered by the unit tests which are added there, too. I raised a powerofffailure exception if libvirt destroy a vm timed out, this exception is tested by the unit tests I refered, I think a new same test is not needed, isn\u0027t it?","accounts_in_message":[],"_revision_number":1},{"id":"516e24064f11460217faa09183ac2015e17ee3ca","author":{"_account_id":4468,"name":"Wangpan","email":"hzwangpan@corp.netease.com","username":"hzwangpan"},"date":"2013-06-14 01:15:36.000000000","message":"Patch Set 1: Rebased","accounts_in_message":[],"_revision_number":1},{"id":"36ad6604ea8a1f354fd3ed6d389c9c4c249f6096","author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"date":"2013-06-14 01:15:55.000000000","message":"Patch Set 2: I would prefer that you didn\u0027t merge this\n\nAutomatically re-added by Gerrit trivial rebase detection script.","accounts_in_message":[],"_revision_number":2},{"id":"c9d3adb975c1797ab474fd0dea030c1c84a37285","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2013-06-14 01:38:05.000000000","message":"Patch Set 2: Works for me\n\nSmokeStack Results (patch set 2):\n\tLibvirt (Fedora 18) Success: http://smokestack.openstack.org/?go\u003d/jobs/91159\n\tXenServer (Fedora 18) Success: http://smokestack.openstack.org/?go\u003d/jobs/91160\n","accounts_in_message":[],"_revision_number":2},{"id":"1e3c1b670334195e35c70a68b57a6f2230d32850","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-06-14 01:56:37.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/32841/2/check/gate-nova-pep8/28836 : SUCCESS in 3m 29s\n- http://docs-draft.openstack.org/32841/2/check/gate-nova-docs/23055/doc/build/html/ : SUCCESS in 4m 24s\n- http://logs.openstack.org/32841/2/check/gate-nova-python26/24443 : SUCCESS in 19m 36s\n- http://logs.openstack.org/32841/2/check/gate-nova-python27/24544 : SUCCESS in 9m 46s\n- http://logs.openstack.org/32841/2/check/gate-tempest-devstack-vm-full/23191 : SUCCESS in 38m 47s\n- http://logs.openstack.org/32841/2/check/gate-tempest-devstack-vm-postgres-full/22898 : SUCCESS in 40m 28s\n- http://logs.openstack.org/32841/2/check/gate-tempest-devstack-vm-quantum/30527 : SUCCESS in 18m 05s\n- http://logs.openstack.org/32841/2/check/gate-grenade-devstack-vm/10253 : FAILURE in 32m 04s (non-voting)\n- http://logs.openstack.org/32841/2/check/gate-nova-pylint/13733 : SUCCESS in 9m 53s (non-voting)\n","accounts_in_message":[],"_revision_number":2},{"id":"cd6adae01ecd58606cc2b4d96dce74bdf64d8929","author":{"_account_id":4468,"name":"Wangpan","email":"hzwangpan@corp.netease.com","username":"hzwangpan"},"date":"2013-06-17 01:12:48.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"cba3797fb0ec14c4ad309808462f6b42718134cd","author":{"_account_id":5494,"name":"Trivial Rebase","email":"trivial-rebase@review.openstack.org","username":"trivial-rebase"},"date":"2013-06-17 01:13:04.000000000","message":"Patch Set 3:\n\nNew patchset patch-id matches previous patchset, but commit message has changed.","accounts_in_message":[],"_revision_number":3},{"id":"bfc068a3a4d3098653d488f21dd4e8dd95b4d347","author":{"_account_id":4468,"name":"Wangpan","email":"hzwangpan@corp.netease.com","username":"hzwangpan"},"date":"2013-06-17 01:14:25.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"4487760e6fee3c511cb6677918e6675daa2fa5d5","author":{"_account_id":5494,"name":"Trivial Rebase","email":"trivial-rebase@review.openstack.org","username":"trivial-rebase"},"date":"2013-06-17 01:14:40.000000000","message":"Patch Set 4:\n\nNew patchset patch-id matches previous patchset, but commit message has changed.","accounts_in_message":[],"_revision_number":4},{"id":"fd83cfd713bbd70ff1ddb65e17137cbe17677242","author":{"_account_id":4468,"name":"Wangpan","email":"hzwangpan@corp.netease.com","username":"hzwangpan"},"date":"2013-06-17 01:19:32.000000000","message":"Patch Set 4: Work In Progress","accounts_in_message":[],"_revision_number":4},{"id":"6e4c0c8633ed2483a48c5da95b9025847e62bba2","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2013-06-17 01:37:38.000000000","message":"Patch Set 4: Works for me\n\nSmokeStack Results (patch set 4):\n\tLibvirt (Fedora 18) Success: http://smokestack.openstack.org/?go\u003d/jobs/91606\n\tXenServer (Fedora 18) Success: http://smokestack.openstack.org/?go\u003d/jobs/91607\n","accounts_in_message":[],"_revision_number":4},{"id":"d858c2a6249fcd3f66968350148a152dce890d92","author":{"_account_id":4468,"name":"Wangpan","email":"hzwangpan@corp.netease.com","username":"hzwangpan"},"date":"2013-06-17 01:52:03.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"9d60b90c6f3a08bf05187d4c349281cbc95e7a46","author":{"_account_id":4468,"name":"Wangpan","email":"hzwangpan@corp.netease.com","username":"hzwangpan"},"date":"2013-06-17 01:55:17.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"cef361d09ab1743562f8d53c296ec1eb2837e7d9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-06-17 02:35:53.000000000","message":"Patch Set 6: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/32841/6/check/gate-nova-pep8/29091 : SUCCESS in 3m 42s\n- http://docs-draft.openstack.org/32841/6/check/gate-nova-docs/23310/doc/build/html/ : SUCCESS in 2m 49s\n- http://logs.openstack.org/32841/6/check/gate-nova-python26/24696 : SUCCESS in 17m 57s\n- http://logs.openstack.org/32841/6/check/gate-nova-python27/24799 : SUCCESS in 9m 41s\n- http://logs.openstack.org/32841/6/check/gate-tempest-devstack-vm-full/23751 : SUCCESS in 40m 12s\n- http://logs.openstack.org/32841/6/check/gate-tempest-devstack-vm-postgres-full/23457 : SUCCESS in 39m 48s\n- http://logs.openstack.org/32841/6/check/gate-tempest-devstack-vm-quantum/31147 : SUCCESS in 17m 17s\n- http://logs.openstack.org/32841/6/check/gate-grenade-devstack-vm/10743 : FAILURE in 33m 41s (non-voting)\n- http://logs.openstack.org/32841/6/check/gate-nova-pylint/13910 : SUCCESS in 10m 11s (non-voting)\n","accounts_in_message":[],"_revision_number":6},{"id":"015b2cd40f2fcf8833f89017851eab688f8580cc","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2013-06-17 14:03:16.000000000","message":"Patch Set 6: Works for me\n\nSmokeStack Results (patch set 6):\n\tLibvirt (Fedora 18) Success: http://smokestack.openstack.org/?go\u003d/jobs/91612\n","accounts_in_message":[],"_revision_number":6},{"id":"7d33733cf71c6655ee02160de8a6751fe3c4ba6c","author":{"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},"date":"2013-06-20 13:45:48.000000000","message":"Patch Set 6: Looks good to me, but someone else must approve\n\nI worry that this could make bug 1190206 or bug 1183523 worse, by cleaning up the fixed ip less often.  But I guess making sure that all our IPs are reachable is more important than making sure all out IPs are cleaned up.","accounts_in_message":[],"_revision_number":6},{"id":"8326f17c3c8941618da6e2c3b4de3b7c47de9130","author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"date":"2013-07-02 19:13:19.000000000","message":"Patch Set 6: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":6},{"id":"7e1a57cdd96e4637d36e746a71d83a46b19cdfbc","author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"date":"2013-07-08 17:22:11.000000000","message":"Patch Set 6: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":6},{"id":"6c1aa2039977de3b4f9e8669b792ed01ca9ca968","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-07-08 17:32:56.000000000","message":"Patch Set 6: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":6},{"id":"cba120008b8e1809a993e48c926b26f230889e0b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-07-08 20:07:38.000000000","message":"Patch Set 6: Verified\n\nBuild succeeded.\n\n- http://docs-draft.openstack.org/32841/6/gate/gate-nova-docs/25895/doc/build/html/ : SUCCESS in 3m 51s\n- http://logs.openstack.org/32841/6/gate/gate-nova-pep8/31675 : SUCCESS in 5m 04s\n- http://logs.openstack.org/32841/6/gate/gate-nova-python26/27268 : SUCCESS in 26m 39s\n- http://logs.openstack.org/32841/6/gate/gate-nova-python27/27380 : SUCCESS in 11m 28s\n- http://logs.openstack.org/32841/6/gate/gate-tempest-devstack-vm-full/29373 : SUCCESS in 54m 25s\n- http://logs.openstack.org/32841/6/gate/gate-tempest-devstack-vm-postgres-full/29079 : SUCCESS in 44m 53s\n- http://logs.openstack.org/32841/6/gate/gate-tempest-devstack-vm-neutron/474 : SUCCESS in 18m 26s\n- http://logs.openstack.org/32841/6/gate/gate-grenade-devstack-vm/15610 : FAILURE in 13m 35s (non-voting)\n","accounts_in_message":[],"_revision_number":6},{"id":"524fb94d119344dcc9750558abeeb6e8b288ed48","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-07-08 20:07:41.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":6}],"current_revision_number":6,"current_revision":"d925044e09509495e7474d5f625bbd45d8985afa","revisions":{"64755edee5d8a6fd5d84139aeb63043f0d1793e4":{"kind":"REWORK","_number":1,"created":"2013-06-13 07:29:43.000000000","uploader":{"_account_id":4468,"name":"Wangpan","email":"hzwangpan@corp.netease.com","username":"hzwangpan"},"ref":"refs/changes/41/32841/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/41/32841/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/41/32841/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/41/32841/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/41/32841/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/41/32841/1"}}},"commit":{"parents":[{"commit":"a5cd0f86530013d62b066d7e917d167e521260b0","subject":"Merge \"Revert \"Fix local variable \u0027root_uuid\u0027 ref before assign\"\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/a5cd0f86530013d62b066d7e917d167e521260b0"}]}],"author":{"name":"Wangpan","email":"hzwangpan@corp.netease.com","date":"2013-06-13 07:19:21.000000000","tz":480},"committer":{"name":"Wangpan","email":"hzwangpan@corp.netease.com","date":"2013-06-13 07:29:17.000000000","tz":480},"subject":"Don\u0027t deallocate network if destroy time out","message":"Don\u0027t deallocate network if destroy time out\n\nFixes bug #1169057\nSames as bug 1180178, if libvirt return time out error during destroy a\ninstance, we also can\u0027t deallocate the network of the instance,\notherwise the fixed ip of it may be re-used by another new instance,\nresult in the new instance can\u0027t be accessed by the fixed ip.\n\nChange-Id: I04dfd21bb1b7168abc71f39e836126a11dad6d8d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/64755edee5d8a6fd5d84139aeb63043f0d1793e4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/64755edee5d8a6fd5d84139aeb63043f0d1793e4"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"a5cd0f86530013d62b066d7e917d167e521260b0","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"4c21edb7bc3475a55fab8acc0ecd5dda7479b416":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2013-06-13 07:29:43.000000000","uploader":{"_account_id":4468,"name":"Wangpan","email":"hzwangpan@corp.netease.com","username":"hzwangpan"},"ref":"refs/changes/41/32841/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/41/32841/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/41/32841/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/41/32841/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/41/32841/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/41/32841/2"}}},"commit":{"parents":[{"commit":"acda8b374169742257c098fa99220d7c823ff5ee","subject":"Merge \"Make sync_power_state routines use InstanceList\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/acda8b374169742257c098fa99220d7c823ff5ee"}]}],"author":{"name":"Wangpan","email":"hzwangpan@corp.netease.com","date":"2013-06-13 07:19:21.000000000","tz":480},"committer":{"name":"Gerrit Code Review","email":"review@openstack.org","date":"2013-06-14 01:15:35.000000000","tz":0},"subject":"Don\u0027t deallocate network if destroy time out","message":"Don\u0027t deallocate network if destroy time out\n\nFixes bug #1169057\nSames as bug 1180178, if libvirt return time out error during destroy a\ninstance, we also can\u0027t deallocate the network of the instance,\notherwise the fixed ip of it may be re-used by another new instance,\nresult in the new instance can\u0027t be accessed by the fixed ip.\n\nChange-Id: I04dfd21bb1b7168abc71f39e836126a11dad6d8d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/4c21edb7bc3475a55fab8acc0ecd5dda7479b416"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/4c21edb7bc3475a55fab8acc0ecd5dda7479b416"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"acda8b374169742257c098fa99220d7c823ff5ee","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"4692cc40467efefba3ff6ea2afeac2ac1dc03a75":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":3,"created":"2013-06-17 01:12:48.000000000","uploader":{"_account_id":4468,"name":"Wangpan","email":"hzwangpan@corp.netease.com","username":"hzwangpan"},"ref":"refs/changes/41/32841/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/41/32841/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/41/32841/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/41/32841/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/41/32841/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/41/32841/3"}}},"commit":{"parents":[{"commit":"d147af21db2db77f578e527883cf2c68abc56496","subject":"Merge \"Remove unused db api call.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/d147af21db2db77f578e527883cf2c68abc56496"}]}],"author":{"name":"Wangpan","email":"hzwangpan@corp.netease.com","date":"2013-06-13 07:19:21.000000000","tz":480},"committer":{"name":"Wangpan","email":"hzwangpan@corp.netease.com","date":"2013-06-17 01:07:40.000000000","tz":480},"subject":"Don\u0027t deallocate network if destroy time out","message":"Don\u0027t deallocate network if destroy time out\n\nFixes bug #1169057\nSames as bug 1180178, if libvirt returns time out error during destroy a\ninstance, we also can\u0027t deallocate the network of the instance,\notherwise the fixed ip of it may be re-used by another new instance,\nand resulted in the new instance can\u0027t be accessed by the fixed ip.\nThe unit tests of this commit is added by the fix commit of bug 1180178,\nso none test is added here.\n\nChange-Id: I04dfd21bb1b7168abc71f39e836126a11dad6d8d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/4692cc40467efefba3ff6ea2afeac2ac1dc03a75"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/4692cc40467efefba3ff6ea2afeac2ac1dc03a75"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"d147af21db2db77f578e527883cf2c68abc56496","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"aa13e3749bd4613371a5d870a06f9efe96e71bdb":{"kind":"NO_CODE_CHANGE","_number":4,"created":"2013-06-17 01:14:25.000000000","uploader":{"_account_id":4468,"name":"Wangpan","email":"hzwangpan@corp.netease.com","username":"hzwangpan"},"ref":"refs/changes/41/32841/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/41/32841/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/41/32841/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/41/32841/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/41/32841/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/41/32841/4"}}},"commit":{"parents":[{"commit":"d147af21db2db77f578e527883cf2c68abc56496","subject":"Merge \"Remove unused db api call.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/d147af21db2db77f578e527883cf2c68abc56496"}]}],"author":{"name":"Wangpan","email":"hzwangpan@corp.netease.com","date":"2013-06-13 07:19:21.000000000","tz":480},"committer":{"name":"Wangpan","email":"hzwangpan@corp.netease.com","date":"2013-06-17 01:13:27.000000000","tz":480},"subject":"Don\u0027t deallocate network if destroy time out","message":"Don\u0027t deallocate network if destroy time out\n\nFixes bug #1169057\nSames as bug 1180178, if libvirt returns time out error during destroy\nan instance, we also can\u0027t deallocate the network of the instance,\notherwise the fixed ip of it may be re-used by another new instance,\nand resulted in the new instance can\u0027t be accessed by the fixed ip.\nThe unit tests of this commit is added by the fix commit of bug 1180178,\nso none test is added here.\n\nChange-Id: I04dfd21bb1b7168abc71f39e836126a11dad6d8d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/aa13e3749bd4613371a5d870a06f9efe96e71bdb"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/aa13e3749bd4613371a5d870a06f9efe96e71bdb"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"d147af21db2db77f578e527883cf2c68abc56496","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"7cec77826ce0312965d5d011412a521fe3097def":{"kind":"REWORK","_number":5,"created":"2013-06-17 01:52:03.000000000","uploader":{"_account_id":4468,"name":"Wangpan","email":"hzwangpan@corp.netease.com","username":"hzwangpan"},"ref":"refs/changes/41/32841/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/41/32841/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/41/32841/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/41/32841/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/41/32841/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/41/32841/5"}}},"commit":{"parents":[{"commit":"d147af21db2db77f578e527883cf2c68abc56496","subject":"Merge \"Remove unused db api call.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/d147af21db2db77f578e527883cf2c68abc56496"}]}],"author":{"name":"Wangpan","email":"hzwangpan@corp.netease.com","date":"2013-06-13 07:19:21.000000000","tz":480},"committer":{"name":"Wangpan","email":"hzwangpan@corp.netease.com","date":"2013-06-17 01:51:07.000000000","tz":480},"subject":"Don\u0027t deallocate network if destroy time out","message":"Don\u0027t deallocate network if destroy time out\n\nFixes bug #1169057\nSames as bug 1180178, if libvirt returns time out error during destroy\nan instance, we also can\u0027t deallocate the network of the instance,\notherwise the fixed ip of it may be re-used by another new instance,\nand resulted in the new instance can\u0027t be accessed by the fixed ip.\n\nChange-Id: I04dfd21bb1b7168abc71f39e836126a11dad6d8d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/7cec77826ce0312965d5d011412a521fe3097def"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/7cec77826ce0312965d5d011412a521fe3097def"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"d147af21db2db77f578e527883cf2c68abc56496","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"d925044e09509495e7474d5f625bbd45d8985afa":{"kind":"REWORK","_number":6,"created":"2013-06-17 01:55:17.000000000","uploader":{"_account_id":4468,"name":"Wangpan","email":"hzwangpan@corp.netease.com","username":"hzwangpan"},"ref":"refs/changes/41/32841/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/41/32841/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/41/32841/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/41/32841/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/41/32841/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/41/32841/6"}}},"commit":{"parents":[{"commit":"d147af21db2db77f578e527883cf2c68abc56496","subject":"Merge \"Remove unused db api call.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/d147af21db2db77f578e527883cf2c68abc56496"}]}],"author":{"name":"Wangpan","email":"hzwangpan@corp.netease.com","date":"2013-06-13 07:19:21.000000000","tz":480},"committer":{"name":"Wangpan","email":"hzwangpan@corp.netease.com","date":"2013-06-17 01:54:46.000000000","tz":480},"subject":"Don\u0027t deallocate network if destroy time out","message":"Don\u0027t deallocate network if destroy time out\n\nFixes bug #1169057\nSames as bug 1180178, if libvirt returns time out error during destroy\nan instance, we also can\u0027t deallocate the network of the instance,\notherwise the fixed ip of it may be re-used by another new instance,\nand resulted in the new instance can\u0027t be accessed by the fixed ip.\n\nChange-Id: I04dfd21bb1b7168abc71f39e836126a11dad6d8d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/d925044e09509495e7474d5f625bbd45d8985afa"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/d925044e09509495e7474d5f625bbd45d8985afa"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"d147af21db2db77f578e527883cf2c68abc56496","is_merged_in_target_branch":true}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
