)]}'
{"nova/virt/xenapi/agent.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"97c68839a242391900883e4a6087bbe4f5f6d503","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        return jsonutils.loads(ret)"},{"line_number":122,"context_line":"    except TypeError:"},{"line_number":123,"context_line":"        LOG.error(_(\u0027The agent call to %(method)s returned an invalid\u0027"},{"line_number":124,"context_line":"                    \u0027 response: %(ret)r. args\u003d%(args)r\u0027),"},{"line_number":125,"context_line":"                  {\u0027method\u0027: method, \u0027ret\u0027: ret, \u0027args\u0027: args},"},{"line_number":126,"context_line":"                  instance\u003dinstance)"},{"line_number":127,"context_line":"        return {\u0027returncode\u0027: \u0027error\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPX%2F%2FqS0%3D","line":124,"updated":"2013-06-13 09:25:37.000000000","message":"nit usually we don\u0027t make whitespace at the begin.","commit_id":"c1201b4a5b390fb641e5b61fe62b5b1644162dbf"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"7a5ea9e40a585bd306192170bdf902daeacada56","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        return jsonutils.loads(ret)"},{"line_number":122,"context_line":"    except TypeError:"},{"line_number":123,"context_line":"        LOG.error(_(\u0027The agent call to %(method)s returned an invalid\u0027"},{"line_number":124,"context_line":"                    \u0027 response: %(ret)r. args\u003d%(args)r\u0027),"},{"line_number":125,"context_line":"                  {\u0027method\u0027: method, \u0027ret\u0027: ret, \u0027args\u0027: args},"},{"line_number":126,"context_line":"                  instance\u003dinstance)"},{"line_number":127,"context_line":"        return {\u0027returncode\u0027: \u0027error\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPX%2F%2FqP8%3D","line":124,"in_reply_to":"AAAAPX%2F%2FqS0%3D","updated":"2013-06-13 09:53:12.000000000","message":"Done","commit_id":"c1201b4a5b390fb641e5b61fe62b5b1644162dbf"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"97c68839a242391900883e4a6087bbe4f5f6d503","unresolved":false,"context_lines":[{"line_number":225,"context_line":""},{"line_number":226,"context_line":"        # Successful return code from password is \u00270\u0027"},{"line_number":227,"context_line":"        if resp[\u0027returncode\u0027] !\u003d \u00270\u0027:"},{"line_number":228,"context_line":"            msg \u003d _(\u0027Failed to exchange keys: %r\u0027) % resp"},{"line_number":229,"context_line":"            LOG.error(msg, instance\u003dself.instance)"},{"line_number":230,"context_line":"            raise NotImplementedError(msg)"},{"line_number":231,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPX%2F%2FqSg%3D","line":228,"updated":"2013-06-13 09:25:37.000000000","message":"pls don\u0027t use local variable, above also","commit_id":"c1201b4a5b390fb641e5b61fe62b5b1644162dbf"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"7a5ea9e40a585bd306192170bdf902daeacada56","unresolved":false,"context_lines":[{"line_number":225,"context_line":""},{"line_number":226,"context_line":"        # Successful return code from password is \u00270\u0027"},{"line_number":227,"context_line":"        if resp[\u0027returncode\u0027] !\u003d \u00270\u0027:"},{"line_number":228,"context_line":"            msg \u003d _(\u0027Failed to exchange keys: %r\u0027) % resp"},{"line_number":229,"context_line":"            LOG.error(msg, instance\u003dself.instance)"},{"line_number":230,"context_line":"            raise NotImplementedError(msg)"},{"line_number":231,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPX%2F%2FqPw%3D","line":228,"in_reply_to":"AAAAPX%2F%2FqSg%3D","updated":"2013-06-13 09:53:12.000000000","message":"local var is used twice here, so it\u0027s justified","commit_id":"c1201b4a5b390fb641e5b61fe62b5b1644162dbf"}],"nova/virt/xenapi/fake.py":[{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"1528bfddc4c587999812002c48c24348e8784f9e","unresolved":false,"context_lines":[{"line_number":479,"context_line":"            return ref"},{"line_number":480,"context_line":"        else:"},{"line_number":481,"context_line":"            # SR not found in db, so we create one"},{"line_number":482,"context_line":"            params \u003d dict(_1\u003d_1,"},{"line_number":483,"context_line":"                          sr_uuid\u003dsr_uuid,"},{"line_number":484,"context_line":"                          label\u003dlabel,"},{"line_number":485,"context_line":"                          desc\u003ddesc,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPX%2F%2FqTo%3D","line":482,"updated":"2013-06-13 09:30:24.000000000","message":"I find it hard to believe we want _1 here, but it\u0027s best to fix that in a separate commit ... keep this commit as non-functional changes","commit_id":"c1201b4a5b390fb641e5b61fe62b5b1644162dbf"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"97c68839a242391900883e4a6087bbe4f5f6d503","unresolved":false,"context_lines":[{"line_number":479,"context_line":"            return ref"},{"line_number":480,"context_line":"        else:"},{"line_number":481,"context_line":"            # SR not found in db, so we create one"},{"line_number":482,"context_line":"            params \u003d dict(_1\u003d_1,"},{"line_number":483,"context_line":"                          sr_uuid\u003dsr_uuid,"},{"line_number":484,"context_line":"                          label\u003dlabel,"},{"line_number":485,"context_line":"                          desc\u003ddesc,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPX%2F%2FqSY%3D","line":482,"updated":"2013-06-13 09:25:37.000000000","message":"use {} instead of dict // performance reason \nhttp://doughellmann.com/2012/11/the-performance-impact-of-using-dict-instead-of-in-cpython-2-7-2.html","commit_id":"c1201b4a5b390fb641e5b61fe62b5b1644162dbf"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"7a5ea9e40a585bd306192170bdf902daeacada56","unresolved":false,"context_lines":[{"line_number":479,"context_line":"            return ref"},{"line_number":480,"context_line":"        else:"},{"line_number":481,"context_line":"            # SR not found in db, so we create one"},{"line_number":482,"context_line":"            params \u003d dict(_1\u003d_1,"},{"line_number":483,"context_line":"                          sr_uuid\u003dsr_uuid,"},{"line_number":484,"context_line":"                          label\u003dlabel,"},{"line_number":485,"context_line":"                          desc\u003ddesc,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPX%2F%2FqPg%3D","line":482,"in_reply_to":"AAAAPX%2F%2FqSY%3D","updated":"2013-06-13 09:53:12.000000000","message":"Done","commit_id":"c1201b4a5b390fb641e5b61fe62b5b1644162dbf"},{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"1528bfddc4c587999812002c48c24348e8784f9e","unresolved":false,"context_lines":[{"line_number":486,"context_line":"                          type\u003dtype,"},{"line_number":487,"context_line":"                          content_type\u003dcontent_type,"},{"line_number":488,"context_line":"                          shared\u003dshared,"},{"line_number":489,"context_line":"                          sm_config\u003dsm_config)"},{"line_number":490,"context_line":"            sr_ref \u003d _create_object(\u0027SR\u0027, params)"},{"line_number":491,"context_line":"            _db_content[\u0027SR\u0027][sr_ref][\u0027uuid\u0027] \u003d sr_uuid"},{"line_number":492,"context_line":"            _db_content[\u0027SR\u0027][sr_ref][\u0027forgotten\u0027] \u003d 0"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPX%2F%2FqTc%3D","line":489,"updated":"2013-06-13 09:30:24.000000000","message":"What about ref and rec?","commit_id":"c1201b4a5b390fb641e5b61fe62b5b1644162dbf"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"7a5ea9e40a585bd306192170bdf902daeacada56","unresolved":false,"context_lines":[{"line_number":486,"context_line":"                          type\u003dtype,"},{"line_number":487,"context_line":"                          content_type\u003dcontent_type,"},{"line_number":488,"context_line":"                          shared\u003dshared,"},{"line_number":489,"context_line":"                          sm_config\u003dsm_config)"},{"line_number":490,"context_line":"            sr_ref \u003d _create_object(\u0027SR\u0027, params)"},{"line_number":491,"context_line":"            _db_content[\u0027SR\u0027][sr_ref][\u0027uuid\u0027] \u003d sr_uuid"},{"line_number":492,"context_line":"            _db_content[\u0027SR\u0027][sr_ref][\u0027forgotten\u0027] \u003d 0"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPX%2F%2FqLU%3D","line":489,"in_reply_to":"AAAAPX%2F%2FqTc%3D","updated":"2013-06-13 09:53:12.000000000","message":"Actually I don\u0027t know what we want to store in the params, but...\nrec is None here, and ref is some counter in the loop, I don\u0027t think it\u0027s needed.","commit_id":"c1201b4a5b390fb641e5b61fe62b5b1644162dbf"},{"author":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"change_message_id":"7993c83453e22867e48cfed2f349fc73bc56a5b7","unresolved":false,"context_lines":[{"line_number":479,"context_line":"            return ref"},{"line_number":480,"context_line":"        else:"},{"line_number":481,"context_line":"            # SR not found in db, so we create one"},{"line_number":482,"context_line":"            params \u003d {\u0027_1\u0027: _1,"},{"line_number":483,"context_line":"                      \u0027sr_uuid\u0027: sr_uuid,"},{"line_number":484,"context_line":"                      \u0027label\u0027: label,"},{"line_number":485,"context_line":"                      \u0027desc\u0027: desc,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPX%2F%2Fpko%3D","line":482,"updated":"2013-06-13 14:22:22.000000000","message":"Adding _1 to params isn\u0027t necessary. It\u0027s not used and meant to be ignored.","commit_id":"a251671dd2783fd116aa904ae8d55ab411bcf7b3"}],"nova/virt/xenapi/host.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"97c68839a242391900883e4a6087bbe4f5f6d503","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"                    break"},{"line_number":100,"context_line":"                except self._session.XenAPI.Failure:"},{"line_number":101,"context_line":"                    LOG.exception(_(\u0027Unable to migrate VM %(vm_ref)s\u0027"},{"line_number":102,"context_line":"                                    \u0027from %(host)s\u0027),"},{"line_number":103,"context_line":"                                  {\u0027vm_ref\u0027: vm_ref, \u0027host\u0027: host})"},{"line_number":104,"context_line":"                    instance.host \u003d host"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPX%2F%2FqSQ%3D","line":101,"updated":"2013-06-13 09:25:37.000000000","message":"whitespace required","commit_id":"c1201b4a5b390fb641e5b61fe62b5b1644162dbf"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"7a5ea9e40a585bd306192170bdf902daeacada56","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"                    break"},{"line_number":100,"context_line":"                except self._session.XenAPI.Failure:"},{"line_number":101,"context_line":"                    LOG.exception(_(\u0027Unable to migrate VM %(vm_ref)s\u0027"},{"line_number":102,"context_line":"                                    \u0027from %(host)s\u0027),"},{"line_number":103,"context_line":"                                  {\u0027vm_ref\u0027: vm_ref, \u0027host\u0027: host})"},{"line_number":104,"context_line":"                    instance.host \u003d host"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPX%2F%2FqPE%3D","line":101,"in_reply_to":"AAAAPX%2F%2FqSQ%3D","updated":"2013-06-13 09:53:12.000000000","message":"Done","commit_id":"c1201b4a5b390fb641e5b61fe62b5b1644162dbf"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"97c68839a242391900883e4a6087bbe4f5f6d503","unresolved":false,"context_lines":[{"line_number":203,"context_line":"        return None"},{"line_number":204,"context_line":"    except session.XenAPI.Failure as e:"},{"line_number":205,"context_line":"        LOG.error(_(\"The call to %(method)s returned \""},{"line_number":206,"context_line":"                    \"an error: %(e)s.\"),"},{"line_number":207,"context_line":"                  {\u0027method\u0027: method, \u0027e\u0027: e})"},{"line_number":208,"context_line":"        return e.details[1]"},{"line_number":209,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPX%2F%2FqSE%3D","line":206,"updated":"2013-06-13 09:25:37.000000000","message":"why do you don\u0027t want to put this part of string to previous line?","commit_id":"c1201b4a5b390fb641e5b61fe62b5b1644162dbf"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"7a5ea9e40a585bd306192170bdf902daeacada56","unresolved":false,"context_lines":[{"line_number":203,"context_line":"        return None"},{"line_number":204,"context_line":"    except session.XenAPI.Failure as e:"},{"line_number":205,"context_line":"        LOG.error(_(\"The call to %(method)s returned \""},{"line_number":206,"context_line":"                    \"an error: %(e)s.\"),"},{"line_number":207,"context_line":"                  {\u0027method\u0027: method, \u0027e\u0027: e})"},{"line_number":208,"context_line":"        return e.details[1]"},{"line_number":209,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPX%2F%2FqOo%3D","line":206,"in_reply_to":"AAAAPX%2F%2FqSE%3D","updated":"2013-06-13 09:53:12.000000000","message":"yep, it fits.","commit_id":"c1201b4a5b390fb641e5b61fe62b5b1644162dbf"}],"nova/virt/xenapi/imageupload/glance.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"97c68839a242391900883e4a6087bbe4f5f6d503","unresolved":false,"context_lines":[{"line_number":70,"context_line":"                            \" ID %(image_id)s\""},{"line_number":71,"context_line":"                            \" glance server: %(glance_host)s:%(glance_port)d\""},{"line_number":72,"context_line":"                            \" attempt %(attempt_num)d/%(max_attempts)d\"),"},{"line_number":73,"context_line":"                          {\u0027vdi_uuids\u0027: vdi_uuids, \u0027image_id\u0027: image_id,"},{"line_number":74,"context_line":"                           \u0027glance_host\u0027: glance_host,"},{"line_number":75,"context_line":"                           \u0027glance_port\u0027: glance_port,"},{"line_number":76,"context_line":"                           \u0027attempt_num\u0027: attempt_num,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPX%2F%2FqSA%3D","line":73,"updated":"2013-06-13 09:25:37.000000000","message":"one param / one line","commit_id":"c1201b4a5b390fb641e5b61fe62b5b1644162dbf"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"7a5ea9e40a585bd306192170bdf902daeacada56","unresolved":false,"context_lines":[{"line_number":70,"context_line":"                            \" ID %(image_id)s\""},{"line_number":71,"context_line":"                            \" glance server: %(glance_host)s:%(glance_port)d\""},{"line_number":72,"context_line":"                            \" attempt %(attempt_num)d/%(max_attempts)d\"),"},{"line_number":73,"context_line":"                          {\u0027vdi_uuids\u0027: vdi_uuids, \u0027image_id\u0027: image_id,"},{"line_number":74,"context_line":"                           \u0027glance_host\u0027: glance_host,"},{"line_number":75,"context_line":"                           \u0027glance_port\u0027: glance_port,"},{"line_number":76,"context_line":"                           \u0027attempt_num\u0027: attempt_num,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPX%2F%2FqOc%3D","line":73,"in_reply_to":"AAAAPX%2F%2FqSA%3D","updated":"2013-06-13 09:53:12.000000000","message":"Done.","commit_id":"c1201b4a5b390fb641e5b61fe62b5b1644162dbf"}],"nova/virt/xenapi/vif.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"97c68839a242391900883e4a6087bbe4f5f6d503","unresolved":false,"context_lines":[{"line_number":121,"context_line":"                                      \"%(bridge)s has VLAN id %(pif_vlan)d. \""},{"line_number":122,"context_line":"                                      \"Expected %(vlan_num)d\"),"},{"line_number":123,"context_line":"                                    {\u0027pif_uuid\u0027: pif_rec[\u0027uuid\u0027],"},{"line_number":124,"context_line":"                                     \u0027bridge\u0027: bridge, \u0027pif_vlan\u0027: pif_vlan,"},{"line_number":125,"context_line":"                                     \u0027vlan_num\u0027: vlan_num})"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        return network_ref"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPX%2F%2FqRk%3D","line":124,"updated":"2013-06-13 09:25:37.000000000","message":"one param / one line\n\n+ align problems","commit_id":"c1201b4a5b390fb641e5b61fe62b5b1644162dbf"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"7a5ea9e40a585bd306192170bdf902daeacada56","unresolved":false,"context_lines":[{"line_number":121,"context_line":"                                      \"%(bridge)s has VLAN id %(pif_vlan)d. \""},{"line_number":122,"context_line":"                                      \"Expected %(vlan_num)d\"),"},{"line_number":123,"context_line":"                                    {\u0027pif_uuid\u0027: pif_rec[\u0027uuid\u0027],"},{"line_number":124,"context_line":"                                     \u0027bridge\u0027: bridge, \u0027pif_vlan\u0027: pif_vlan,"},{"line_number":125,"context_line":"                                     \u0027vlan_num\u0027: vlan_num})"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        return network_ref"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPX%2F%2FqOU%3D","line":124,"in_reply_to":"AAAAPX%2F%2FqRk%3D","updated":"2013-06-13 09:53:12.000000000","message":"aligning is ok, i believe it\u0027s some issue on the page.","commit_id":"c1201b4a5b390fb641e5b61fe62b5b1644162dbf"}],"nova/virt/xenapi/vm_utils.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"97c68839a242391900883e4a6087bbe4f5f6d503","unresolved":false,"context_lines":[{"line_number":471,"context_line":"          \u0027tags\u0027: []})"},{"line_number":472,"context_line":"    LOG.debug(_(\u0027Created VDI %(vdi_ref)s (%(name_label)s,\u0027"},{"line_number":473,"context_line":"                \u0027 %(virtual_size)s, %(read_only)s) on %(sr_ref)s.\u0027),"},{"line_number":474,"context_line":"              {\u0027vdi_ref\u0027: vdi_ref, \u0027name_label\u0027: name_label,"},{"line_number":475,"context_line":"               \u0027virtual_size\u0027: virtual_size, \u0027read_only\u0027: read_only,"},{"line_number":476,"context_line":"               \u0027sr_ref\u0027: sr_ref})"},{"line_number":477,"context_line":"    return vdi_ref"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPX%2F%2FqRQ%3D","line":474,"updated":"2013-06-13 09:25:37.000000000","message":"one param pro line","commit_id":"c1201b4a5b390fb641e5b61fe62b5b1644162dbf"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"7a5ea9e40a585bd306192170bdf902daeacada56","unresolved":false,"context_lines":[{"line_number":471,"context_line":"          \u0027tags\u0027: []})"},{"line_number":472,"context_line":"    LOG.debug(_(\u0027Created VDI %(vdi_ref)s (%(name_label)s,\u0027"},{"line_number":473,"context_line":"                \u0027 %(virtual_size)s, %(read_only)s) on %(sr_ref)s.\u0027),"},{"line_number":474,"context_line":"              {\u0027vdi_ref\u0027: vdi_ref, \u0027name_label\u0027: name_label,"},{"line_number":475,"context_line":"               \u0027virtual_size\u0027: virtual_size, \u0027read_only\u0027: read_only,"},{"line_number":476,"context_line":"               \u0027sr_ref\u0027: sr_ref})"},{"line_number":477,"context_line":"    return vdi_ref"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPX%2F%2FqNs%3D","line":474,"in_reply_to":"AAAAPX%2F%2FqRQ%3D","updated":"2013-06-13 09:53:12.000000000","message":"I think this one is ok from formatting perspective","commit_id":"c1201b4a5b390fb641e5b61fe62b5b1644162dbf"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"97c68839a242391900883e4a6087bbe4f5f6d503","unresolved":false,"context_lines":[{"line_number":1817,"context_line":""},{"line_number":1818,"context_line":"    parent_uuid \u003d vdi_rec[\u0027sm_config\u0027][\u0027vhd-parent\u0027]"},{"line_number":1819,"context_line":"    vdi_uuid \u003d vdi_rec[\u0027uuid\u0027]"},{"line_number":1820,"context_line":"    LOG.debug(_(\"VHD %(vdi_uuid)s has parent %(parent_uuid)s\"),"},{"line_number":1821,"context_line":"              {\u0027vdi_uuid\u0027: vdi_uuid, \u0027parent_uuid\u0027: parent_uuid})"},{"line_number":1822,"context_line":"    return parent_uuid"},{"line_number":1823,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPX%2F%2FqQw%3D","line":1820,"updated":"2013-06-13 09:25:37.000000000","message":"\" -\u003e \u0027","commit_id":"c1201b4a5b390fb641e5b61fe62b5b1644162dbf"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"7a5ea9e40a585bd306192170bdf902daeacada56","unresolved":false,"context_lines":[{"line_number":1817,"context_line":""},{"line_number":1818,"context_line":"    parent_uuid \u003d vdi_rec[\u0027sm_config\u0027][\u0027vhd-parent\u0027]"},{"line_number":1819,"context_line":"    vdi_uuid \u003d vdi_rec[\u0027uuid\u0027]"},{"line_number":1820,"context_line":"    LOG.debug(_(\"VHD %(vdi_uuid)s has parent %(parent_uuid)s\"),"},{"line_number":1821,"context_line":"              {\u0027vdi_uuid\u0027: vdi_uuid, \u0027parent_uuid\u0027: parent_uuid})"},{"line_number":1822,"context_line":"    return parent_uuid"},{"line_number":1823,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPX%2F%2FqLI%3D","line":1820,"in_reply_to":"AAAAPX%2F%2FqQw%3D","updated":"2013-06-13 09:53:12.000000000","message":"Done","commit_id":"c1201b4a5b390fb641e5b61fe62b5b1644162dbf"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"97c68839a242391900883e4a6087bbe4f5f6d503","unresolved":false,"context_lines":[{"line_number":2098,"context_line":""},{"line_number":2099,"context_line":"    LOG.debug(_(\u0027Writing partition table %(primary_first)d %(primary_last)d\u0027"},{"line_number":2100,"context_line":"                \u0027 to %(dev_path)s...\u0027),"},{"line_number":2101,"context_line":"              {\u0027primary_first\u0027: primary_first, \u0027primary_last\u0027: primary_last,"},{"line_number":2102,"context_line":"               \u0027dev_path\u0027: dev_path})"},{"line_number":2103,"context_line":""},{"line_number":2104,"context_line":"    def execute(*cmd, **kwargs):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPX%2F%2FqQU%3D","line":2101,"updated":"2013-06-13 09:25:37.000000000","message":"one param / line","commit_id":"c1201b4a5b390fb641e5b61fe62b5b1644162dbf"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"7a5ea9e40a585bd306192170bdf902daeacada56","unresolved":false,"context_lines":[{"line_number":2098,"context_line":""},{"line_number":2099,"context_line":"    LOG.debug(_(\u0027Writing partition table %(primary_first)d %(primary_last)d\u0027"},{"line_number":2100,"context_line":"                \u0027 to %(dev_path)s...\u0027),"},{"line_number":2101,"context_line":"              {\u0027primary_first\u0027: primary_first, \u0027primary_last\u0027: primary_last,"},{"line_number":2102,"context_line":"               \u0027dev_path\u0027: dev_path})"},{"line_number":2103,"context_line":""},{"line_number":2104,"context_line":"    def execute(*cmd, **kwargs):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPX%2F%2FqMs%3D","line":2101,"in_reply_to":"AAAAPX%2F%2FqQU%3D","updated":"2013-06-13 09:53:12.000000000","message":"I think it doesn\u0027t make sense here as it the line fits 80 chars","commit_id":"c1201b4a5b390fb641e5b61fe62b5b1644162dbf"}],"nova/virt/xenapi/vmops.py":[{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"1528bfddc4c587999812002c48c24348e8784f9e","unresolved":false,"context_lines":[{"line_number":873,"context_line":"            transfer_vhd_to_dest(new_vdi_ref, new_vdi_uuid)"},{"line_number":874,"context_line":"        except Exception as error:"},{"line_number":875,"context_line":"            msg \u003d _(\"_migrate_disk_resizing_down failed. \""},{"line_number":876,"context_line":"                    \"Restoring orig vm due_to: %{exception}.\")"},{"line_number":877,"context_line":"            LOG.exception(msg, instance\u003dinstance)"},{"line_number":878,"context_line":"            undo_mgr._rollback()"},{"line_number":879,"context_line":"            raise exception.InstanceFaultRollback(error)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPX%2F%2FqQE%3D","side":"PARENT","line":876,"updated":"2013-06-13 09:30:24.000000000","message":"Ok, either I don\u0027t understand how %{exception} could possibly work or this is a bug\n\nBut your version makes more sense to me either way","commit_id":"a5cd0f86530013d62b066d7e917d167e521260b0"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"7a5ea9e40a585bd306192170bdf902daeacada56","unresolved":false,"context_lines":[{"line_number":873,"context_line":"            transfer_vhd_to_dest(new_vdi_ref, new_vdi_uuid)"},{"line_number":874,"context_line":"        except Exception as error:"},{"line_number":875,"context_line":"            msg \u003d _(\"_migrate_disk_resizing_down failed. \""},{"line_number":876,"context_line":"                    \"Restoring orig vm due_to: %{exception}.\")"},{"line_number":877,"context_line":"            LOG.exception(msg, instance\u003dinstance)"},{"line_number":878,"context_line":"            undo_mgr._rollback()"},{"line_number":879,"context_line":"            raise exception.InstanceFaultRollback(error)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPX%2F%2FqLs%3D","side":"PARENT","line":876,"in_reply_to":"AAAAPX%2F%2FqQE%3D","updated":"2013-06-13 09:53:12.000000000","message":"Probably that wasn\u0027t covered by UTs","commit_id":"a5cd0f86530013d62b066d7e917d167e521260b0"}]}