)]}'
{"nova/network/neutronv2/api.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c5bd8439ab2bbca2b50ded423ee52fe0a0c19627","unresolved":false,"context_lines":[{"line_number":276,"context_line":"            port_client \u003d (neutron if not port_binding else"},{"line_number":277,"context_line":"                           get_client(context, admin\u003dTrue))"},{"line_number":278,"context_line":"        for port_id in ports:"},{"line_number":279,"context_line":"            # A port_id is optional in the NetworkRequest object so check here"},{"line_number":280,"context_line":"            # in case the caller forgot to filter the list."},{"line_number":281,"context_line":"            if port_id is None:"},{"line_number":282,"context_line":"                continue"},{"line_number":283,"context_line":"            port_req_body \u003d {\u0027port\u0027: {\u0027device_id\u0027: \u0027\u0027, \u0027device_owner\u0027: \u0027\u0027}}"},{"line_number":284,"context_line":"            if port_binding:"},{"line_number":285,"context_line":"                port_req_body[\u0027port\u0027][\u0027binding:host_id\u0027] \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_4b4fd36a","line":282,"range":{"start_line":279,"start_character":12,"end_line":282,"end_character":24},"updated":"2016-07-13 00:46:21.000000000","message":"And it\u0027s handled here....we should probably handle this better in deallocate.","commit_id":"872c165e37177a78d22aea79c2185f494f784f85"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9d6494d31e57ad02854343b7e7c6c5eae1fbd64e","unresolved":false,"context_lines":[{"line_number":810,"context_line":"        # NOTE(danms): Temporary and transitional"},{"line_number":811,"context_line":"        if isinstance(requested_networks, objects.NetworkRequestList):"},{"line_number":812,"context_line":"            requested_networks \u003d requested_networks.as_tuples()"},{"line_number":813,"context_line":"        ports_to_skip \u003d set([port_id for nets, fips, port_id, pci_request_id"},{"line_number":814,"context_line":"                             in requested_networks])"},{"line_number":815,"context_line":"        # NOTE(boden): requested_networks only passed in when deallocating"},{"line_number":816,"context_line":"        # from a failed build / spawn call. Therefore we need to include"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_0b614bd3","line":813,"range":{"start_line":813,"start_character":29,"end_line":813,"end_character":36},"updated":"2016-07-13 00:49:17.000000000","message":"We should skip None here.","commit_id":"872c165e37177a78d22aea79c2185f494f784f85"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c5bd8439ab2bbca2b50ded423ee52fe0a0c19627","unresolved":false,"context_lines":[{"line_number":819,"context_line":"        ports_to_skip |\u003d set(self._get_preexisting_port_ids(instance))"},{"line_number":820,"context_line":"        ports \u003d set(ports) - ports_to_skip"},{"line_number":821,"context_line":""},{"line_number":822,"context_line":"        if ports_to_skip:"},{"line_number":823,"context_line":"            # Reset device_id and device_owner for the ports that are skipped"},{"line_number":824,"context_line":"            LOG.debug(\u0027Unbinding ports: %s\u0027, ports_to_skip, instance\u003dinstance)"},{"line_number":825,"context_line":"            self._unbind_ports(context, ports_to_skip, neutron)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_cb3c63ca","line":822,"range":{"start_line":822,"start_character":11,"end_line":822,"end_character":24},"updated":"2016-07-13 00:46:21.000000000","message":"Hmm this can have a set with 1 None element in it:\n\nhttp://logs.openstack.org/73/328673/1/check/gate-tempest-dsvm-neutron-full/230adfc/logs/screen-n-cpu.txt.gz#_2016-06-12_14_03_59_454","commit_id":"872c165e37177a78d22aea79c2185f494f784f85"}]}
