)]}'
{"nova/compute/resource_tracker.py":[{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"d0b9e49b7d83f561a24c9304cc4a3b5f7d800fb4","unresolved":false,"context_lines":[{"line_number":774,"context_line":"                    migration)"},{"line_number":775,"context_line":"            numa_topology \u003d self._get_migration_context_resource("},{"line_number":776,"context_line":"                \u0027numa_topology\u0027, instance)"},{"line_number":777,"context_line":"            sign \u003d 1"},{"line_number":778,"context_line":""},{"line_number":779,"context_line":"        elif outbound and not record:"},{"line_number":780,"context_line":"            # instance migrated, but record usage for a possible revert:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_4c9a826f","line":777,"range":{"start_line":777,"start_character":12,"end_line":777,"end_character":20},"updated":"2016-06-13 13:11:04.000000000","message":"maybe you should also clean the sign\u003d0 in this patch\nas it seem it not going to be used, right?","commit_id":"b6005b4432b333e0ff5b541ce5cc47da993528d8"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"0a0f87aaa5b519a67c824205a450cbc306a7ac24","unresolved":false,"context_lines":[{"line_number":793,"context_line":"                    migration)"},{"line_number":794,"context_line":"            numa_topology \u003d self._get_migration_context_resource("},{"line_number":795,"context_line":"                \u0027numa_topology\u0027, instance)"},{"line_number":796,"context_line":"            sign \u003d 1"},{"line_number":797,"context_line":""},{"line_number":798,"context_line":"        elif outbound and not record:"},{"line_number":799,"context_line":"            # instance migrated, but record usage for a possible revert:"}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_b73cff93","line":796,"updated":"2016-07-12 12:07:44.000000000","message":"I\u0027d say a small comment here as you have indicated in the commit message can be useful.","commit_id":"fb2698500ae2a058b2f86ed348d6de02e7b2d3ac"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"eee3d3bc9ea6fe626dd7c1ed29e5f0b196d16966","unresolved":false,"context_lines":[{"line_number":793,"context_line":"                    migration)"},{"line_number":794,"context_line":"            numa_topology \u003d self._get_migration_context_resource("},{"line_number":795,"context_line":"                \u0027numa_topology\u0027, instance)"},{"line_number":796,"context_line":"            sign \u003d 1"},{"line_number":797,"context_line":""},{"line_number":798,"context_line":"        elif outbound and not record:"},{"line_number":799,"context_line":"            # instance migrated, but record usage for a possible revert:"}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_bd38ded5","line":796,"in_reply_to":"1aa78d24_b73cff93","updated":"2016-07-14 13:30:46.000000000","message":"Done","commit_id":"fb2698500ae2a058b2f86ed348d6de02e7b2d3ac"}],"nova/tests/unit/compute/test_resource_tracker.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"44a7f527f78df7133c095c26f0ab7d5f0f02def0","unresolved":false,"context_lines":[{"line_number":861,"context_line":"            self.context, instance, None, migration)"},{"line_number":862,"context_line":"        update_pci_for_instance.assert_called_once_with(self.context,"},{"line_number":863,"context_line":"                                                        instance,"},{"line_number":864,"context_line":"                                                        sign\u003d1)"}],"source_content_type":"text/x-python","patch_set":21,"id":"dada55a8_00f98f80","line":864,"updated":"2016-07-25 18:12:40.000000000","message":"Please add all new resource tracker test cases to test_tracker.py. test_resource_tracker.py is basically deprecated. I need to remove or move the remaining unit tests in there to test_tracker.py.","commit_id":"ddff4734237aad32fba576d55a0af6b9ae554a9c"}],"nova/tests/unit/compute/test_tracker.py":[{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"e523a7003111b3e2041aec0c7a647bfbcef787a1","unresolved":false,"context_lines":[{"line_number":1872,"context_line":"        self.assertEqual(1, len(self.rt.tracked_migrations))"},{"line_number":1873,"context_line":""},{"line_number":1874,"context_line":""},{"line_number":1875,"context_line":"class TestMoveClaimWithPci(BaseTestCase):"},{"line_number":1876,"context_line":"    def setUp(self):"},{"line_number":1877,"context_line":"        super(TestMoveClaimWithPci, self).setUp()"},{"line_number":1878,"context_line":"        self.flags(reserved_host_disk_mb\u003d0, reserved_host_memory_mb\u003d0)"}],"source_content_type":"text/x-python","patch_set":23,"id":"bacf61ea_7f0ae5d3","line":1875,"range":{"start_line":1875,"start_character":6,"end_line":1875,"end_character":27},"updated":"2016-07-28 10:50:36.000000000","message":"I don\u0027t like that this in different class and not in the move claim","commit_id":"a4c0664735923943f32ee540befafc0907f64152"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"823eae56575f33fd50bb508a9b6743f3418dd01d","unresolved":false,"context_lines":[{"line_number":1872,"context_line":"        self.assertEqual(1, len(self.rt.tracked_migrations))"},{"line_number":1873,"context_line":""},{"line_number":1874,"context_line":""},{"line_number":1875,"context_line":"class TestMoveClaimWithPci(BaseTestCase):"},{"line_number":1876,"context_line":"    def setUp(self):"},{"line_number":1877,"context_line":"        super(TestMoveClaimWithPci, self).setUp()"},{"line_number":1878,"context_line":"        self.flags(reserved_host_disk_mb\u003d0, reserved_host_memory_mb\u003d0)"}],"source_content_type":"text/x-python","patch_set":23,"id":"bacf61ea_c0ca0da1","line":1875,"range":{"start_line":1875,"start_character":6,"end_line":1875,"end_character":27},"in_reply_to":"bacf61ea_7f0ae5d3","updated":"2016-07-28 12:32:15.000000000","message":"Done","commit_id":"a4c0664735923943f32ee540befafc0907f64152"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"f3f5532fe1f138486563e6b270d9ae8f0f992619","unresolved":false,"context_lines":[{"line_number":1725,"context_line":"        ) as (update_mock, save_mock, create_mig_mock, allocate_mock):"},{"line_number":1726,"context_line":"            self.rt.resize_claim("},{"line_number":1727,"context_line":"                self.ctx, self.instance, self.flavor, None)"},{"line_number":1728,"context_line":"            allocate_mock.assert_called_once_with(self.instance)"},{"line_number":1729,"context_line":""},{"line_number":1730,"context_line":"    def test_claim_abort(self, pci_mock, inst_list_mock,"},{"line_number":1731,"context_line":"            inst_by_uuid, migr_mock, inst_save_mock):"}],"source_content_type":"text/x-python","patch_set":26,"id":"bacf61ea_9232dc5c","line":1728,"updated":"2016-08-04 14:30:20.000000000","message":"LOL, I know I asked you to write a unit test in test_tracker.py instead of test_resource_tracker.py :) But I have totally rewritten all the unit tests in TestMoveClaim because they were unreadable and hide assertions in sub-methods to the test case class too much.\n\nI\u0027m good with this though. If this merges before my patch here:\n\nhttps://review.openstack.org/#/c/349746/3/nova/tests/unit/compute/test_tracker.py\n\nI\u0027ll just rebase and refactor the above into a new unit test like I do in the above patch.","commit_id":"5129f48226cb06a77faa89dd04d290d49e76036f"}]}