)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"74353ccfb181ac186ef13b979c5c485820f75c00","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Improve help text for upgrade_levels options"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The previous commit moved the upgrade_levels options to a"},{"line_number":10,"context_line":"central location. This commit adds additional help text to"},{"line_number":11,"context_line":"those options."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"1a95cdbc_6c757ef8","line":9,"range":{"start_line":9,"start_character":1,"end_line":9,"end_character":19},"updated":"2016-10-07 16:00:28.000000000","message":"A previous change (the dependency went in a while back so it won\u0027t be linear like this suggests)","commit_id":"10455d0dc3c5584bcc68063518b5c94b526c256d"}],"nova/conf/upgrade_levels.py":[{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"1be52b5caa22b2178ee37a20654fc126e09585c1","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"Possible values:"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"Any valid OpenStack release name, in lower case, such as \u0027mitaka\u0027 or \u0027liberty\u0027."},{"line_number":104,"context_line":"Alternatively, it can be any string representing a version number in the format"},{"line_number":105,"context_line":"\u0027N.N\u0027; for example, possible values might be \u00271.12\u0027 or \u00272.0\u0027."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"* None: This is the default value."},{"line_number":108,"context_line":"* icehouse: message version 3.23"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a9d85d2_a45bab53","line":105,"range":{"start_line":103,"start_character":0,"end_line":105,"end_character":61},"updated":"2016-06-20 17:20:16.000000000","message":"Nit: with an asterisk or an indentation it would be more readable :)","commit_id":"d4d1b727a147cdccde4c599d74bedc936b0fad1f"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"38746f2b85e9776cb9236924935417f47bb820a7","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"Possible values:"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"Any valid OpenStack release name, in lower case, such as \u0027mitaka\u0027 or \u0027liberty\u0027."},{"line_number":104,"context_line":"Alternatively, it can be any string representing a version number in the format"},{"line_number":105,"context_line":"\u0027N.N\u0027; for example, possible values might be \u00271.12\u0027 or \u00272.0\u0027."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"* None: This is the default value."},{"line_number":108,"context_line":"* icehouse: message version 3.23"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_de66a328","line":105,"range":{"start_line":103,"start_character":0,"end_line":105,"end_character":61},"in_reply_to":"5a9d85d2_a45bab53","updated":"2016-06-27 16:04:31.000000000","message":"+1","commit_id":"d4d1b727a147cdccde4c599d74bedc936b0fad1f"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"1be52b5caa22b2178ee37a20654fc126e09585c1","unresolved":false,"context_lines":[{"line_number":131,"context_line":""},{"line_number":132,"context_line":"Possible values:"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"Any valid OpenStack release name, in lower case, such as \u0027mitaka\u0027 or \u0027liberty\u0027."},{"line_number":135,"context_line":"Alternatively, it can be any string representing a version number in the format"},{"line_number":136,"context_line":"\u0027N.N\u0027; for example, possible values might be \u00271.12\u0027 or \u00272.0\u0027."},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"* None: This is the default value."},{"line_number":139,"context_line":"* grizzly: message version 2.6"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a9d85d2_4431270b","line":136,"range":{"start_line":134,"start_character":0,"end_line":136,"end_character":61},"updated":"2016-06-20 17:20:16.000000000","message":"Nit: with an asterisk or an indentation it would be more readable :)","commit_id":"d4d1b727a147cdccde4c599d74bedc936b0fad1f"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"1be52b5caa22b2178ee37a20654fc126e09585c1","unresolved":false,"context_lines":[{"line_number":159,"context_line":""},{"line_number":160,"context_line":"Possible values:"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"Any valid OpenStack release name, in lower case, such as \u0027mitaka\u0027 or \u0027liberty\u0027."},{"line_number":163,"context_line":"Alternatively, it can be any string representing a version number in the format"},{"line_number":164,"context_line":"\u0027N.N\u0027; for example, possible values might be \u00271.12\u0027 or \u00272.0\u0027."},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"* None: This is the default value."},{"line_number":167,"context_line":"* grizzly: message version 1.48"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a9d85d2_843b0feb","line":164,"range":{"start_line":162,"start_character":0,"end_line":164,"end_character":61},"updated":"2016-06-20 17:20:16.000000000","message":"Nit: with an asterisk or an indentation it would be more readable :)","commit_id":"d4d1b727a147cdccde4c599d74bedc936b0fad1f"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"1be52b5caa22b2178ee37a20654fc126e09585c1","unresolved":false,"context_lines":[{"line_number":186,"context_line":""},{"line_number":187,"context_line":"Possible values:"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"Any valid OpenStack release name, in lower case, such as \u0027mitaka\u0027 or \u0027liberty\u0027."},{"line_number":190,"context_line":"Alternatively, it can be any string representing a version number in the format"},{"line_number":191,"context_line":"\u0027N.N\u0027; for example, possible values might be \u00271.12\u0027 or \u00272.0\u0027."},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"* None: This is the default value."},{"line_number":194,"context_line":"* grizzly: message version 1.1"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a9d85d2_0430bf00","line":191,"range":{"start_line":189,"start_character":0,"end_line":191,"end_character":61},"updated":"2016-06-20 17:20:16.000000000","message":"Nit: with an asterisk or an indentation it would be more readable :)","commit_id":"d4d1b727a147cdccde4c599d74bedc936b0fad1f"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"1be52b5caa22b2178ee37a20654fc126e09585c1","unresolved":false,"context_lines":[{"line_number":214,"context_line":""},{"line_number":215,"context_line":"Possible values:"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"Any valid OpenStack release name, in lower case, such as \u0027mitaka\u0027 or \u0027liberty\u0027."},{"line_number":218,"context_line":"Alternatively, it can be any string representing a version number in the format"},{"line_number":219,"context_line":"\u0027N.N\u0027; for example, possible values might be \u00271.12\u0027 or \u00272.0\u0027."},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"* None: This is the default value."},{"line_number":222,"context_line":"* grizzly: message version 1.2"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a9d85d2_e42c93ad","line":219,"range":{"start_line":217,"start_character":0,"end_line":219,"end_character":61},"updated":"2016-06-20 17:20:16.000000000","message":"Nit: with an asterisk or an indentation it would be more readable :)","commit_id":"d4d1b727a147cdccde4c599d74bedc936b0fad1f"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"1be52b5caa22b2178ee37a20654fc126e09585c1","unresolved":false,"context_lines":[{"line_number":242,"context_line":""},{"line_number":243,"context_line":"Possible values:"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"Any valid OpenStack release name, in lower case, such as \u0027mitaka\u0027 or \u0027liberty\u0027."},{"line_number":246,"context_line":"Alternatively, it can be any string representing a version number in the format"},{"line_number":247,"context_line":"\u0027N.N\u0027; for example, possible values might be \u00271.12\u0027 or \u00272.0\u0027."},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"* None: This is the default value."},{"line_number":250,"context_line":"* grizzly: message version 1.9"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a9d85d2_241dfb73","line":247,"range":{"start_line":245,"start_character":0,"end_line":247,"end_character":61},"updated":"2016-06-20 17:20:16.000000000","message":"Nit: with an asterisk or an indentation it would be more readable :)","commit_id":"d4d1b727a147cdccde4c599d74bedc936b0fad1f"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"36053f464568ba1913db16b0b4aa01c338f5ff1a","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from oslo_config import cfg"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"upgrade_group \u003d cfg.OptGroup(\u0027upgrade_levels\u0027,"},{"line_number":20,"context_line":"        title\u003d\u0027Upgrade levels Options\u0027)"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"upgrade_levels_opts \u003d ["},{"line_number":23,"context_line":"    cfg.StrOpt(\u0027cells\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"fad55976_3ff89b7c","line":20,"updated":"2016-07-15 16:37:03.000000000","message":"We probably should describe what these options are for, and how to use them. use help\u003d in here.\n\nSomething like:\n\n\"These options all define the max version of RPC call that a client is able to send to the appropriate topic/manager.\"","commit_id":"36fc2b5715c853baec252c53ec509ceef97fd828"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"522954430631cf8d6f6e1da913a3993e8de94bb2","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from oslo_config import cfg"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"upgrade_group \u003d cfg.OptGroup(\u0027upgrade_levels\u0027,"},{"line_number":20,"context_line":"        title\u003d\u0027Upgrade levels Options\u0027)"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"upgrade_levels_opts \u003d ["},{"line_number":23,"context_line":"    cfg.StrOpt(\u0027cells\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"fad55976_9149bbd3","line":20,"in_reply_to":"fad55976_3ff89b7c","updated":"2016-07-15 16:45:28.000000000","message":"This might not make sense if we only have the compute option.","commit_id":"36fc2b5715c853baec252c53ec509ceef97fd828"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"36053f464568ba1913db16b0b4aa01c338f5ff1a","unresolved":false,"context_lines":[{"line_number":35,"context_line":"* icehouse: message version 1.27."},{"line_number":36,"context_line":"* juno: message version 1.29."},{"line_number":37,"context_line":"* kilo: message version 1.34."},{"line_number":38,"context_line":"* liberty: message version 1.37."},{"line_number":39,"context_line":"\"\"\"),"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    cfg.StrOpt(\u0027intercell\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"fad55976_7ffcd33e","line":38,"updated":"2016-07-15 16:37:03.000000000","message":"I think we should probably generate this text from this variable:\nhttps://git.openstack.org/cgit/openstack/nova/tree/nova/cells/rpcapi.py#n123\n\nWhat we probably should do is move that variable here (to avoid circular import) and then generate the help string from that variable.\n\nThat should keep the code DRY.\n\nLets do this in a separate follow up patch. We should just not add any more for now.","commit_id":"36fc2b5715c853baec252c53ec509ceef97fd828"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"522954430631cf8d6f6e1da913a3993e8de94bb2","unresolved":false,"context_lines":[{"line_number":35,"context_line":"* icehouse: message version 1.27."},{"line_number":36,"context_line":"* juno: message version 1.29."},{"line_number":37,"context_line":"* kilo: message version 1.34."},{"line_number":38,"context_line":"* liberty: message version 1.37."},{"line_number":39,"context_line":"\"\"\"),"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    cfg.StrOpt(\u0027intercell\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"fad55976_d11173b1","line":38,"in_reply_to":"fad55976_7ffcd33e","updated":"2016-07-15 16:45:28.000000000","message":"If we deprecate this, I think we should just drop all these options here.","commit_id":"36fc2b5715c853baec252c53ec509ceef97fd828"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"36053f464568ba1913db16b0b4aa01c338f5ff1a","unresolved":false,"context_lines":[{"line_number":49,"context_line":"Possible values:"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"* None: This is the default value."},{"line_number":52,"context_line":"* grizzly: message version 1.0."},{"line_number":53,"context_line":"\"\"\"),"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    cfg.StrOpt(\"cert\","}],"source_content_type":"text/x-python","patch_set":3,"id":"fad55976_7f81738f","line":52,"updated":"2016-07-15 16:37:03.000000000","message":"So this looks correct, but we should fix it like line 38.","commit_id":"36fc2b5715c853baec252c53ec509ceef97fd828"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"36053f464568ba1913db16b0b4aa01c338f5ff1a","unresolved":false,"context_lines":[{"line_number":71,"context_line":"  * juno: message version 2.0"},{"line_number":72,"context_line":"  * kilo: message version 2.0"},{"line_number":73,"context_line":"  * liberty: message version 2.0"},{"line_number":74,"context_line":"  * mitaka: message version 2.0"},{"line_number":75,"context_line":"\"\"\"),"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    cfg.StrOpt(\u0027compute\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"fad55976_bf176b53","line":74,"updated":"2016-07-15 16:37:03.000000000","message":"lets not add these for now, while we fix up how to do this one.","commit_id":"36fc2b5715c853baec252c53ec509ceef97fd828"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"522954430631cf8d6f6e1da913a3993e8de94bb2","unresolved":false,"context_lines":[{"line_number":71,"context_line":"  * juno: message version 2.0"},{"line_number":72,"context_line":"  * kilo: message version 2.0"},{"line_number":73,"context_line":"  * liberty: message version 2.0"},{"line_number":74,"context_line":"  * mitaka: message version 2.0"},{"line_number":75,"context_line":"\"\"\"),"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    cfg.StrOpt(\u0027compute\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"fad55976_711d27bd","line":74,"in_reply_to":"fad55976_bf176b53","updated":"2016-07-15 16:45:28.000000000","message":"yeah, lets just drop these bits for now.","commit_id":"36fc2b5715c853baec252c53ec509ceef97fd828"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"522954430631cf8d6f6e1da913a3993e8de94bb2","unresolved":false,"context_lines":[{"line_number":74,"context_line":"  * mitaka: message version 2.0"},{"line_number":75,"context_line":"\"\"\"),"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    cfg.StrOpt(\u0027compute\u0027,"},{"line_number":78,"context_line":"        help\u003d\"\"\""},{"line_number":79,"context_line":"Set a version cap for messages sent to compute services."},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fad55976_f17117e2","line":77,"updated":"2016-07-15 16:45:28.000000000","message":"Note: lets NOT deprecate this one.","commit_id":"36fc2b5715c853baec252c53ec509ceef97fd828"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"36053f464568ba1913db16b0b4aa01c338f5ff1a","unresolved":false,"context_lines":[{"line_number":98,"context_line":"   * juno: message version 3.35"},{"line_number":99,"context_line":"   * kilo: message version 4.0"},{"line_number":100,"context_line":"   * liberty: message version 4.5"},{"line_number":101,"context_line":"   * mitaka: message version 4.11"},{"line_number":102,"context_line":"\"\"\"),"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    cfg.StrOpt(\"scheduler\","}],"source_content_type":"text/x-python","patch_set":3,"id":"fad55976_d125f3ae","line":101,"updated":"2016-07-15 16:37:03.000000000","message":"We should probably describe auto in this list, but we need to do the same as line 74 first.\n\nLets also have another follow up patch to make start using \"auto\" by default, rather than defaulting to None.","commit_id":"36fc2b5715c853baec252c53ec509ceef97fd828"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"522954430631cf8d6f6e1da913a3993e8de94bb2","unresolved":false,"context_lines":[{"line_number":98,"context_line":"   * juno: message version 3.35"},{"line_number":99,"context_line":"   * kilo: message version 4.0"},{"line_number":100,"context_line":"   * liberty: message version 4.5"},{"line_number":101,"context_line":"   * mitaka: message version 4.11"},{"line_number":102,"context_line":"\"\"\"),"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    cfg.StrOpt(\"scheduler\","}],"source_content_type":"text/x-python","patch_set":3,"id":"fad55976_b14e7f94","line":101,"in_reply_to":"fad55976_d125f3ae","updated":"2016-07-15 16:45:28.000000000","message":"So this option is staying around.\n\nSince we have auto now, we could probably just drop the whole alias thing. Lets make Mitaka the last one, and make a note we are deprecating the alias.\n\nSo we probably just need to describe the auto thing, and how you could specify a version instead.\n\nThat follow patch to move the default to \"auto\" needs to depend on this bug fix: https://review.openstack.org/#/c/339072","commit_id":"36fc2b5715c853baec252c53ec509ceef97fd828"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"36053f464568ba1913db16b0b4aa01c338f5ff1a","unresolved":false,"context_lines":[{"line_number":127,"context_line":"  * juno: message version 3.0"},{"line_number":128,"context_line":"  * kilo: message version 4.2"},{"line_number":129,"context_line":"  * liberty: message version 4.2"},{"line_number":130,"context_line":"  * mitaka: message version 4.3"},{"line_number":131,"context_line":"\"\"\"),"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    cfg.StrOpt(\u0027conductor\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"fad55976_116e6bc9","line":130,"updated":"2016-07-15 16:37:03.000000000","message":"as above.","commit_id":"36fc2b5715c853baec252c53ec509ceef97fd828"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"522954430631cf8d6f6e1da913a3993e8de94bb2","unresolved":false,"context_lines":[{"line_number":244,"context_line":""},{"line_number":245,"context_line":"def register_opts(conf):"},{"line_number":246,"context_line":"    conf.register_group(upgrade_group)"},{"line_number":247,"context_line":"    conf.register_opts(upgrade_levels_opts, group\u003dupgrade_group)"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"def list_opts():"}],"source_content_type":"text/x-python","patch_set":3,"id":"fad55976_71efe7b0","line":247,"updated":"2016-07-15 16:45:28.000000000","message":"So... I think we actually need a follow patch that deprecates all of these options, except compute. But I have a feeling I am over simplifying, so we should check with dansmith in case he has a plan for these in the future.","commit_id":"36fc2b5715c853baec252c53ec509ceef97fd828"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"c65e15a9740e4d8e48f2ef2ba12d43d958af72de","unresolved":false,"context_lines":[{"line_number":19,"context_line":"upgrade_group \u003d cfg.OptGroup(\u0027upgrade_levels\u0027,"},{"line_number":20,"context_line":"        title\u003d\u0027Upgrade levels Options\u0027,"},{"line_number":21,"context_line":"        help\u003d\"\"\""},{"line_number":22,"context_line":"Upgrade levels provide version locking on the RPC (Message Queue)"},{"line_number":23,"context_line":"communications between the various Compute services."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"These options define the max version of RPC"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_1d0ba38f","line":22,"range":{"start_line":22,"start_character":23,"end_line":22,"end_character":38},"updated":"2016-08-10 10:24:23.000000000","message":"version cap for messages, is a better way to put this I think.","commit_id":"acb1fa809c10bbd44d703f33e90e17852fda7555"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"c65e15a9740e4d8e48f2ef2ba12d43d958af72de","unresolved":false,"context_lines":[{"line_number":23,"context_line":"communications between the various Compute services."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"These options define the max version of RPC"},{"line_number":26,"context_line":"call that a client is able to send to the appropriate topic/manager."},{"line_number":27,"context_line":"\"\"\")"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"upgrade_levels_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_bdd37703","line":26,"updated":"2016-08-10 10:24:23.000000000","message":"Its tempting to say, that by default they all use the very latest RPC version.","commit_id":"acb1fa809c10bbd44d703f33e90e17852fda7555"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"c65e15a9740e4d8e48f2ef2ba12d43d958af72de","unresolved":false,"context_lines":[{"line_number":37,"context_line":"Note: Normally, you should not use this configuration. It is here only"},{"line_number":38,"context_line":"to help with possible backport issues."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Possible values:"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"* Any valid OpenStack release name, in lower case, such as \u0027mitaka\u0027 or"},{"line_number":43,"context_line":"  \u0027liberty\u0027. Alternatively, it can be any string representing a version"},{"line_number":44,"context_line":"  number in the format \u0027N.N\u0027; for example, possible values might be"},{"line_number":45,"context_line":"  \u00271.12\u0027 or \u00272.0\u0027."},{"line_number":46,"context_line":"\"\"\"),"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    cfg.StrOpt(\u0027intercell\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_ddbf4ba8","line":45,"range":{"start_line":40,"start_character":0,"end_line":45,"end_character":18},"updated":"2016-08-10 10:24:23.000000000","message":"So this is hard to maintain, and for an option we don\u0027t want folks to really use. I think we should probably drop this detail on all but the compute option.","commit_id":"acb1fa809c10bbd44d703f33e90e17852fda7555"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"c65e15a9740e4d8e48f2ef2ba12d43d958af72de","unresolved":false,"context_lines":[{"line_number":73,"context_line":"  \u00271.12\u0027 or \u00272.0\u0027."},{"line_number":74,"context_line":"\"\"\"),"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    cfg.StrOpt(\u0027compute\u0027,"},{"line_number":77,"context_line":"        help\u003d\"\"\""},{"line_number":78,"context_line":"Set a version cap for messages sent to compute services."},{"line_number":79,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_3d914748","line":76,"updated":"2016-08-10 10:24:23.000000000","message":"This reminds me, we must work on the patch to move this default to auto.","commit_id":"acb1fa809c10bbd44d703f33e90e17852fda7555"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"c65e15a9740e4d8e48f2ef2ba12d43d958af72de","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    cfg.StrOpt(\"scheduler\","},{"line_number":99,"context_line":"        help\u003d\"\"\""},{"line_number":100,"context_line":"Sets a version cap (limit) for messages sent to scheduler services. In the"},{"line_number":101,"context_line":"situation where there were multiple scheduler services running, and they were"},{"line_number":102,"context_line":"not being upgraded together, you would set this to the lowest deployed version"},{"line_number":103,"context_line":"to guarantee that other services never send messages that any of your running"},{"line_number":104,"context_line":"schedulers cannot understand."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"This is rarely needed in practice as most deployments run a single scheduler."},{"line_number":107,"context_line":"It exists mainly for design compatibility with the other services, such as"},{"line_number":108,"context_line":"compute, which are routinely upgraded in a rolling fashion."},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"Note: Normally, you should not use this configuration. It is here only"},{"line_number":111,"context_line":"to help with possible backport issues."}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_dd1bcbc8","line":108,"range":{"start_line":100,"start_character":0,"end_line":108,"end_character":59},"updated":"2016-08-10 10:24:23.000000000","message":"We should drop this detail, as we don\u0027t actually support it.","commit_id":"acb1fa809c10bbd44d703f33e90e17852fda7555"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"5f2d64a163cc56d7da48dcb48c2adf537b6d7a2e","unresolved":false,"context_lines":[{"line_number":30,"context_line":"\"\"\")"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"upgrade_levels_opts \u003d ["},{"line_number":33,"context_line":"    cfg.StrOpt(\u0027compute\u0027,"},{"line_number":34,"context_line":"        help\u003d\"\"\""},{"line_number":35,"context_line":"Compute RPC API version cap."},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9ad45d7e_ac545021","line":33,"updated":"2016-08-12 16:38:49.000000000","message":"Why not add a default\u003dauto now, or leave a TODO for that?","commit_id":"a736a4a4fc6822b6ae64d0a8cf33e1bf759c290e"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"3068e0cdd3c092cf3b8d927f42cd1c0c0aa85fce","unresolved":false,"context_lines":[{"line_number":30,"context_line":"\"\"\")"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"upgrade_levels_opts \u003d ["},{"line_number":33,"context_line":"    cfg.StrOpt(\u0027compute\u0027,"},{"line_number":34,"context_line":"        help\u003d\"\"\""},{"line_number":35,"context_line":"Compute RPC API version cap."},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9a89bdaa_6e9f6c03","line":33,"in_reply_to":"9ad45d7e_ac545021","updated":"2016-09-12 12:43:03.000000000","message":"Yea, it seems that stated default is indeed auto.","commit_id":"a736a4a4fc6822b6ae64d0a8cf33e1bf759c290e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6a206e01a7be2b2120e832d85699b14725c24936","unresolved":false,"context_lines":[{"line_number":126,"context_line":"        help\u003d\"\"\""},{"line_number":127,"context_line":"Base API RPC API version cap."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"Note: Normally, you should not use this configuration. It is here only"},{"line_number":130,"context_line":"to help with possible backport issues."},{"line_number":131,"context_line":"\"\"\")"},{"line_number":132,"context_line":"]"},{"line_number":133,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9a89bdaa_6b3f16b4","line":130,"range":{"start_line":129,"start_character":0,"end_line":130,"end_character":38},"updated":"2016-09-13 13:21:00.000000000","message":"Couldn\u0027t we move this text into the option group? :)","commit_id":"a736a4a4fc6822b6ae64d0a8cf33e1bf759c290e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"df05a91984f672a513d06e641827e4dbcbdfaae8","unresolved":false,"context_lines":[{"line_number":25,"context_line":"The compute upgrade level is an important part of rolling upgrades"},{"line_number":26,"context_line":"where old and new nova-compute services run side by side."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"The other options can largely by ignored, and are only kept to help"},{"line_number":29,"context_line":"with a possible future backport issue."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Note: All options in this group except compute are here only to"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a8bc5a2_d3cd61b8","line":28,"range":{"start_line":28,"start_character":30,"end_line":28,"end_character":32},"updated":"2016-09-26 10:13:04.000000000","message":"be","commit_id":"69ccda40a020dd7e12125fff9348111793b89291"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"df05a91984f672a513d06e641827e4dbcbdfaae8","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"The other options can largely by ignored, and are only kept to help"},{"line_number":29,"context_line":"with a possible future backport issue."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Note: All options in this group except compute are here only to"},{"line_number":32,"context_line":"help with possible backport issues. Normally, they should not be"},{"line_number":33,"context_line":"used."},{"line_number":34,"context_line":"\"\"\")"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"# TODO(sneti): Add default\u003dauto for compute"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a8bc5a2_1372697b","line":33,"range":{"start_line":30,"start_character":0,"end_line":33,"end_character":5},"updated":"2016-09-26 10:13:04.000000000","message":"You can delete this - you said as much in the previous two paragraphs.","commit_id":"69ccda40a020dd7e12125fff9348111793b89291"},{"author":{"_account_id":18337,"name":"Sujitha","email":"sujitha.neti@intel.com","username":"Sujitha"},"change_message_id":"7f7ab82053a9c933273cf1ff943164786eda2ce4","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"The other options can largely by ignored, and are only kept to help"},{"line_number":29,"context_line":"with a possible future backport issue."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Note: All options in this group except compute are here only to"},{"line_number":32,"context_line":"help with possible backport issues. Normally, they should not be"},{"line_number":33,"context_line":"used."},{"line_number":34,"context_line":"\"\"\")"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"# TODO(sneti): Add default\u003dauto for compute"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a8bc5a2_ed1896d5","line":33,"range":{"start_line":30,"start_character":0,"end_line":33,"end_character":5},"in_reply_to":"5a8bc5a2_1372697b","updated":"2016-09-26 18:24:43.000000000","message":"I think it would be nice to add the note for each option like in the previous patch. But I\u0027m not sure which one would be better.","commit_id":"69ccda40a020dd7e12125fff9348111793b89291"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"42c82169d45aa2edbbf0e529796104cec361169e","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"The other options can largely by ignored, and are only kept to help"},{"line_number":29,"context_line":"with a possible future backport issue."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Note: All options in this group except compute are here only to"},{"line_number":32,"context_line":"help with possible backport issues. Normally, they should not be"},{"line_number":33,"context_line":"used."},{"line_number":34,"context_line":"\"\"\")"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"# TODO(sneti): Add default\u003dauto for compute"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a95cdbc_815f9e0d","line":33,"range":{"start_line":30,"start_character":0,"end_line":33,"end_character":5},"in_reply_to":"5a8bc5a2_ed1896d5","updated":"2016-10-04 14:23:10.000000000","message":"hmm, I think I get stephen\u0027s point, this repeats what the main body of the text is saying, maybe just drop this text, and then we are good.","commit_id":"69ccda40a020dd7e12125fff9348111793b89291"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"df05a91984f672a513d06e641827e4dbcbdfaae8","unresolved":false,"context_lines":[{"line_number":62,"context_line":"* An OpenStack release name, in lower case, such as \u0027mitaka\u0027 or"},{"line_number":63,"context_line":"  \u0027liberty\u0027."},{"line_number":64,"context_line":"\"\"\"),"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    cfg.StrOpt(\u0027cells\u0027,"},{"line_number":67,"context_line":"        help\u003d\"\"\""},{"line_number":68,"context_line":"Cells RPC API version cap."}],"source_content_type":"text/x-python","patch_set":9,"id":"5a8bc5a2_732e4d44","line":65,"updated":"2016-09-26 10:13:04.000000000","message":"nit: can you remove these spaces between opts","commit_id":"69ccda40a020dd7e12125fff9348111793b89291"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"df05a91984f672a513d06e641827e4dbcbdfaae8","unresolved":false,"context_lines":[{"line_number":64,"context_line":"\"\"\"),"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    cfg.StrOpt(\u0027cells\u0027,"},{"line_number":67,"context_line":"        help\u003d\"\"\""},{"line_number":68,"context_line":"Cells RPC API version cap."},{"line_number":69,"context_line":"\"\"\"),"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    cfg.StrOpt(\u0027intercell\u0027,"},{"line_number":72,"context_line":"        help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":9,"id":"5a8bc5a2_b3b29504","line":69,"range":{"start_line":67,"start_character":14,"end_line":69,"end_character":3},"updated":"2016-09-26 10:13:04.000000000","message":"nit: none of these really need to be wrapped like this. I assume it\u0027s just for consistency?","commit_id":"69ccda40a020dd7e12125fff9348111793b89291"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"42c82169d45aa2edbbf0e529796104cec361169e","unresolved":false,"context_lines":[{"line_number":64,"context_line":"\"\"\"),"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    cfg.StrOpt(\u0027cells\u0027,"},{"line_number":67,"context_line":"        help\u003d\"\"\""},{"line_number":68,"context_line":"Cells RPC API version cap."},{"line_number":69,"context_line":"\"\"\"),"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    cfg.StrOpt(\u0027intercell\u0027,"},{"line_number":72,"context_line":"        help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":9,"id":"1a95cdbc_21416a3a","line":69,"range":{"start_line":67,"start_character":14,"end_line":69,"end_character":3},"in_reply_to":"5a8bc5a2_b3b29504","updated":"2016-10-04 14:23:10.000000000","message":"yeah, we could just drop the wrapping of the text here.","commit_id":"69ccda40a020dd7e12125fff9348111793b89291"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"74353ccfb181ac186ef13b979c5c485820f75c00","unresolved":false,"context_lines":[{"line_number":18,"context_line":"upgrade_group \u003d cfg.OptGroup(\u0027upgrade_levels\u0027,"},{"line_number":19,"context_line":"        title\u003d\u0027Upgrade levels Options\u0027,"},{"line_number":20,"context_line":"        help\u003d\"\"\""},{"line_number":21,"context_line":"These options are used to set a version cap for RPC messages sent"},{"line_number":22,"context_line":"between different nova services. By default all services send"},{"line_number":23,"context_line":"messages using the latest version they know about."},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"1a95cdbc_ec57ce57","line":21,"updated":"2016-10-07 16:00:28.000000000","message":"Could we get a summary line?","commit_id":"10455d0dc3c5584bcc68063518b5c94b526c256d"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"8c5378446608007aa02a1b37f8a78b8cff1b664f","unresolved":false,"context_lines":[{"line_number":31,"context_line":"help with a possible future backport issue."},{"line_number":32,"context_line":"\"\"\")"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"# TODO(sneti): Add default\u003dauto for compute"},{"line_number":35,"context_line":"upgrade_levels_opts \u003d ["},{"line_number":36,"context_line":"    cfg.StrOpt(\u0027compute\u0027,"},{"line_number":37,"context_line":"        help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":12,"id":"fa6399be_52b866c8","line":34,"updated":"2016-10-13 15:42:18.000000000","message":"That might not be possible, but +1 on adding the TODO to have a closer look at that.","commit_id":"7ab306383f4307d9252d68699f70dcf7d6ef4518"}]}