)]}'
{"doc/notification_samples/instance-shutdown-end.json":[{"author":{"_account_id":20158,"name":"Andy Hsiang","email":"yh418t@att.com","username":"yh418t"},"change_message_id":"12bf72d8d080e24c193d6d189e8fad5c89d483c3","unresolved":false,"context_lines":[{"line_number":33,"context_line":"            \"progress\":0,"},{"line_number":34,"context_line":"            \"ramdisk_id\":\"\","},{"line_number":35,"context_line":"            \"reservation_id\":\"r-npxv0e40\","},{"line_number":36,"context_line":"            \"state\":\"active\","},{"line_number":37,"context_line":"            \"task_state\":\"deleting\","},{"line_number":38,"context_line":"            \"power_state\":\"running\","},{"line_number":39,"context_line":"            \"tenant_id\":\"6f70656e737461636b20342065766572\","},{"line_number":40,"context_line":"            \"terminated_at\":null,"},{"line_number":41,"context_line":"            \"flavor\": {"}],"source_content_type":"application/json","patch_set":2,"id":"7aa08908_54e6f244","line":38,"range":{"start_line":36,"start_character":12,"end_line":38,"end_character":34},"updated":"2016-06-16 01:57:24.000000000","message":"shouldn\u0027t the states be updated?","commit_id":"a29d6c615edb19b0d27064c0545de98a9b1b0eaf"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"6193182cfbed78ea0ccd8351f1c2cd7a0d7b6715","unresolved":false,"context_lines":[{"line_number":33,"context_line":"            \"progress\":0,"},{"line_number":34,"context_line":"            \"ramdisk_id\":\"\","},{"line_number":35,"context_line":"            \"reservation_id\":\"r-npxv0e40\","},{"line_number":36,"context_line":"            \"state\":\"active\","},{"line_number":37,"context_line":"            \"task_state\":\"deleting\","},{"line_number":38,"context_line":"            \"power_state\":\"running\","},{"line_number":39,"context_line":"            \"tenant_id\":\"6f70656e737461636b20342065766572\","},{"line_number":40,"context_line":"            \"terminated_at\":null,"},{"line_number":41,"context_line":"            \"flavor\": {"}],"source_content_type":"application/json","patch_set":2,"id":"7aa08908_49200df9","line":38,"range":{"start_line":36,"start_character":12,"end_line":38,"end_character":34},"in_reply_to":"7aa08908_54e6f244","updated":"2016-06-16 09:15:44.000000000","message":"From the transformation point of view this is not a problem as we have the same state in the legacy notification. \n\nIn general it can be a next step after the transformation to check if the notification data is meaningful and file bugs to fix the contradictions.","commit_id":"a29d6c615edb19b0d27064c0545de98a9b1b0eaf"}],"doc/notification_samples/instance-shutdown-start.json":[{"author":{"_account_id":20158,"name":"Andy Hsiang","email":"yh418t@att.com","username":"yh418t"},"change_message_id":"12bf72d8d080e24c193d6d189e8fad5c89d483c3","unresolved":false,"context_lines":[{"line_number":34,"context_line":"            \"ramdisk_id\":\"\","},{"line_number":35,"context_line":"            \"reservation_id\":\"r-npxv0e40\","},{"line_number":36,"context_line":"            \"state\":\"active\","},{"line_number":37,"context_line":"            \"task_state\":\"deleting\","},{"line_number":38,"context_line":"            \"power_state\":\"running\","},{"line_number":39,"context_line":"            \"tenant_id\":\"6f70656e737461636b20342065766572\","},{"line_number":40,"context_line":"            \"terminated_at\":null,"}],"source_content_type":"application/json","patch_set":2,"id":"7aa08908_54bd5201","line":37,"range":{"start_line":37,"start_character":12,"end_line":37,"end_character":36},"updated":"2016-06-16 01:57:24.000000000","message":"is deleting correct task_state for shutdown event?","commit_id":"a29d6c615edb19b0d27064c0545de98a9b1b0eaf"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"6193182cfbed78ea0ccd8351f1c2cd7a0d7b6715","unresolved":false,"context_lines":[{"line_number":34,"context_line":"            \"ramdisk_id\":\"\","},{"line_number":35,"context_line":"            \"reservation_id\":\"r-npxv0e40\","},{"line_number":36,"context_line":"            \"state\":\"active\","},{"line_number":37,"context_line":"            \"task_state\":\"deleting\","},{"line_number":38,"context_line":"            \"power_state\":\"running\","},{"line_number":39,"context_line":"            \"tenant_id\":\"6f70656e737461636b20342065766572\","},{"line_number":40,"context_line":"            \"terminated_at\":null,"}],"source_content_type":"application/json","patch_set":2,"id":"7aa08908_2959418f","line":37,"range":{"start_line":37,"start_character":12,"end_line":37,"end_character":36},"in_reply_to":"7aa08908_54bd5201","updated":"2016-06-16 09:15:44.000000000","message":"See my answer in your other comment.","commit_id":"a29d6c615edb19b0d27064c0545de98a9b1b0eaf"}],"nova/notifications/objects/instance.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"ce7cfafafa3b73c327aa50001c96018c7cb1a561","unresolved":false,"context_lines":[{"line_number":149,"context_line":"        self.populate_schema(instance\u003dinstance)"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"@base.notification_sample(\u0027instance-shutdown-start.json\u0027)"},{"line_number":153,"context_line":"@base.notification_sample(\u0027instance-shutdown-end.json\u0027)"},{"line_number":154,"context_line":"@base.notification_sample(\u0027instance-delete-start.json\u0027)"},{"line_number":155,"context_line":"@base.notification_sample(\u0027instance-delete-end.json\u0027)"},{"line_number":156,"context_line":"# @base.notification_sample(\u0027instance-pause-start.json\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7aa08908_1226decd","line":153,"range":{"start_line":152,"start_character":0,"end_line":153,"end_character":55},"updated":"2016-06-17 14:51:13.000000000","message":"just un-comment the lines in there original places. This will help to avoid merge conflict with others.","commit_id":"7d6554aca0e89cc51b04beb412239351315afaa6"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"c5c2c717a367a45081d7417160ed1740907e835c","unresolved":false,"context_lines":[{"line_number":149,"context_line":"        self.populate_schema(instance\u003dinstance)"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"@base.notification_sample(\u0027instance-shutdown-start.json\u0027)"},{"line_number":153,"context_line":"@base.notification_sample(\u0027instance-shutdown-end.json\u0027)"},{"line_number":154,"context_line":"@base.notification_sample(\u0027instance-delete-start.json\u0027)"},{"line_number":155,"context_line":"@base.notification_sample(\u0027instance-delete-end.json\u0027)"},{"line_number":156,"context_line":"# @base.notification_sample(\u0027instance-pause-start.json\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_53627dae","line":153,"range":{"start_line":152,"start_character":0,"end_line":153,"end_character":55},"in_reply_to":"7aa08908_1226decd","updated":"2016-06-28 11:14:15.000000000","message":"+1","commit_id":"7d6554aca0e89cc51b04beb412239351315afaa6"}],"nova/tests/functional/notification_sample_tests/test_instance.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"1b013655d197b0577b5e84a69b492defc6b299e5","unresolved":false,"context_lines":[{"line_number":128,"context_line":"                \u0027uuid\u0027: server[\u0027id\u0027]},"},{"line_number":129,"context_line":"            actual\u003dfake_notifier.VERSIONED_NOTIFICATIONS[0])"},{"line_number":130,"context_line":"        self._verify_notification("},{"line_number":131,"context_line":"            \u0027instance-shutdown-start\u0027,"},{"line_number":132,"context_line":"            replacements\u003d{"},{"line_number":133,"context_line":"                \u0027reservation_id\u0027:"},{"line_number":134,"context_line":"                    notification_sample_base.NotificationSampleTestBase.ANY,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_ae57fac8","line":131,"updated":"2016-06-28 11:26:46.000000000","message":"hmm, I thought this one would have had notify turned off...","commit_id":"7d6554aca0e89cc51b04beb412239351315afaa6"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"c5c2c717a367a45081d7417160ed1740907e835c","unresolved":false,"context_lines":[{"line_number":141,"context_line":"                    notification_sample_base.NotificationSampleTestBase.ANY,"},{"line_number":142,"context_line":"                \u0027uuid\u0027: server[\u0027id\u0027]},"},{"line_number":143,"context_line":"            actual\u003dfake_notifier.VERSIONED_NOTIFICATIONS[2])"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        self._verify_notification("},{"line_number":146,"context_line":"            \u0027instance-delete-end\u0027,"},{"line_number":147,"context_line":"            replacements\u003d{"}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_1300f5a9","line":144,"updated":"2016-06-28 11:14:15.000000000","message":"Nit: why the extra gap here?","commit_id":"7d6554aca0e89cc51b04beb412239351315afaa6"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"10371a9601ff96ade1bce8f2a25f5093103128bd","unresolved":false,"context_lines":[{"line_number":73,"context_line":"            \u0027instance-shutdown-end\u0027,"},{"line_number":74,"context_line":"            replacements\u003d{"},{"line_number":75,"context_line":"                \u0027reservation_id\u0027:"},{"line_number":76,"context_line":"                    notification_sample_base.NotificationSampleTestBase.ANY,"},{"line_number":77,"context_line":"                \u0027uuid\u0027: server[\u0027id\u0027]},"},{"line_number":78,"context_line":"            actual\u003dfake_notifier.VERSIONED_NOTIFICATIONS[2])"},{"line_number":79,"context_line":"        self._verify_notification("}],"source_content_type":"text/x-python","patch_set":7,"id":"fa6399be_485f5d72","line":76,"range":{"start_line":76,"start_character":20,"end_line":76,"end_character":75},"updated":"2016-10-11 05:58:14.000000000","message":"It should be \"server[\u0027reservation_id\u0027]\".","commit_id":"c90b1c3d06989db68ba09b6f32602146b5c77de3"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"10371a9601ff96ade1bce8f2a25f5093103128bd","unresolved":false,"context_lines":[{"line_number":80,"context_line":"            \u0027instance-delete-end\u0027,"},{"line_number":81,"context_line":"            replacements\u003d{"},{"line_number":82,"context_line":"                \u0027reservation_id\u0027:"},{"line_number":83,"context_line":"                    notification_sample_base.NotificationSampleTestBase.ANY,"},{"line_number":84,"context_line":"                \u0027uuid\u0027: server[\u0027id\u0027]},"},{"line_number":85,"context_line":"            actual\u003dfake_notifier.VERSIONED_NOTIFICATIONS[3])"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"fa6399be_68542154","line":83,"range":{"start_line":83,"start_character":20,"end_line":83,"end_character":75},"updated":"2016-10-11 05:58:14.000000000","message":"ditto","commit_id":"c90b1c3d06989db68ba09b6f32602146b5c77de3"}],"nova/tests/unit/compute/test_compute_mgr.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c587b97d54738a414b4c85b2fd175b03bcfbd3f1","unresolved":false,"context_lines":[{"line_number":1159,"context_line":"    @mock.patch(\u0027nova.compute.utils.notify_about_instance_action\u0027)"},{"line_number":1160,"context_line":"    @mock.patch("},{"line_number":1161,"context_line":"        \u0027nova.compute.manager.ComputeManager._notify_about_instance_usage\u0027)"},{"line_number":1162,"context_line":"    def test_shutdown_instance(self, mock_notify_unversioned, mock_notify,"},{"line_number":1163,"context_line":"            mock_connector, mock_destroy, mock_blk_device_info, mock_nw_info,"},{"line_number":1164,"context_line":"            mock_elevated):"},{"line_number":1165,"context_line":"        mock_elevated.return_value \u003d self.context"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba5da102_0365f1df","line":1162,"range":{"start_line":1162,"start_character":8,"end_line":1162,"end_character":30},"updated":"2016-10-31 15:41:25.000000000","message":"A better name for this test would be something like \u0027test_shutdown_instance_versioned_notifications\u0027 since this test isn\u0027t testing anything but that.\n\nIn fact, this would have probably been a better test to modify:\n\nhttps://github.com/openstack/nova/blob/03f8f5a08418080162a3d2f90658a597606e7c45/nova/tests/unit/compute/test_compute.py#L3998","commit_id":"002b18690eeeaca4a4a41cbce3ff39ef6ff6707e"}]}