)]}'
{"nova/api/openstack/compute/server_tags.py":[{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"3e1b67f4a640a8179a30b77d45f04c8562f964ca","unresolved":false,"context_lines":[{"line_number":179,"context_line":"    def delete(self, req, server_id, id):"},{"line_number":180,"context_line":"        context \u003d req.environ[\"nova.context\"]"},{"line_number":181,"context_line":"        authorize(context, action\u003d\u0027delete\u0027)"},{"line_number":182,"context_line":"        self._check_instance_in_valid_state(context, server_id, \u0027delete tag\u0027)"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"        try:"},{"line_number":185,"context_line":"            objects.Tag.destroy(context, server_id, id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_6a3c5793","line":182,"range":{"start_line":182,"start_character":8,"end_line":182,"end_character":77},"updated":"2016-06-14 08:42:19.000000000","message":"what is the reason of verifying instance state while deleting tags?","commit_id":"a0aa1cacf1e59f67b99206ad4ad3f435b30bf5ff"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"3c2a577f9d126b36da570f901caddaebe229a8b4","unresolved":false,"context_lines":[{"line_number":179,"context_line":"    def delete(self, req, server_id, id):"},{"line_number":180,"context_line":"        context \u003d req.environ[\"nova.context\"]"},{"line_number":181,"context_line":"        authorize(context, action\u003d\u0027delete\u0027)"},{"line_number":182,"context_line":"        self._check_instance_in_valid_state(context, server_id, \u0027delete tag\u0027)"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"        try:"},{"line_number":185,"context_line":"            objects.Tag.destroy(context, server_id, id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_c6ab9b73","line":182,"range":{"start_line":182,"start_character":8,"end_line":182,"end_character":77},"in_reply_to":"7aa08908_3a8445d1","updated":"2016-06-14 20:34:46.000000000","message":"I think it\u0027s worth having the check for delete. If the instance is not found or in a valid state it\u0027s possible that the tag delete would fail. It\u0027s maybe not super important now but if we get to a point where tags can be specified at boot time we\u0027ll need to be sure of the instance state before allowing a delete.","commit_id":"a0aa1cacf1e59f67b99206ad4ad3f435b30bf5ff"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"47a376b369ab39190e4dbe6d7cc72eb804821db9","unresolved":false,"context_lines":[{"line_number":179,"context_line":"    def delete(self, req, server_id, id):"},{"line_number":180,"context_line":"        context \u003d req.environ[\"nova.context\"]"},{"line_number":181,"context_line":"        authorize(context, action\u003d\u0027delete\u0027)"},{"line_number":182,"context_line":"        self._check_instance_in_valid_state(context, server_id, \u0027delete tag\u0027)"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"        try:"},{"line_number":185,"context_line":"            objects.Tag.destroy(context, server_id, id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_3a8445d1","line":182,"range":{"start_line":182,"start_character":8,"end_line":182,"end_character":77},"in_reply_to":"7aa08908_6a3c5793","updated":"2016-06-14 15:51:19.000000000","message":"I made it symmetric with the update/delete instance metadata API, thinking they were similar. If there isn\u0027t a reason to disallow delete tag in various states, I can change it","commit_id":"a0aa1cacf1e59f67b99206ad4ad3f435b30bf5ff"}]}