)]}'
{"nova/conf/compute.py":[{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"a7b2e262dc092b4453d432ec0d2ff14165dc30ab","unresolved":false,"context_lines":[{"line_number":49,"context_line":"Possible values:"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    * Any string representing an availability zone name"},{"line_number":52,"context_line":"    * Default value is None."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Related options:"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a9d85d2_45f3ee73","line":52,"range":{"start_line":52,"start_character":6,"end_line":52,"end_character":28},"updated":"2016-06-20 14:33:03.000000000","message":"If so we should have a default param set to None.","commit_id":"b2931ca9a0b1b9f0c833cb3d6e4552ef7a88f17d"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"6dfac75e7118d8a3a9b933060ade9bfd35b07a1e","unresolved":false,"context_lines":[{"line_number":49,"context_line":"Possible values:"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    * Any string representing an availability zone name"},{"line_number":52,"context_line":"    * Default value is None."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Related options:"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a9d85d2_4bd81d54","line":52,"range":{"start_line":52,"start_character":6,"end_line":52,"end_character":28},"in_reply_to":"5a9d85d2_45f3ee73","updated":"2016-06-20 15:16:17.000000000","message":"https://review.openstack.org/#/c/243007/\nMaciej, according to this patch, it is not required to add default\u003dNone. So I didn\u0027t add.","commit_id":"b2931ca9a0b1b9f0c833cb3d6e4552ef7a88f17d"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"a7b2e262dc092b4453d432ec0d2ff14165dc30ab","unresolved":false,"context_lines":[{"line_number":123,"context_line":"converted to volumes and boot instances from volumes - it just means that all"},{"line_number":124,"context_line":"requests that attempt to create a local disk will fail."},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"Possible values:"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    * 0: Creating a local disk is not allowed."},{"line_number":129,"context_line":"    * Negative number: Allows unlimited number of local discs."}],"source_content_type":"text/x-python","patch_set":3,"id":"5a9d85d2_e55e5a44","line":126,"range":{"start_line":126,"start_character":0,"end_line":126,"end_character":15},"updated":"2016-06-20 14:33:03.000000000","message":"Add note on default value","commit_id":"b2931ca9a0b1b9f0c833cb3d6e4552ef7a88f17d"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"6dfac75e7118d8a3a9b933060ade9bfd35b07a1e","unresolved":false,"context_lines":[{"line_number":123,"context_line":"converted to volumes and boot instances from volumes - it just means that all"},{"line_number":124,"context_line":"requests that attempt to create a local disk will fail."},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"Possible values:"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    * 0: Creating a local disk is not allowed."},{"line_number":129,"context_line":"    * Negative number: Allows unlimited number of local discs."}],"source_content_type":"text/x-python","patch_set":3,"id":"5a9d85d2_ab442174","line":126,"range":{"start_line":126,"start_character":0,"end_line":126,"end_character":15},"in_reply_to":"5a9d85d2_e55e5a44","updated":"2016-06-20 15:16:17.000000000","message":"Done","commit_id":"b2931ca9a0b1b9f0c833cb3d6e4552ef7a88f17d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"aa50d6756fe30b554ed98373d09885dc9ab6e49b","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    cfg.StrOpt(\u0027default_schedule_zone\u0027,"},{"line_number":34,"context_line":"               help\u003d\"\"\""},{"line_number":35,"context_line":"Availability zone to use when user doesn\u0027t specify one."},{"line_number":36,"context_line":"This option is used by the scheduler to determine which availability zone"},{"line_number":37,"context_line":"to place a new VM instance into if the user did not specify one at the time"},{"line_number":38,"context_line":"of VM boot request."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Possible values:"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_a48e4476","line":38,"range":{"start_line":36,"start_character":0,"end_line":38,"end_character":19},"updated":"2016-07-01 10:18:54.000000000","message":"nit: if you place a newline a line 36, will it appear in nova.conf? If so, can you do this (breaks this into summary and description)","commit_id":"3a46277636ea384b2f3da6991186e9ff4704c0a9"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"98ac6c61ac5419e2f01349354d7eb70c70403db5","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    cfg.StrOpt(\u0027default_schedule_zone\u0027,"},{"line_number":34,"context_line":"               help\u003d\"\"\""},{"line_number":35,"context_line":"Availability zone to use when user doesn\u0027t specify one."},{"line_number":36,"context_line":"This option is used by the scheduler to determine which availability zone"},{"line_number":37,"context_line":"to place a new VM instance into if the user did not specify one at the time"},{"line_number":38,"context_line":"of VM boot request."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Possible values:"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_dba763a5","line":38,"range":{"start_line":36,"start_character":0,"end_line":38,"end_character":19},"in_reply_to":"3aaa91ec_a48e4476","updated":"2016-07-11 17:30:18.000000000","message":"Done","commit_id":"3a46277636ea384b2f3da6991186e9ff4704c0a9"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"aa50d6756fe30b554ed98373d09885dc9ab6e49b","unresolved":false,"context_lines":[{"line_number":40,"context_line":"Possible values:"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    * Any string representing an availability zone name"},{"line_number":43,"context_line":"    * Default value is None."},{"line_number":44,"context_line":"\"\"\"),"},{"line_number":45,"context_line":"    cfg.ListOpt(\u0027non_inheritable_image_properties\u0027,"},{"line_number":46,"context_line":"                default\u003d[\u0027cache_in_nova\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_84898871","line":43,"range":{"start_line":43,"start_character":0,"end_line":43,"end_character":28},"updated":"2016-07-01 10:18:54.000000000","message":"Reword this to remove reference to defaults. Maybe:\n\n    * None: Don\u0027t use a default availability zone","commit_id":"3a46277636ea384b2f3da6991186e9ff4704c0a9"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"aa50d6756fe30b554ed98373d09885dc9ab6e49b","unresolved":false,"context_lines":[{"line_number":46,"context_line":"                default\u003d[\u0027cache_in_nova\u0027,"},{"line_number":47,"context_line":"                         \u0027bittorrent\u0027],"},{"line_number":48,"context_line":"                help\u003d\"\"\""},{"line_number":49,"context_line":"These are the image properties that should not be inherited from the instance"},{"line_number":50,"context_line":"when taking a snapshot. This option gives an opportunity to select which"},{"line_number":51,"context_line":"image-properties should not be inherited by newly created snapshots."},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_4448402d","line":49,"range":{"start_line":49,"start_character":0,"end_line":49,"end_character":14},"updated":"2016-07-01 10:18:54.000000000","message":"Drop this","commit_id":"3a46277636ea384b2f3da6991186e9ff4704c0a9"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"98ac6c61ac5419e2f01349354d7eb70c70403db5","unresolved":false,"context_lines":[{"line_number":46,"context_line":"                default\u003d[\u0027cache_in_nova\u0027,"},{"line_number":47,"context_line":"                         \u0027bittorrent\u0027],"},{"line_number":48,"context_line":"                help\u003d\"\"\""},{"line_number":49,"context_line":"These are the image properties that should not be inherited from the instance"},{"line_number":50,"context_line":"when taking a snapshot. This option gives an opportunity to select which"},{"line_number":51,"context_line":"image-properties should not be inherited by newly created snapshots."},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_5b37f34c","line":49,"range":{"start_line":49,"start_character":0,"end_line":49,"end_character":14},"in_reply_to":"3aaa91ec_4448402d","updated":"2016-07-11 17:30:18.000000000","message":"Done","commit_id":"3a46277636ea384b2f3da6991186e9ff4704c0a9"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"aa50d6756fe30b554ed98373d09885dc9ab6e49b","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                         \u0027bittorrent\u0027],"},{"line_number":48,"context_line":"                help\u003d\"\"\""},{"line_number":49,"context_line":"These are the image properties that should not be inherited from the instance"},{"line_number":50,"context_line":"when taking a snapshot. This option gives an opportunity to select which"},{"line_number":51,"context_line":"image-properties should not be inherited by newly created snapshots."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_2456d4cd","line":50,"updated":"2016-07-01 10:18:54.000000000","message":"new line after first sentence","commit_id":"3a46277636ea384b2f3da6991186e9ff4704c0a9"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"98ac6c61ac5419e2f01349354d7eb70c70403db5","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                         \u0027bittorrent\u0027],"},{"line_number":48,"context_line":"                help\u003d\"\"\""},{"line_number":49,"context_line":"These are the image properties that should not be inherited from the instance"},{"line_number":50,"context_line":"when taking a snapshot. This option gives an opportunity to select which"},{"line_number":51,"context_line":"image-properties should not be inherited by newly created snapshots."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_db43e3ad","line":50,"in_reply_to":"3aaa91ec_2456d4cd","updated":"2016-07-11 17:30:18.000000000","message":"Done","commit_id":"3a46277636ea384b2f3da6991186e9ff4704c0a9"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"aa50d6756fe30b554ed98373d09885dc9ab6e49b","unresolved":false,"context_lines":[{"line_number":56,"context_line":"      properties that are only needed by base images can be included here,"},{"line_number":57,"context_line":"      since the snapshots that are created from the base images doesn\u0027t"},{"line_number":58,"context_line":"      need them."},{"line_number":59,"context_line":"    * Default list: [\u0027cache_in_nova\u0027, \u0027bittorrent\u0027]"},{"line_number":60,"context_line":"\"\"\"),"},{"line_number":61,"context_line":"    cfg.StrOpt(\u0027null_kernel\u0027,"},{"line_number":62,"context_line":"               default\u003d\u0027nokernel\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_c409d0de","line":59,"range":{"start_line":59,"start_character":0,"end_line":59,"end_character":51},"updated":"2016-07-01 10:18:54.000000000","message":"drop this","commit_id":"3a46277636ea384b2f3da6991186e9ff4704c0a9"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"aa50d6756fe30b554ed98373d09885dc9ab6e49b","unresolved":false,"context_lines":[{"line_number":67,"context_line":"Possible values:"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    * Any kernel image other than \u0027nokernel\u0027 will disable this option."},{"line_number":70,"context_line":"    * Default is \u0027nokernel\u0027."},{"line_number":71,"context_line":"\"\"\"),"},{"line_number":72,"context_line":"    cfg.StrOpt(\u0027multi_instance_display_name_template\u0027,"},{"line_number":73,"context_line":"               default\u003d\u0027%(name)s-%(count)d\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_64fbbcc1","line":70,"range":{"start_line":70,"start_character":0,"end_line":70,"end_character":28},"updated":"2016-07-01 10:18:54.000000000","message":"drop this","commit_id":"3a46277636ea384b2f3da6991186e9ff4704c0a9"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"aa50d6756fe30b554ed98373d09885dc9ab6e49b","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    cfg.IntOpt(\u0027max_local_block_devices\u0027,"},{"line_number":90,"context_line":"               default\u003d3,"},{"line_number":91,"context_line":"               help\u003d\"\"\""},{"line_number":92,"context_line":"Maximum number of devices that will result in a local image being created"},{"line_number":93,"context_line":"on the hypervisor node. A negative number means unlimited. Setting"},{"line_number":94,"context_line":"max_local_block_devices to 0 means that any request that attempts to create"},{"line_number":95,"context_line":"a local disk will fail. This option is meant to limit the number of local discs"},{"line_number":96,"context_line":"(so root local disc that is the result of --image being used, and any other"}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_e4d4cc20","line":93,"range":{"start_line":92,"start_character":0,"end_line":93,"end_character":24},"updated":"2016-07-01 10:18:54.000000000","message":"Two newlines after this sentence (summary - break - detail, a lá git commit messages)","commit_id":"3a46277636ea384b2f3da6991186e9ff4704c0a9"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"98ac6c61ac5419e2f01349354d7eb70c70403db5","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    cfg.IntOpt(\u0027max_local_block_devices\u0027,"},{"line_number":90,"context_line":"               default\u003d3,"},{"line_number":91,"context_line":"               help\u003d\"\"\""},{"line_number":92,"context_line":"Maximum number of devices that will result in a local image being created"},{"line_number":93,"context_line":"on the hypervisor node. A negative number means unlimited. Setting"},{"line_number":94,"context_line":"max_local_block_devices to 0 means that any request that attempts to create"},{"line_number":95,"context_line":"a local disk will fail. This option is meant to limit the number of local discs"},{"line_number":96,"context_line":"(so root local disc that is the result of --image being used, and any other"}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_9b6b1b1e","line":93,"range":{"start_line":92,"start_character":0,"end_line":93,"end_character":24},"in_reply_to":"3aaa91ec_e4d4cc20","updated":"2016-07-11 17:30:18.000000000","message":"Done","commit_id":"3a46277636ea384b2f3da6991186e9ff4704c0a9"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"aa50d6756fe30b554ed98373d09885dc9ab6e49b","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    * 0: Creating a local disk is not allowed."},{"line_number":104,"context_line":"    * Negative number: Allows unlimited number of local discs."},{"line_number":105,"context_line":"    * Positive number: Allows only these many number of local discs."},{"line_number":106,"context_line":"                       (Default value is 3)."},{"line_number":107,"context_line":"\"\"\"),"},{"line_number":108,"context_line":"    cfg.MultiStrOpt(\u0027compute_available_monitors\u0027,"},{"line_number":109,"context_line":"                    deprecated_for_removal\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_24db7450","line":106,"range":{"start_line":106,"start_character":0,"end_line":106,"end_character":44},"updated":"2016-07-01 10:18:54.000000000","message":"drop this","commit_id":"3a46277636ea384b2f3da6991186e9ff4704c0a9"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"aa50d6756fe30b554ed98373d09885dc9ab6e49b","unresolved":false,"context_lines":[{"line_number":125,"context_line":""},{"line_number":126,"context_line":"Possible values:"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    * Empty list (Defualt)."},{"line_number":129,"context_line":"    * An example value that would enable both the CPU and NUMA memory"},{"line_number":130,"context_line":"      bandwidth monitors that used the virt driver variant:"},{"line_number":131,"context_line":"      [\"cpu.virt_driver\", \"numa_mem_bw.virt_driver\"]"}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_a4c64465","line":128,"range":{"start_line":128,"start_character":0,"end_line":128,"end_character":27},"updated":"2016-07-01 10:18:54.000000000","message":"Remove reference to default value (already specified on line 119), and instead say what the empty list corresponds to: does it disable the feature?","commit_id":"3a46277636ea384b2f3da6991186e9ff4704c0a9"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"5b3179f40d8ba9602effc34330beab4b249f9290","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    cfg.StrOpt(\u0027null_kernel\u0027,"},{"line_number":65,"context_line":"               default\u003d\u0027nokernel\u0027,"},{"line_number":66,"context_line":"               help\u003d\"\"\""},{"line_number":67,"context_line":"Kernel image that indicates not to use a kernel, but to use a raw disk"},{"line_number":68,"context_line":"image instead. \u0027nokernel\u0027 signals Nova to use a raw image."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"Possible values:"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    * Any kernel image other than \u0027nokernel\u0027 will disable this option."},{"line_number":73,"context_line":"    * Default is \u0027nokernel\u0027."},{"line_number":74,"context_line":"\"\"\"),"},{"line_number":75,"context_line":"    cfg.StrOpt(\u0027multi_instance_display_name_template\u0027,"},{"line_number":76,"context_line":"               default\u003d\u0027%(name)s-%(count)d\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"9ad45d7e_5eab91d6","line":73,"range":{"start_line":67,"start_character":0,"end_line":73,"end_character":28},"updated":"2016-08-09 11:26:38.000000000","message":"So this is all very confusing, I went digging in the code here:\nhttps://github.com/openstack/nova/blob/f0a841369a0bfe3b7c08e187feacb30c9b2b8f8b/nova/compute/api.py#L461\n\nTurns out, what this means is quite odd.... here is a go:\n\nThis flag is used to decide when an image has no external ramdisk or kernel. By default this is set to \u0027nokernel\u0027, so when an image is booted with the property \u0027kernel_id\u0027 with the value \u0027nokernel\u0027, Nova assumes the image doesn\u0027t require an external kernel and ramdisk.\n\nWe should also add a TODO to deprecate this option, its nuts.","commit_id":"81c931934855e39002071cd26687dc46683663e6"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"cdfeb1b0291c5f6aa4a1a8c9ba33878b159fb562","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    cfg.StrOpt(\u0027null_kernel\u0027,"},{"line_number":65,"context_line":"               default\u003d\u0027nokernel\u0027,"},{"line_number":66,"context_line":"               help\u003d\"\"\""},{"line_number":67,"context_line":"Kernel image that indicates not to use a kernel, but to use a raw disk"},{"line_number":68,"context_line":"image instead. \u0027nokernel\u0027 signals Nova to use a raw image."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"Possible values:"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    * Any kernel image other than \u0027nokernel\u0027 will disable this option."},{"line_number":73,"context_line":"    * Default is \u0027nokernel\u0027."},{"line_number":74,"context_line":"\"\"\"),"},{"line_number":75,"context_line":"    cfg.StrOpt(\u0027multi_instance_display_name_template\u0027,"},{"line_number":76,"context_line":"               default\u003d\u0027%(name)s-%(count)d\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"9ad45d7e_3e696626","line":73,"range":{"start_line":67,"start_character":0,"end_line":73,"end_character":28},"in_reply_to":"9ad45d7e_5eab91d6","updated":"2016-08-09 18:00:03.000000000","message":"I really got confused with this option help text and the code where it is being used, so couldn\u0027t write good help text. Waiting on reviews.\nNow this makes sense.\nI\u0027ll add a TODO in this patch and deprecate this option in the follow up patch.","commit_id":"81c931934855e39002071cd26687dc46683663e6"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"5b3179f40d8ba9602effc34330beab4b249f9290","unresolved":false,"context_lines":[{"line_number":78,"context_line":"When creating multiple instances with a single request using the"},{"line_number":79,"context_line":"os-multiple-create API extension, this template will be used to build"},{"line_number":80,"context_line":"the display name for each instance. The benefit is that the instances"},{"line_number":81,"context_line":"end up with different hostnames. To restore legacy behavior of every"},{"line_number":82,"context_line":"instance having the same name, set this option to \"%(name)s\"."},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"Possible values:"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9ad45d7e_fed08555","line":82,"range":{"start_line":81,"start_character":33,"end_line":82,"end_character":61},"updated":"2016-08-09 11:26:38.000000000","message":"I think we could drop this bit. Its a bit confusing now.","commit_id":"81c931934855e39002071cd26687dc46683663e6"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"cdfeb1b0291c5f6aa4a1a8c9ba33878b159fb562","unresolved":false,"context_lines":[{"line_number":78,"context_line":"When creating multiple instances with a single request using the"},{"line_number":79,"context_line":"os-multiple-create API extension, this template will be used to build"},{"line_number":80,"context_line":"the display name for each instance. The benefit is that the instances"},{"line_number":81,"context_line":"end up with different hostnames. To restore legacy behavior of every"},{"line_number":82,"context_line":"instance having the same name, set this option to \"%(name)s\"."},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"Possible values:"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9ad45d7e_9efdf23c","line":82,"range":{"start_line":81,"start_character":33,"end_line":82,"end_character":61},"in_reply_to":"9ad45d7e_fed08555","updated":"2016-08-09 18:00:03.000000000","message":"Done","commit_id":"81c931934855e39002071cd26687dc46683663e6"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"5b3179f40d8ba9602effc34330beab4b249f9290","unresolved":false,"context_lines":[{"line_number":84,"context_line":"Possible values:"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    * Valid keys for the template are: name, uuid, count."},{"line_number":87,"context_line":"      Example display name when creating two VM\u0027s (Default using name key):"},{"line_number":88,"context_line":"      name-1, name-2."},{"line_number":89,"context_line":"      Example display name when creating two VM\u0027s (with uuid key):"},{"line_number":90,"context_line":"      uuid-1, uuid-2."},{"line_number":91,"context_line":"\"\"\"),"}],"source_content_type":"text/x-python","patch_set":6,"id":"9ad45d7e_7ede556e","line":88,"range":{"start_line":87,"start_character":6,"end_line":88,"end_character":21},"updated":"2016-08-09 11:26:38.000000000","message":"Nit: this is great, but I would add this in the main text above, at ln83.","commit_id":"81c931934855e39002071cd26687dc46683663e6"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"cdfeb1b0291c5f6aa4a1a8c9ba33878b159fb562","unresolved":false,"context_lines":[{"line_number":84,"context_line":"Possible values:"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    * Valid keys for the template are: name, uuid, count."},{"line_number":87,"context_line":"      Example display name when creating two VM\u0027s (Default using name key):"},{"line_number":88,"context_line":"      name-1, name-2."},{"line_number":89,"context_line":"      Example display name when creating two VM\u0027s (with uuid key):"},{"line_number":90,"context_line":"      uuid-1, uuid-2."},{"line_number":91,"context_line":"\"\"\"),"}],"source_content_type":"text/x-python","patch_set":6,"id":"9ad45d7e_3e85e6ac","line":88,"range":{"start_line":87,"start_character":6,"end_line":88,"end_character":21},"in_reply_to":"9ad45d7e_7ede556e","updated":"2016-08-09 18:00:03.000000000","message":"Done","commit_id":"81c931934855e39002071cd26687dc46683663e6"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"5b3179f40d8ba9602effc34330beab4b249f9290","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    * Valid keys for the template are: name, uuid, count."},{"line_number":87,"context_line":"      Example display name when creating two VM\u0027s (Default using name key):"},{"line_number":88,"context_line":"      name-1, name-2."},{"line_number":89,"context_line":"      Example display name when creating two VM\u0027s (with uuid key):"},{"line_number":90,"context_line":"      uuid-1, uuid-2."},{"line_number":91,"context_line":"\"\"\"),"},{"line_number":92,"context_line":"    cfg.IntOpt(\u0027max_local_block_devices\u0027,"},{"line_number":93,"context_line":"               default\u003d3,"}],"source_content_type":"text/x-python","patch_set":6,"id":"9ad45d7e_fee9a51b","line":90,"range":{"start_line":89,"start_character":0,"end_line":90,"end_character":21},"updated":"2016-08-09 11:26:38.000000000","message":"can we drop this bit please? I find it confusing.","commit_id":"81c931934855e39002071cd26687dc46683663e6"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"cdfeb1b0291c5f6aa4a1a8c9ba33878b159fb562","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    * Valid keys for the template are: name, uuid, count."},{"line_number":87,"context_line":"      Example display name when creating two VM\u0027s (Default using name key):"},{"line_number":88,"context_line":"      name-1, name-2."},{"line_number":89,"context_line":"      Example display name when creating two VM\u0027s (with uuid key):"},{"line_number":90,"context_line":"      uuid-1, uuid-2."},{"line_number":91,"context_line":"\"\"\"),"},{"line_number":92,"context_line":"    cfg.IntOpt(\u0027max_local_block_devices\u0027,"},{"line_number":93,"context_line":"               default\u003d3,"}],"source_content_type":"text/x-python","patch_set":6,"id":"9ad45d7e_7e8f5ecc","line":90,"range":{"start_line":89,"start_character":0,"end_line":90,"end_character":21},"in_reply_to":"9ad45d7e_fee9a51b","updated":"2016-08-09 18:00:03.000000000","message":"Done","commit_id":"81c931934855e39002071cd26687dc46683663e6"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"5b3179f40d8ba9602effc34330beab4b249f9290","unresolved":false,"context_lines":[{"line_number":88,"context_line":"      name-1, name-2."},{"line_number":89,"context_line":"      Example display name when creating two VM\u0027s (with uuid key):"},{"line_number":90,"context_line":"      uuid-1, uuid-2."},{"line_number":91,"context_line":"\"\"\"),"},{"line_number":92,"context_line":"    cfg.IntOpt(\u0027max_local_block_devices\u0027,"},{"line_number":93,"context_line":"               default\u003d3,"},{"line_number":94,"context_line":"               help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"9ad45d7e_fe5ec5e7","line":91,"updated":"2016-08-09 11:26:38.000000000","message":"Can we add a TODO to deprecate this. Its a config that changes API behaviour, and we should get rid of those, where possible.","commit_id":"81c931934855e39002071cd26687dc46683663e6"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"28f4190dcf0012afc6e839253e73979eebd40023","unresolved":false,"context_lines":[{"line_number":88,"context_line":"      name-1, name-2."},{"line_number":89,"context_line":"      Example display name when creating two VM\u0027s (with uuid key):"},{"line_number":90,"context_line":"      uuid-1, uuid-2."},{"line_number":91,"context_line":"\"\"\"),"},{"line_number":92,"context_line":"    cfg.IntOpt(\u0027max_local_block_devices\u0027,"},{"line_number":93,"context_line":"               default\u003d3,"},{"line_number":94,"context_line":"               help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"9ad45d7e_69f7e5f5","line":91,"in_reply_to":"9ad45d7e_b950d00b","updated":"2016-08-12 17:37:36.000000000","message":"I think we can just hard code this template. There is no real need to change the template. We can\u0027t remove that API (as much as I would like to).","commit_id":"81c931934855e39002071cd26687dc46683663e6"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"cdfeb1b0291c5f6aa4a1a8c9ba33878b159fb562","unresolved":false,"context_lines":[{"line_number":88,"context_line":"      name-1, name-2."},{"line_number":89,"context_line":"      Example display name when creating two VM\u0027s (with uuid key):"},{"line_number":90,"context_line":"      uuid-1, uuid-2."},{"line_number":91,"context_line":"\"\"\"),"},{"line_number":92,"context_line":"    cfg.IntOpt(\u0027max_local_block_devices\u0027,"},{"line_number":93,"context_line":"               default\u003d3,"},{"line_number":94,"context_line":"               help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"9ad45d7e_b950d00b","line":91,"in_reply_to":"9ad45d7e_fe5ec5e7","updated":"2016-08-09 18:00:03.000000000","message":"So if we deprecate this, os-multiple-create API extension will also be deprecated?\nLike we don\u0027t support this feature of creating multiple instances with single request or we come up with something that replaces this template only?","commit_id":"81c931934855e39002071cd26687dc46683663e6"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"5b3179f40d8ba9602effc34330beab4b249f9290","unresolved":false,"context_lines":[{"line_number":120,"context_line":"Monitor classes available to the compute which may be specified more than once."},{"line_number":121,"context_line":"This option is DEPRECATED and no longer used. Use setuptools entry points to"},{"line_number":122,"context_line":"list available monitor plugins."},{"line_number":123,"context_line":"\"\"\"),"},{"line_number":124,"context_line":"    cfg.ListOpt(\u0027compute_monitors\u0027,"},{"line_number":125,"context_line":"                default\u003d[],"},{"line_number":126,"context_line":"                help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"9ad45d7e_deb941cd","line":123,"updated":"2016-08-09 11:26:38.000000000","message":"Nit: we can remove this in a follow up patch, that has the required reno note.","commit_id":"81c931934855e39002071cd26687dc46683663e6"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"cdfeb1b0291c5f6aa4a1a8c9ba33878b159fb562","unresolved":false,"context_lines":[{"line_number":120,"context_line":"Monitor classes available to the compute which may be specified more than once."},{"line_number":121,"context_line":"This option is DEPRECATED and no longer used. Use setuptools entry points to"},{"line_number":122,"context_line":"list available monitor plugins."},{"line_number":123,"context_line":"\"\"\"),"},{"line_number":124,"context_line":"    cfg.ListOpt(\u0027compute_monitors\u0027,"},{"line_number":125,"context_line":"                default\u003d[],"},{"line_number":126,"context_line":"                help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"9ad45d7e_f9a888dd","line":123,"in_reply_to":"9ad45d7e_deb941cd","updated":"2016-08-09 18:00:03.000000000","message":"Done","commit_id":"81c931934855e39002071cd26687dc46683663e6"}]}