)]}'
{"nova/network/neutronv2/api.py":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"ba565bfb6d057ac7a86e7282dce2bcfe968c8834","unresolved":false,"context_lines":[{"line_number":381,"context_line":""},{"line_number":382,"context_line":"        return ports, net_ids, ordered_networks"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"    def _filter_hypervisor_macs(self, instance, ports, hypervisor_macs):"},{"line_number":385,"context_line":"        \"\"\"Removes macs from set if used by existing ports"},{"line_number":386,"context_line":""},{"line_number":387,"context_line":"        :param requested_networks: list of NetworkRequests"}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_52898974","line":384,"updated":"2016-06-23 17:38:43.000000000","message":"this is another case where self is unused, right. Can we get them out of the class and keep them at the module level?","commit_id":"52a2ca72dad85cc7bf539763cb23bd6b8d30ce67"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"8380f8e6bf99a115f7c191ce8e3bdec9fa77593b","unresolved":false,"context_lines":[{"line_number":381,"context_line":""},{"line_number":382,"context_line":"        return ports, net_ids, ordered_networks"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"    def _filter_hypervisor_macs(self, instance, ports, hypervisor_macs):"},{"line_number":385,"context_line":"        \"\"\"Removes macs from set if used by existing ports"},{"line_number":386,"context_line":""},{"line_number":387,"context_line":"        :param requested_networks: list of NetworkRequests"}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_2064f2e3","line":384,"in_reply_to":"3aaa91ec_52898974","updated":"2016-06-27 14:10:04.000000000","message":"yeah, I hadn\u0027t spotted that, its a good plan.","commit_id":"52a2ca72dad85cc7bf539763cb23bd6b8d30ce67"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"4ae5b2a8e519139e842af1dca1734349f60b5931","unresolved":false,"context_lines":[{"line_number":143,"context_line":"        the bare metal hypervisor (which is the only one known to limit"},{"line_number":144,"context_line":"        MAC addresses)."},{"line_number":145,"context_line":"    :type hypervisor_macs: set"},{"line_number":146,"context_line":"    :returns a set of available MAC addresses to use if"},{"line_number":147,"context_line":"            creating a port later; this is the set of hypervisor_macs"},{"line_number":148,"context_line":"            after removing any MAC addresses from explicitly"},{"line_number":149,"context_line":"            requested ports."}],"source_content_type":"text/x-python","patch_set":7,"id":"3aaa91ec_5ea95a23","line":146,"updated":"2016-06-30 15:30:21.000000000","message":"nit: can also return None.","commit_id":"e320abccbde322c3367a999f6a88428d3c2a23a3"}]}