)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"296a8b64c505a5bec0f69441052248224b407580","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Improve help text for allocation_ratio_opts"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit adds additional help text to allocation_"},{"line_number":10,"context_line":"ratio_opts"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I4654bb26184a2a993aab9476e5d303f5f00803e0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5a9d85d2_5f461224","line":10,"updated":"2016-06-20 17:34:16.000000000","message":"commit message should mention the bug being fixed with a line like \"Closes-Bug: #1590133\"","commit_id":"c820a90a65b7ea07eba6f2402c31fb07c42b4655"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"51fe78e5dd02cc7c6ae57fcbdaa1f5a86daf4aad","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Improve help text for allocation_ratio_opts"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit adds additional help text to allocation_"},{"line_number":10,"context_line":"ratio_opts"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I4654bb26184a2a993aab9476e5d303f5f00803e0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3aaa91ec_a772aa47","line":10,"in_reply_to":"5a9d85d2_13c62649","updated":"2016-06-27 16:43:02.000000000","message":"+1","commit_id":"c820a90a65b7ea07eba6f2402c31fb07c42b4655"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"93c88d1d66c186d8e05d787e71b7e1ce711eb825","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Improve help text for allocation_ratio_opts"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit adds additional help text to allocation_"},{"line_number":10,"context_line":"ratio_opts"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I4654bb26184a2a993aab9476e5d303f5f00803e0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5a9d85d2_13c62649","line":10,"in_reply_to":"5a9d85d2_5f461224","updated":"2016-06-21 09:32:03.000000000","message":"Actually, in this case, its part of the BP, but that BP should be included here.","commit_id":"c820a90a65b7ea07eba6f2402c31fb07c42b4655"}],"nova/conf/compute.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"233aa1a5d41259dfcd4385d5dc5584f9caff3b41","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        default\u003d0.0,"},{"line_number":99,"context_line":"        help\u003d\"\"\""},{"line_number":100,"context_line":"This option helps you specify virtual CPU to physical CPU"},{"line_number":101,"context_line":"allocation ratio which affects all CPU filters."},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"This configuration specifies a global ratio for CoreFilter."},{"line_number":104,"context_line":"For AggregateCoreFilter, it will fall back to this configuration"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_617b557c","line":101,"range":{"start_line":101,"start_character":31,"end_line":101,"end_character":46},"updated":"2016-06-16 12:40:32.000000000","message":"so really, it is affecting VM density,  and how much RAM is given to VMs compared to how much ram is available on the a compute node.","commit_id":"c820a90a65b7ea07eba6f2402c31fb07c42b4655"},{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"9fceb6aaf88e29078783cd030b3fc095842ba16c","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        default\u003d0.0,"},{"line_number":99,"context_line":"        help\u003d\"\"\""},{"line_number":100,"context_line":"This option helps you specify virtual CPU to physical CPU"},{"line_number":101,"context_line":"allocation ratio which affects all CPU filters."},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"This configuration specifies a global ratio for CoreFilter."},{"line_number":104,"context_line":"For AggregateCoreFilter, it will fall back to this configuration"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_bb32820d","line":101,"range":{"start_line":101,"start_character":31,"end_line":101,"end_character":46},"in_reply_to":"7aa08908_617b557c","updated":"2016-06-16 16:03:35.000000000","message":"John, can you please help me understand in what way this parameter would be different from ram_allocation_ratio as I see both deals with overcommiting the RAM. Should I change help text from \"all cpu filters\" to \"VM density\"","commit_id":"c820a90a65b7ea07eba6f2402c31fb07c42b4655"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"93c88d1d66c186d8e05d787e71b7e1ce711eb825","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        default\u003d0.0,"},{"line_number":99,"context_line":"        help\u003d\"\"\""},{"line_number":100,"context_line":"This option helps you specify virtual CPU to physical CPU"},{"line_number":101,"context_line":"allocation ratio which affects all CPU filters."},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"This configuration specifies a global ratio for CoreFilter."},{"line_number":104,"context_line":"For AggregateCoreFilter, it will fall back to this configuration"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a9d85d2_f30c3a96","line":101,"range":{"start_line":101,"start_character":31,"end_line":101,"end_character":46},"in_reply_to":"7aa08908_bb32820d","updated":"2016-06-21 09:32:03.000000000","message":"It affects how must we under or over allocate RAM to servers running on the compute node. Does that help?","commit_id":"c820a90a65b7ea07eba6f2402c31fb07c42b4655"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"233aa1a5d41259dfcd4385d5dc5584f9caff3b41","unresolved":false,"context_lines":[{"line_number":100,"context_line":"This option helps you specify virtual CPU to physical CPU"},{"line_number":101,"context_line":"allocation ratio which affects all CPU filters."},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"This configuration specifies a global ratio for CoreFilter."},{"line_number":104,"context_line":"For AggregateCoreFilter, it will fall back to this configuration"},{"line_number":105,"context_line":"value if no per-aggregate setting found."},{"line_number":106,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_219aedc5","line":103,"range":{"start_line":103,"start_character":29,"end_line":103,"end_character":43},"updated":"2016-06-16 12:40:32.000000000","message":"This is no longer global actually, it  can now be set on every compute node individually. See line 107.","commit_id":"c820a90a65b7ea07eba6f2402c31fb07c42b4655"},{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"9fceb6aaf88e29078783cd030b3fc095842ba16c","unresolved":false,"context_lines":[{"line_number":100,"context_line":"This option helps you specify virtual CPU to physical CPU"},{"line_number":101,"context_line":"allocation ratio which affects all CPU filters."},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"This configuration specifies a global ratio for CoreFilter."},{"line_number":104,"context_line":"For AggregateCoreFilter, it will fall back to this configuration"},{"line_number":105,"context_line":"value if no per-aggregate setting found."},{"line_number":106,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_71ecb9bb","line":103,"range":{"start_line":103,"start_character":29,"end_line":103,"end_character":43},"in_reply_to":"7aa08908_219aedc5","updated":"2016-06-16 16:03:35.000000000","message":"John, I am thinking of changing it to \" ratio for CoreFilter which can be set per compute node\" and adding a note saying the option of setting this in scheduler node would be deprecated in future. Please let me know if that works for all the below cases ?","commit_id":"c820a90a65b7ea07eba6f2402c31fb07c42b4655"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"93c88d1d66c186d8e05d787e71b7e1ce711eb825","unresolved":false,"context_lines":[{"line_number":100,"context_line":"This option helps you specify virtual CPU to physical CPU"},{"line_number":101,"context_line":"allocation ratio which affects all CPU filters."},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"This configuration specifies a global ratio for CoreFilter."},{"line_number":104,"context_line":"For AggregateCoreFilter, it will fall back to this configuration"},{"line_number":105,"context_line":"value if no per-aggregate setting found."},{"line_number":106,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a9d85d2_f3839aca","line":103,"range":{"start_line":103,"start_character":29,"end_line":103,"end_character":43},"in_reply_to":"7aa08908_71ecb9bb","updated":"2016-06-21 09:32:03.000000000","message":"Yes, that sounds perfect.","commit_id":"c820a90a65b7ea07eba6f2402c31fb07c42b4655"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"233aa1a5d41259dfcd4385d5dc5584f9caff3b41","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"Possible values:"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    * Any valid integer or float value"},{"line_number":114,"context_line":"    * Default value is 0.0"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"Related options:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_c18a0964","line":113,"range":{"start_line":113,"start_character":6,"end_line":113,"end_character":38},"updated":"2016-06-16 12:40:32.000000000","message":"I think it has to be a positive value.","commit_id":"c820a90a65b7ea07eba6f2402c31fb07c42b4655"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"233aa1a5d41259dfcd4385d5dc5584f9caff3b41","unresolved":false,"context_lines":[{"line_number":111,"context_line":"Possible values:"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    * Any valid integer or float value"},{"line_number":114,"context_line":"    * Default value is 0.0"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"Related options:"},{"line_number":117,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_618195fb","line":114,"range":{"start_line":114,"start_character":6,"end_line":114,"end_character":26},"updated":"2016-06-16 12:40:32.000000000","message":"So the default value is very complicated right now, see:\nhttps://github.com/openstack/nova/blob/e092ca6716a7568b7ddf6a4cf4264943e11f51da/nova/objects/compute_node.py#L174\n\nBasically, the default is actually 16.0, although for backwards compatibility reasons, we default the configuration to 0.0.","commit_id":"c820a90a65b7ea07eba6f2402c31fb07c42b4655"},{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"9fceb6aaf88e29078783cd030b3fc095842ba16c","unresolved":false,"context_lines":[{"line_number":111,"context_line":"Possible values:"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    * Any valid integer or float value"},{"line_number":114,"context_line":"    * Default value is 0.0"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"Related options:"},{"line_number":117,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_91f16598","line":114,"range":{"start_line":114,"start_character":6,"end_line":114,"end_character":26},"in_reply_to":"7aa08908_618195fb","updated":"2016-06-16 16:03:35.000000000","message":"John, Should I change the default value and help text to 16.0, 1.5 and 1.0 in all places ?","commit_id":"c820a90a65b7ea07eba6f2402c31fb07c42b4655"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"93c88d1d66c186d8e05d787e71b7e1ce711eb825","unresolved":false,"context_lines":[{"line_number":111,"context_line":"Possible values:"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    * Any valid integer or float value"},{"line_number":114,"context_line":"    * Default value is 0.0"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"Related options:"},{"line_number":117,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a9d85d2_932e96f8","line":114,"range":{"start_line":114,"start_character":6,"end_line":114,"end_character":26},"in_reply_to":"7aa08908_91f16598","updated":"2016-06-21 09:32:03.000000000","message":"No, I think we need to add a comment here saying what the 0.0 means, i.e. 0.0 means if this is not set on the scheduler node or the compute node, we default to 16.0.","commit_id":"c820a90a65b7ea07eba6f2402c31fb07c42b4655"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"233aa1a5d41259dfcd4385d5dc5584f9caff3b41","unresolved":false,"context_lines":[{"line_number":123,"context_line":"This option helps you specify virtual RAM to physical RAM"},{"line_number":124,"context_line":"allocation ratio which affects all RAM filters"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"This configuration specifies a global ratio for RamFilter."},{"line_number":127,"context_line":"For AggregateRamFilter, it will fall back to this configuration"},{"line_number":128,"context_line":"value if no per-aggregate setting found."},{"line_number":129,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_8176413d","line":126,"range":{"start_line":126,"start_character":31,"end_line":126,"end_character":43},"updated":"2016-06-16 12:40:32.000000000","message":"as above, this is no longer true.","commit_id":"c820a90a65b7ea07eba6f2402c31fb07c42b4655"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"233aa1a5d41259dfcd4385d5dc5584f9caff3b41","unresolved":false,"context_lines":[{"line_number":133,"context_line":"Possible values:"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    * Any valid integer or float value"},{"line_number":136,"context_line":"    * Default value is 0.0"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"Related options:"},{"line_number":139,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_218e6d27","line":136,"updated":"2016-06-16 12:40:32.000000000","message":"as above, its really 1.5","commit_id":"c820a90a65b7ea07eba6f2402c31fb07c42b4655"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"233aa1a5d41259dfcd4385d5dc5584f9caff3b41","unresolved":false,"context_lines":[{"line_number":155,"context_line":"instances."},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"NOTE: This can be set per-compute, or if set to 0.0, the value"},{"line_number":158,"context_line":"set on the scheduler node(s) will be used and defaulted to 1.0\u0027."},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"Possible values:"},{"line_number":161,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_e1c3c536","line":158,"updated":"2016-06-16 12:40:32.000000000","message":"This applies to the above cases as well, but we are deprecating setting this value on the scheduler node, it should be set on the compute node.","commit_id":"c820a90a65b7ea07eba6f2402c31fb07c42b4655"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"233aa1a5d41259dfcd4385d5dc5584f9caff3b41","unresolved":false,"context_lines":[{"line_number":160,"context_line":"Possible values:"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    * Any valid integer or float value"},{"line_number":163,"context_line":"    * Default value is 0.0"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"Related options:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_0191b146","line":163,"updated":"2016-06-16 12:40:32.000000000","message":"as above, its really 1.0","commit_id":"c820a90a65b7ea07eba6f2402c31fb07c42b4655"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"f2dbd1460f198b4bef30d76910cd4e06bb07d0b9","unresolved":false,"context_lines":[{"line_number":111,"context_line":"Possible values:"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    * Any valid positive integer or float value"},{"line_number":114,"context_line":"    * Default value is 0.0"},{"line_number":115,"context_line":"\"\"\"),"},{"line_number":116,"context_line":"    cfg.FloatOpt(\u0027ram_allocation_ratio\u0027,"},{"line_number":117,"context_line":"        default\u003d0.0,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_ed5ffa3e","line":114,"updated":"2016-06-29 15:44:08.000000000","message":"I think we probably want to add a note that the 0.0 default really means 16.0 here.","commit_id":"fd79f0850a8dfc7ff2dc25eada784f3fadbaf7ba"},{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"9d20bf299a8dcc4e8b4c240fe1118d162cd71e8f","unresolved":false,"context_lines":[{"line_number":111,"context_line":"Possible values:"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    * Any valid positive integer or float value"},{"line_number":114,"context_line":"    * Default value is 0.0"},{"line_number":115,"context_line":"\"\"\"),"},{"line_number":116,"context_line":"    cfg.FloatOpt(\u0027ram_allocation_ratio\u0027,"},{"line_number":117,"context_line":"        default\u003d0.0,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_88bbbde4","line":114,"in_reply_to":"3aaa91ec_ed5ffa3e","updated":"2016-06-29 18:06:03.000000000","message":"John, above there is a note saying that 0.0 will be defaulted to 16.0. Would you like to reiterate that again in possible values as well ?","commit_id":"fd79f0850a8dfc7ff2dc25eada784f3fadbaf7ba"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"f2dbd1460f198b4bef30d76910cd4e06bb07d0b9","unresolved":false,"context_lines":[{"line_number":130,"context_line":"Possible values:"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    * Any valid positive integer or float value"},{"line_number":133,"context_line":"    * Default value is 0.0"},{"line_number":134,"context_line":"\"\"\"),"},{"line_number":135,"context_line":"    cfg.FloatOpt(\u0027disk_allocation_ratio\u0027,"},{"line_number":136,"context_line":"        default\u003d0.0,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_cd231ebc","line":133,"updated":"2016-06-29 15:44:08.000000000","message":"as above, except 1.5","commit_id":"fd79f0850a8dfc7ff2dc25eada784f3fadbaf7ba"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"f2dbd1460f198b4bef30d76910cd4e06bb07d0b9","unresolved":false,"context_lines":[{"line_number":154,"context_line":"Possible values:"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    * Any valid positive integer or float value"},{"line_number":157,"context_line":"    * Default value is 0.0"},{"line_number":158,"context_line":"\"\"\")"},{"line_number":159,"context_line":"]"},{"line_number":160,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_2d2d82a8","line":157,"updated":"2016-06-29 15:44:08.000000000","message":"as above, except 1.0","commit_id":"fd79f0850a8dfc7ff2dc25eada784f3fadbaf7ba"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"642aa59ffcf44258c58e08d7de989d1951210349","unresolved":false,"context_lines":[{"line_number":142,"context_line":"A ratio greater than 1.0 will result in over-subscription of the"},{"line_number":143,"context_line":"available physical disk, which can be useful for more"},{"line_number":144,"context_line":"efficiently packing instances created with images that do not"},{"line_number":145,"context_line":"use the entire virtual disk,such as sparse or compressed"},{"line_number":146,"context_line":"images. It can be set to a value between 0.0 and 1.0 in order"},{"line_number":147,"context_line":"to preserve a percentage of the disk for uses other than"},{"line_number":148,"context_line":"instances."}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_0df9d180","line":145,"range":{"start_line":145,"start_character":23,"end_line":145,"end_character":32},"updated":"2016-07-11 08:43:56.000000000","message":"nit, missing a space at here","commit_id":"1214a2391e7d19d355fbbcb9c3592e87cf5bd195"}]}