)]}'
{"nova/rootwrap/filters.py":[{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"dd09db5c00adf7b01473375d0d6057d393032074","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    def get_environment(self, userargs):"},{"line_number":45,"context_line":"        \"\"\"Returns specific environment to set, None if none\"\"\""},{"line_number":46,"context_line":"        return None"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"class RegExpFilter(CommandFilter):"},{"line_number":50,"context_line":"    \"\"\"Command filter doing regexp matching for every argument\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAEH%2F%2F%2F70%3D","line":47,"updated":"2012-01-23 11:07:08.000000000","message":"None means \u0027inherit the current process environment\u0027\n\nWould {} make more sense ?","commit_id":"2261aba0b828b3d1d8d8986da384534e5aaf9bcd"},{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"dd09db5c00adf7b01473375d0d6057d393032074","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    def get_environment(self, userargs):"},{"line_number":87,"context_line":"        return {\u0027FLAGFILE\u0027: userargs[0].split(\u0027\u003d\u0027)[-1],"},{"line_number":88,"context_line":"                \u0027NETWORK_ID\u0027: userargs[1].split(\u0027\u003d\u0027)[-1]}"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAEH%2F%2F%2F7w%3D","line":88,"updated":"2012-01-23 11:07:08.000000000","message":"If the default behaviour is to inherit the current process environment, shouldn\u0027t this be more like:\n\n  def get_environment(self, userargs):\n      env \u003d os.environ.copy()\n      env[\u0027FLAGFILE\u0027] \u003d ...\n      ...\n      return env","commit_id":"2261aba0b828b3d1d8d8986da384534e5aaf9bcd"}]}