)]}'
{"nova/conf/compute.py":[{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"f108b83a810f21ce67869c3ad184c751a6f52b8d","unresolved":false,"context_lines":[{"line_number":133,"context_line":"    cfg.StrOpt(\u0027console_host\u0027,"},{"line_number":134,"context_line":"               default\u003dsocket.gethostname(),"},{"line_number":135,"context_line":"               help\u003d\"\"\""},{"line_number":136,"context_line":"This option represents console proxy host to use to connect to instances"},{"line_number":137,"context_line":"on this host. It is publically visible name for the console host."},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_de1b437f","line":136,"range":{"start_line":136,"start_character":42,"end_line":136,"end_character":48},"updated":"2016-06-27 16:11:52.000000000","message":"to be used","commit_id":"1a1f510d7933c3eca736afebb4047d909216cb5f"},{"author":{"_account_id":18335,"name":"Pushkar Umaranikar","email":"pushkar.umaranikar@intel.com","username":"pushkarumaranikar"},"change_message_id":"f8d59390d08fc913ab47e1ec2a0e0ce655349fc0","unresolved":false,"context_lines":[{"line_number":133,"context_line":"    cfg.StrOpt(\u0027console_host\u0027,"},{"line_number":134,"context_line":"               default\u003dsocket.gethostname(),"},{"line_number":135,"context_line":"               help\u003d\"\"\""},{"line_number":136,"context_line":"This option represents console proxy host to use to connect to instances"},{"line_number":137,"context_line":"on this host. It is publically visible name for the console host."},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_92308aea","line":136,"range":{"start_line":136,"start_character":42,"end_line":136,"end_character":48},"in_reply_to":"3aaa91ec_de1b437f","updated":"2016-06-27 16:49:28.000000000","message":"Done","commit_id":"1a1f510d7933c3eca736afebb4047d909216cb5f"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"f35da5bde4055cb4da2a0b200d06e4823976f5bd","unresolved":false,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":"Possible values:"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"* Any string representing hostname."},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"Related options:"},{"line_number":144,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5a9d85d2_82877e60","line":141,"range":{"start_line":141,"start_character":2,"end_line":141,"end_character":35},"updated":"2016-06-20 17:58:46.000000000","message":"+ info about default value","commit_id":"1a1f510d7933c3eca736afebb4047d909216cb5f"},{"author":{"_account_id":18335,"name":"Pushkar Umaranikar","email":"pushkar.umaranikar@intel.com","username":"pushkarumaranikar"},"change_message_id":"f8d59390d08fc913ab47e1ec2a0e0ce655349fc0","unresolved":false,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":"Possible values:"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"* Any string representing hostname."},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"Related options:"},{"line_number":144,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_b23306f6","line":141,"range":{"start_line":141,"start_character":2,"end_line":141,"end_character":35},"in_reply_to":"5a9d85d2_82877e60","updated":"2016-06-27 16:49:28.000000000","message":"Done","commit_id":"1a1f510d7933c3eca736afebb4047d909216cb5f"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"f108b83a810f21ce67869c3ad184c751a6f52b8d","unresolved":false,"context_lines":[{"line_number":146,"context_line":"\"\"\"),"},{"line_number":147,"context_line":"    cfg.StrOpt(\u0027default_access_ip_network_name\u0027,"},{"line_number":148,"context_line":"               help\u003d\"\"\""},{"line_number":149,"context_line":"This option specifies name of network to use to set access IPs for instances."},{"line_number":150,"context_line":"If there are multiple IPs to choose from, an arbitrary one will be chosen."},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_e177829d","line":149,"range":{"start_line":149,"start_character":30,"end_line":149,"end_character":44},"updated":"2016-06-27 16:11:52.000000000","message":"the network to be used","commit_id":"1a1f510d7933c3eca736afebb4047d909216cb5f"},{"author":{"_account_id":18335,"name":"Pushkar Umaranikar","email":"pushkar.umaranikar@intel.com","username":"pushkarumaranikar"},"change_message_id":"f8d59390d08fc913ab47e1ec2a0e0ce655349fc0","unresolved":false,"context_lines":[{"line_number":146,"context_line":"\"\"\"),"},{"line_number":147,"context_line":"    cfg.StrOpt(\u0027default_access_ip_network_name\u0027,"},{"line_number":148,"context_line":"               help\u003d\"\"\""},{"line_number":149,"context_line":"This option specifies name of network to use to set access IPs for instances."},{"line_number":150,"context_line":"If there are multiple IPs to choose from, an arbitrary one will be chosen."},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_12249aad","line":149,"range":{"start_line":149,"start_character":30,"end_line":149,"end_character":44},"in_reply_to":"3aaa91ec_e177829d","updated":"2016-06-27 16:49:28.000000000","message":"Done","commit_id":"1a1f510d7933c3eca736afebb4047d909216cb5f"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"f108b83a810f21ce67869c3ad184c751a6f52b8d","unresolved":false,"context_lines":[{"line_number":255,"context_line":"               default\u003d10,"},{"line_number":256,"context_line":"               help\u003d\"\"\""},{"line_number":257,"context_line":"This option limits the maximum number of instance builds to run concurrently"},{"line_number":258,"context_line":"by nova-compute. Compute service can attempt to build an infinite number"},{"line_number":259,"context_line":"of instances, if asked to do so. This limit is enforced to avoid building"},{"line_number":260,"context_line":"unlimited instance concurrently on a compute node."},{"line_number":261,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_e12f823c","line":258,"range":{"start_line":258,"start_character":3,"end_line":258,"end_character":15},"updated":"2016-06-27 16:11:52.000000000","message":"So is this per node setting or generic that is pushed to all nodes?","commit_id":"1a1f510d7933c3eca736afebb4047d909216cb5f"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"9a30cff3c5b0f88c214be812fa5b60ab4cc8f530","unresolved":false,"context_lines":[{"line_number":255,"context_line":"               default\u003d10,"},{"line_number":256,"context_line":"               help\u003d\"\"\""},{"line_number":257,"context_line":"This option limits the maximum number of instance builds to run concurrently"},{"line_number":258,"context_line":"by nova-compute. Compute service can attempt to build an infinite number"},{"line_number":259,"context_line":"of instances, if asked to do so. This limit is enforced to avoid building"},{"line_number":260,"context_line":"unlimited instance concurrently on a compute node."},{"line_number":261,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_f3d11031","line":258,"range":{"start_line":258,"start_character":3,"end_line":258,"end_character":15},"in_reply_to":"3aaa91ec_d229728b","updated":"2016-06-27 17:57:43.000000000","message":"Ok, So I think it\u0027s worth to mention that here.","commit_id":"1a1f510d7933c3eca736afebb4047d909216cb5f"},{"author":{"_account_id":18335,"name":"Pushkar Umaranikar","email":"pushkar.umaranikar@intel.com","username":"pushkarumaranikar"},"change_message_id":"f8d59390d08fc913ab47e1ec2a0e0ce655349fc0","unresolved":false,"context_lines":[{"line_number":255,"context_line":"               default\u003d10,"},{"line_number":256,"context_line":"               help\u003d\"\"\""},{"line_number":257,"context_line":"This option limits the maximum number of instance builds to run concurrently"},{"line_number":258,"context_line":"by nova-compute. Compute service can attempt to build an infinite number"},{"line_number":259,"context_line":"of instances, if asked to do so. This limit is enforced to avoid building"},{"line_number":260,"context_line":"unlimited instance concurrently on a compute node."},{"line_number":261,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_d229728b","line":258,"range":{"start_line":258,"start_character":3,"end_line":258,"end_character":15},"in_reply_to":"3aaa91ec_e12f823c","updated":"2016-06-27 16:49:28.000000000","message":"I think every compute node has its own configuration file. Hence, we can set this value per node.","commit_id":"1a1f510d7933c3eca736afebb4047d909216cb5f"},{"author":{"_account_id":18335,"name":"Pushkar Umaranikar","email":"pushkar.umaranikar@intel.com","username":"pushkarumaranikar"},"change_message_id":"2a070031e20094e1b8ea5408ed8ea954999f1d10","unresolved":false,"context_lines":[{"line_number":255,"context_line":"               default\u003d10,"},{"line_number":256,"context_line":"               help\u003d\"\"\""},{"line_number":257,"context_line":"This option limits the maximum number of instance builds to run concurrently"},{"line_number":258,"context_line":"by nova-compute. Compute service can attempt to build an infinite number"},{"line_number":259,"context_line":"of instances, if asked to do so. This limit is enforced to avoid building"},{"line_number":260,"context_line":"unlimited instance concurrently on a compute node."},{"line_number":261,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_656c3709","line":258,"range":{"start_line":258,"start_character":3,"end_line":258,"end_character":15},"in_reply_to":"3aaa91ec_f3d11031","updated":"2016-06-27 18:22:18.000000000","message":"Done","commit_id":"1a1f510d7933c3eca736afebb4047d909216cb5f"},{"author":{"_account_id":15524,"name":"dane-fichter","email":"dane.fichter@jhuapl.edu","username":"dane-fichter"},"change_message_id":"414c8c1b7ddc871931904195de14fedb4ce483a3","unresolved":false,"context_lines":[{"line_number":134,"context_line":"               default\u003dsocket.gethostname(),"},{"line_number":135,"context_line":"               help\u003d\"\"\""},{"line_number":136,"context_line":"This option represents console proxy host to be used to connect to instances"},{"line_number":137,"context_line":"on this host. It is publically visible name for the console host."},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"Possible values:"},{"line_number":140,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3aaa91ec_af5ef80f","line":137,"updated":"2016-06-27 20:12:34.000000000","message":"s/publically/the publicly","commit_id":"f0a59eb1c0e8af7730c365c21303d3608b1cd000"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"cf56eb7b271835e74ffbfe2ce32be5f439e1ad38","unresolved":false,"context_lines":[{"line_number":258,"context_line":"This option limits the maximum number of instance builds to run concurrently"},{"line_number":259,"context_line":"by nova-compute. Compute service can attempt to build an infinite number"},{"line_number":260,"context_line":"of instances, if asked to do so. This limit is enforced to avoid building"},{"line_number":261,"context_line":"unlimited instance concurrently on a compute node. The value can be different"},{"line_number":262,"context_line":"for different compute nodes."},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"Possible Values:"},{"line_number":265,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3aaa91ec_36a34ea0","line":262,"range":{"start_line":261,"start_character":51,"end_line":262,"end_character":28},"updated":"2016-06-28 15:43:46.000000000","message":"nit: This value can be set per compute node.","commit_id":"3a09e750dd4d9e73742705c3482a23b09c14a068"},{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"e5c3ddf349482fbd8fd0cb8a475b5ae9a668c5b4","unresolved":false,"context_lines":[{"line_number":287,"context_line":"* None"},{"line_number":288,"context_line":"\"\"\"),"},{"line_number":289,"context_line":"    cfg.IntOpt(\u0027block_device_allocate_retries\u0027,"},{"line_number":290,"context_line":"               default\u003d60,"},{"line_number":291,"context_line":"               help\u003d\"\"\""},{"line_number":292,"context_line":"The options specifies the number of times to retry block device allocation"},{"line_number":293,"context_line":"on failures. Starting with Liberty, Cinder can use image volume cache."}],"source_content_type":"text/x-python","patch_set":9,"id":"3aaa91ec_cbca15a1","line":290,"range":{"start_line":290,"start_character":15,"end_line":290,"end_character":25},"updated":"2016-06-28 21:05:54.000000000","message":"I thinks its worth adding the below info in help text\n\n(1) treat  negative config value as 0\n(2) the configured value is 0, one attempt should be made\n(3) the configured value is \u003e 0, then the total number attempts\nis (retries + 1)","commit_id":"a34e567fd9e235a4086fe809115a0f35b5486669"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"ab8cd7175fae371c44727dd0f795e6b5a5bc0db5","unresolved":false,"context_lines":[{"line_number":157,"context_line":"This option specifies whether to batch up the application of IPTables rules"},{"line_number":158,"context_line":"during a host restart and apply all at the end of the init phase."},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"Possible values:"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"* False (default)"},{"line_number":163,"context_line":"* True"},{"line_number":164,"context_line":"\"\"\"),"},{"line_number":165,"context_line":"    cfg.StrOpt(\u0027instances_path\u0027,"},{"line_number":166,"context_line":"               default\u003dpaths.state_path_def(\u0027instances\u0027),"}],"source_content_type":"text/x-python","patch_set":10,"id":"3aaa91ec_5c140d4c","line":163,"range":{"start_line":160,"start_character":0,"end_line":163,"end_character":6},"updated":"2016-06-29 12:15:07.000000000","message":"Nit: boolean values are trivial and following The Musician\u0027s comment these should be dropped.","commit_id":"252ea2b0118fc62bdf3d1f622c02302253bc3f89"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"ab8cd7175fae371c44727dd0f795e6b5a5bc0db5","unresolved":false,"context_lines":[{"line_number":180,"context_line":"compute node must be configured to generate system usage data. These"},{"line_number":181,"context_line":"notifications are consumed by OpenStack Telemetry service."},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"Possible values:"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"* False (default)"},{"line_number":186,"context_line":"* True"},{"line_number":187,"context_line":"\"\"\"),"},{"line_number":188,"context_line":"    cfg.IntOpt(\u0027live_migration_retry_count\u0027,"},{"line_number":189,"context_line":"               default\u003d30,"}],"source_content_type":"text/x-python","patch_set":10,"id":"3aaa91ec_fc03390e","line":186,"range":{"start_line":183,"start_character":0,"end_line":186,"end_character":6},"updated":"2016-06-29 12:15:07.000000000","message":"Ditto","commit_id":"252ea2b0118fc62bdf3d1f622c02302253bc3f89"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"ab8cd7175fae371c44727dd0f795e6b5a5bc0db5","unresolved":false,"context_lines":[{"line_number":195,"context_line":""},{"line_number":196,"context_line":"Possible values:"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"* 30 (default) or any positive integer"},{"line_number":199,"context_line":"\"\"\"),"},{"line_number":200,"context_line":"    cfg.BoolOpt(\u0027resume_guests_state_on_host_boot\u0027,"},{"line_number":201,"context_line":"                default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":10,"id":"3aaa91ec_ff1a0b6e","line":198,"range":{"start_line":198,"start_character":18,"end_line":198,"end_character":38},"updated":"2016-06-29 12:15:07.000000000","message":"Add min\u003d0 flag to IntOpt","commit_id":"252ea2b0118fc62bdf3d1f622c02302253bc3f89"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"ab8cd7175fae371c44727dd0f795e6b5a5bc0db5","unresolved":false,"context_lines":[{"line_number":204,"context_line":"host rebooted. It ensures that all of the instances on a Nova compute node"},{"line_number":205,"context_line":"resume their state each time the compute node boots or restarts."},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"Possible values:"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"* False (default)"},{"line_number":210,"context_line":"* True"},{"line_number":211,"context_line":"\"\"\"),"},{"line_number":212,"context_line":"    cfg.IntOpt(\u0027network_allocate_retries\u0027,"},{"line_number":213,"context_line":"               default\u003d0,"}],"source_content_type":"text/x-python","patch_set":10,"id":"3aaa91ec_5f223fa4","line":210,"range":{"start_line":207,"start_character":0,"end_line":210,"end_character":6},"updated":"2016-06-29 12:15:07.000000000","message":"Ditto","commit_id":"252ea2b0118fc62bdf3d1f622c02302253bc3f89"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"ab8cd7175fae371c44727dd0f795e6b5a5bc0db5","unresolved":false,"context_lines":[{"line_number":218,"context_line":""},{"line_number":219,"context_line":"Possible values:"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"* 0 (default) or any positive integer."},{"line_number":222,"context_line":"\"\"\"),"},{"line_number":223,"context_line":"    cfg.IntOpt(\u0027max_concurrent_builds\u0027,"},{"line_number":224,"context_line":"               default\u003d10,"}],"source_content_type":"text/x-python","patch_set":10,"id":"3aaa91ec_bf3b63d0","line":221,"range":{"start_line":221,"start_character":21,"end_line":221,"end_character":29},"updated":"2016-06-29 12:15:07.000000000","message":"Add min\u003d0 flag to IntOpt","commit_id":"252ea2b0118fc62bdf3d1f622c02302253bc3f89"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"ab8cd7175fae371c44727dd0f795e6b5a5bc0db5","unresolved":false,"context_lines":[{"line_number":231,"context_line":""},{"line_number":232,"context_line":"Possible Values:"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"* 10 (default) or any positive integer."},{"line_number":235,"context_line":"\"\"\"),"},{"line_number":236,"context_line":"    cfg.IntOpt(\u0027max_concurrent_live_migrations\u0027,"},{"line_number":237,"context_line":"               default\u003d1,"}],"source_content_type":"text/x-python","patch_set":10,"id":"3aaa91ec_ff316bee","line":234,"range":{"start_line":234,"start_character":22,"end_line":234,"end_character":30},"updated":"2016-06-29 12:15:07.000000000","message":"Ditto","commit_id":"252ea2b0118fc62bdf3d1f622c02302253bc3f89"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"ab8cd7175fae371c44727dd0f795e6b5a5bc0db5","unresolved":false,"context_lines":[{"line_number":244,"context_line":""},{"line_number":245,"context_line":"Possible values:"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"* 1 (default) or any positive integer."},{"line_number":248,"context_line":"\"\"\"),"},{"line_number":249,"context_line":"    cfg.IntOpt(\u0027block_device_allocate_retries\u0027,"},{"line_number":250,"context_line":"               default\u003d60,"}],"source_content_type":"text/x-python","patch_set":10,"id":"3aaa91ec_df2e2f8b","line":247,"range":{"start_line":247,"start_character":21,"end_line":247,"end_character":29},"updated":"2016-06-29 12:15:07.000000000","message":"Ditto","commit_id":"252ea2b0118fc62bdf3d1f622c02302253bc3f89"},{"author":{"_account_id":18337,"name":"Sujitha","email":"sujitha.neti@intel.com","username":"Sujitha"},"change_message_id":"4a8387ad7f3775b0da0cd80075938c145d94d4da","unresolved":false,"context_lines":[{"line_number":165,"context_line":""},{"line_number":166,"context_line":"Possible values:"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"* Directory where nova python module is installed (default) or"},{"line_number":169,"context_line":"  Any string representing directory path."},{"line_number":170,"context_line":"\"\"\"),"},{"line_number":171,"context_line":"    cfg.BoolOpt(\u0027instance_usage_audit\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"3aaa91ec_645315e3","line":168,"updated":"2016-06-29 21:28:10.000000000","message":"Default path for instances is: $state_path/instances\nwhere state_path is a config option that specifies the top-level directory for maintaining nova\u0027s state.","commit_id":"31dee3ab47d62003b476c38a7ffe49477eb6bce6"},{"author":{"_account_id":18335,"name":"Pushkar Umaranikar","email":"pushkar.umaranikar@intel.com","username":"pushkarumaranikar"},"change_message_id":"927f4e731fe5637152cd4166480a7190dc086603","unresolved":false,"context_lines":[{"line_number":165,"context_line":""},{"line_number":166,"context_line":"Possible values:"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"* Directory where nova python module is installed (default) or"},{"line_number":169,"context_line":"  Any string representing directory path."},{"line_number":170,"context_line":"\"\"\"),"},{"line_number":171,"context_line":"    cfg.BoolOpt(\u0027instance_usage_audit\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"3aaa91ec_a05206dc","line":168,"in_reply_to":"3aaa91ec_645315e3","updated":"2016-06-29 22:05:46.000000000","message":"ok. I can change this. $state_path can be $pybasedir. Hence, I mentioned python module directory.","commit_id":"31dee3ab47d62003b476c38a7ffe49477eb6bce6"},{"author":{"_account_id":18337,"name":"Sujitha","email":"sujitha.neti@intel.com","username":"Sujitha"},"change_message_id":"4a8387ad7f3775b0da0cd80075938c145d94d4da","unresolved":false,"context_lines":[{"line_number":179,"context_line":"               min\u003d0,"},{"line_number":180,"context_line":"               default\u003d30,"},{"line_number":181,"context_line":"               help\u003d\"\"\""},{"line_number":182,"context_line":"This option specifies maximum number of 1 second retries in live_migration."},{"line_number":183,"context_line":"This limit is enforced to avoid concurrent request to iptables when user"},{"line_number":184,"context_line":"continously send live-migration request to the same host. Iptable complains"},{"line_number":185,"context_line":"if it receive concurrent requests."}],"source_content_type":"text/x-python","patch_set":11,"id":"3aaa91ec_7f8efe2e","line":182,"updated":"2016-06-29 21:28:10.000000000","message":"I think this help text is not correct. It doesn\u0027t avoid concurrent request to iptables but handles this issue. This option retries for the specified number of times when iptables complains. Which happens when user continuously sends live-migration request to same host leading to concurrent request to iptables.","commit_id":"31dee3ab47d62003b476c38a7ffe49477eb6bce6"},{"author":{"_account_id":18337,"name":"Sujitha","email":"sujitha.neti@intel.com","username":"Sujitha"},"change_message_id":"4a8387ad7f3775b0da0cd80075938c145d94d4da","unresolved":false,"context_lines":[{"line_number":238,"context_line":"    cfg.IntOpt(\u0027block_device_allocate_retries\u0027,"},{"line_number":239,"context_line":"               default\u003d60,"},{"line_number":240,"context_line":"               help\u003d\"\"\""},{"line_number":241,"context_line":"The options specifies the number of times to retry block device allocation"},{"line_number":242,"context_line":"on failures. Starting with Liberty, Cinder can use image volume cache."},{"line_number":243,"context_line":"This may help with block device allocation performance. Look at the cinder"},{"line_number":244,"context_line":"image_volume_cache_enabled configuration option."}],"source_content_type":"text/x-python","patch_set":11,"id":"3aaa91ec_ba7074a5","line":241,"updated":"2016-06-29 21:28:10.000000000","message":"nit: s/The options/This option","commit_id":"31dee3ab47d62003b476c38a7ffe49477eb6bce6"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5539cc813a595af90d97a984fa2d9107f9ea67e3","unresolved":false,"context_lines":[{"line_number":133,"context_line":"    cfg.StrOpt(\u0027console_host\u0027,"},{"line_number":134,"context_line":"               default\u003dsocket.gethostname(),"},{"line_number":135,"context_line":"               help\u003d\"\"\""},{"line_number":136,"context_line":"This option represents console proxy host to be used to connect to instances"},{"line_number":137,"context_line":"on this host. It is the publicly visible name for the console host."},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"Possible values:"},{"line_number":140,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"3aaa91ec_997571fb","line":137,"range":{"start_line":136,"start_character":0,"end_line":137,"end_character":67},"updated":"2016-07-01 10:09:42.000000000","message":"The way this was worded previously was clearer. Consider breaking this into a summary and description, a lá git commit messages:\n\n    Console proxy host to use to connect to instances on the host.\n\n    It is the publicly...","commit_id":"7c0999ecf003edce8eb42bdee46e418bfb671b67"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5539cc813a595af90d97a984fa2d9107f9ea67e3","unresolved":false,"context_lines":[{"line_number":142,"context_line":"\"\"\"),"},{"line_number":143,"context_line":"    cfg.StrOpt(\u0027default_access_ip_network_name\u0027,"},{"line_number":144,"context_line":"               help\u003d\"\"\""},{"line_number":145,"context_line":"This option specifies name of network to be used to set access IPs for"},{"line_number":146,"context_line":"instances. If there are multiple IPs to choose from, an arbitrary one will"},{"line_number":147,"context_line":"be chosen."},{"line_number":148,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"3aaa91ec_99e3b1a3","line":145,"range":{"start_line":145,"start_character":0,"end_line":145,"end_character":12},"updated":"2016-07-01 10:09:42.000000000","message":"Please don\u0027t say \"this option\" - I already know this is an option. See above.","commit_id":"7c0999ecf003edce8eb42bdee46e418bfb671b67"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5539cc813a595af90d97a984fa2d9107f9ea67e3","unresolved":false,"context_lines":[{"line_number":187,"context_line":""},{"line_number":188,"context_line":"Possible values:"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"* 30 (default) or any positive integer"},{"line_number":191,"context_line":"\"\"\"),"},{"line_number":192,"context_line":"    cfg.BoolOpt(\u0027resume_guests_state_on_host_boot\u0027,"},{"line_number":193,"context_line":"                default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":12,"id":"3aaa91ec_3951dd62","line":190,"range":{"start_line":190,"start_character":2,"end_line":190,"end_character":18},"updated":"2016-07-01 10:09:42.000000000","message":"Drop this","commit_id":"7c0999ecf003edce8eb42bdee46e418bfb671b67"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5539cc813a595af90d97a984fa2d9107f9ea67e3","unresolved":false,"context_lines":[{"line_number":187,"context_line":""},{"line_number":188,"context_line":"Possible values:"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"* 30 (default) or any positive integer"},{"line_number":191,"context_line":"\"\"\"),"},{"line_number":192,"context_line":"    cfg.BoolOpt(\u0027resume_guests_state_on_host_boot\u0027,"},{"line_number":193,"context_line":"                default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":12,"id":"3aaa91ec_d9c89924","line":190,"range":{"start_line":190,"start_character":22,"end_line":190,"end_character":38},"updated":"2016-07-01 10:09:42.000000000","message":"positive integer corresponding to...?","commit_id":"7c0999ecf003edce8eb42bdee46e418bfb671b67"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"3401d67b22dc365d74af4fad03e3db9d1b10e701","unresolved":false,"context_lines":[{"line_number":131,"context_line":""},{"line_number":132,"context_line":"compute_manager_opts \u003d ["},{"line_number":133,"context_line":"    cfg.StrOpt(\u0027console_host\u0027,"},{"line_number":134,"context_line":"               default\u003dsocket.gethostname(),"},{"line_number":135,"context_line":"               help\u003d\"\"\""},{"line_number":136,"context_line":"Console proxy host to be used to connect to instances on this host. It is the"},{"line_number":137,"context_line":"publicly visible name for the console host."}],"source_content_type":"text/x-python","patch_set":13,"id":"9ad45d7e_23804a46","line":134,"updated":"2016-08-09 11:05:06.000000000","message":"Nit: We should really kill these confusing defaults, docs wise. We should move this into the code, and make it clear what the behaviour is when the default is not set. If we respin, lets add a TODO for that.","commit_id":"9fbd45cc5f1024456496d8fb22f7314faef84127"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"3401d67b22dc365d74af4fad03e3db9d1b10e701","unresolved":false,"context_lines":[{"line_number":157,"context_line":"and apply all at the end of the init phase."},{"line_number":158,"context_line":"\"\"\"),"},{"line_number":159,"context_line":"    cfg.StrOpt(\u0027instances_path\u0027,"},{"line_number":160,"context_line":"               default\u003dpaths.state_path_def(\u0027instances\u0027),"},{"line_number":161,"context_line":"               help\u003d\"\"\""},{"line_number":162,"context_line":"Specifies where instances are stored on the hypervisor\u0027s disk."},{"line_number":163,"context_line":"It can point to locally attached storage or a directory on NFS."}],"source_content_type":"text/x-python","patch_set":13,"id":"9ad45d7e_a3ba7a08","line":160,"updated":"2016-08-09 11:05:06.000000000","message":"Nit: We should find a better way to do this default, it will give an odd confusing default in the docs right now. \"$state_path/instances\" isn\u0027t good as it breaks on windows, I think probably just moving this into code is the best bet. If we respin, add a TODO for that.","commit_id":"9fbd45cc5f1024456496d8fb22f7314faef84127"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"3401d67b22dc365d74af4fad03e3db9d1b10e701","unresolved":false,"context_lines":[{"line_number":210,"context_line":"               min\u003d0,"},{"line_number":211,"context_line":"               default\u003d10,"},{"line_number":212,"context_line":"               help\u003d\"\"\""},{"line_number":213,"context_line":"Limits the maximum number of instance builds to run concurrently by"},{"line_number":214,"context_line":"nova-compute. Compute service can attempt to build an infinite number of"},{"line_number":215,"context_line":"instances, if asked to do so. This limit is enforced to avoid building"},{"line_number":216,"context_line":"unlimited instance concurrently on a compute node. This value can be set"},{"line_number":217,"context_line":"per compute node."},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"Possible Values:"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"* Any positive integer representing maximum concurrent builds."},{"line_number":222,"context_line":"\"\"\"),"},{"line_number":223,"context_line":"    cfg.IntOpt(\u0027max_concurrent_live_migrations\u0027,"},{"line_number":224,"context_line":"               min\u003d0,"}],"source_content_type":"text/x-python","patch_set":13,"id":"9ad45d7e_23020a70","line":221,"range":{"start_line":213,"start_character":0,"end_line":221,"end_character":62},"updated":"2016-08-09 11:05:06.000000000","message":"So zero means \"allow infinite builds\". We should include that here.","commit_id":"9fbd45cc5f1024456496d8fb22f7314faef84127"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"3401d67b22dc365d74af4fad03e3db9d1b10e701","unresolved":false,"context_lines":[{"line_number":232,"context_line":"Possible values:"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"* Any positive integer representing maximum number of live migrations"},{"line_number":235,"context_line":"  to run concurrently."},{"line_number":236,"context_line":"\"\"\"),"},{"line_number":237,"context_line":"    cfg.IntOpt(\u0027block_device_allocate_retries\u0027,"},{"line_number":238,"context_line":"               default\u003d60,"}],"source_content_type":"text/x-python","patch_set":13,"id":"9ad45d7e_c3f32e9d","line":235,"updated":"2016-08-09 11:05:06.000000000","message":"As above, we should be clear that zero means allow infinite.","commit_id":"9fbd45cc5f1024456496d8fb22f7314faef84127"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"2282e6f8afcec6ca304603e702a608b3cfa16808","unresolved":false,"context_lines":[{"line_number":200,"context_line":""},{"line_number":201,"context_line":"compute_manager_opts \u003d ["},{"line_number":202,"context_line":"# TODO(pumaranikar): We can handle default value for this option into the"},{"line_number":203,"context_line":"# code."},{"line_number":204,"context_line":"    cfg.StrOpt(\u0027console_host\u0027,"},{"line_number":205,"context_line":"               default\u003dsocket.gethostname(),"},{"line_number":206,"context_line":"               help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":16,"id":"9ad45d7e_a676b1a1","line":203,"updated":"2016-08-10 17:32:18.000000000","message":"Sorry, I remembered how to fix this now, we can use sample_default that can say something like \"socket.gethostname()\"","commit_id":"dd30067809de8450de58b9408a1c9d402bacac5f"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"2282e6f8afcec6ca304603e702a608b3cfa16808","unresolved":false,"context_lines":[{"line_number":230,"context_line":""},{"line_number":231,"context_line":"# TODO(pumaranikar): This option has confusing default in docs. We can handle"},{"line_number":232,"context_line":"# default for this in the code. \"$state_path/instances\" is not a good default"},{"line_number":233,"context_line":"# represention."},{"line_number":234,"context_line":"    cfg.StrOpt(\u0027instances_path\u0027,"},{"line_number":235,"context_line":"               default\u003dpaths.state_path_def(\u0027instances\u0027),"},{"line_number":236,"context_line":"               help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":16,"id":"9ad45d7e_c6a805de","line":233,"updated":"2016-08-10 17:32:18.000000000","message":"We can do sample_default\u003d\"$state_path/instances\" so its clearer in the sample files.","commit_id":"dd30067809de8450de58b9408a1c9d402bacac5f"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"023eb529d4ded1138ef822f71bf632b9b46fe9bc","unresolved":false,"context_lines":[{"line_number":200,"context_line":""},{"line_number":201,"context_line":"compute_manager_opts \u003d ["},{"line_number":202,"context_line":"    cfg.StrOpt(\u0027console_host\u0027,"},{"line_number":203,"context_line":"               sample_default\u003dsocket.gethostname(),"},{"line_number":204,"context_line":"               help\u003d\"\"\""},{"line_number":205,"context_line":"Console proxy host to be used to connect to instances on this host. It is the"},{"line_number":206,"context_line":"publicly visible name for the console host."}],"source_content_type":"text/x-python","patch_set":19,"id":"9ad45d7e_12be4eff","line":203,"updated":"2016-08-12 18:38:13.000000000","message":"Sorry, I was unclear. This will break everything. Try this:\n\n  default\u003dsocket.gethostname(),\n  sample_default\u003d\"socket.gethostname()\"","commit_id":"0bc3b8811553b59d77f8c0bfbd9f1d3c35e2bd0b"},{"author":{"_account_id":18335,"name":"Pushkar Umaranikar","email":"pushkar.umaranikar@intel.com","username":"pushkarumaranikar"},"change_message_id":"43bc20f4786f7bafb58ee61705b49a89fd66e42e","unresolved":false,"context_lines":[{"line_number":200,"context_line":""},{"line_number":201,"context_line":"compute_manager_opts \u003d ["},{"line_number":202,"context_line":"    cfg.StrOpt(\u0027console_host\u0027,"},{"line_number":203,"context_line":"               sample_default\u003dsocket.gethostname(),"},{"line_number":204,"context_line":"               help\u003d\"\"\""},{"line_number":205,"context_line":"Console proxy host to be used to connect to instances on this host. It is the"},{"line_number":206,"context_line":"publicly visible name for the console host."}],"source_content_type":"text/x-python","patch_set":19,"id":"9ad45d7e_8f85f4ae","line":203,"in_reply_to":"9ad45d7e_12be4eff","updated":"2016-08-12 20:02:57.000000000","message":"my mistake.","commit_id":"0bc3b8811553b59d77f8c0bfbd9f1d3c35e2bd0b"}]}