)]}'
{"nova/api/openstack/placement/handler.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"e2ea756ade6171a251ad058de66305a8bf575ac5","unresolved":false,"context_lines":[{"line_number":29,"context_line":"from nova.api.openstack.placement.handlers import inventory"},{"line_number":30,"context_line":"from nova.api.openstack.placement.handlers import resource_provider"},{"line_number":31,"context_line":"from nova.api.openstack.placement.handlers import root"},{"line_number":32,"context_line":"from nova.api.openstack.placement.handlers import usages"},{"line_number":33,"context_line":"from nova.api.openstack.placement import util"},{"line_number":34,"context_line":"from nova import exception"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":58,"id":"3ac371cc_1a11625e","line":32,"updated":"2016-08-18 21:18:01.000000000","message":"Perhaps you could name the module \"usage\" instead of usages to be consistent with \"resource_provider\" and \"inventory\", both of which are singular?","commit_id":"add467bee718c2697e76b69c0e59d90bcbf2e762"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"da6c86b76446d7a7c3e2a7219224b6763cba1ae8","unresolved":false,"context_lines":[{"line_number":29,"context_line":"from nova.api.openstack.placement.handlers import inventory"},{"line_number":30,"context_line":"from nova.api.openstack.placement.handlers import resource_provider"},{"line_number":31,"context_line":"from nova.api.openstack.placement.handlers import root"},{"line_number":32,"context_line":"from nova.api.openstack.placement.handlers import usages"},{"line_number":33,"context_line":"from nova.api.openstack.placement import util"},{"line_number":34,"context_line":"from nova import exception"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":58,"id":"3ac371cc_b52f7f3d","line":32,"in_reply_to":"3ac371cc_1a11625e","updated":"2016-08-18 21:23:57.000000000","message":"fie, I even had that in my notes to do (for this and for the aggregates related stuff too) and forgot to do it","commit_id":"add467bee718c2697e76b69c0e59d90bcbf2e762"}],"nova/api/openstack/placement/handlers/usages.py":[{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"2722ca1c884939f2cac6b7c838114a41450b965a","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    uuid \u003d util.wsgi_path_item(req.environ, \u0027uuid\u0027)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    # Resource provider object needed for generation."},{"line_number":35,"context_line":"    # TODO(cdent): I\u0027m not convinced of the value of generation in"},{"line_number":36,"context_line":"    # the output here. It\u0027s not like we\u0027re going to put the usage"},{"line_number":37,"context_line":"    # information \"back\". It\u0027s quite likely the calling context is"},{"line_number":38,"context_line":"    # already going to have its own resource provider."}],"source_content_type":"text/x-python","patch_set":57,"id":"3ac371cc_645eff13","line":35,"updated":"2016-08-18 20:12:55.000000000","message":"I agree with this. Usages are updated by creating allocations right? And there\u0027s no concept of a generation there. I don\u0027t see the benefit of adding the generation here.\n\nIf there\u0027s no reason to add it should it just be removed from the start and if it turns out to be needed for some reason it can be added back?","commit_id":"7c782d5c32295f83751a58aa37585baa26deae5f"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"4b9d3ff071be37db2cd4963e8c2f915d139d4f0a","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    uuid \u003d util.wsgi_path_item(req.environ, \u0027uuid\u0027)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    # Resource provider object needed for generation."},{"line_number":35,"context_line":"    # TODO(cdent): I\u0027m not convinced of the value of generation in"},{"line_number":36,"context_line":"    # the output here. It\u0027s not like we\u0027re going to put the usage"},{"line_number":37,"context_line":"    # information \"back\". It\u0027s quite likely the calling context is"},{"line_number":38,"context_line":"    # already going to have its own resource provider."}],"source_content_type":"text/x-python","patch_set":57,"id":"3ac371cc_e444af1c","line":35,"in_reply_to":"3ac371cc_645eff13","updated":"2016-08-18 20:17:31.000000000","message":"It\u0027s currently in here because it is in the spec: http://specs.openstack.org/openstack/nova-specs/specs/newton/approved/generic-resource-pools.html#get-resource-providers-uuid-usages\n\nBut it seems odd. Jay, you wanna state an opinion?","commit_id":"7c782d5c32295f83751a58aa37585baa26deae5f"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"a2d12d11890ab31d5211c092206e96dc95fe058c","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    uuid \u003d util.wsgi_path_item(req.environ, \u0027uuid\u0027)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    # Resource provider object needed for generation."},{"line_number":35,"context_line":"    # TODO(cdent): I\u0027m not convinced of the value of generation in"},{"line_number":36,"context_line":"    # the output here. It\u0027s not like we\u0027re going to put the usage"},{"line_number":37,"context_line":"    # information \"back\". It\u0027s quite likely the calling context is"},{"line_number":38,"context_line":"    # already going to have its own resource provider."}],"source_content_type":"text/x-python","patch_set":57,"id":"3ac371cc_1a8162fc","line":35,"in_reply_to":"3ac371cc_e444af1c","updated":"2016-08-18 21:00:50.000000000","message":"For the record, conversation with dansmith indicated that the generation could be useful for client side comparisons, which I hadn\u0027t really thought about in this context, so it says in.","commit_id":"7c782d5c32295f83751a58aa37585baa26deae5f"}],"nova/tests/functional/api/openstack/placement/fixtures.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"e2ea756ade6171a251ad058de66305a8bf575ac5","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"class AllocationFixture(APIFixture):"},{"line_number":74,"context_line":"    \"\"\"An APIFixture that has some pre-made Allocaitons.\"\"\""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def start_fixture(self):"},{"line_number":77,"context_line":"        super(AllocationFixture, self).start_fixture()"}],"source_content_type":"text/x-python","patch_set":58,"id":"3ac371cc_951c036c","line":74,"updated":"2016-08-18 21:18:01.000000000","message":"s/Allocaitons/Allocations","commit_id":"add467bee718c2697e76b69c0e59d90bcbf2e762"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"da6c86b76446d7a7c3e2a7219224b6763cba1ae8","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"class AllocationFixture(APIFixture):"},{"line_number":74,"context_line":"    \"\"\"An APIFixture that has some pre-made Allocaitons.\"\"\""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def start_fixture(self):"},{"line_number":77,"context_line":"        super(AllocationFixture, self).start_fixture()"}],"source_content_type":"text/x-python","patch_set":58,"id":"3ac371cc_551f2b09","line":74,"in_reply_to":"3ac371cc_951c036c","updated":"2016-08-18 21:23:57.000000000","message":"I make that typo every\nsingle\ntime","commit_id":"add467bee718c2697e76b69c0e59d90bcbf2e762"}],"nova/tests/functional/api/openstack/placement/gabbits/usages.yaml":[{"author":{"_account_id":21813,"name":"Andrey Volkov","email":"m@amadev.ru","username":"avolkov"},"change_message_id":"27edaf2c5f2b7d71babb5b69b150f63a0876ed14","unresolved":false,"context_lines":[{"line_number":27,"context_line":"      name: a name"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"- name: get empty usages"},{"line_number":30,"context_line":"  GET: $LAST_URL/usages"},{"line_number":31,"context_line":"  request_headers:"},{"line_number":32,"context_line":"      content-type: application/json"},{"line_number":33,"context_line":"  response_json_paths:"}],"source_content_type":"text/x-yaml","patch_set":32,"id":"1aa78d24_2ceb6b14","line":30,"updated":"2016-07-13 11:39:45.000000000","message":"Is it depend on previous test? Should they always be in particular order?","commit_id":"f02becedcbf9be5b9be0e8a0919a7bc772a057fc"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"04633d276452969adcee10fdc3e9ca8d70424743","unresolved":false,"context_lines":[{"line_number":27,"context_line":"      name: a name"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"- name: get empty usages"},{"line_number":30,"context_line":"  GET: $LAST_URL/usages"},{"line_number":31,"context_line":"  request_headers:"},{"line_number":32,"context_line":"      content-type: application/json"},{"line_number":33,"context_line":"  response_json_paths:"}],"source_content_type":"text/x-yaml","patch_set":32,"id":"1aa78d24_035bd086","line":30,"in_reply_to":"1aa78d24_2ceb6b14","updated":"2016-07-13 14:57:34.000000000","message":"Yes, order matters in a gabbi yaml file and the tests will be run, in order, in one process, even when in a concurrent environment.\n\nIsolation in a gabbi tests is per file, which, under the covers is a GabbiTestSuite, which is a subclass of unittest.TestSuite.\n\nI\u0027ll provide a bit more about that in response to your comments on the other patch.","commit_id":"f02becedcbf9be5b9be0e8a0919a7bc772a057fc"}]}