)]}'
{"nova/tests/unit/test_metadata.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"cf1432048a2953079c7445e3387c2ce8c7b576b5","unresolved":false,"context_lines":[{"line_number":465,"context_line":"        instance \u003d self.instance.obj_clone()"},{"line_number":466,"context_line":"        # we want to make sure that key_name is set but not keypairs so it has"},{"line_number":467,"context_line":"        # to be lazy-loaded from the database"},{"line_number":468,"context_line":"        delattr(instance, \u0027keypairs\u0027)"},{"line_number":469,"context_line":"        mock_inst_get_by_uuid.return_value \u003d instance"},{"line_number":470,"context_line":"        md \u003d fake_InstanceMetadata(self.stubs, instance)"},{"line_number":471,"context_line":"        meta \u003d md._metadata_as_json(base.OPENSTACK_VERSIONS[-1], path\u003dNone)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_cbaba673","line":468,"updated":"2016-06-14 20:13:05.000000000","message":"This doesn\u0027t seem right and I\u0027m not sure how it\u0027s actually working, because instance.keypairs is an @property that loads instance._obj_keypairs. Deleting what you\u0027re deleting will also remove the lazy loading...\n\nCan you just set this to an empty KeyPairList?","commit_id":"4317166b72bb0aadd0321acdf9f2450c1a99d0a4"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"7b2980acc1aa2fd42549c6a21d6664a95f5e1b3d","unresolved":false,"context_lines":[{"line_number":465,"context_line":"        instance \u003d self.instance.obj_clone()"},{"line_number":466,"context_line":"        # we want to make sure that key_name is set but not keypairs so it has"},{"line_number":467,"context_line":"        # to be lazy-loaded from the database"},{"line_number":468,"context_line":"        delattr(instance, \u0027keypairs\u0027)"},{"line_number":469,"context_line":"        mock_inst_get_by_uuid.return_value \u003d instance"},{"line_number":470,"context_line":"        md \u003d fake_InstanceMetadata(self.stubs, instance)"},{"line_number":471,"context_line":"        meta \u003d md._metadata_as_json(base.OPENSTACK_VERSIONS[-1], path\u003dNone)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_06ebe313","line":468,"in_reply_to":"7aa08908_cbaba673","updated":"2016-06-14 20:27:31.000000000","message":"Nevermind, apparently I forgot that we have delete support on the @property:\n\nhttps://github.com/openstack/oslo.versionedobjects/blob/master/oslo_versionedobjects/base.py#L90\n\nSo this must be doing the right thing, which is good, since otherwise I can\u0027t explain why it passes :)","commit_id":"4317166b72bb0aadd0321acdf9f2450c1a99d0a4"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2133954108f6e9cef2d6c301201330c9de66bfef","unresolved":false,"context_lines":[{"line_number":465,"context_line":"        instance \u003d self.instance.obj_clone()"},{"line_number":466,"context_line":"        # we want to make sure that key_name is set but not keypairs so it has"},{"line_number":467,"context_line":"        # to be lazy-loaded from the database"},{"line_number":468,"context_line":"        delattr(instance, \u0027keypairs\u0027)"},{"line_number":469,"context_line":"        mock_inst_get_by_uuid.return_value \u003d instance"},{"line_number":470,"context_line":"        md \u003d fake_InstanceMetadata(self.stubs, instance)"},{"line_number":471,"context_line":"        meta \u003d md._metadata_as_json(base.OPENSTACK_VERSIONS[-1], path\u003dNone)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_cbfa8642","line":468,"in_reply_to":"7aa08908_cbaba673","updated":"2016-06-14 20:19:11.000000000","message":"Setting an empty KeyPairList for instance.keypairs defeats the purpose of the test which is to hit instance._load_keypairs. That\u0027s why I had to mock out Instance.get_by_uuid:\n\nhttps://gist.github.com/mriedem/b71ca1e00503aee0d5f2bb29dc5028a6","commit_id":"4317166b72bb0aadd0321acdf9f2450c1a99d0a4"}]}