)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"04a9f98f06d3b7936d2cddd4723a3c40ea783ef8","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This includes the parameter, example, and body"},{"line_number":10,"context_line":"verification for os-floating-ips."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"part of bp:api-ref-in-rst"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I4beff34b41baf77827a2e4d916ad5319bdefbfa1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"7a8ec9b2_d86dc7cd","line":12,"updated":"2016-09-20 15:50:13.000000000","message":"Please move this to blueprint api-ref-in-rst-ocata along with the topic branch.","commit_id":"14d4f61b3723c5ae9fe25cb8cebaa84b9a7d8ef7"}],"api-ref/source/os-floating-ips.inc":[{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"63fec410fc24e7b0d95e0a924878dc7982509f6a","unresolved":false,"context_lines":[{"line_number":1,"context_line":".. -*- rst -*-"},{"line_number":2,"context_line":".. needs:parameter_verification"},{"line_number":3,"context_line":".. needs:example_verification"},{"line_number":4,"context_line":".. needs:body_verification"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"7aa08908_3a9ed654","side":"PARENT","line":3,"range":{"start_line":3,"start_character":9,"end_line":3,"end_character":29},"updated":"2016-06-15 12:12:27.000000000","message":"nit: guess step by step will be better :)","commit_id":"2c8b08d310befcd2260e8e299fdb4ead3cb179bb"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"63fec410fc24e7b0d95e0a924878dc7982509f6a","unresolved":false,"context_lines":[{"line_number":151,"context_line":"Response"},{"line_number":152,"context_line":"--------"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"There is no body content for the response of a successful DELETE query."}],"source_content_type":"text/x-c++src","patch_set":1,"id":"7aa08908_ba912649","line":154,"range":{"start_line":154,"start_character":65,"end_line":154,"end_character":70},"updated":"2016-06-15 12:12:27.000000000","message":"\u0027action\u0027 might be better I guess","commit_id":"8ce574cb0b3e48b03ef46278ce813e2a02af9ee8"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"dfa290ada64b2ffe9e54dff4cc4dfe404291315e","unresolved":false,"context_lines":[{"line_number":45,"context_line":"Response"},{"line_number":46,"context_line":"--------"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"  - fixed_ip : fixed_ip"},{"line_number":51,"context_line":"  - id : id"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"5a9d85d2_c80877dc","line":48,"range":{"start_line":48,"start_character":32,"end_line":48,"end_character":36},"updated":"2016-06-21 02:39:32.000000000","message":"floating_ips: is missing (list of floating_ip objects)","commit_id":"00e73a89416fec647def7d8b6bde8af6c4cf6874"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"dfa290ada64b2ffe9e54dff4cc4dfe404291315e","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"  - fixed_ip : fixed_ip"},{"line_number":51,"context_line":"  - id : id"},{"line_number":52,"context_line":"  - instance_id : instance_id"},{"line_number":53,"context_line":"  - ip : ip"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"5a9d85d2_e8dd7315","line":50,"range":{"start_line":50,"start_character":4,"end_line":50,"end_character":23},"updated":"2016-06-21 02:39:32.000000000","message":"this is mandatory element in response but in parameters.yaml it is not.\n\nAlso need to define new parameter with description \"Fixed IP associated with Floating ip\"","commit_id":"00e73a89416fec647def7d8b6bde8af6c4cf6874"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"dfa290ada64b2ffe9e54dff4cc4dfe404291315e","unresolved":false,"context_lines":[{"line_number":48,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"  - fixed_ip : fixed_ip"},{"line_number":51,"context_line":"  - id : id"},{"line_number":52,"context_line":"  - instance_id : instance_id"},{"line_number":53,"context_line":"  - ip : ip"},{"line_number":54,"context_line":"  - pool: pool"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"5a9d85d2_e818d386","line":51,"range":{"start_line":51,"start_character":9,"end_line":51,"end_character":11},"updated":"2016-06-21 02:39:32.000000000","message":"this is not right one from parameter.yaml\n\nNeed to define new one \u0027type\u0027 as integer and \u0027in\u0027 body","commit_id":"00e73a89416fec647def7d8b6bde8af6c4cf6874"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"dfa290ada64b2ffe9e54dff4cc4dfe404291315e","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"  - fixed_ip : fixed_ip"},{"line_number":51,"context_line":"  - id : id"},{"line_number":52,"context_line":"  - instance_id : instance_id"},{"line_number":53,"context_line":"  - ip : ip"},{"line_number":54,"context_line":"  - pool: pool"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":2,"id":"5a9d85d2_eb260db9","line":52,"range":{"start_line":52,"start_character":18,"end_line":52,"end_character":29},"updated":"2016-06-21 02:39:32.000000000","message":"-\u003eserver_id","commit_id":"00e73a89416fec647def7d8b6bde8af6c4cf6874"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"dfa290ada64b2ffe9e54dff4cc4dfe404291315e","unresolved":false,"context_lines":[{"line_number":50,"context_line":"  - fixed_ip : fixed_ip"},{"line_number":51,"context_line":"  - id : id"},{"line_number":52,"context_line":"  - instance_id : instance_id"},{"line_number":53,"context_line":"  - ip : ip"},{"line_number":54,"context_line":"  - pool: pool"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"**Example List Floating Ip Addresses: JSON response**"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"5a9d85d2_4b3da1ba","line":53,"range":{"start_line":53,"start_character":9,"end_line":53,"end_character":11},"updated":"2016-06-21 02:39:32.000000000","message":"this also need to define new one. This should be floating ip address and required one","commit_id":"00e73a89416fec647def7d8b6bde8af6c4cf6874"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"dfa290ada64b2ffe9e54dff4cc4dfe404291315e","unresolved":false,"context_lines":[{"line_number":51,"context_line":"  - id : id"},{"line_number":52,"context_line":"  - instance_id : instance_id"},{"line_number":53,"context_line":"  - ip : ip"},{"line_number":54,"context_line":"  - pool: pool"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"**Example List Floating Ip Addresses: JSON response**"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":2,"id":"5a9d85d2_4babe1d6","line":54,"range":{"start_line":54,"start_character":10,"end_line":54,"end_character":14},"updated":"2016-06-21 02:39:32.000000000","message":"this should be pool from which floating ip has been created.\ncurrent description seems like for POST one","commit_id":"00e73a89416fec647def7d8b6bde8af6c4cf6874"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"dfa290ada64b2ffe9e54dff4cc4dfe404291315e","unresolved":false,"context_lines":[{"line_number":92,"context_line":"Response"},{"line_number":93,"context_line":"--------"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"  - fixed_ip : fixed_ip"},{"line_number":98,"context_line":"  - id : id"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"5a9d85d2_2bf495f0","line":95,"range":{"start_line":95,"start_character":35,"end_line":95,"end_character":36},"updated":"2016-06-21 02:39:32.000000000","message":"also need floating_ip in response as outer object","commit_id":"00e73a89416fec647def7d8b6bde8af6c4cf6874"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"dfa290ada64b2ffe9e54dff4cc4dfe404291315e","unresolved":false,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"  - fixed_ip : fixed_ip"},{"line_number":98,"context_line":"  - id : id"},{"line_number":99,"context_line":"  - instance_id : instance_id"},{"line_number":100,"context_line":"  - ip : ip"},{"line_number":101,"context_line":"  - pool: pool"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"**Example Create (Allocate) Floating Ip Address: JSON response**"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":2,"id":"5a9d85d2_ebe9ed1b","line":101,"range":{"start_line":97,"start_character":0,"end_line":101,"end_character":14},"updated":"2016-06-21 02:39:32.000000000","message":"ditto","commit_id":"00e73a89416fec647def7d8b6bde8af6c4cf6874"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"dfa290ada64b2ffe9e54dff4cc4dfe404291315e","unresolved":false,"context_lines":[{"line_number":132,"context_line":""},{"line_number":133,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"  - fixed_ip : fixed_ip"},{"line_number":136,"context_line":"  - id : id"},{"line_number":137,"context_line":"  - instance_id : instance_id"},{"line_number":138,"context_line":"  - ip : ip"},{"line_number":139,"context_line":"  - pool: pool"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"**Example Show Floating Ip Address Details: JSON response**"},{"line_number":142,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":2,"id":"5a9d85d2_0bf719f6","line":139,"range":{"start_line":135,"start_character":0,"end_line":139,"end_character":14},"updated":"2016-06-21 02:39:32.000000000","message":"ditto","commit_id":"00e73a89416fec647def7d8b6bde8af6c4cf6874"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7923d83557ee3dd1b040fbaa7e2982728c9154db","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"  - floating_ips: floating_ips"},{"line_number":51,"context_line":"  - fixed_ip : fixed_ip_address"},{"line_number":52,"context_line":"  - id : floating_ip_id_value"},{"line_number":53,"context_line":"  - instance_id : server_id"}],"source_content_type":"text/x-c++src","patch_set":7,"id":"3aaa91ec_f4be13d3","line":50,"range":{"start_line":50,"start_character":18,"end_line":50,"end_character":30},"updated":"2016-06-22 02:32:56.000000000","message":"this is array of objects. in parameter.yaml it is defined as \n\"The number of allowed floating IP addresses for each tenant.\" which does not fit here. you can define new one like below-\n\nfloating_ips_list:\n  description: |\n    An array of Floating ips objects.\n  in: body\n  required: true\n  type: array","commit_id":"53b836efcc427dbf6ba19e4eaad618a1d99db41c"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7923d83557ee3dd1b040fbaa7e2982728c9154db","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"  - floating_ips: floating_ips"},{"line_number":100,"context_line":"  - fixed_ip : fixed_ip_address"},{"line_number":101,"context_line":"  - id : floating_ip_id_value"},{"line_number":102,"context_line":"  - instance_id : server_id"}],"source_content_type":"text/x-c++src","patch_set":7,"id":"3aaa91ec_946d0f35","line":99,"range":{"start_line":99,"start_character":4,"end_line":99,"end_character":16},"updated":"2016-06-22 02:32:56.000000000","message":"-\u003e floating_ip","commit_id":"53b836efcc427dbf6ba19e4eaad618a1d99db41c"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7923d83557ee3dd1b040fbaa7e2982728c9154db","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"  - floating_ips: floating_ips"},{"line_number":100,"context_line":"  - fixed_ip : fixed_ip_address"},{"line_number":101,"context_line":"  - id : floating_ip_id_value"},{"line_number":102,"context_line":"  - instance_id : server_id"}],"source_content_type":"text/x-c++src","patch_set":7,"id":"3aaa91ec_545a8784","line":99,"range":{"start_line":99,"start_character":18,"end_line":99,"end_character":30},"updated":"2016-06-22 02:32:56.000000000","message":"this should be defined as new one like below\n\n-floating_ip_obj:\n  description: |\n    A Floating IP address object.\n  in: body\n  required: true\n  type: object","commit_id":"53b836efcc427dbf6ba19e4eaad618a1d99db41c"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7923d83557ee3dd1b040fbaa7e2982728c9154db","unresolved":false,"context_lines":[{"line_number":134,"context_line":"Response"},{"line_number":135,"context_line":"--------"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"  - fixed_ip : fixed_ip_address"},{"line_number":140,"context_line":"  - id : floating_ip_id_value"}],"source_content_type":"text/x-c++src","patch_set":7,"id":"3aaa91ec_94db4fed","line":137,"range":{"start_line":137,"start_character":35,"end_line":137,"end_character":36},"updated":"2016-06-22 02:32:56.000000000","message":"here also we need outer object\n- floating_ip\n\nsame as create API\n\nref-  https://github.com/openstack/nova/blob/master/nova/tests/functional/api_sample_tests/api_samples/os-floating-ips/floating-ips-get-resp.json.tpl#L2","commit_id":"53b836efcc427dbf6ba19e4eaad618a1d99db41c"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"4fc69cd60620d722313edefae34ae683da9ea58a","unresolved":false,"context_lines":[{"line_number":166,"context_line":"Normal response codes: 202"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"Error response codes: badRequest(400), unauthorized(401), forbidden(403),"},{"line_number":169,"context_line":" itemNotFound(404), conflict(409)"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"Request"},{"line_number":172,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":9,"id":"3aaa91ec_11c38639","line":169,"range":{"start_line":169,"start_character":0,"end_line":169,"end_character":1},"updated":"2016-06-23 16:02:16.000000000","message":"nit: this space is not needed.  It is line breaking at an odd spot.","commit_id":"f1c901e3071a9d5f70f826cc07d8e581618d5c4e"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"bceb6767d8275e423692c0947345971b0beae323","unresolved":false,"context_lines":[{"line_number":1,"context_line":".. -*- rst -*-"},{"line_number":2,"context_line":".. needs:parameter_verification"},{"line_number":3,"context_line":".. needs:example_verification"},{"line_number":4,"context_line":".. needs:body_verification"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-c++src","patch_set":11,"id":"1aa78d24_71c0437d","side":"PARENT","line":3,"range":{"start_line":3,"start_character":0,"end_line":3,"end_character":29},"updated":"2016-07-05 06:52:03.000000000","message":"The value of \u0027id\u0027 is integer in the following sample files.\nThey should be changed to string.\n\n* floating-ips-create-resp.json\n* floating-ips-get-resp.json\n* floating-ips-list-resp.json","commit_id":"4fee0f0dc6cf0e27daf75386487fe4b1bc589ffd"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"41b5bfc948f064dbe121a0a6de4205acb2c6b6e2","unresolved":false,"context_lines":[{"line_number":56,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"  - floating_ips: floating_ips_list"},{"line_number":59,"context_line":"  - fixed_ip : fixed_ip_address"},{"line_number":60,"context_line":"  - id : floating_ip_id_value"},{"line_number":61,"context_line":"  - instance_id : server_id"},{"line_number":62,"context_line":"  - ip : floating_ip"}],"source_content_type":"text/x-c++src","patch_set":13,"id":"9a89bdaa_406a5582","line":59,"range":{"start_line":59,"start_character":12,"end_line":59,"end_character":14},"updated":"2016-09-12 23:17:26.000000000","message":"Why do we need to put a space before :?\nI never see such descriptions at another places.","commit_id":"7102f3cb0b1d6e6ad333210249f3fe7f7d8ed8ff"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"41b5bfc948f064dbe121a0a6de4205acb2c6b6e2","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"  - floating_ips: floating_ips_list"},{"line_number":59,"context_line":"  - fixed_ip : fixed_ip_address"},{"line_number":60,"context_line":"  - id : floating_ip_id_value"},{"line_number":61,"context_line":"  - instance_id : server_id"},{"line_number":62,"context_line":"  - ip : floating_ip"},{"line_number":63,"context_line":"  - pool: floating_ip_pool_name"}],"source_content_type":"text/x-c++src","patch_set":13,"id":"9a89bdaa_802d3d48","line":60,"range":{"start_line":60,"start_character":6,"end_line":60,"end_character":8},"updated":"2016-09-12 23:17:26.000000000","message":"ditto","commit_id":"7102f3cb0b1d6e6ad333210249f3fe7f7d8ed8ff"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"41b5bfc948f064dbe121a0a6de4205acb2c6b6e2","unresolved":false,"context_lines":[{"line_number":58,"context_line":"  - floating_ips: floating_ips_list"},{"line_number":59,"context_line":"  - fixed_ip : fixed_ip_address"},{"line_number":60,"context_line":"  - id : floating_ip_id_value"},{"line_number":61,"context_line":"  - instance_id : server_id"},{"line_number":62,"context_line":"  - ip : floating_ip"},{"line_number":63,"context_line":"  - pool: floating_ip_pool_name"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":13,"id":"9a89bdaa_4018951e","line":61,"range":{"start_line":61,"start_character":15,"end_line":61,"end_character":17},"updated":"2016-09-12 23:17:26.000000000","message":"ditto","commit_id":"7102f3cb0b1d6e6ad333210249f3fe7f7d8ed8ff"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"41b5bfc948f064dbe121a0a6de4205acb2c6b6e2","unresolved":false,"context_lines":[{"line_number":59,"context_line":"  - fixed_ip : fixed_ip_address"},{"line_number":60,"context_line":"  - id : floating_ip_id_value"},{"line_number":61,"context_line":"  - instance_id : server_id"},{"line_number":62,"context_line":"  - ip : floating_ip"},{"line_number":63,"context_line":"  - pool: floating_ip_pool_name"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"**Example List Floating Ip Addresses: JSON response**"}],"source_content_type":"text/x-c++src","patch_set":13,"id":"9a89bdaa_80d45d20","line":62,"range":{"start_line":62,"start_character":6,"end_line":62,"end_character":8},"updated":"2016-09-12 23:17:26.000000000","message":"ditto","commit_id":"7102f3cb0b1d6e6ad333210249f3fe7f7d8ed8ff"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"83bbe7b823c642f55348a7a1f10d083f08449829","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"  - floating_ips: floating_ips_list"},{"line_number":59,"context_line":"  - fixed_ip: fixed_ip_address"},{"line_number":60,"context_line":"  - id: floating_ip_id_value"},{"line_number":61,"context_line":"  - instance_id: server_id"},{"line_number":62,"context_line":"  - ip: floating_ip"},{"line_number":63,"context_line":"  - pool: floating_ip_pool_name"}],"source_content_type":"text/x-c++src","patch_set":14,"id":"7a8ec9b2_aee2cad2","line":60,"updated":"2016-09-19 11:47:11.000000000","message":"I think we should be clearer this is an integer when using nova-network and a string when using neutron.","commit_id":"14d4f61b3723c5ae9fe25cb8cebaa84b9a7d8ef7"},{"author":{"_account_id":21111,"name":"STEW TY","email":"punsoca@gmail.com","username":"stewie925"},"change_message_id":"86a31303e2841fc9361e569e92478c0220a6220a","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"  - floating_ips: floating_ips_list"},{"line_number":59,"context_line":"  - fixed_ip: fixed_ip_address"},{"line_number":60,"context_line":"  - id: floating_ip_id_value"},{"line_number":61,"context_line":"  - instance_id: server_id"},{"line_number":62,"context_line":"  - ip: floating_ip"},{"line_number":63,"context_line":"  - pool: floating_ip_pool_name"}],"source_content_type":"text/x-c++src","patch_set":15,"id":"5a8bc5a2_c6fd330a","line":60,"range":{"start_line":60,"start_character":2,"end_line":60,"end_character":28},"updated":"2016-09-27 20:30:53.000000000","message":"I will add a statement to clarify that the \"id\" value type is an integer for nova-net and string for neutron\n\nHowever, do I have to create two sets for this \"rest_parameters\" to show one with \"id: \u003cnetwork_id\u003e\" (nova-net)  and another with \"id: network_uuid\" (neutron)?  If Im not mistaken, the parameter field can be of only a single type (can either be integer or string, but not both).   Please advise.","commit_id":"fc52e9ed7d665eddf1d92a3f918318763a219f65"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"f0024613d907ae3e84f223f99791885b264f9fcf","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"  - floating_ips: floating_ips_list"},{"line_number":59,"context_line":"  - fixed_ip: fixed_ip_address"},{"line_number":60,"context_line":"  - id: floating_ip_id_value"},{"line_number":61,"context_line":"  - instance_id: server_id"},{"line_number":62,"context_line":"  - ip: floating_ip"},{"line_number":63,"context_line":"  - pool: floating_ip_pool_name"}],"source_content_type":"text/x-c++src","patch_set":15,"id":"5a8bc5a2_10cc1169","line":60,"updated":"2016-09-26 13:35:23.000000000","message":"See previous patchset comments.","commit_id":"fc52e9ed7d665eddf1d92a3f918318763a219f65"},{"author":{"_account_id":21111,"name":"STEW TY","email":"punsoca@gmail.com","username":"stewie925"},"change_message_id":"86a31303e2841fc9361e569e92478c0220a6220a","unresolved":false,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":"  - floating_ip: floating_ip_obj"},{"line_number":108,"context_line":"  - fixed_ip: fixed_ip_address"},{"line_number":109,"context_line":"  - id: floating_ip_id_value"},{"line_number":110,"context_line":"  - instance_id: server_id"},{"line_number":111,"context_line":"  - ip: floating_ip"},{"line_number":112,"context_line":"  - pool: floating_ip_pool_name"}],"source_content_type":"text/x-c++src","patch_set":15,"id":"5a8bc5a2_260df737","line":109,"range":{"start_line":109,"start_character":0,"end_line":109,"end_character":28},"updated":"2016-09-27 20:30:53.000000000","message":"Ditto","commit_id":"fc52e9ed7d665eddf1d92a3f918318763a219f65"},{"author":{"_account_id":21111,"name":"STEW TY","email":"punsoca@gmail.com","username":"stewie925"},"change_message_id":"86a31303e2841fc9361e569e92478c0220a6220a","unresolved":false,"context_lines":[{"line_number":146,"context_line":""},{"line_number":147,"context_line":"  - floating-ip: floating_ip_obj"},{"line_number":148,"context_line":"  - fixed_ip: fixed_ip_address"},{"line_number":149,"context_line":"  - id: floating_ip_id_value"},{"line_number":150,"context_line":"  - instance_id: server_id"},{"line_number":151,"context_line":"  - ip: floating_ip"},{"line_number":152,"context_line":"  - pool: floating_ip_pool_name"}],"source_content_type":"text/x-c++src","patch_set":15,"id":"5a8bc5a2_660fff2e","line":149,"range":{"start_line":149,"start_character":0,"end_line":149,"end_character":28},"updated":"2016-09-27 20:30:53.000000000","message":"Ditto","commit_id":"fc52e9ed7d665eddf1d92a3f918318763a219f65"},{"author":{"_account_id":21111,"name":"STEW TY","email":"punsoca@gmail.com","username":"stewie925"},"change_message_id":"e574a292470dd31d19ac21dd5a43f2ca50b75c28","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"  - floating_ips: floating_ips_list"},{"line_number":59,"context_line":"  - fixed_ip: fixed_ip_address"},{"line_number":60,"context_line":"  - id: floating_ip_id_value"},{"line_number":61,"context_line":"  - instance_id: server_id"},{"line_number":62,"context_line":"  - ip: floating_ip"},{"line_number":63,"context_line":"  - pool: floating_ip_pool_name"}],"source_content_type":"text/x-c++src","patch_set":17,"id":"3a98d1f4_e2b1db90","line":60,"range":{"start_line":60,"start_character":0,"end_line":60,"end_character":28},"updated":"2016-09-30 00:42:03.000000000","message":"in Patch 14, John mentioned to leave a statement to clarify that the \"id\" value type would be an integer when using nova-network and a string when using neutron.  I thought I\u0027d put that statement inside the description of the floating_ip_id field in the parameters.yaml instead.","commit_id":"9624b40773724336c9d98adce539fb604763a4d5"},{"author":{"_account_id":15293,"name":"Karen Bradshaw","email":"kbhawkey@gmail.com","username":"karenb"},"change_message_id":"3c69ca1fc17ae271cfb38ae2c4d1e9be55ebf9c2","unresolved":false,"context_lines":[{"line_number":11,"context_line":"   instead."},{"line_number":12,"context_line":"   See: `Relevant Network APIs"},{"line_number":13,"context_line":"   \u003chttp://developer.openstack.org/api-ref-networking-v2-ext.html#layer3-ext\u003e`__."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Lists floating IP addresses for a project. Also, creates (allocates) a"},{"line_number":16,"context_line":"floating IP address for a project, shows floating IP address details,"},{"line_number":17,"context_line":"and deletes (deallocates) a floating IP address from a project."}],"source_content_type":"text/x-c++src","patch_set":18,"id":"3a98d1f4_8579baca","line":14,"updated":"2016-10-01 15:48:32.000000000","message":"Does this link work?","commit_id":"a1f02c14a5eb2cbcca549647f37f4b4960bb83a6"},{"author":{"_account_id":21111,"name":"STEW TY","email":"punsoca@gmail.com","username":"stewie925"},"change_message_id":"290832e523ab436e8aa6edd85dc240e7f9e17a6a","unresolved":false,"context_lines":[{"line_number":11,"context_line":"   instead."},{"line_number":12,"context_line":"   See: `Relevant Network APIs"},{"line_number":13,"context_line":"   \u003chttp://developer.openstack.org/api-ref-networking-v2-ext.html#layer3-ext\u003e`__."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Lists floating IP addresses for a project. Also, creates (allocates) a"},{"line_number":16,"context_line":"floating IP address for a project, shows floating IP address details,"},{"line_number":17,"context_line":"and deletes (deallocates) a floating IP address from a project."}],"source_content_type":"text/x-c++src","patch_set":18,"id":"3a98d1f4_ab573924","line":14,"in_reply_to":"3a98d1f4_8579baca","updated":"2016-10-04 01:26:19.000000000","message":"I\u0027ll update the link in the next patch.","commit_id":"a1f02c14a5eb2cbcca549647f37f4b4960bb83a6"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"2c8565a33a5606a417ebc7085b9c473a51729083","unresolved":false,"context_lines":[{"line_number":144,"context_line":""},{"line_number":145,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"  - floating-ip: floating_ip_obj"},{"line_number":148,"context_line":"  - fixed_ip: fixed_ip_address"},{"line_number":149,"context_line":"  - id: floating_ip_id_value"},{"line_number":150,"context_line":"  - instance_id: server_id"}],"source_content_type":"text/x-c++src","patch_set":18,"id":"fa6399be_2d12a257","line":147,"range":{"start_line":147,"start_character":4,"end_line":147,"end_character":15},"updated":"2016-10-13 23:03:46.000000000","message":"s/floating-ip/floating_ip/","commit_id":"a1f02c14a5eb2cbcca549647f37f4b4960bb83a6"},{"author":{"_account_id":21111,"name":"STEW TY","email":"punsoca@gmail.com","username":"stewie925"},"change_message_id":"01af984fb300944fa07a90e413cefabc6742272a","unresolved":false,"context_lines":[{"line_number":24,"context_line":"for a project, you can:"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"-  `Add (associate) the floating IP"},{"line_number":27,"context_line":"   address \u003chttp://developer.openstack.org/api-ref/compute/#create-allocate-floating-ip-address\u003e`__"},{"line_number":28,"context_line":"   with an instance in the project. You can associate only one floating"},{"line_number":29,"context_line":"   IP address with an instance at a time."},{"line_number":30,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":20,"id":"fa6399be_7ee83717","line":27,"range":{"start_line":27,"start_character":12,"end_line":27,"end_character":95},"updated":"2016-10-18 15:37:36.000000000","message":"OK I see your point now - I\u0027ll update this link to point to the actual API method.","commit_id":"92bbfac60ed342edf9f7602972747de74647d183"},{"author":{"_account_id":15293,"name":"Karen Bradshaw","email":"kbhawkey@gmail.com","username":"karenb"},"change_message_id":"93b8d04c536f3cbdce0d3ffd00bcc585a94bd99b","unresolved":false,"context_lines":[{"line_number":27,"context_line":"   address \u003chttp://developer.openstack.org/api-ref/compute/#create-allocate-floating-ip-address\u003e`__"},{"line_number":28,"context_line":"   with an instance in the project. You can associate only one floating"},{"line_number":29,"context_line":"   IP address with an instance at a time."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"-  `Remove (disassociate) the floating IP"},{"line_number":32,"context_line":"   address \u003chttp://developer.openstack.org/api-ref/compute/#delete-deallocate-floating-ip-address\u003e`__"},{"line_number":33,"context_line":"   from an instance in the project."}],"source_content_type":"text/x-c++src","patch_set":20,"id":"fa6399be_62b8ea75","line":30,"updated":"2016-10-16 15:18:53.000000000","message":"Not sure these links add much value here as the links drop the user to a few lines below.","commit_id":"92bbfac60ed342edf9f7602972747de74647d183"},{"author":{"_account_id":21111,"name":"STEW TY","email":"punsoca@gmail.com","username":"stewie925"},"change_message_id":"881fd907da71dc8a0b8475cc9f172366d5cae3df","unresolved":false,"context_lines":[{"line_number":27,"context_line":"   address \u003chttp://developer.openstack.org/api-ref/compute/#create-allocate-floating-ip-address\u003e`__"},{"line_number":28,"context_line":"   with an instance in the project. You can associate only one floating"},{"line_number":29,"context_line":"   IP address with an instance at a time."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"-  `Remove (disassociate) the floating IP"},{"line_number":32,"context_line":"   address \u003chttp://developer.openstack.org/api-ref/compute/#delete-deallocate-floating-ip-address\u003e`__"},{"line_number":33,"context_line":"   from an instance in the project."}],"source_content_type":"text/x-c++src","patch_set":20,"id":"fa6399be_aedbaf20","line":30,"in_reply_to":"fa6399be_62b8ea75","updated":"2016-10-17 15:19:30.000000000","message":"These are additional information so I believe it\u0027s best to leave them in here.","commit_id":"92bbfac60ed342edf9f7602972747de74647d183"},{"author":{"_account_id":15293,"name":"Karen Bradshaw","email":"kbhawkey@gmail.com","username":"karenb"},"change_message_id":"793f4177fed5ab4de0f5aa58da999c94987bc6ef","unresolved":false,"context_lines":[{"line_number":27,"context_line":"   address \u003chttp://developer.openstack.org/api-ref/compute/#create-allocate-floating-ip-address\u003e`__"},{"line_number":28,"context_line":"   with an instance in the project. You can associate only one floating"},{"line_number":29,"context_line":"   IP address with an instance at a time."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"-  `Remove (disassociate) the floating IP"},{"line_number":32,"context_line":"   address \u003chttp://developer.openstack.org/api-ref/compute/#delete-deallocate-floating-ip-address\u003e`__"},{"line_number":33,"context_line":"   from an instance in the project."}],"source_content_type":"text/x-c++src","patch_set":20,"id":"fa6399be_82b853e7","line":30,"in_reply_to":"fa6399be_aedbaf20","updated":"2016-10-18 13:19:32.000000000","message":"Yes, the information is good as long as the reader can match the description to the actual API method. The links would be more useful if they took the reader to a place in the doc outside of this section, otherwise, the link just drops the view slightly below in the section not to the specific method.","commit_id":"92bbfac60ed342edf9f7602972747de74647d183"},{"author":{"_account_id":21111,"name":"STEW TY","email":"punsoca@gmail.com","username":"stewie925"},"change_message_id":"01af984fb300944fa07a90e413cefabc6742272a","unresolved":false,"context_lines":[{"line_number":29,"context_line":"   IP address with an instance at a time."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"-  `Remove (disassociate) the floating IP"},{"line_number":32,"context_line":"   address \u003chttp://developer.openstack.org/api-ref/compute/#delete-deallocate-floating-ip-address\u003e`__"},{"line_number":33,"context_line":"   from an instance in the project."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"-  Delete, or deallocate, a floating IP from the project, which"}],"source_content_type":"text/x-c++src","patch_set":20,"id":"fa6399be_bec9efae","line":32,"range":{"start_line":32,"start_character":12,"end_line":32,"end_character":97},"updated":"2016-10-18 15:37:36.000000000","message":"I will update this as well to point directly to its corresponding API method.","commit_id":"92bbfac60ed342edf9f7602972747de74647d183"},{"author":{"_account_id":15293,"name":"Karen Bradshaw","email":"kbhawkey@gmail.com","username":"karenb"},"change_message_id":"93b8d04c536f3cbdce0d3ffd00bcc585a94bd99b","unresolved":false,"context_lines":[{"line_number":93,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"  - pool: pool"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"**Example Create (Allocate) Floating Ip Address: JSON request**"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":".. literalinclude:: ../../doc/api_samples/os-floating-ips/floating-ips-create-req.json"}],"source_content_type":"text/x-c++src","patch_set":20,"id":"fa6399be_02664e29","line":96,"updated":"2016-10-16 15:18:53.000000000","message":"Is there a reason to use the pool key here instead of the floating_ip_pool_name. The descriptions are different.","commit_id":"92bbfac60ed342edf9f7602972747de74647d183"},{"author":{"_account_id":21111,"name":"STEW TY","email":"punsoca@gmail.com","username":"stewie925"},"change_message_id":"881fd907da71dc8a0b8475cc9f172366d5cae3df","unresolved":false,"context_lines":[{"line_number":93,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"  - pool: pool"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"**Example Create (Allocate) Floating Ip Address: JSON request**"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":".. literalinclude:: ../../doc/api_samples/os-floating-ips/floating-ips-create-req.json"}],"source_content_type":"text/x-c++src","patch_set":20,"id":"fa6399be_0ea9fbdf","line":96,"in_reply_to":"fa6399be_02664e29","updated":"2016-10-17 15:19:30.000000000","message":"fixed.","commit_id":"92bbfac60ed342edf9f7602972747de74647d183"},{"author":{"_account_id":15293,"name":"Karen Bradshaw","email":"kbhawkey@gmail.com","username":"karenb"},"change_message_id":"93b8d04c536f3cbdce0d3ffd00bcc585a94bd99b","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"**Example Create (Allocate) Floating Ip Address: JSON request**"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":".. literalinclude:: ../../doc/api_samples/os-floating-ips/floating-ips-create-req.json"},{"line_number":100,"context_line":"   :language: javascript"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"Response"}],"source_content_type":"text/x-c++src","patch_set":20,"id":"fa6399be_827a5ebb","line":99,"updated":"2016-10-16 15:18:53.000000000","message":"Do we want to standardize the Example title string by removing the JSON request/JSON response text?","commit_id":"92bbfac60ed342edf9f7602972747de74647d183"},{"author":{"_account_id":15293,"name":"Karen Bradshaw","email":"kbhawkey@gmail.com","username":"karenb"},"change_message_id":"793f4177fed5ab4de0f5aa58da999c94987bc6ef","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"**Example Create (Allocate) Floating Ip Address: JSON request**"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":".. literalinclude:: ../../doc/api_samples/os-floating-ips/floating-ips-create-req.json"},{"line_number":100,"context_line":"   :language: javascript"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"Response"}],"source_content_type":"text/x-c++src","patch_set":20,"id":"fa6399be_a225570b","line":99,"in_reply_to":"fa6399be_4e9f7350","updated":"2016-10-18 13:19:32.000000000","message":"I understand your point, though, I think the nova api ref needs to be consistent, one way or the other. I don\u0027t think you need the JSON attribute as all request and response in nova is JSON, right?","commit_id":"92bbfac60ed342edf9f7602972747de74647d183"},{"author":{"_account_id":15293,"name":"Karen Bradshaw","email":"kbhawkey@gmail.com","username":"karenb"},"change_message_id":"793f4177fed5ab4de0f5aa58da999c94987bc6ef","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"**Example Create (Allocate) Floating Ip Address: JSON request**"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":".. literalinclude:: ../../doc/api_samples/os-floating-ips/floating-ips-create-req.json"},{"line_number":100,"context_line":"   :language: javascript"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"Response"}],"source_content_type":"text/x-c++src","patch_set":20,"id":"fa6399be_22a067a5","line":99,"in_reply_to":"fa6399be_827a5ebb","updated":"2016-10-18 13:19:32.000000000","message":"Done","commit_id":"92bbfac60ed342edf9f7602972747de74647d183"},{"author":{"_account_id":21111,"name":"STEW TY","email":"punsoca@gmail.com","username":"stewie925"},"change_message_id":"881fd907da71dc8a0b8475cc9f172366d5cae3df","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"**Example Create (Allocate) Floating Ip Address: JSON request**"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":".. literalinclude:: ../../doc/api_samples/os-floating-ips/floating-ips-create-req.json"},{"line_number":100,"context_line":"   :language: javascript"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"Response"}],"source_content_type":"text/x-c++src","patch_set":20,"id":"fa6399be_4e9f7350","line":99,"in_reply_to":"fa6399be_827a5ebb","updated":"2016-10-17 15:19:30.000000000","message":"I\u0027ve been looking at the committed/merged api-ref items and I see that they all got the \u0027JSON request/ JSON response\u0027 wording in the Example title so I decide to leave them as is.","commit_id":"92bbfac60ed342edf9f7602972747de74647d183"},{"author":{"_account_id":21111,"name":"STEW TY","email":"punsoca@gmail.com","username":"stewie925"},"change_message_id":"223a77a991c98b15639ad142bed88b0bcd0c02ee","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"**Example Create (Allocate) Floating Ip Address: JSON request**"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":".. literalinclude:: ../../doc/api_samples/os-floating-ips/floating-ips-create-req.json"},{"line_number":100,"context_line":"   :language: javascript"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"Response"}],"source_content_type":"text/x-c++src","patch_set":20,"id":"7a77a97e_f3228000","line":99,"in_reply_to":"fa6399be_a225570b","updated":"2016-11-16 18:22:34.000000000","message":"Done. Please review latest patch (patch #23 as of 2016/11/16).","commit_id":"92bbfac60ed342edf9f7602972747de74647d183"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"0a5ad5ad7be03d78412d09db1502b9b8b7959d28","unresolved":false,"context_lines":[{"line_number":174,"context_line":"Normal response codes: 202"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"Error response codes: badRequest(400), unauthorized(401), forbidden(403),"},{"line_number":177,"context_line":" itemNotFound(404), conflict(409)"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"Request"},{"line_number":180,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":23,"id":"7a77a97e_74930450","line":177,"range":{"start_line":177,"start_character":18,"end_line":177,"end_character":33},"updated":"2016-11-21 21:31:14.000000000","message":"I checked all response code, and I found this status code(409) is not returned actually. So it is necessary to remove this.\n\nref: https://review.openstack.org/#/c/400413/","commit_id":"2352b4e673f6e8075604e2a6eacb139543334f76"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"7f298f239c5f869da64ae11eec4a518de1063571","unresolved":false,"context_lines":[{"line_number":174,"context_line":"Normal response codes: 202"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"Error response codes: badRequest(400), unauthorized(401), forbidden(403),"},{"line_number":177,"context_line":" itemNotFound(404)"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"Request"},{"line_number":180,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":24,"id":"7a77a97e_eb33aaf4","line":177,"updated":"2016-11-22 02:32:15.000000000","message":"Actually we have 409, but it hide deep into the code https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/floating_ips.py#L92","commit_id":"2ecbbd8d432e323edaf34dda7302edd3d2539453"}],"api-ref/source/parameters.yaml":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7923d83557ee3dd1b040fbaa7e2982728c9154db","unresolved":false,"context_lines":[{"line_number":1526,"context_line":"  type: string"},{"line_number":1527,"context_line":"floating_ip_id_value:"},{"line_number":1528,"context_line":"  description: |"},{"line_number":1529,"context_line":"    The floating ip od value returned in response body."},{"line_number":1530,"context_line":"  in: body"},{"line_number":1531,"context_line":"  required: true"},{"line_number":1532,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3aaa91ec_148f5f24","line":1529,"range":{"start_line":1529,"start_character":20,"end_line":1529,"end_character":22},"updated":"2016-06-22 02:32:56.000000000","message":"id","commit_id":"53b836efcc427dbf6ba19e4eaad618a1d99db41c"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"3a671d27822db4ad3bc73b954ea526a14f830de2","unresolved":false,"context_lines":[{"line_number":1526,"context_line":"  type: string"},{"line_number":1527,"context_line":"floating_ip_id_value:"},{"line_number":1528,"context_line":"  description: |"},{"line_number":1529,"context_line":"    The floating ip od value returned in response body."},{"line_number":1530,"context_line":"  in: body"},{"line_number":1531,"context_line":"  required: true"},{"line_number":1532,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3aaa91ec_c74e416e","line":1529,"range":{"start_line":1529,"start_character":20,"end_line":1529,"end_character":22},"updated":"2016-06-24 06:53:44.000000000","message":"-\u003eid","commit_id":"8af74de9ee2863409c5cde49c3bc1f59276f5b02"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"41b5bfc948f064dbe121a0a6de4205acb2c6b6e2","unresolved":false,"context_lines":[{"line_number":1801,"context_line":"  type: object"},{"line_number":1802,"context_line":"floating_ip_id_value:"},{"line_number":1803,"context_line":"  description: |"},{"line_number":1804,"context_line":"    The floating ip od value returned in response body."},{"line_number":1805,"context_line":"  in: body"},{"line_number":1806,"context_line":"  required: true"},{"line_number":1807,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"9a89bdaa_c07f4515","line":1804,"range":{"start_line":1804,"start_character":20,"end_line":1804,"end_character":22},"updated":"2016-09-12 23:17:26.000000000","message":"s/od/id/ ?","commit_id":"7102f3cb0b1d6e6ad333210249f3fe7f7d8ed8ff"},{"author":{"_account_id":15293,"name":"Karen Bradshaw","email":"kbhawkey@gmail.com","username":"karenb"},"change_message_id":"242b3930b1006e895e66cc88c6ed2ca9bc24c0b7","unresolved":false,"context_lines":[{"line_number":1802,"context_line":"floating_ip_id_value:"},{"line_number":1803,"context_line":"  description: |"},{"line_number":1804,"context_line":"    The floating ip ID value returned in response body.  For nova-network,"},{"line_number":1805,"context_line":"    the value will be of type integer, whereas for neutron it will be of"},{"line_number":1806,"context_line":"    type string."},{"line_number":1807,"context_line":"  in: body"},{"line_number":1808,"context_line":"  required: true"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"3a98d1f4_8a8f1a29","line":1805,"updated":"2016-09-30 19:10:39.000000000","message":"- To be consistent, use IP instead of ip.\n- Do you need \u0027returned in the response body\u0027?\n\nYou may want to add a .. note:: or warning directive to highlight the network change.","commit_id":"9624b40773724336c9d98adce539fb604763a4d5"},{"author":{"_account_id":15293,"name":"Karen Bradshaw","email":"kbhawkey@gmail.com","username":"karenb"},"change_message_id":"3c69ca1fc17ae271cfb38ae2c4d1e9be55ebf9c2","unresolved":false,"context_lines":[{"line_number":1804,"context_line":"    The floating IP id value."},{"line_number":1805,"context_line":""},{"line_number":1806,"context_line":"    .. note::"},{"line_number":1807,"context_line":""},{"line_number":1808,"context_line":"      For nova-network, the value will be of type integer, whereas for"},{"line_number":1809,"context_line":"      neutron, the value will be of type string."},{"line_number":1810,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"3a98d1f4_e5e0be98","line":1807,"updated":"2016-10-01 15:48:32.000000000","message":"Not to belabor the point, is there a reason to use one network svc versus the other?\n\nWould be good if all parameters used IP not ip? I think IP makes sense.","commit_id":"a1f02c14a5eb2cbcca549647f37f4b4960bb83a6"},{"author":{"_account_id":21111,"name":"STEW TY","email":"punsoca@gmail.com","username":"stewie925"},"change_message_id":"290832e523ab436e8aa6edd85dc240e7f9e17a6a","unresolved":false,"context_lines":[{"line_number":1804,"context_line":"    The floating IP id value."},{"line_number":1805,"context_line":""},{"line_number":1806,"context_line":"    .. note::"},{"line_number":1807,"context_line":""},{"line_number":1808,"context_line":"      For nova-network, the value will be of type integer, whereas for"},{"line_number":1809,"context_line":"      neutron, the value will be of type string."},{"line_number":1810,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"3a98d1f4_2e6df7cb","line":1807,"in_reply_to":"3a98d1f4_e5e0be98","updated":"2016-10-04 01:26:19.000000000","message":"on reason to use one network svc over the other:\n   Looking at Core Reviewer comment from https://review.openstack.org/#/c/329704/14/doc/api_samples/os-floating-ips/floating-ips-create-resp.json, \nit looks like we are still able to add floating-ip via nova network or via neutron.  \n\n\nusing IP not ip:\nI am following the pattern currently in this yaml file where all parameter names use \"ip\" in lowercase whereas the parameter descriptions use the uppercase \"IP\".","commit_id":"a1f02c14a5eb2cbcca549647f37f4b4960bb83a6"}],"doc/api_samples/os-floating-ips/floating-ips-create-resp.json":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"83bbe7b823c642f55348a7a1f10d083f08449829","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"floating_ip\": {"},{"line_number":3,"context_line":"        \"fixed_ip\": null,"},{"line_number":4,"context_line":"        \"id\": \"0e0b78c7-e5bf-454b-8bdd-b1266a01faf3\","},{"line_number":5,"context_line":"        \"instance_id\": null,"},{"line_number":6,"context_line":"        \"ip\": \"10.10.10.1\","},{"line_number":7,"context_line":"        \"pool\": \"nova\""}],"source_content_type":"application/json","patch_set":14,"id":"7a8ec9b2_2e707a71","line":4,"updated":"2016-09-19 11:47:11.000000000","message":"How was this sample updated? Was it updated using tox? It doesn\u0027t look that way, but I could be wrong.\n\nIt looks like this should be an integer and not a string, at least for the nova-network case:\nhttps://github.com/openstack/nova/blob/ceaacaa24fb50d484d4434915f3943fd9d97642a/nova/objects/floating_ip.py#L41\n\nAh, but it is a string in the Neutron case.\nhttps://github.com/openstack/nova/blob/ceaacaa24fb50d484d4434915f3943fd9d97642a/nova/objects/floating_ip.py#L240","commit_id":"14d4f61b3723c5ae9fe25cb8cebaa84b9a7d8ef7"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"f0024613d907ae3e84f223f99791885b264f9fcf","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"floating_ip\": {"},{"line_number":3,"context_line":"        \"fixed_ip\": null,"},{"line_number":4,"context_line":"        \"id\": \"0e0b78c7-e5bf-454b-8bdd-b1266a01faf3\","},{"line_number":5,"context_line":"        \"instance_id\": null,"},{"line_number":6,"context_line":"        \"ip\": \"10.10.10.1\","},{"line_number":7,"context_line":"        \"pool\": \"nova\""}],"source_content_type":"application/json","patch_set":15,"id":"5a8bc5a2_f0008568","line":4,"updated":"2016-09-26 13:35:23.000000000","message":"How did you generate these diffs? See previous comments in previous patchset.","commit_id":"fc52e9ed7d665eddf1d92a3f918318763a219f65"},{"author":{"_account_id":21111,"name":"STEW TY","email":"punsoca@gmail.com","username":"stewie925"},"change_message_id":"86a31303e2841fc9361e569e92478c0220a6220a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"floating_ip\": {"},{"line_number":3,"context_line":"        \"fixed_ip\": null,"},{"line_number":4,"context_line":"        \"id\": \"0e0b78c7-e5bf-454b-8bdd-b1266a01faf3\","},{"line_number":5,"context_line":"        \"instance_id\": null,"},{"line_number":6,"context_line":"        \"ip\": \"10.10.10.1\","},{"line_number":7,"context_line":"        \"pool\": \"nova\""}],"source_content_type":"application/json","patch_set":15,"id":"5a8bc5a2_ccbd57d9","line":4,"in_reply_to":"5a8bc5a2_f0008568","updated":"2016-09-27 20:30:53.000000000","message":"(Input requested for second paragraph):\n\nI incorrectly tested this with neutron thus the id showed the network UUID instead of the network ID (integer value) for nova-network.  I will rollback the changes for this response json in the next patch.  Thank you.\n\nSpeaking of neutron / nova-network versions... this looks similar to the discussion notes in https://review.openstack.org/#/c/338606/8/doc/api_samples/os-multinic/multinic-add-fixed-ip-req.json.    Matt had suggested to create two api-sample versions for the fixed ip jsons  (one showing \"id\" as integer for nova, and the other showing \"id\" as the \"network UUID\" for neutron. Please advise if we should create another api-sample for neutron (showing \"id\":\u003cnetwork uuid\u003e for the floating-ip json as well?","commit_id":"fc52e9ed7d665eddf1d92a3f918318763a219f65"}],"doc/api_samples/os-floating-ips/floating-ips-get-resp.json":[{"author":{"_account_id":21111,"name":"STEW TY","email":"punsoca@gmail.com","username":"stewie925"},"change_message_id":"86a31303e2841fc9361e569e92478c0220a6220a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"floating_ip\": {"},{"line_number":3,"context_line":"        \"fixed_ip\": null,"},{"line_number":4,"context_line":"        \"id\": \"0e0b78c7-e5bf-454b-8bdd-b1266a01faf3\","},{"line_number":5,"context_line":"        \"instance_id\": null,"},{"line_number":6,"context_line":"        \"ip\": \"10.10.10.1\","},{"line_number":7,"context_line":"        \"pool\": \"nova\""}],"source_content_type":"application/json","patch_set":15,"id":"5a8bc5a2_92b52a33","line":4,"range":{"start_line":4,"start_character":14,"end_line":4,"end_character":53},"updated":"2016-09-27 20:30:53.000000000","message":"Will rollback this change as I tested this incorrectly with neutron and it should be an integer with nova-network.\n\nHowever, do I need to create another api-sample to show \"id\":\u003cnetwork UUID\u003e for neutron?","commit_id":"fc52e9ed7d665eddf1d92a3f918318763a219f65"}],"doc/api_samples/os-floating-ips/floating-ips-list-resp.json":[{"author":{"_account_id":21111,"name":"STEW TY","email":"punsoca@gmail.com","username":"stewie925"},"change_message_id":"86a31303e2841fc9361e569e92478c0220a6220a","unresolved":false,"context_lines":[{"line_number":2,"context_line":"    \"floating_ips\": ["},{"line_number":3,"context_line":"        {"},{"line_number":4,"context_line":"            \"fixed_ip\": null,"},{"line_number":5,"context_line":"            \"id\": \"0e0b78c7-e5bf-454b-8bdd-b1266a01faf3\","},{"line_number":6,"context_line":"            \"instance_id\": null,"},{"line_number":7,"context_line":"            \"ip\": \"10.10.10.1\","},{"line_number":8,"context_line":"            \"pool\": \"nova\""}],"source_content_type":"application/json","patch_set":15,"id":"5a8bc5a2_573b9438","line":5,"range":{"start_line":5,"start_character":18,"end_line":5,"end_character":57},"updated":"2016-09-27 20:30:53.000000000","message":"Will rollback this change as I tested this incorrectly with neutron and it should be an integer with nova-network.\n\nHowever, do I need to create another api-sample to show \"id\":\u003cnetwork UUID\u003e for neutron?","commit_id":"fc52e9ed7d665eddf1d92a3f918318763a219f65"},{"author":{"_account_id":21111,"name":"STEW TY","email":"punsoca@gmail.com","username":"stewie925"},"change_message_id":"86a31303e2841fc9361e569e92478c0220a6220a","unresolved":false,"context_lines":[{"line_number":9,"context_line":"        },"},{"line_number":10,"context_line":"        {"},{"line_number":11,"context_line":"            \"fixed_ip\": null,"},{"line_number":12,"context_line":"            \"id\": \"6cf6c060-abaf-44f3-a81f-03ace104f5e8\","},{"line_number":13,"context_line":"            \"instance_id\": null,"},{"line_number":14,"context_line":"            \"ip\": \"10.10.10.2\","},{"line_number":15,"context_line":"            \"pool\": \"nova\""}],"source_content_type":"application/json","patch_set":15,"id":"5a8bc5a2_d715e49b","line":12,"range":{"start_line":12,"start_character":19,"end_line":12,"end_character":57},"updated":"2016-09-27 20:30:53.000000000","message":"Ditto","commit_id":"fc52e9ed7d665eddf1d92a3f918318763a219f65"}]}