)]}'
{"nova/db/sqlalchemy/api_migrations/migrate_repo/versions/018_instance_groups.py":[{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"cd3a506ee3df97411353c23322aa732f8aaeae70","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        Column(\u0027created_at\u0027, DateTime),"},{"line_number":61,"context_line":"        Column(\u0027updated_at\u0027, DateTime),"},{"line_number":62,"context_line":"        Column(\u0027id\u0027, Integer, primary_key\u003dTrue, nullable\u003dFalse),"},{"line_number":63,"context_line":"        Column(\u0027instance_id\u0027, String(length\u003d255)),"},{"line_number":64,"context_line":"        Column(\u0027group_id\u0027, Integer, ForeignKey(\u0027instance_groups.id\u0027),"},{"line_number":65,"context_line":"               nullable\u003dFalse),"},{"line_number":66,"context_line":"        Index(\u0027instance_group_member_instance_idx\u0027, \u0027instance_id\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_4771bb0b","line":63,"updated":"2016-06-17 18:26:09.000000000","message":"When I saw this I got concerned that it was linked against the instance.id db column. Fortunately it\u0027s actually the uuid from what I can tell, but I think this should be named better to reflect that.\n\nIt\u0027s also worth considering a FK there.","commit_id":"b4a15856cea098ff09777d5a39ed4ebeb4b83ffe"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"a3abd263b63ff1227c549974c6603cf9931877c3","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        Column(\u0027created_at\u0027, DateTime),"},{"line_number":61,"context_line":"        Column(\u0027updated_at\u0027, DateTime),"},{"line_number":62,"context_line":"        Column(\u0027id\u0027, Integer, primary_key\u003dTrue, nullable\u003dFalse),"},{"line_number":63,"context_line":"        Column(\u0027instance_id\u0027, String(length\u003d255)),"},{"line_number":64,"context_line":"        Column(\u0027group_id\u0027, Integer, ForeignKey(\u0027instance_groups.id\u0027),"},{"line_number":65,"context_line":"               nullable\u003dFalse),"},{"line_number":66,"context_line":"        Index(\u0027instance_group_member_instance_idx\u0027, \u0027instance_id\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_6e395d41","line":63,"in_reply_to":"3aaa91ec_d3e9311c","updated":"2016-06-23 12:01:44.000000000","message":"Right. This came up a while back with something Mark was working on and we considered using the instance_mapping entries as a substitute for that. The uuid is there, and the mapping exists before the instance is created and will live as long as the instance does. So I think we can reasonably use that for foreign keys.","commit_id":"b4a15856cea098ff09777d5a39ed4ebeb4b83ffe"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"9a6345329232f73b95aaf8d471c0826bafcf3431","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        Column(\u0027created_at\u0027, DateTime),"},{"line_number":61,"context_line":"        Column(\u0027updated_at\u0027, DateTime),"},{"line_number":62,"context_line":"        Column(\u0027id\u0027, Integer, primary_key\u003dTrue, nullable\u003dFalse),"},{"line_number":63,"context_line":"        Column(\u0027instance_id\u0027, String(length\u003d255)),"},{"line_number":64,"context_line":"        Column(\u0027group_id\u0027, Integer, ForeignKey(\u0027instance_groups.id\u0027),"},{"line_number":65,"context_line":"               nullable\u003dFalse),"},{"line_number":66,"context_line":"        Index(\u0027instance_group_member_instance_idx\u0027, \u0027instance_id\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_d3e9311c","line":63,"in_reply_to":"7aa08908_4771bb0b","updated":"2016-06-23 00:05:24.000000000","message":"Agree that\u0027s a good idea. I tried to add a FK without realizing and instances are in the cell db, so we can\u0027t","commit_id":"b4a15856cea098ff09777d5a39ed4ebeb4b83ffe"}]}