)]}'
{"doc/notification_samples/instance-poweron-start.json":[{"author":{"_account_id":20158,"name":"Andy Hsiang","email":"yh418t@att.com","username":"yh418t"},"change_message_id":"c70f498f28c49ae311d636479d44dc56a33bed49","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"event_type\":\"instance.power_on.start\","},{"line_number":3,"context_line":"    \"payload\":{"},{"line_number":4,"context_line":"        \"nova_object.data\":{"},{"line_number":5,"context_line":"            \"architecture\":\"x86_64\","}],"source_content_type":"application/json","patch_set":3,"id":"7aa08908_327261b1","line":2,"range":{"start_line":2,"start_character":27,"end_line":2,"end_character":35},"updated":"2016-06-15 20:38:07.000000000","message":"newbie question here, is there a reason that it\u0027s power_on instead of poweron? does the sample file name need not match the event_type?","commit_id":"5e997c33500abfee7deafc2eb99eb213685831c7"},{"author":{"_account_id":20158,"name":"Andy Hsiang","email":"yh418t@att.com","username":"yh418t"},"change_message_id":"547d7c618a1869cd0b5c3e1012c6722f8e235d99","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"event_type\":\"instance.power_on.start\","},{"line_number":3,"context_line":"    \"payload\":{"},{"line_number":4,"context_line":"        \"nova_object.data\":{"},{"line_number":5,"context_line":"            \"architecture\":\"x86_64\","}],"source_content_type":"application/json","patch_set":3,"id":"7aa08908_b2f6518e","line":2,"range":{"start_line":2,"start_character":27,"end_line":2,"end_character":35},"in_reply_to":"7aa08908_327261b1","updated":"2016-06-15 20:48:15.000000000","message":"nvm, i found the list of legacy event type in code. :)","commit_id":"5e997c33500abfee7deafc2eb99eb213685831c7"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"87df3a388d089deb8ea2735d1bc6166703d68df5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"event_type\":\"instance.power_on.start\","},{"line_number":3,"context_line":"    \"payload\":{"},{"line_number":4,"context_line":"        \"nova_object.data\":{"},{"line_number":5,"context_line":"            \"architecture\":\"x86_64\","}],"source_content_type":"application/json","patch_set":3,"id":"7aa08908_46459a13","line":2,"range":{"start_line":2,"start_character":27,"end_line":2,"end_character":35},"in_reply_to":"7aa08908_b2f6518e","updated":"2016-06-16 09:02:48.000000000","message":"The event_type is correct. But your other point about a matching sample file name is valid. I agree that the file name shall be like instance-power_on-start.json","commit_id":"5e997c33500abfee7deafc2eb99eb213685831c7"}],"nova/notifications/objects/instance.py":[{"author":{"_account_id":20158,"name":"Andy Hsiang","email":"yh418t@att.com","username":"yh418t"},"change_message_id":"23c948f35dbaf91913ccf75b732dae377e005a8c","unresolved":false,"context_lines":[{"line_number":150,"context_line":""},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"@base.notification_sample(\u0027instance-power_on-start.json\u0027)"},{"line_number":153,"context_line":"@base.notification_sample(\u0027instance-power_on-end.json\u0027)"},{"line_number":154,"context_line":"@base.notification_sample(\u0027instance-delete-start.json\u0027)"},{"line_number":155,"context_line":"@base.notification_sample(\u0027instance-delete-end.json\u0027)"},{"line_number":156,"context_line":"# @base.notification_sample(\u0027instance-pause-start.json\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7aa08908_a89b2416","line":153,"updated":"2016-06-17 12:14:30.000000000","message":"these are included on line 164, 165.","commit_id":"53c271a41c4b107cc3f4c5ccec48397791f15da0"},{"author":{"_account_id":14762,"name":"Zhihai Song","email":"zhhsng@gmail.com","username":"ZhihaiSong"},"change_message_id":"d05f4fa6830d1066b0bcd756ad81379219f1f3a3","unresolved":false,"context_lines":[{"line_number":150,"context_line":""},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"@base.notification_sample(\u0027instance-power_on-start.json\u0027)"},{"line_number":153,"context_line":"@base.notification_sample(\u0027instance-power_on-end.json\u0027)"},{"line_number":154,"context_line":"@base.notification_sample(\u0027instance-delete-start.json\u0027)"},{"line_number":155,"context_line":"@base.notification_sample(\u0027instance-delete-end.json\u0027)"},{"line_number":156,"context_line":"# @base.notification_sample(\u0027instance-pause-start.json\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a9d85d2_2ba65510","line":153,"in_reply_to":"7aa08908_a89b2416","updated":"2016-06-21 02:39:01.000000000","message":"Done","commit_id":"53c271a41c4b107cc3f4c5ccec48397791f15da0"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"ae194d49b20cfd570d0bfecbb45b1b0af40028d6","unresolved":false,"context_lines":[{"line_number":149,"context_line":"        self.populate_schema(instance\u003dinstance)"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"@base.notification_sample(\u0027instance-power_on-start.json\u0027)"},{"line_number":153,"context_line":"@base.notification_sample(\u0027instance-power_on-end.json\u0027)"},{"line_number":154,"context_line":"@base.notification_sample(\u0027instance-delete-start.json\u0027)"},{"line_number":155,"context_line":"@base.notification_sample(\u0027instance-delete-end.json\u0027)"},{"line_number":156,"context_line":"# @base.notification_sample(\u0027instance-pause-start.json\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7aa08908_126ede2e","line":153,"range":{"start_line":152,"start_character":0,"end_line":153,"end_character":55},"updated":"2016-06-17 14:45:57.000000000","message":"Yeah, just remove the \u0027# \u0027 from that line as Andy suggested in patch set 6. This will help avoiding merge conflicts.","commit_id":"5728f1a927c9064ec7e46a178dfae76aea374324"},{"author":{"_account_id":14762,"name":"Zhihai Song","email":"zhhsng@gmail.com","username":"ZhihaiSong"},"change_message_id":"815043a3202a98aefe2f42951faa0d0a1c56f75f","unresolved":false,"context_lines":[{"line_number":149,"context_line":"        self.populate_schema(instance\u003dinstance)"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"@base.notification_sample(\u0027instance-power_on-start.json\u0027)"},{"line_number":153,"context_line":"@base.notification_sample(\u0027instance-power_on-end.json\u0027)"},{"line_number":154,"context_line":"@base.notification_sample(\u0027instance-delete-start.json\u0027)"},{"line_number":155,"context_line":"@base.notification_sample(\u0027instance-delete-end.json\u0027)"},{"line_number":156,"context_line":"# @base.notification_sample(\u0027instance-pause-start.json\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a9d85d2_4bd92183","line":153,"range":{"start_line":152,"start_character":0,"end_line":153,"end_character":55},"in_reply_to":"7aa08908_126ede2e","updated":"2016-06-21 02:38:44.000000000","message":"Done","commit_id":"5728f1a927c9064ec7e46a178dfae76aea374324"}],"nova/tests/functional/notification_sample_tests/test_instance.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"cc4ecd1500ab91b6a11ed2d33135624f54e93153","unresolved":false,"context_lines":[{"line_number":141,"context_line":"                                  [{\u0027port\u0027: NeutronFixture.port_1[\u0027id\u0027]}]})"},{"line_number":142,"context_line":"        self.api.post_server_action(server[\u0027id\u0027], {\u0027os-stop\u0027: {}})"},{"line_number":143,"context_line":"        self._wait_for_state_change(server, expected_status\u003d\u0027SHUTOFF\u0027)"},{"line_number":144,"context_line":"        self.api.post_server_action(server[\u0027id\u0027], {\u0027os-start\u0027: {}})"},{"line_number":145,"context_line":"        self._wait_for_state_change(server, expected_status\u003d\u0027ACTIVE\u0027)"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        self.assertEqual(2, len(fake_notifier.VERSIONED_NOTIFICATIONS))"}],"source_content_type":"text/x-python","patch_set":10,"id":"3aaa91ec_eecd8287","line":144,"range":{"start_line":144,"start_character":52,"end_line":144,"end_character":60},"updated":"2016-06-28 11:28:50.000000000","message":"hmm I wonder if instance-start-start would be \"better\" as it matches the API more. Although that ends up very confusing, lets stick with what we have here.","commit_id":"466b55aeb14e421060ec796bd6137714646c1a8a"}]}