)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"2917b71111bd22d85522fe99d3386b7c3d17848d","unresolved":false,"context_lines":[{"line_number":1558,"context_line":""},{"line_number":1559,"context_line":"    def _add_missing_dev_names(self, bdms, instance):"},{"line_number":1560,"context_line":"        for bdm in bdms:"},{"line_number":1561,"context_line":"            if bdm.device_name is not None:"},{"line_number":1562,"context_line":"                continue"},{"line_number":1563,"context_line":""},{"line_number":1564,"context_line":"            device_name \u003d self._get_device_name_for_instance(instance,"},{"line_number":1565,"context_line":"                                                             bdms, bdm)"},{"line_number":1566,"context_line":"            values \u003d {\u0027device_name\u0027: device_name}"},{"line_number":1567,"context_line":"            bdm.update(values)"},{"line_number":1568,"context_line":"            bdm.save()"},{"line_number":1569,"context_line":""},{"line_number":1570,"context_line":"    def _prep_block_device(self, context, instance, bdms,"},{"line_number":1571,"context_line":"                           do_check_attach\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_1140caa4","line":1568,"range":{"start_line":1561,"start_character":0,"end_line":1568,"end_character":22},"updated":"2016-06-28 22:27:19.000000000","message":"The following would also fit assuming you\u0027re using the continue to avoid having to further wrap the _get_device_name_for_instance call :\n\n\nif bdm.device_name is None:\n    dev \u003d self._get_device_name_for_instance(instance, bdms, bdm)\n    bdm.update({\u0027device_name\u0027: dev})\n    bdm.save()","commit_id":"9c49d74c56be2a62dd3c20d2154f493843fb22c1"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"900680505869133fe9879a715c556e5fd1cef15f","unresolved":false,"context_lines":[{"line_number":1558,"context_line":"                                                             bdms, bdm)"},{"line_number":1559,"context_line":"            values \u003d {\u0027device_name\u0027: device_name}"},{"line_number":1560,"context_line":"            bdm.update(values)"},{"line_number":1561,"context_line":"            bdm.save()"},{"line_number":1562,"context_line":""},{"line_number":1563,"context_line":"    def _prep_block_device(self, context, instance, bdms,"},{"line_number":1564,"context_line":"                           do_check_attach\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_d3cdc55e","line":1561,"updated":"2016-08-03 10:35:53.000000000","message":"This does add extra DB load, but it certainly seems safer to do it here. It could well be a bug.","commit_id":"27b15516ae2ab1a83cad2c41fdbe09c08cc75d88"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9d6f2bcc3e914678245a459851e0dd0594498cbe","unresolved":false,"context_lines":[{"line_number":1558,"context_line":"                                                             bdms, bdm)"},{"line_number":1559,"context_line":"            values \u003d {\u0027device_name\u0027: device_name}"},{"line_number":1560,"context_line":"            bdm.update(values)"},{"line_number":1561,"context_line":"            bdm.save()"},{"line_number":1562,"context_line":""},{"line_number":1563,"context_line":"    def _prep_block_device(self, context, instance, bdms,"},{"line_number":1564,"context_line":"                           do_check_attach\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_10bc616b","line":1561,"in_reply_to":"bacf61ea_d3cdc55e","updated":"2016-08-03 15:21:50.000000000","message":"driver_block_device.attach_block_devices would eventually call the save on the bdm, which was probably why it was originally omitted, but that\u0027s a guess. This doesn\u0027t hurt.","commit_id":"27b15516ae2ab1a83cad2c41fdbe09c08cc75d88"}]}