)]}'
{"nova/api/openstack/compute/disk_config.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f702444f317ff5f2c36150d72156b467f8f9bdea","unresolved":false,"context_lines":[{"line_number":25,"context_line":"authorize \u003d extensions.os_compute_soft_authorizer(ALIAS)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"def disk_config_to_api(value):"},{"line_number":29,"context_line":"    return \u0027AUTO\u0027 if value else \u0027MANUAL\u0027"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_d6c69115","line":28,"updated":"2016-06-21 18:52:23.000000000","message":"Why not move this to the view builder where it\u0027s used?","commit_id":"a759faab1c9bbabfdf3bfde2e7d74cb3c276956c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f702444f317ff5f2c36150d72156b467f8f9bdea","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    return \u0027AUTO\u0027 if value else \u0027MANUAL\u0027"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"def disk_config_from_api(value):"},{"line_number":33,"context_line":"    if value \u003d\u003d \u0027AUTO\u0027:"},{"line_number":34,"context_line":"        return True"},{"line_number":35,"context_line":"    elif value \u003d\u003d \u0027MANUAL\u0027:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_16d139ce","line":32,"updated":"2016-06-21 18:52:23.000000000","message":"Nor is this. When can we just drop this entire module?","commit_id":"a759faab1c9bbabfdf3bfde2e7d74cb3c276956c"}],"nova/api/openstack/compute/views/images.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c016e50f8add1d511b0c732d40c606600657dad5","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    _collection_name \u003d \"images\""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def basic(self, request, image):"},{"line_number":30,"context_line":"        \"\"\"Return a dictionary with basic image attributes.\"\"\""},{"line_number":31,"context_line":"        image_resp \u003d {"},{"line_number":32,"context_line":"            \"image\": {"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_cc2564af","line":29,"updated":"2016-06-21 19:08:39.000000000","message":"Do we actually want to modify this? This is used for listing images with basic attributes.\n\nhttps://review.openstack.org/#/c/330206/3/nova/api/openstack/compute/disk_config.py\n\nWas adding this info to show and listing images with details, which from what I\u0027m looking at below, \u0027detail\u0027 calls show, not \u0027basic\u0027.","commit_id":"a759faab1c9bbabfdf3bfde2e7d74cb3c276956c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f702444f317ff5f2c36150d72156b467f8f9bdea","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        }"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        auto_disk_config \u003d image.get("},{"line_number":42,"context_line":"            \"properties\", {}).get("},{"line_number":43,"context_line":"                \"auto_disk_config\", None)"},{"line_number":44,"context_line":"        if auto_disk_config is not None:"},{"line_number":45,"context_line":"            value \u003d strutils.bool_from_string(auto_disk_config)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_76a7dd4f","line":42,"range":{"start_line":42,"start_character":13,"end_line":42,"end_character":23},"updated":"2016-06-21 18:52:23.000000000","message":"metadata? I\u0027m guessing we\u0027re stubbing something out in tests incorrectly, or just not testing this.","commit_id":"a759faab1c9bbabfdf3bfde2e7d74cb3c276956c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c016e50f8add1d511b0c732d40c606600657dad5","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        }"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        auto_disk_config \u003d image.get("},{"line_number":42,"context_line":"            \"properties\", {}).get("},{"line_number":43,"context_line":"                \"auto_disk_config\", None)"},{"line_number":44,"context_line":"        if auto_disk_config is not None:"},{"line_number":45,"context_line":"            value \u003d strutils.bool_from_string(auto_disk_config)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_a9356af8","line":42,"range":{"start_line":42,"start_character":13,"end_line":42,"end_character":23},"in_reply_to":"3aaa91ec_76a7dd4f","updated":"2016-06-21 19:08:39.000000000","message":"Nevermind, sdague clarified. This is the image that we get back from the glance v2 image API. The image[\u0027metadata\u0027] that the os-disk-config extension was messing with was from the nova response, i.e. L57 below.","commit_id":"a759faab1c9bbabfdf3bfde2e7d74cb3c276956c"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"93b92564e9309b12d7c31541363ae80b20fdebd2","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        }"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        auto_disk_config \u003d image.get("},{"line_number":42,"context_line":"            \"properties\", {}).get("},{"line_number":43,"context_line":"                \"auto_disk_config\", None)"},{"line_number":44,"context_line":"        if auto_disk_config is not None:"},{"line_number":45,"context_line":"            value \u003d strutils.bool_from_string(auto_disk_config)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_29485a2d","line":42,"range":{"start_line":42,"start_character":13,"end_line":42,"end_character":23},"in_reply_to":"3aaa91ec_76a7dd4f","updated":"2016-06-21 19:13:46.000000000","message":"see Line 57 below","commit_id":"a759faab1c9bbabfdf3bfde2e7d74cb3c276956c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c31350fa73c2851bdc9296418c74f84590280c0e","unresolved":false,"context_lines":[{"line_number":43,"context_line":"                \"auto_disk_config\", None)"},{"line_number":44,"context_line":"        if auto_disk_config is not None:"},{"line_number":45,"context_line":"            value \u003d strutils.bool_from_string(auto_disk_config)"},{"line_number":46,"context_line":"            image_resp[\"OS-DCF:diskConfig\"] \u003d \\"},{"line_number":47,"context_line":"                    disk_config.disk_config_to_api(value)"},{"line_number":48,"context_line":"        return image_resp"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_38f53e83","line":46,"range":{"start_line":46,"start_character":12,"end_line":46,"end_character":43},"updated":"2016-06-21 20:26:37.000000000","message":"Should be image_resp[\u0027image\u0027], else it\u0027s not nested but _list_view was filtering it out anyway. But this breaks the list API.","commit_id":"a759faab1c9bbabfdf3bfde2e7d74cb3c276956c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f702444f317ff5f2c36150d72156b467f8f9bdea","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        if auto_disk_config is not None:"},{"line_number":45,"context_line":"            value \u003d strutils.bool_from_string(auto_disk_config)"},{"line_number":46,"context_line":"            image_resp[\"OS-DCF:diskConfig\"] \u003d \\"},{"line_number":47,"context_line":"                    disk_config.disk_config_to_api(value)"},{"line_number":48,"context_line":"        return image_resp"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def show(self, request, image):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_762cfdab","line":47,"range":{"start_line":47,"start_character":32,"end_line":47,"end_character":50},"updated":"2016-06-21 18:52:23.000000000","message":"Why not just bring this helper in here?","commit_id":"a759faab1c9bbabfdf3bfde2e7d74cb3c276956c"}]}