)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"c454cd2af828f34823b2c35bf64021faba44e80f","unresolved":false,"context_lines":[{"line_number":14,"context_line":"Added also an unitary test to test quantumv2 api"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Ib2f1a0d49a12114b28f0cd5ce0bb7119f864d1a6"},{"line_number":17,"context_line":"Fixes: bug #1160309"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"AAAAP3%2F%2Fif8%3D","line":17,"updated":"2013-07-16 20:21:08.000000000","message":"Should be above 16:  also  Fixes bug 1200175","commit_id":"c78d830f8ba024f49e0609f94e58071dec93cfb1"}],"nova/network/neutronv2/api.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"738b56192ff8781c1a7987dcb7fe730dde6e2223","unresolved":false,"context_lines":[{"line_number":632,"context_line":"            fip \u003d client.show_floatingip(id)[\u0027floatingip\u0027]"},{"line_number":633,"context_line":"        except neutronv2.exceptions.NeutronClientException as e:"},{"line_number":634,"context_line":"            if e.status_code \u003d\u003d 404:"},{"line_number":635,"context_line":"                raise exception.NotFound"},{"line_number":636,"context_line":"            raise"},{"line_number":637,"context_line":"        pool_dict \u003d self._setup_net_dict(client,"},{"line_number":638,"context_line":"                                         fip[\u0027floating_network_id\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAP3%2F%2FpNo%3D","line":635,"updated":"2013-07-15 13:25:33.000000000","message":"Can you embed the original exception in the new NotFound that is being raised so we don\u0027t lose the stack trace and message from the original exception, or at a minimum at least log the original exception before raising NotFound?","commit_id":"2b99f9e5709e2f50e52ba13aac2d7ccb80a9207d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7ea6f46c9bb01a1257af2afd023e7fd6ac7e8791","unresolved":false,"context_lines":[{"line_number":632,"context_line":"            fip \u003d client.show_floatingip(id)[\u0027floatingip\u0027]"},{"line_number":633,"context_line":"        except neutronv2.exceptions.NeutronClientException as e:"},{"line_number":634,"context_line":"            if e.status_code \u003d\u003d 404:"},{"line_number":635,"context_line":"                raise exception.NotFound"},{"line_number":636,"context_line":"            raise"},{"line_number":637,"context_line":"        pool_dict \u003d self._setup_net_dict(client,"},{"line_number":638,"context_line":"                                         fip[\u0027floating_network_id\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAP3%2F%2Foos%3D","line":635,"in_reply_to":"AAAAP3%2F%2Fo0Y%3D","updated":"2013-07-15 15:34:35.000000000","message":"I don\u0027t like assuming that the downstream code will always handle this the way you want it to, so yes, I think at a minimum the original exception needs to be logged.","commit_id":"2b99f9e5709e2f50e52ba13aac2d7ccb80a9207d"},{"author":{"_account_id":7781,"name":"Ala Rezmerita","email":"ala.rezmerita@orange.com","username":"alla"},"change_message_id":"80871e2d1fd62b2f8776a8018067d0d33f394e1c","unresolved":false,"context_lines":[{"line_number":632,"context_line":"            fip \u003d client.show_floatingip(id)[\u0027floatingip\u0027]"},{"line_number":633,"context_line":"        except neutronv2.exceptions.NeutronClientException as e:"},{"line_number":634,"context_line":"            if e.status_code \u003d\u003d 404:"},{"line_number":635,"context_line":"                raise exception.NotFound"},{"line_number":636,"context_line":"            raise"},{"line_number":637,"context_line":"        pool_dict \u003d self._setup_net_dict(client,"},{"line_number":638,"context_line":"                                         fip[\u0027floating_network_id\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAP3%2F%2Fo0Y%3D","line":635,"in_reply_to":"AAAAP3%2F%2FpNo%3D","updated":"2013-07-15 15:07:48.000000000","message":"@Matt: Here the message from NeutronClientException is \"NeutronError\": \"Floating IP xxx could not be found\". Once the exception.NotFound is raised it will be caught later in nova/api/openstack/compute/contrib/floating_ips.py (method show line 121)  and the message \"Floating ip not found for id xxx\" will be given for webob.exc.HTTPNotFound that is raised.\nSo in my opinion it is not necessary to keep neutron message, but if you still consider that is it useful to log it, I will do it.","commit_id":"2b99f9e5709e2f50e52ba13aac2d7ccb80a9207d"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"afd78cdd4bcdb23bedf59090cfdcba0e37bae1d1","unresolved":false,"context_lines":[{"line_number":632,"context_line":"            fip \u003d client.show_floatingip(id)[\u0027floatingip\u0027]"},{"line_number":633,"context_line":"        except neutronv2.exceptions.NeutronClientException as e:"},{"line_number":634,"context_line":"            if e.status_code \u003d\u003d 404:"},{"line_number":635,"context_line":"                LOG.exception(e)"},{"line_number":636,"context_line":"                raise exception.NotFound"},{"line_number":637,"context_line":"            raise"},{"line_number":638,"context_line":"        pool_dict \u003d self._setup_net_dict(client,"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAP3%2F%2FoIE%3D","line":635,"updated":"2013-07-15 17:23:46.000000000","message":"actually, I had review comments exactly the opposite from matt\u0027s we shouldn\u0027t log exceptions except in exceptional cases. This isn\u0027t one of those.","commit_id":"450e5950fa54d4d21d748c8dcaf816bf21ac708e"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"b783236036afcbce6107deb1be9bd32f9a6cbc7b","unresolved":false,"context_lines":[{"line_number":632,"context_line":"            fip \u003d client.show_floatingip(id)[\u0027floatingip\u0027]"},{"line_number":633,"context_line":"        except neutronv2.exceptions.NeutronClientException as e:"},{"line_number":634,"context_line":"            if e.status_code \u003d\u003d 404:"},{"line_number":635,"context_line":"                LOG.exception(e)"},{"line_number":636,"context_line":"                raise exception.NotFound"},{"line_number":637,"context_line":"            raise"},{"line_number":638,"context_line":"        pool_dict \u003d self._setup_net_dict(client,"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAP3%2F%2Flgw%3D","line":635,"in_reply_to":"AAAAP3%2F%2FnkQ%3D","updated":"2013-07-16 08:11:34.000000000","message":"Is it enough to remove the L635, for now ?","commit_id":"450e5950fa54d4d21d748c8dcaf816bf21ac708e"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"ce882937ea4b2692d901e1171eae430862617cff","unresolved":false,"context_lines":[{"line_number":632,"context_line":"            fip \u003d client.show_floatingip(id)[\u0027floatingip\u0027]"},{"line_number":633,"context_line":"        except neutronv2.exceptions.NeutronClientException as e:"},{"line_number":634,"context_line":"            if e.status_code \u003d\u003d 404:"},{"line_number":635,"context_line":"                LOG.exception(e)"},{"line_number":636,"context_line":"                raise exception.NotFound"},{"line_number":637,"context_line":"            raise"},{"line_number":638,"context_line":"        pool_dict \u003d self._setup_net_dict(client,"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAP3%2F%2FnkQ%3D","line":635,"in_reply_to":"AAAAP3%2F%2FoIE%3D","updated":"2013-07-15 19:31:05.000000000","message":"Agreed.","commit_id":"450e5950fa54d4d21d748c8dcaf816bf21ac708e"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"c454cd2af828f34823b2c35bf64021faba44e80f","unresolved":false,"context_lines":[{"line_number":645,"context_line":"            fip \u003d client.show_floatingip(id)[\u0027floatingip\u0027]"},{"line_number":646,"context_line":"        except neutronv2.exceptions.NeutronClientException as e:"},{"line_number":647,"context_line":"            if e.status_code \u003d\u003d 404:"},{"line_number":648,"context_line":"                raise exception.NotFound"},{"line_number":649,"context_line":"            raise"},{"line_number":650,"context_line":"        pool_dict \u003d self._setup_net_dict(client,"},{"line_number":651,"context_line":"                                         fip[\u0027floating_network_id\u0027])"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAP3%2F%2FigQ%3D","line":648,"updated":"2013-07-16 20:21:08.000000000","message":"nit: raise exception.FloatingIpNotFound(id\u003did)","commit_id":"c78d830f8ba024f49e0609f94e58071dec93cfb1"}],"nova/network/quantumv2/api.py":[{"author":{"_account_id":1501,"name":"Phil Day","email":"philip.day@hp.com","username":"philip-day"},"change_message_id":"ee9b91f9d7d9c2e27da0a4bdc523d90efd1944a8","unresolved":false,"context_lines":[{"line_number":599,"context_line":"        client \u003d quantumv2.get_client(context)"},{"line_number":600,"context_line":"        try:"},{"line_number":601,"context_line":"            fip \u003d client.show_floatingip(id)[\u0027floatingip\u0027]"},{"line_number":602,"context_line":"        except quantumv2.exceptions.QuantumClientException as e:"},{"line_number":603,"context_line":"            if e.status_code \u003d\u003d 404:"},{"line_number":604,"context_line":"                raise exception.NotFound"},{"line_number":605,"context_line":"            raise"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPn%2F%2FgFI%3D","line":602,"updated":"2013-06-29 01:52:08.000000000","message":"Can we really relate the general quantum client exception to NotFound without risking that we mask some other quantum error ?\n\nWhen I raise the original bug I was really expecting any fix to make the quantum client return a richer set of exceptions.\n\n(See similar review on https://review.openstack.org/#/c/34825/)","commit_id":"a8918f6ce8184d270cb6ab08df1ea443e5d6da43"}]}