)]}'
{"nova/virt/libvirt/driver.py":[{"author":{"_account_id":10224,"name":"Feodor Tersin","email":"ftersin@hotmail.com","username":"ftersin"},"change_message_id":"2c401ebdc0aab1e51f2ca3df5cbdf43250d109a4","unresolved":false,"context_lines":[{"line_number":6974,"context_line":"                fname \u003d os.path.basename(img_path)"},{"line_number":6975,"context_line":"                from_path \u003d os.path.join(inst_base_resize, fname)"},{"line_number":6976,"context_line":""},{"line_number":6977,"context_line":"                # To properly resize the swap partition, it must be"},{"line_number":6978,"context_line":"                # re-created with the proper size.  This is acceptable"},{"line_number":6979,"context_line":"                # because when an OS is shut down, the contents of the"},{"line_number":6980,"context_line":"                # swap space are just garbage, the OS doesn\u0027t bother about"},{"line_number":6981,"context_line":"                # what is in it."}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_cc5e0f76","side":"PARENT","line":6978,"range":{"start_line":6977,"start_character":16,"end_line":6978,"end_character":50},"updated":"2016-06-21 16:30:05.000000000","message":"I think this reason should be kept in comments. This reason is more valuable than \"makes resize simpler\", imho.","commit_id":"fab0cba7cdad9a4d7407ae342e739152436914e0"},{"author":{"_account_id":10224,"name":"Feodor Tersin","email":"ftersin@hotmail.com","username":"ftersin"},"change_message_id":"5895c07fa87e07cd6b21245e0ef75a2ad219811d","unresolved":false,"context_lines":[{"line_number":6983,"context_line":"                # We will not copy over the swap disk here, and rely on"},{"line_number":6984,"context_line":"                # finish_migration/_create_image to re-create it for us."},{"line_number":6985,"context_line":"                if not (fname \u003d\u003d \u0027disk.swap\u0027 and"},{"line_number":6986,"context_line":"                    active_flavor.get(\u0027swap\u0027, 0) !\u003d flavor.get(\u0027swap\u0027, 0)):"},{"line_number":6987,"context_line":""},{"line_number":6988,"context_line":"                    compression \u003d info[\u0027type\u0027] not in NO_COMPRESSION_TYPES"},{"line_number":6989,"context_line":"                    libvirt_utils.copy_image(from_path, img_path, host\u003ddest,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a9d85d2_7c314e0b","side":"PARENT","line":6986,"updated":"2016-06-20 23:09:53.000000000","message":"Could it be a case for migration only (not resize)?","commit_id":"fab0cba7cdad9a4d7407ae342e739152436914e0"},{"author":{"_account_id":10224,"name":"Feodor Tersin","email":"ftersin@hotmail.com","username":"ftersin"},"change_message_id":"2c401ebdc0aab1e51f2ca3df5cbdf43250d109a4","unresolved":false,"context_lines":[{"line_number":6983,"context_line":"                # We will not copy over the swap disk here, and rely on"},{"line_number":6984,"context_line":"                # finish_migration/_create_image to re-create it for us."},{"line_number":6985,"context_line":"                if not (fname \u003d\u003d \u0027disk.swap\u0027 and"},{"line_number":6986,"context_line":"                    active_flavor.get(\u0027swap\u0027, 0) !\u003d flavor.get(\u0027swap\u0027, 0)):"},{"line_number":6987,"context_line":""},{"line_number":6988,"context_line":"                    compression \u003d info[\u0027type\u0027] not in NO_COMPRESSION_TYPES"},{"line_number":6989,"context_line":"                    libvirt_utils.copy_image(from_path, img_path, host\u003ddest,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_ac3623b2","side":"PARENT","line":6986,"in_reply_to":"5a9d85d2_75e1459a","updated":"2016-06-21 16:30:05.000000000","message":"I was wrong with pure migration case. It looks like this method is not called in this case.","commit_id":"fab0cba7cdad9a4d7407ae342e739152436914e0"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"dc8ddde21f270b001c651550239efbc256d35032","unresolved":false,"context_lines":[{"line_number":6983,"context_line":"                # We will not copy over the swap disk here, and rely on"},{"line_number":6984,"context_line":"                # finish_migration/_create_image to re-create it for us."},{"line_number":6985,"context_line":"                if not (fname \u003d\u003d \u0027disk.swap\u0027 and"},{"line_number":6986,"context_line":"                    active_flavor.get(\u0027swap\u0027, 0) !\u003d flavor.get(\u0027swap\u0027, 0)):"},{"line_number":6987,"context_line":""},{"line_number":6988,"context_line":"                    compression \u003d info[\u0027type\u0027] not in NO_COMPRESSION_TYPES"},{"line_number":6989,"context_line":"                    libvirt_utils.copy_image(from_path, img_path, host\u003ddest,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a9d85d2_75e1459a","side":"PARENT","line":6986,"in_reply_to":"5a9d85d2_7c314e0b","updated":"2016-06-21 12:53:56.000000000","message":"It can be safely recreated in both cases. Resize may or may not include a migration anyway at the whim of the scheduler. IoW the copy may be over the network or locally from the _resize directory, but it\u0027s still a copy.","commit_id":"fab0cba7cdad9a4d7407ae342e739152436914e0"},{"author":{"_account_id":7789,"name":"John Wood","email":"john.wood@rackspace.com","username":"woodster"},"change_message_id":"3bb163a595eaeb51a57eae4ab48266150ea8476e","unresolved":false,"context_lines":[{"line_number":7104,"context_line":"                from_path \u003d os.path.join(inst_base_resize, fname)"},{"line_number":7105,"context_line":""},{"line_number":7106,"context_line":"                # We will not copy over the swap disk here, and rely on"},{"line_number":7107,"context_line":"                # finish_migration to re-create it for us. This is ok because"},{"line_number":7108,"context_line":"                # the OS is shut down, and as recreating a swap disk is very"},{"line_number":7109,"context_line":"                # cheap it is more efficient than copying either locally or"},{"line_number":7110,"context_line":"                # over the network. This also means we don\u0027t have to resize it."}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_ae1f0e08","line":7107,"updated":"2016-07-08 14:51:34.000000000","message":"This first sentence is a bit confusing to me anyway. Perhaps part of it is missing?","commit_id":"d9ca30b389ed59f0f5e46c0e023db54e4a9306d8"}]}