)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"53fab09fb10273f30bd98210567b0dd45133d542","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Phil Day \u003cphilip.day@hp.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-06-16 21:31:31 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Handle instance being deleted while in fliter scheduler"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adds handling of InstanceNotFound when trying to update the"},{"line_number":10,"context_line":"scheduled_at time of an instance."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAPn%2F%2F6rE%3D","line":7,"updated":"2013-06-18 10:19:29.000000000","message":"fliter \u003d\u003e filter","commit_id":"a282a1a1ef4df2c293633acd9ebc09507bd673b1"}],"nova/scheduler/filter_scheduler.py":[{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"69b9874ee75ce289b598d88b5fdc230b873bbd09","unresolved":false,"context_lines":[{"line_number":197,"context_line":"                    admin_password\u003dadmin_password, is_first_time\u003dis_first_time,"},{"line_number":198,"context_line":"                    node\u003dweighed_host.obj.nodename)"},{"line_number":199,"context_line":"        except exception.InstanceNotFound:"},{"line_number":200,"context_line":"            LOG.warning(_(\"Instance disappeared during reboot\"),"},{"line_number":201,"context_line":"                        context\u003dcontext, instance_uuid\u003dinstance_uuid)"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    def _post_select_populate_filter_properties(self, filter_properties,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2F%2Fyw%3D","line":200,"updated":"2013-06-14 22:09:34.000000000","message":"during scheduling.. not reboot ;)","commit_id":"3ad461b3881a0aa8649b258d706eaab8ccf3b259"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"e3babb6ab23def9e6db0d072f19d98657367f103","unresolved":false,"context_lines":[{"line_number":196,"context_line":"                    injected_files\u003dinjected_files,"},{"line_number":197,"context_line":"                    admin_password\u003dadmin_password, is_first_time\u003dis_first_time,"},{"line_number":198,"context_line":"                    node\u003dweighed_host.obj.nodename)"},{"line_number":199,"context_line":"        except exception.InstanceNotFound:"},{"line_number":200,"context_line":"            LOG.warning(_(\"Instance disappeared during scheduling\"),"},{"line_number":201,"context_line":"                        context\u003dcontext, instance_uuid\u003dinstance_uuid)"},{"line_number":202,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAP3%2F%2F4F0%3D","line":199,"updated":"2013-07-09 22:49:41.000000000","message":"run_instance is an rpc cast, so it\u0027s not going to raise InstanceNotFound","commit_id":"881f96c011ffb5b6b063c6260974b698c172b4fc"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"0c6a0d51ce0e83e6224bb684df0abd1ecdf4d9e0","unresolved":false,"context_lines":[{"line_number":196,"context_line":"                    injected_files\u003dinjected_files,"},{"line_number":197,"context_line":"                    admin_password\u003dadmin_password, is_first_time\u003dis_first_time,"},{"line_number":198,"context_line":"                    node\u003dweighed_host.obj.nodename)"},{"line_number":199,"context_line":"        except exception.InstanceNotFound:"},{"line_number":200,"context_line":"            LOG.warning(_(\"Instance disappeared during scheduling\"),"},{"line_number":201,"context_line":"                        context\u003dcontext, instance_uuid\u003dinstance_uuid)"},{"line_number":202,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAP3%2F%2Fz%2FQ%3D","line":199,"in_reply_to":"AAAAP3%2F%2F1Xw%3D","updated":"2013-07-11 02:46:20.000000000","message":"compute.rpcapi.run_instance doesn\u0027t _do_ anything besides convert the instance to a json primitive, and make an RPC message.\n\nThis try block only makes sense around driver.instance_update_db(). Perhaps this would be a better approach?\n\n  try:\n    updated_instance \u003d driver.instance_update_db(...)\n  except exception.InstanceNotFound:\n    LOG.warning(...)\n  else:\n    self._post_select_populate_filter_properties(...)\n    self.compute_rpcapi.run_instance(...)","commit_id":"881f96c011ffb5b6b063c6260974b698c172b4fc"},{"author":{"_account_id":1501,"name":"Phil Day","email":"philip.day@hp.com","username":"philip-day"},"change_message_id":"349161864edd8926ec279e9a148a150f76b00bb3","unresolved":false,"context_lines":[{"line_number":196,"context_line":"                    injected_files\u003dinjected_files,"},{"line_number":197,"context_line":"                    admin_password\u003dadmin_password, is_first_time\u003dis_first_time,"},{"line_number":198,"context_line":"                    node\u003dweighed_host.obj.nodename)"},{"line_number":199,"context_line":"        except exception.InstanceNotFound:"},{"line_number":200,"context_line":"            LOG.warning(_(\"Instance disappeared during scheduling\"),"},{"line_number":201,"context_line":"                        context\u003dcontext, instance_uuid\u003dinstance_uuid)"},{"line_number":202,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAP3%2F%2F1Xw%3D","line":199,"in_reply_to":"AAAAP3%2F%2F4F0%3D","updated":"2013-07-10 17:22:46.000000000","message":"Once the cast is made it won\u0027t raise the exception, but are you sure that the code inside rpcapi won\u0027t ever need to do something to the instance before it makes the cast that could cause the exception to be raised ?\n\nI can scope the try block to just the instance_update_db call if you prefer - I was trying to just make it more general / bullet proof","commit_id":"881f96c011ffb5b6b063c6260974b698c172b4fc"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"9549bd6c669a720616ff0a181a38ece99d87634b","unresolved":false,"context_lines":[{"line_number":208,"context_line":"            LOG.warning(_(\"Instance disappeared during scheduling\"),"},{"line_number":209,"context_line":"                        context\u003dcontext, instance_uuid\u003dinstance_uuid)"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"        else:"},{"line_number":212,"context_line":"            scheduler_utils.populate_filter_properties(filter_properties,"},{"line_number":213,"context_line":"                    weighed_host.obj)"},{"line_number":214,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAQn%2F%2F6PU%3D","line":211,"updated":"2013-07-19 11:35:15.000000000","message":"try: else: isn\u0027t an idiom we use much in nova (I could only find a couple of instances, being the giant webobj exception translator and something in the bm driver).\n\nAs such my preference would be to put the logic inside the try. That being said it\u0027s a nano nit, so I\u0027m +2ing anyway, as the fix looks fine.\n\n(Also, reading last review rounds, and everyone else was pushing towards the else... so be it. :))","commit_id":"79039a7f6ffce2d5cc2e92eee03de94a3c2292f8"}],"nova/tests/scheduler/test_filter_scheduler.py":[{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"6caf99500f64bd9dc29360938412f9bfcff2ed38","unresolved":false,"context_lines":[{"line_number":750,"context_line":"                          self.driver.select_hosts, self.context, {}, {})"},{"line_number":751,"context_line":""},{"line_number":752,"context_line":"    def test_handles_deleted_instance(self):"},{"line_number":753,"context_line":"        \"\"\"Make sure the scheduler copes with an instance being"},{"line_number":754,"context_line":"        deleted while its scheduling it"},{"line_number":755,"context_line":"        \"\"\""},{"line_number":756,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2F90c%3D","line":753,"updated":"2013-06-17 08:43:02.000000000","message":"pep257: Multi-line docstrings consist of a summary line just like a one-line docstring, followed by a blank line, followed by a more elaborate description.","commit_id":"a282a1a1ef4df2c293633acd9ebc09507bd673b1"}]}