)]}'
{"nova/network/neutronv2/api.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"4c75a7d99da2280179954ca9733064082bb73f97","unresolved":false,"context_lines":[{"line_number":608,"context_line":"                    # \u0027port_security_enabled\u003dFalse\u0027."},{"line_number":609,"context_line":"                    LOG.debug(\u0027Network has port security disabled so security \u0027"},{"line_number":610,"context_line":"                              \u0027groups cannot be applied: %s\u0027, network,"},{"line_number":611,"context_line":"                              instance\u003dinstance)"},{"line_number":612,"context_line":"                    raise exception.SecurityGroupCannotBeApplied()"},{"line_number":613,"context_line":""},{"line_number":614,"context_line":"            zone \u003d \u0027compute:%s\u0027 % instance.availability_zone"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_f1d385d3","line":611,"updated":"2016-06-28 19:24:07.000000000","message":"Is there a reason to log these separately instead of making them the msg for the exception i.e. SecurityGroupCannotBeApplied(msg)?","commit_id":"2ce5c8c3be56ec791b712b86b9e5a20d543c5dbd"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"3037b428e74bb802c2b069dce236513a644097ea","unresolved":false,"context_lines":[{"line_number":608,"context_line":"                    # \u0027port_security_enabled\u003dFalse\u0027."},{"line_number":609,"context_line":"                    LOG.debug(\u0027Network has port security disabled so security \u0027"},{"line_number":610,"context_line":"                              \u0027groups cannot be applied: %s\u0027, network,"},{"line_number":611,"context_line":"                              instance\u003dinstance)"},{"line_number":612,"context_line":"                    raise exception.SecurityGroupCannotBeApplied()"},{"line_number":613,"context_line":""},{"line_number":614,"context_line":"            zone \u003d \u0027compute:%s\u0027 % instance.availability_zone"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_db4eed36","line":611,"in_reply_to":"3aaa91ec_20cc2034","updated":"2016-06-30 19:28:00.000000000","message":"I was thinking higher up code could benefit from being able to log the difference in the scenarios upon failure.\n\nBut, looking again I see that we probably wouldn\u0027t want to propagate the \u0027network\u0027 variable content in the exception and also the exception message would reach an end-user, so in that case the exception message should probably just be the base message without the \u0027network\u0027 variable dump.\n\nIf that\u0027s not considered useful, then this is fine as-is.","commit_id":"2ce5c8c3be56ec791b712b86b9e5a20d543c5dbd"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"94b5dfc621e9c066ba9fb8f0cd68291eac623414","unresolved":false,"context_lines":[{"line_number":608,"context_line":"                    # \u0027port_security_enabled\u003dFalse\u0027."},{"line_number":609,"context_line":"                    LOG.debug(\u0027Network has port security disabled so security \u0027"},{"line_number":610,"context_line":"                              \u0027groups cannot be applied: %s\u0027, network,"},{"line_number":611,"context_line":"                              instance\u003dinstance)"},{"line_number":612,"context_line":"                    raise exception.SecurityGroupCannotBeApplied()"},{"line_number":613,"context_line":""},{"line_number":614,"context_line":"            zone \u003d \u0027compute:%s\u0027 % instance.availability_zone"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_431df371","line":611,"in_reply_to":"3aaa91ec_43f33373","updated":"2016-06-30 21:04:19.000000000","message":"Sorry, should have traced it myself but glad you noticed something else useful from it","commit_id":"2ce5c8c3be56ec791b712b86b9e5a20d543c5dbd"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"cba25eb43b933d3beb473a7dff3a81ec3205301a","unresolved":false,"context_lines":[{"line_number":608,"context_line":"                    # \u0027port_security_enabled\u003dFalse\u0027."},{"line_number":609,"context_line":"                    LOG.debug(\u0027Network has port security disabled so security \u0027"},{"line_number":610,"context_line":"                              \u0027groups cannot be applied: %s\u0027, network,"},{"line_number":611,"context_line":"                              instance\u003dinstance)"},{"line_number":612,"context_line":"                    raise exception.SecurityGroupCannotBeApplied()"},{"line_number":613,"context_line":""},{"line_number":614,"context_line":"            zone \u003d \u0027compute:%s\u0027 % instance.availability_zone"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_20cc2034","line":611,"in_reply_to":"3aaa91ec_c66663ec","updated":"2016-06-30 19:15:27.000000000","message":"There are different messages for different scenarios.","commit_id":"2ce5c8c3be56ec791b712b86b9e5a20d543c5dbd"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c14b1967fc0643457f4b1ba3cd306294946257c6","unresolved":false,"context_lines":[{"line_number":608,"context_line":"                    # \u0027port_security_enabled\u003dFalse\u0027."},{"line_number":609,"context_line":"                    LOG.debug(\u0027Network has port security disabled so security \u0027"},{"line_number":610,"context_line":"                              \u0027groups cannot be applied: %s\u0027, network,"},{"line_number":611,"context_line":"                              instance\u003dinstance)"},{"line_number":612,"context_line":"                    raise exception.SecurityGroupCannotBeApplied()"},{"line_number":613,"context_line":""},{"line_number":614,"context_line":"            zone \u003d \u0027compute:%s\u0027 % instance.availability_zone"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_43f33373","line":611,"in_reply_to":"3aaa91ec_db4eed36","updated":"2016-06-30 20:55:39.000000000","message":"I think the stacktrace gets logged here:\n\nhttps://github.com/openstack/nova/blob/master/nova/compute/manager.py#L1399\n\ne.g.:\n\nhttp://logs.openstack.org/90/264590/28/check/gate-grenade-dsvm-ironic/4ed061f/logs/new/screen-n-cpu.txt.gz#_2016-06-30_20_31_08_172\n\nThis specific exception doesn\u0027t get handled in the compute manager (but probably should in this case and abort the build), so I think we actually get here and then reschedule:\n\nhttps://github.com/openstack/nova/blob/master/nova/compute/manager.py#L1957\n\n^ will send a notification with the fault, but an end user wouldn\u0027t get that unless they can see faults for their instance, which has the stack trace, but I think viewing faults for instance action events (or on instances) is admin-only.\n\nThe existing error message in the exception probably covers both cases fine:\n\n    msg_fmt \u003d _(\"Network requires port_security_enabled and subnet associated\"\n                \" in order to apply security groups.\")\n\nThe point of this change is really to log the network dict, which as you said is not something we probably want to propagate up the stack.","commit_id":"2ce5c8c3be56ec791b712b86b9e5a20d543c5dbd"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"c802d83e1dfc5ee17489a713b4bd25752b3ecd41","unresolved":false,"context_lines":[{"line_number":608,"context_line":"                    # \u0027port_security_enabled\u003dFalse\u0027."},{"line_number":609,"context_line":"                    LOG.debug(\u0027Network has port security disabled so security \u0027"},{"line_number":610,"context_line":"                              \u0027groups cannot be applied: %s\u0027, network,"},{"line_number":611,"context_line":"                              instance\u003dinstance)"},{"line_number":612,"context_line":"                    raise exception.SecurityGroupCannotBeApplied()"},{"line_number":613,"context_line":""},{"line_number":614,"context_line":"            zone \u003d \u0027compute:%s\u0027 % instance.availability_zone"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_c66663ec","line":611,"in_reply_to":"3aaa91ec_f1d385d3","updated":"2016-06-29 14:25:26.000000000","message":"+1","commit_id":"2ce5c8c3be56ec791b712b86b9e5a20d543c5dbd"}]}