)]}'
{"nova/tests/unit/virt/xenapi/plugins/test_partition_utils.py":[{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"80c2b873e7a53e5615cd73abfd051455e5e6007d","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from nova.tests.unit.virt.xenapi.plugins import plugin_test"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class PartitionUtils(plugin_test.PluginTestBase):"},{"line_number":23,"context_line":"    def setUp(self):"},{"line_number":24,"context_line":"        super(PartitionUtils, self).setUp()"},{"line_number":25,"context_line":"        self.partition_utils \u003d self.load_plugin(\"partition_utils.py\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_aedf7338","line":22,"updated":"2016-06-24 17:52:07.000000000","message":"Very nice. It\u0027s great that these are getting some testing.","commit_id":"5a1e21ad32da1a74ef6760f78b86ea0d2c07fde4"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"80c2b873e7a53e5615cd73abfd051455e5e6007d","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class PartitionUtils(plugin_test.PluginTestBase):"},{"line_number":23,"context_line":"    def setUp(self):"},{"line_number":24,"context_line":"        super(PartitionUtils, self).setUp()"},{"line_number":25,"context_line":"        self.partition_utils \u003d self.load_plugin(\"partition_utils.py\")"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_8961d1ab","line":23,"updated":"2016-06-24 17:52:07.000000000","message":"It doesn\u0027t look like make_partition is tested, or am I missing it?","commit_id":"5a1e21ad32da1a74ef6760f78b86ea0d2c07fde4"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"4948828fadfbc1b972c377e8485417adf9c20ac4","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class PartitionUtils(plugin_test.PluginTestBase):"},{"line_number":23,"context_line":"    def setUp(self):"},{"line_number":24,"context_line":"        super(PartitionUtils, self).setUp()"},{"line_number":25,"context_line":"        self.partition_utils \u003d self.load_plugin(\"partition_utils.py\")"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_b3484ccd","line":23,"in_reply_to":"3aaa91ec_8961d1ab","updated":"2016-06-27 08:09:35.000000000","message":"Done","commit_id":"5a1e21ad32da1a74ef6760f78b86ea0d2c07fde4"}],"nova/tests/unit/virt/xenapi/test_xenapi.py":[{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"80c2b873e7a53e5615cd73abfd051455e5e6007d","unresolved":false,"context_lines":[{"line_number":1895,"context_line":""},{"line_number":1896,"context_line":"        self.stubs.Set(vm_utils, \u0027_get_partitions\u0027, fake_get_partitions)"},{"line_number":1897,"context_line":""},{"line_number":1898,"context_line":"        self.mox.ReplayAll()"},{"line_number":1899,"context_line":"        self.assertRaises(exception.InstanceFaultRollback,"},{"line_number":1900,"context_line":"                          conn.migrate_disk_and_power_off,"},{"line_number":1901,"context_line":"                          self.context, instance,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_299a5d6e","line":1898,"updated":"2016-06-24 17:52:07.000000000","message":"Interesting that these were missed before.","commit_id":"5a1e21ad32da1a74ef6760f78b86ea0d2c07fde4"}],"nova/virt/xenapi/vm_utils.py":[{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"80c2b873e7a53e5615cd73abfd051455e5e6007d","unresolved":false,"context_lines":[{"line_number":972,"context_line":""},{"line_number":973,"context_line":"        3. Create partition"},{"line_number":974,"context_line":""},{"line_number":975,"context_line":"        4. Create VBD between instance VM and VDI"},{"line_number":976,"context_line":"    \"\"\""},{"line_number":977,"context_line":"    # 1. Create VDI"},{"line_number":978,"context_line":"    sr_ref \u003d safe_find_sr(session)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_2901bd06","line":975,"updated":"2016-06-24 17:52:07.000000000","message":"This could use some more detail, and perhaps the commit message as well. Because depending on the filesystem in use the VDI is attached to this compute worker as well.","commit_id":"5a1e21ad32da1a74ef6760f78b86ea0d2c07fde4"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"4948828fadfbc1b972c377e8485417adf9c20ac4","unresolved":false,"context_lines":[{"line_number":972,"context_line":""},{"line_number":973,"context_line":"        3. Create partition"},{"line_number":974,"context_line":""},{"line_number":975,"context_line":"        4. Create VBD between instance VM and VDI"},{"line_number":976,"context_line":"    \"\"\""},{"line_number":977,"context_line":"    # 1. Create VDI"},{"line_number":978,"context_line":"    sr_ref \u003d safe_find_sr(session)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_f37bf4f2","line":975,"in_reply_to":"3aaa91ec_2901bd06","updated":"2016-06-27 08:09:35.000000000","message":"Done","commit_id":"5a1e21ad32da1a74ef6760f78b86ea0d2c07fde4"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"80c2b873e7a53e5615cd73abfd051455e5e6007d","unresolved":false,"context_lines":[{"line_number":2137,"context_line":""},{"line_number":2138,"context_line":""},{"line_number":2139,"context_line":"@contextlib.contextmanager"},{"line_number":2140,"context_line":"def vdi_attached_here(session, vdi_ref, read_only\u003dFalse, dom0\u003dFalse):"},{"line_number":2141,"context_line":"    if dom0:"},{"line_number":2142,"context_line":"        this_vm_ref \u003d _get_dom0_ref(session)"},{"line_number":2143,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_69c2a5ea","line":2140,"updated":"2016-06-24 17:52:07.000000000","message":"Small nit, but this may be better called vdi_attached now.","commit_id":"5a1e21ad32da1a74ef6760f78b86ea0d2c07fde4"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"4948828fadfbc1b972c377e8485417adf9c20ac4","unresolved":false,"context_lines":[{"line_number":2137,"context_line":""},{"line_number":2138,"context_line":""},{"line_number":2139,"context_line":"@contextlib.contextmanager"},{"line_number":2140,"context_line":"def vdi_attached_here(session, vdi_ref, read_only\u003dFalse, dom0\u003dFalse):"},{"line_number":2141,"context_line":"    if dom0:"},{"line_number":2142,"context_line":"        this_vm_ref \u003d _get_dom0_ref(session)"},{"line_number":2143,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_13a16046","line":2140,"in_reply_to":"3aaa91ec_69c2a5ea","updated":"2016-06-27 08:09:35.000000000","message":"I did think about this, but left it as it was to avoid the rename everywhere.  Have renamed now.","commit_id":"5a1e21ad32da1a74ef6760f78b86ea0d2c07fde4"}],"plugins/xenserver/xenapi/etc/xapi.d/plugins/partition_utils.py":[{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"80c2b873e7a53e5615cd73abfd051455e5e6007d","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    return \"\""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"def make_partition(session, dev, partition_start, partition_end):"},{"line_number":40,"context_line":"    dev_path \u003d utils.make_dev_path(dev)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    if partition_end !\u003d \"-\":"}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_ae281334","line":39,"updated":"2016-06-24 17:52:07.000000000","message":"nit, but given the check and exception raised this could have been named make_unbounded_partition.","commit_id":"5a1e21ad32da1a74ef6760f78b86ea0d2c07fde4"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"8f5bdc7ef6f67f0af7fe63357ae7f36bcfeee319","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    return \"\""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"def make_partition(session, dev, partition_start, partition_end):"},{"line_number":40,"context_line":"    dev_path \u003d utils.make_dev_path(dev)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    if partition_end !\u003d \"-\":"}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_0fabe9d7","line":39,"in_reply_to":"3aaa91ec_730f0437","updated":"2016-06-27 12:13:26.000000000","message":"Fair point. I have no problem with it as is.","commit_id":"5a1e21ad32da1a74ef6760f78b86ea0d2c07fde4"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"4948828fadfbc1b972c377e8485417adf9c20ac4","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    return \"\""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"def make_partition(session, dev, partition_start, partition_end):"},{"line_number":40,"context_line":"    dev_path \u003d utils.make_dev_path(dev)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    if partition_end !\u003d \"-\":"}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_730f0437","line":39,"in_reply_to":"3aaa91ec_ae281334","updated":"2016-06-27 08:09:35.000000000","message":"I\u0027d rather keep as it is.  The version of the code we are replacing had an end-limit for the size (even though it was always full-disk) and if we keep the argument then we can support fixed length partitions in a future version of the code.\nIf we don\u0027t pass the argument down here, we would need to create a new function with that argument.","commit_id":"5a1e21ad32da1a74ef6760f78b86ea0d2c07fde4"}]}